expo-manifests 0.3.1 → 0.4.0

package/CHANGELOG.md

@@ -10,6 +10,16 @@
 
 ### 💡 Others
 
+## 0.4.0 — 2022-10-25
+
+### 🛠 Breaking changes
+
+- Bumped iOS deployment target to 13.0 and deprecated support for iOS 12. ([#18873](https://github.com/expo/expo/pull/18873) by [@tsapeta](https://github.com/tsapeta))
+
+### ⚠️ Notices
+
+- Replace `getAndroidJsEngine` as `jsEngine` lazy kotlin property. ([#19116](https://github.com/expo/expo/pull/19116) by [@kudo](https://github.com/kudo))
+
 ## 0.3.1 — 2022-07-16
 
 _This version does not introduce any user-facing changes._

package/android/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'maven-publish'
 
 group = 'host.exp.exponent'
-version = '0.3.1'
+version = '0.4.0'
 
 buildscript {
   def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
@@ -74,7 +74,7 @@ android {
     minSdkVersion safeExtGet("minSdkVersion", 21)
     targetSdkVersion safeExtGet("targetSdkVersion", 31)
     versionCode 31
-    versionName '0.3.1'
+    versionName '0.4.0'
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
   }
   lintOptions {

package/android/src/main/java/expo/modules/manifests/core/Manifest.kt

@@ -167,12 +167,10 @@ abstract class Manifest(protected val json: JSONObject) {
     return expoClientConfig.getNullable("androidNavigationBar")
   }
 
-  fun getAndroidJsEngine(): String? {
-    val expoClientConfig = getExpoClientConfigRootObject() ?: return null
-    val sharedJsEngine = expoClientConfig.getNullable<String>("jsEngine")
-    val androidJsEngine = expoClientConfig
-      .getNullable<JSONObject>("android")?.getNullable<String>("jsEngine")
-    return androidJsEngine ?: sharedJsEngine
+  val jsEngine: String by lazy {
+    val expoClientConfig = getExpoClientConfigRootObject()
+    expoClientConfig
+      ?.getNullable<JSONObject>("android")?.getNullable<String>("jsEngine") ?: expoClientConfig?.getNullable<String>("jsEngine") ?: "jsc"
   }
 
   fun getIconUrl(): String? {

package/ios/EXManifests/EXManifestsBaseManifest.h

@@ -30,6 +30,7 @@ NS_ASSUME_NONNULL_BEGIN
 - (nullable NSString *)facebookAppId;
 - (nullable NSString *)facebookApplicationName;
 - (BOOL)facebookAutoInitEnabled;
+- (NSString *)jsEngine;
 
 - (BOOL)isDevelopmentMode;
 - (BOOL)isDevelopmentSilentLaunch;

package/ios/EXManifests/EXManifestsBaseManifest.m

@@ -152,6 +152,22 @@
   return enabledNumber != nil && [enabledNumber boolValue];
 }
 
+- (NSString *)jsEngine {
+  NSString *result = nil;
+  NSDictionary *expoClientConfig = self.expoClientConfigRootObject;
+  if (expoClientConfig) {
+    result = [[self class] getStringFromManifest:expoClientConfig
+                                         paths:@[
+                                           @[@"ios", @"jsEngine"],
+                                           @[@"jsEngine"],
+                                         ]];
+  }
+  if (!result) {
+    result = @"jsc";
+  }
+  return result;
+}
+
 # pragma mark - Derived Methods
 
 - (BOOL)isDevelopmentMode {

package/ios/EXManifests/EXManifestsManifest.h

@@ -60,6 +60,7 @@ NS_ASSUME_NONNULL_BEGIN
 - (nullable NSString *)facebookAppId;
 - (nullable NSString *)facebookApplicationName;
 - (BOOL)facebookAutoInitEnabled;
+- (NSString *)jsEngine;
 
 # pragma mark - Derived Methods
 

package/ios/EXManifests.podspec

@@ -10,7 +10,7 @@ Pod::Spec.new do |s|
   s.license        = package['license']
   s.author         = package['author']
   s.homepage       = package['homepage']
-  s.platform       = :ios, '12.0'
+  s.platform       = :ios, '13.0'
   s.source         = { git: 'https://github.com/expo/expo.git' }
   s.static_framework = true
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-manifests",
-  "version": "0.3.1",
+  "version": "0.4.0",
   "description": "Code to parse and use Expo and Expo Updates manifests.",
   "main": "index.js",
   "keywords": [
@@ -20,7 +20,7 @@
   "license": "MIT",
   "homepage": "https://docs.expo.dev/versions/latest/sdk/module-template",
   "dependencies": {
-    "expo-json-utils": "~0.3.0"
+    "expo-json-utils": "~0.4.0"
   },
-  "gitHead": "c6678c65b68e45062d49a2deea8e822f69388278"
+  "gitHead": "eab2b09c735fb0fc2bf734a3f29a6593adba3838"
 }