expo-location 16.5.4 → 16.5.5

package/CHANGELOG.md

@@ -10,17 +10,23 @@
 
 ### 💡 Others
 
+## 16.5.5 — 2024-02-29
+
+_This version does not introduce any user-facing changes._
+
 ## 16.5.4 — 2024-02-27
 
 ### 🎉 New features
 
 - [Android] Make foreground service permission opt-in with `isAndroidForegroundServiceEnabled` config plugin option [#27265](https://github.com/expo/expo/pull/27265) by [@brentvatne](https://github.com/brentvatne))
+- [Android] Enable foreground service by default when background location is enabled [#27359](https://github.com/expo/expo/pull/27359) by [@brentvatne](https://github.com/brentvatne))
 
 ## 16.5.3 — 2024-02-06
 
 ### 🐛 Bug fixes
 
 - [Android] Fixed: `NullPointerException: it must not be null`. ([#26688](https://github.com/expo/expo/pull/26688) by [@lukmccall](https://github.com/lukmccall))
+- On `Android`, prevent location service from starting when permission is not in the manifest. ([#27355](https://github.com/expo/expo/pull/27355) by [@alanjhughes](https://github.com/alanjhughes))
 
 ## 16.5.2 — 2024-01-10
 

package/android/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'maven-publish'
 
 group = 'host.exp.exponent'
-version = '16.5.4'
+version = '16.5.5'
 
 def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
 if (expoModulesCorePlugin.exists()) {
@@ -94,7 +94,7 @@ android {
   namespace "expo.modules.location"
   defaultConfig {
     versionCode 29
-    versionName "16.5.4"
+    versionName "16.5.5"
   }
 }
 

package/android/src/main/java/expo/modules/location/LocationExceptions.kt

@@ -57,4 +57,7 @@ internal class ConversionException(fromClass: Class<*>, toClass: Class<*>, messa
   CodedException("Couldn't cast from ${fromClass::class.simpleName} to ${toClass::class.java.simpleName}: $message")
 
 internal class ForegroundServiceStartNotAllowedException :
-  CodedException("Couldn't start the foreground service. Foreground service cannot be started when the application is in the background.")
+  CodedException("Couldn't start the foreground service. Foreground service cannot be started when the application is in the background")
+
+internal class ForegroundServicePermissionsException :
+  CodedException("Couldn't start the foreground service. Foreground service permissions were not found in the manifest")

package/android/src/main/java/expo/modules/location/LocationModule.kt

@@ -273,6 +273,10 @@ class LocationModule : Module(), LifecycleEventListener, SensorEventListener, Ac
         throw ForegroundServiceStartNotAllowedException()
       }
 
+      if (!hasForegroundServicePermissions()) {
+        throw ForegroundServicePermissionsException()
+      }
+
       mTaskManager.registerTask(taskName, LocationTaskConsumer::class.java, options.toMutableMap())
       return@AsyncFunction
     }
@@ -722,8 +726,22 @@ class LocationModule : Module(), LifecycleEventListener, SensorEventListener, Ac
       val canAccessFineLocation = it.hasGrantedPermissions(Manifest.permission.ACCESS_FINE_LOCATION)
       val canAccessCoarseLocation = it.hasGrantedPermissions(Manifest.permission.ACCESS_COARSE_LOCATION)
       return !canAccessFineLocation && !canAccessCoarseLocation
-    }
-    return true
+    } ?: throw Exceptions.AppContextLost()
+  }
+
+  private fun hasForegroundServicePermissions(): Boolean {
+    appContext.permissions?.let {
+      return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
+        val canAccessForegroundServiceLocation = it.hasGrantedPermissions(Manifest.permission.FOREGROUND_SERVICE_LOCATION)
+        val canAccessForegroundService = it.hasGrantedPermissions(Manifest.permission.FOREGROUND_SERVICE)
+        canAccessForegroundService && canAccessForegroundServiceLocation
+      } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
+        val canAccessForegroundService = it.hasGrantedPermissions(Manifest.permission.FOREGROUND_SERVICE)
+        canAccessForegroundService
+      } else {
+        true
+      }
+    } ?: throw Exceptions.AppContextLost()
   }
 
   /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-location",
-  "version": "16.5.4",
+  "version": "16.5.5",
   "description": "Allows reading geolocation information from the device. Your app can poll for the current location or subscribe to location update events.",
   "main": "build/Location.js",
   "types": "build/Location.d.ts",
@@ -44,5 +44,5 @@
   "peerDependencies": {
     "expo": "*"
   },
-  "gitHead": "e94e2aac39cbb7f8788869cd6798bbdeadc58f42"
+  "gitHead": "01bef8630cd9fd913bb465afd010d6030a9ca38f"
 }

package/plugin/build/withLocation.js

@@ -33,6 +33,12 @@ const withLocation = (config, { locationAlwaysAndWhenInUsePermission, locationAl
                 LOCATION_USAGE;
         return config;
     });
+    // If the user has not specified a value for isAndroidForegroundServiceEnabled,
+    // we default to the value of isAndroidBackgroundLocationEnabled because we want
+    // to enable foreground by default if background location is enabled.
+    const enableAndroidForegroundService = typeof isAndroidForegroundServiceEnabled === 'undefined'
+        ? isAndroidBackgroundLocationEnabled
+        : isAndroidForegroundServiceEnabled;
     return config_plugins_1.AndroidConfig.Permissions.withPermissions(config, [
         // Note: these are already added in the library AndroidManifest.xml and so
         // are not required here, we may want to remove them in the future.
@@ -40,8 +46,8 @@ const withLocation = (config, { locationAlwaysAndWhenInUsePermission, locationAl
         'android.permission.ACCESS_FINE_LOCATION',
         // These permissions are optional, and not listed in the library AndroidManifest.xml
         isAndroidBackgroundLocationEnabled && 'android.permission.ACCESS_BACKGROUND_LOCATION',
-        isAndroidForegroundServiceEnabled && 'android.permission.FOREGROUND_SERVICE',
-        isAndroidForegroundServiceEnabled && 'android.permission.FOREGROUND_SERVICE_LOCATION',
+        enableAndroidForegroundService && 'android.permission.FOREGROUND_SERVICE',
+        enableAndroidForegroundService && 'android.permission.FOREGROUND_SERVICE_LOCATION',
     ].filter(Boolean));
 };
 exports.default = (0, config_plugins_1.createRunOncePlugin)(withLocation, pkg.name, pkg.version);

package/plugin/src/withLocation.ts

@@ -61,6 +61,14 @@ const withLocation: ConfigPlugin<
     return config;
   });
 
+  // If the user has not specified a value for isAndroidForegroundServiceEnabled,
+  // we default to the value of isAndroidBackgroundLocationEnabled because we want
+  // to enable foreground by default if background location is enabled.
+  const enableAndroidForegroundService =
+    typeof isAndroidForegroundServiceEnabled === 'undefined'
+      ? isAndroidBackgroundLocationEnabled
+      : isAndroidForegroundServiceEnabled;
+
   return AndroidConfig.Permissions.withPermissions(
     config,
     [
@@ -70,8 +78,8 @@ const withLocation: ConfigPlugin<
       'android.permission.ACCESS_FINE_LOCATION',
       // These permissions are optional, and not listed in the library AndroidManifest.xml
       isAndroidBackgroundLocationEnabled && 'android.permission.ACCESS_BACKGROUND_LOCATION',
-      isAndroidForegroundServiceEnabled && 'android.permission.FOREGROUND_SERVICE',
-      isAndroidForegroundServiceEnabled && 'android.permission.FOREGROUND_SERVICE_LOCATION',
+      enableAndroidForegroundService && 'android.permission.FOREGROUND_SERVICE',
+      enableAndroidForegroundService && 'android.permission.FOREGROUND_SERVICE_LOCATION',
     ].filter(Boolean) as string[]
   );
 };