expo-iap 4.5.0 → 4.5.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (3) hide show
  1. package/package.json +1 -1
  2. package/plugin/build/withIAP.js +5 -2
  3. package/plugin/src/withIAP.ts +5 -2
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "expo-iap",
3
- "version": "4.5.0",
3
+ "version": "4.5.1",
4
4
  "description": "In App Purchase module in Expo",
5
5
  "main": "build/index.js",
6
6
  "types": "build/index.d.ts",
package/plugin/build/withIAP.js CHANGED
@@ -102,8 +102,11 @@ const normalizeGeneratedGroovyAppBuildGradle = (gradle) => {
102
102
  /^(\s*)compileSdk\s+rootProject\.ext\.compileSdkVersion\s*$/gm,
103
103
  '$1compileSdk = rootProject.ext.compileSdkVersion',
104
104
  ],
105
- [/^(\s*)namespace\s+(['"][^'"]+['"])\s*$/gm, '$1namespace = $2'],
106
- [/^(\s*)applicationId\s+(['"][^'"]+['"])\s*$/gm, '$1applicationId = $2'],
105
+ // Note: `namespace` and `applicationId` are intentionally left in
106
+ // method-call form. AGP accepts both, but @expo/config-plugins parses them
107
+ // with regexes that only match the no-`=` form (getApplicationIdAsync and
108
+ // setPackageInBuildGradle), so converting them breaks `expo run:android`
109
+ // app-id resolution. See hyodotdev/openiap#228.
107
110
  [
108
111
  /^(\s*)minSdkVersion\s+rootProject\.ext\.minSdkVersion\s*$/gm,
109
112
  '$1minSdk = rootProject.ext.minSdkVersion',
package/plugin/src/withIAP.ts CHANGED
@@ -106,8 +106,11 @@ export const normalizeGeneratedGroovyAppBuildGradle = (
106
106
  /^(\s*)compileSdk\s+rootProject\.ext\.compileSdkVersion\s*$/gm,
107
107
  '$1compileSdk = rootProject.ext.compileSdkVersion',
108
108
  ],
109
- [/^(\s*)namespace\s+(['"][^'"]+['"])\s*$/gm, '$1namespace = $2'],
110
- [/^(\s*)applicationId\s+(['"][^'"]+['"])\s*$/gm, '$1applicationId = $2'],
109
+ // Note: `namespace` and `applicationId` are intentionally left in
110
+ // method-call form. AGP accepts both, but @expo/config-plugins parses them
111
+ // with regexes that only match the no-`=` form (getApplicationIdAsync and
112
+ // setPackageInBuildGradle), so converting them breaks `expo run:android`
113
+ // app-id resolution. See hyodotdev/openiap#228.
111
114
  [
112
115
  /^(\s*)minSdkVersion\s+rootProject\.ext\.minSdkVersion\s*$/gm,
113
116
  '$1minSdk = rootProject.ext.minSdkVersion',