expo-file-system 18.0.0 → 18.0.2

package/CHANGELOG.md

@@ -10,6 +10,16 @@
 
 ### 💡 Others
 
+## 18.0.2 — 2024-11-11
+
+_This version does not introduce any user-facing changes._
+
+## 18.0.1 — 2024-11-07
+
+### 🐛 Bug fixes
+
+- [expo-file-system][next] Fix download function throwing an unexpected error if destination already exists. ([#32626](https://github.com/expo/expo/pull/32626) by [@aleqsio](https://github.com/aleqsio))
+
 ## 18.0.0 — 2024-10-22
 
 ### 🛠 Breaking changes

package/android/build.gradle

@@ -1,7 +1,7 @@
 apply plugin: 'com.android.library'
 
 group = 'host.exp.exponent'
-version = '18.0.0'
+version = '18.0.2'
 
 def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
 apply from: expoModulesCorePlugin
@@ -14,7 +14,7 @@ android {
   namespace "expo.modules.filesystem"
   defaultConfig {
     versionCode 30
-    versionName "18.0.0"
+    versionName "18.0.2"
   }
 }
 

package/android/src/main/java/expo/modules/filesystem/next/FileSystemNextExceptions.kt

@@ -28,3 +28,8 @@ internal class InvalidPermissionException(permission: Permission) :
   CodedException(
     "Missing '${permission.name}' permission for accessing the file."
   )
+
+internal class DestinationAlreadyExistsException :
+  CodedException(
+    "Destination already exists"
+  )

package/android/src/main/java/expo/modules/filesystem/next/FileSystemNextModule.kt

@@ -52,6 +52,10 @@ class FileSystemNextModule : Module() {
         to.file
       }
 
+      if (destination.exists()) {
+        throw DestinationAlreadyExistsException()
+      }
+
       val body = response.body ?: throw UnableToDownloadException("response body is null")
       body.byteStream().use { input ->
         FileOutputStream(destination).use { output ->

package/ios/Next/FileSystemNextExceptions.swift

@@ -48,3 +48,9 @@ internal class UnableToCreateFileException: GenericException<String> {
     "Unable to create file: \(param)"
   }
 }
+
+internal class DestinationAlreadyExistsException: Exception {
+  override var reason: String {
+    "Destination already exists"
+  }
+}

package/ios/Next/FileSystemNextModule.swift

@@ -33,17 +33,19 @@ public final class FileSystemNextModule: Module {
         }
 
         do {
+          let destination: URL
           if let to = to as? FileSystemDirectory {
             let filename = httpResponse.suggestedFilename ?? url.lastPathComponent
-            let destination = to.url.appendingPathComponent(filename)
-            try FileManager.default.copyItem(at: fileURL, to: to.url.appendingPathComponent(filename))
-            // TODO: Remove .url.absoluteString once returning shared objects works
-            promise.resolve(FileSystemFile(url: destination).url.absoluteString)
+            destination = to.url.appendingPathComponent(filename)
           } else {
-            try FileManager.default.moveItem(at: fileURL, to: to.url)
-            // TODO: Remove .url.absoluteString once returning shared objects works
-            promise.resolve(to.url.absoluteString)
+            destination = to.url
           }
+          if FileManager.default.fileExists(atPath: destination.path) {
+            throw DestinationAlreadyExistsException()
+          }
+          try FileManager.default.moveItem(at: fileURL, to: destination)
+          // TODO: Remove .url.absoluteString once returning shared objects works
+          promise.resolve(destination.absoluteString)
         } catch {
           promise.reject(error)
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-file-system",
-  "version": "18.0.0",
+  "version": "18.0.2",
   "description": "Provides access to the local file system on the device.",
   "main": "src/index.ts",
   "types": "build/index.d.ts",
@@ -36,11 +36,11 @@
   },
   "devDependencies": {
     "expo-module-scripts": "^4.0.0",
-    "jest-expo": "~52.0.0-preview.0"
+    "jest-expo": "~52.0.0"
   },
   "peerDependencies": {
     "expo": "*",
     "react-native": "*"
   },
-  "gitHead": "7c7d2362fff23bec26cd145ed34edd9c403551bd"
+  "gitHead": "8f11fad6f46b878de4746b49b18599fc57b5729f"
 }