expo-file-system 16.0.4 → 16.0.6

package/CHANGELOG.md

@@ -10,6 +10,18 @@
 
 ### 💡 Others
 
+## 16.0.6 — 2024-02-06
+
+### 🐛 Bug fixes
+
+- On `iOS`, fix upload task requests. ([#26880](https://github.com/expo/expo/pull/26880) by [@alanjhughes](https://github.com/alanjhughes))
+
+## 16.0.5 — 2024-01-23
+
+### 🐛 Bug fixes
+
+- On `iOS`, set `httpMethod` on upload requests. ([#26516](https://github.com/expo/expo/pull/26516) by [@alanjhughes](https://github.com/alanjhughes))
+
 ## 16.0.4 — 2024-01-18
 
 _This version does not introduce any user-facing changes._

package/android/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'maven-publish'
 
 group = 'host.exp.exponent'
-version = '16.0.4'
+version = '16.0.6'
 
 def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
 if (expoModulesCorePlugin.exists()) {
@@ -94,7 +94,7 @@ android {
   namespace "expo.modules.filesystem"
   defaultConfig {
     versionCode 30
-    versionName "16.0.4"
+    versionName "16.0.6"
   }
 }
 

package/ios/FileSystemExceptions.swift

@@ -67,3 +67,15 @@ final class CannotDetermineDiskCapacity: Exception {
     "Unable to determine free disk storage capacity"
   }
 }
+
+final class FailedToCreateBodyException: Exception {
+  override var reason: String {
+    "Unable to create multipart body"
+  }
+}
+
+final class FailedToAccessDirectoryException: Exception {
+  override var reason: String {
+    "Failed to access `Caches` directory"
+  }
+}

package/ios/FileSystemModule.swift

@@ -156,7 +156,7 @@ public final class FileSystemModule: Module {
         throw FileNotExistsException(localUrl.path)
       }
       let session = options.sessionType == .background ? backgroundSession : foregroundSession
-      let task = createUploadTask(session: session, targetUrl: targetUrl, sourceUrl: localUrl, options: options)
+      let task = try createUploadTask(session: session, targetUrl: targetUrl, sourceUrl: localUrl, options: options)
       let taskDelegate = EXSessionUploadTaskDelegate(resolve: promise.resolver, reject: promise.legacyRejecter)
 
       sessionTaskDispatcher.register(taskDelegate, for: task)
@@ -165,7 +165,7 @@ public final class FileSystemModule: Module {
 
     AsyncFunction("uploadTaskStartAsync") { (targetUrl: URL, localUrl: URL, uuid: String, options: UploadOptions, promise: Promise) in
       let session = options.sessionType == .background ? backgroundSession : foregroundSession
-      let task = createUploadTask(session: session, targetUrl: targetUrl, sourceUrl: localUrl, options: options)
+      let task = try createUploadTask(session: session, targetUrl: targetUrl, sourceUrl: localUrl, options: options)
       let onSend: EXUploadDelegateOnSendCallback = { [weak self] _, _, totalBytesSent, totalBytesExpectedToSend in
         self?.sendEvent(EVENT_UPLOAD_PROGRESS, [
           "uuid": uuid,

package/ios/NetworkingHelpers.swift

@@ -30,55 +30,69 @@ func createUrlRequest(url: URL, headers: [String: String]?) -> URLRequest {
   return request
 }
 
-func createUploadTask(session: URLSession, targetUrl: URL, sourceUrl: URL, options: UploadOptions) -> URLSessionUploadTask {
+func createUploadTask(session: URLSession, targetUrl: URL, sourceUrl: URL, options: UploadOptions) throws -> URLSessionUploadTask {
   var request = createUrlRequest(url: targetUrl, headers: options.headers)
+  request.httpMethod = options.httpMethod.rawValue
 
   switch options.uploadType {
   case .binaryContent:
     return session.uploadTask(with: request, fromFile: sourceUrl)
   case .multipart:
     let boundaryString = UUID().uuidString
-    let data = try? createMultipartBody(boundary: boundaryString, sourceUrl: sourceUrl, options: options)
+    guard let data = createMultipartBody(boundary: boundaryString, sourceUrl: sourceUrl, options: options) else {
+      throw FailedToCreateBodyException()
+    }
 
     request.setValue("multipart/form-data; boundary=\(boundaryString)", forHTTPHeaderField: "Content-Type")
-    request.httpBody = data
 
-    return session.uploadTask(withStreamedRequest: request)
+    let localURL = try createLocalUrl(from: sourceUrl)
+    try? data.write(to: localURL)
+
+    return session.uploadTask(with: request, fromFile: localURL)
+  }
+}
+
+func createLocalUrl(from sourceUrl: URL) throws -> URL {
+  guard let cachesDir = FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask).first else {
+    throw FailedToAccessDirectoryException()
   }
+  let tempDir = cachesDir.appendingPathComponent("uploads")
+  FileSystemUtilities.ensureDirExists(at: tempDir)
+  return tempDir.appendingPathComponent(sourceUrl.lastPathComponent)
 }
 
-func createMultipartBody(boundary: String, sourceUrl: URL, options: UploadOptions) throws -> Data {
-  let fileName = options.fieldName ?? sourceUrl.lastPathComponent
-  let fileContents = try String(contentsOf: sourceUrl)
-  let mimeType = options.mimeType ?? findMimeType(forAttachment: sourceUrl)
+func createMultipartBody(boundary: String, sourceUrl: URL, options: UploadOptions) -> Data? {
+  let fieldName = options.fieldName ?? sourceUrl.lastPathComponent
+  var mimeType = options.mimeType ?? findMimeType(forAttachment: sourceUrl)
+  guard let data = try? Data(contentsOf: sourceUrl) else {
+    return nil
+  }
 
-  let body = """
-\(headersForMultipartParams(options.parameters, boundary: boundary))
---\(boundary)
-Content-Disposition: form-data; name="\(fileName)"; filename="\(sourceUrl.lastPathComponent)"
-Content-Type: \(mimeType)
+  var body = Data()
+  headersForMultipartParams(options.parameters, boundary: boundary, body: &body)
 
-\(fileContents)
---\(boundary)--
-"""
+  body.append("--\(boundary)\r\n".data)
+  body.append("Content-Disposition: form-data; name=\"\(fieldName)\"; filename=\"\(sourceUrl.lastPathComponent)\"\r\n".data)
+  body.append("Content-Type: \(mimeType)\r\n\r\n".data)
+  body.append(data)
+  body.append("\r\n".data)
+  body.append("--\(boundary)--\r\n".data)
 
-  guard let bodyData = body.data(using: .utf8) else {
-    throw HeaderEncodingFailedException(sourceUrl.absoluteString)
-  }
-  return bodyData
+  return body
 }
 
-func headersForMultipartParams(_ params: [String: String]?, boundary: String) -> String {
-  guard let params else {
-    return ""
+func headersForMultipartParams(_ params: [String: String]?, boundary: String, body: inout Data) {
+  if let params {
+    for (key, value) in params {
+      body.append("--\(boundary)\r\n".data)
+      body.append("Content-Disposition: form-data; name=\"\(key)\"\r\n\r\n".data)
+      body.append("\(value)\r\n".data)
+    }
   }
-  return params.map { (key: String, value: String) in
-"""
---\(boundary)
-Content-Disposition: form-data; name="\(key)"
+}
 
-\(value)
-"""
-  }
-  .joined()
+// All swift strings are unicode correct.
+// This avoids the optional created by string.data(using: .utf8)
+private extension String {
+  var data: Data { Data(self.utf8) }
 }

package/ios/Tests/EXFileSystemSpec.swift

@@ -20,7 +20,7 @@ class EXFileSystemSpec: ExpoSpec {
       it("should handle UTF-8 characters") {
         let utf8UriInput = "file:///var/mobile/中文"
         let utf8UriExpectedOutput = "file:///var/mobile/%E4%B8%AD%E6%96%87"
-        let utf8Uri = fileSystem.percentEncodedURL(fromURIString:utf8UriInput)
+        let utf8Uri = fileSystem.percentEncodedURL(fromURIString: utf8UriInput)
 
         expect(utf8Uri?.absoluteString) == utf8UriExpectedOutput
         expect(utf8Uri?.scheme) == "file"
@@ -29,7 +29,7 @@ class EXFileSystemSpec: ExpoSpec {
       it("should handle URI with percent, numbers and UTF-8 characters") {
         let input = "file:///document/directory/%40%2F中文"
         let expectedOutput = "file:///document/directory/%40%2F%E4%B8%AD%E6%96%87"
-        let uri = fileSystem.percentEncodedURL(fromURIString:input)
+        let uri = fileSystem.percentEncodedURL(fromURIString: input)
 
         expect(uri?.absoluteString) == expectedOutput
       }
@@ -37,7 +37,7 @@ class EXFileSystemSpec: ExpoSpec {
       it("should not decode percentages in URI") {
         let input = "file:///document/hello%2Fworld.txt"
         let unexpectedOutput = "file:///document/hello/world.txt"
-        let uri = fileSystem.percentEncodedURL(fromURIString:input)
+        let uri = fileSystem.percentEncodedURL(fromURIString: input)
 
         // Should not create a directory named "hello"
         expect(uri?.absoluteString) != unexpectedOutput
@@ -45,7 +45,7 @@ class EXFileSystemSpec: ExpoSpec {
 
       it("should handle assets-library URIs") {
         let assetsLibraryUriInput = "assets-library://asset/asset.JPG?id=3C1D9C54-9521-488F-BB27-AA1EA0F8AF04/L0/001&ext=JPG"
-        let assetsLibraryUri = fileSystem.percentEncodedURL(fromURIString:assetsLibraryUriInput)
+        let assetsLibraryUri = fileSystem.percentEncodedURL(fromURIString: assetsLibraryUriInput)
 
         expect(assetsLibraryUri?.absoluteString) == assetsLibraryUriInput
         expect(assetsLibraryUri?.scheme) == "assets-library"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-file-system",
-  "version": "16.0.4",
+  "version": "16.0.6",
   "description": "Provides access to the local file system on the device.",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -41,5 +41,5 @@
   "peerDependencies": {
     "expo": "*"
   },
-  "gitHead": "102899632731658eecba006c0d1c79b98ba8f5f7"
+  "gitHead": "4f3dcf3e23eae997f884117fdd34ad734efad9fd"
 }