expo-dev-launcher 0.7.0 → 0.8.3

package/ios/EXDevLauncher.xcodeproj/xcuserdata/brentvatne.xcuserdatad/xcschemes/xcschememanagement.plist

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>SchemeUserState</key>
+	<dict>
+		<key>EXDevLauncher.xcscheme_^#shared#^_</key>
+		<dict>
+			<key>orderHint</key>
+			<integer>0</integer>
+		</dict>
+	</dict>
+</dict>
+</plist>

package/ios/EXDevLauncherController.h

@@ -3,13 +3,13 @@
 
 #import <UIKit/UIKit.h>
 
+#import <EXManifests/EXManifestsManifest.h>
 #import <EXUpdatesInterface/EXUpdatesExternalInterface.h>
 
 NS_ASSUME_NONNULL_BEGIN
 
 @class EXDevLauncherPendingDeepLinkRegistry;
 @class EXDevLauncherController;
-@class EXDevLauncherManifest;
 @class EXDevLauncherErrorManager;
 
 @protocol EXDevLauncherControllerDelegate <NSObject>
@@ -42,7 +42,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (NSDictionary<UIApplicationLaunchOptionsKey, NSObject*> *)getLaunchOptions;
 
-- (EXDevLauncherManifest * _Nullable)appManifest;
+- (EXManifestsManifest * _Nullable)appManifest;
 
 - (NSURL * _Nullable)appManifestURL;
 

package/ios/EXDevLauncherController.m

@@ -17,7 +17,14 @@
 #import "EXDevLauncherUpdatesHelper.h"
 #import "RCTPackagerConnection+EXDevLauncherPackagerConnectionInterceptor.h"
 
+#if __has_include(<EXDevLauncher/EXDevLauncher-Swift.h>)
+// For cocoapods framework, the generated swift header will be inside EXDevLauncher module
+#import <EXDevLauncher/EXDevLauncher-Swift.h>
+#else
 #import <EXDevLauncher-Swift.h>
+#endif
+
+#import <EXManifests/EXManifestsManifestFactory.h>
 
 @import EXDevMenuInterface;
 
@@ -41,7 +48,7 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
 @property (nonatomic, strong) NSURL *sourceUrl;
 @property (nonatomic, assign) BOOL shouldPreferUpdatesInterfaceSourceUrl;
 @property (nonatomic, strong) EXDevLauncherRecentlyOpenedAppsRegistry *recentlyOpenedAppsRegistry;
-@property (nonatomic, strong) EXDevLauncherManifest *manifest;
+@property (nonatomic, strong) EXManifestsManifest *manifest;
 @property (nonatomic, strong) NSURL *manifestURL;
 @property (nonatomic, strong) EXDevLauncherErrorManager *errorManager;
 
@@ -119,7 +126,7 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
   };
 }
 
-- (EXDevLauncherManifest *)appManifest
+- (EXManifestsManifest *)appManifest
 {
   return self.manifest;
 }
@@ -147,6 +154,9 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
 
   if (!launchOptions[UIApplicationLaunchOptionsURLKey]) {
     [self navigateToLauncher];
+  } else {
+    // For deeplink launch, we need the keyWindow for expo-splash-screen to setup correctly.
+    [_window makeKeyWindow];
   }
 }
 
@@ -277,7 +287,7 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
     }
   };
 
-  void (^launchExpoApp)(NSURL *, EXDevLauncherManifest *) = ^(NSURL *bundleURL, EXDevLauncherManifest *manifest) {
+  void (^launchExpoApp)(NSURL *, EXManifestsManifest *) = ^(NSURL *bundleURL, EXManifestsManifest *manifest) {
     self->_shouldPreferUpdatesInterfaceSourceUrl = !manifest.isUsingDeveloperTool;
     RCTDevLoadingViewSetEnabled(manifest.isUsingDeveloperTool);
     [self.recentlyOpenedAppsRegistry appWasOpened:expoUrl.absoluteString name:manifest.name];
@@ -300,7 +310,7 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
     }
 
     if (!self->_updatesInterface) {
-      [manifestParser tryToParseManifest:^(EXDevLauncherManifest *manifest) {
+      [manifestParser tryToParseManifest:^(EXManifestsManifest *manifest) {
         if (!manifest.isUsingDeveloperTool) {
           onError([NSError errorWithDomain:@"DevelopmentClient" code:1 userInfo:@{NSLocalizedDescriptionKey: @"expo-updates is not properly installed or integrated. In order to load published projects with this development client, follow all installation and setup instructions for both the expo-dev-client and expo-updates packages."}]);
           return;
@@ -311,7 +321,7 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
     }
 
     [self->_updatesInterface fetchUpdateWithConfiguration:updatesConfiguration onManifest:^BOOL(NSDictionary *manifest) {
-      EXDevLauncherManifest *devLauncherManifest = [EXDevLauncherManifest fromJsonObject:manifest];
+      EXManifestsManifest *devLauncherManifest = [EXManifestsManifestFactory manifestForManifestJSON:manifest];
       if (devLauncherManifest.isUsingDeveloperTool) {
         // launch right away rather than continuing to load through EXUpdates
         launchExpoApp([NSURL URLWithString:devLauncherManifest.bundleUrl], devLauncherManifest);
@@ -322,18 +332,18 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
       // do nothing for now
     } success:^(NSDictionary * _Nullable manifest) {
       if (manifest) {
-        launchExpoApp(self->_updatesInterface.launchAssetURL, [EXDevLauncherManifest fromJsonObject:manifest]);
+        launchExpoApp(self->_updatesInterface.launchAssetURL, [EXManifestsManifestFactory manifestForManifestJSON:manifest]);
       }
     } error:onError];
   } onError:onError];
 }
 
-- (void)_initAppWithUrl:(NSURL *)appUrl bundleUrl:(NSURL *)bundleUrl manifest:(EXDevLauncherManifest * _Nullable)manifest
+- (void)_initAppWithUrl:(NSURL *)appUrl bundleUrl:(NSURL *)bundleUrl manifest:(EXManifestsManifest * _Nullable)manifest
 {
   self.manifest = manifest;
   self.manifestURL = appUrl;
-  __block UIInterfaceOrientation orientation = manifest.orientation;
-  __block UIColor *backgroundColor = manifest.backgroundColor;
+  __block UIInterfaceOrientation orientation = [EXDevLauncherManifestHelper exportManifestOrientation:manifest.orientation];
+  __block UIColor *backgroundColor = [EXDevLauncherManifestHelper hexStringToColor:manifest.iosOrRootBackgroundColor];
   
   __weak __typeof(self) weakSelf = self;
   dispatch_async(dispatch_get_main_queue(), ^{
@@ -350,14 +360,15 @@ NSString *fakeLauncherBundleUrl = @"embedded://EXDevLauncher/dummy";
 #endif
     
     if (@available(iOS 12, *)) {
-      [self _applyUserInterfaceStyle:manifest.userInterfaceStyle];
+      UIUserInterfaceStyle userInterfaceStyle = [EXDevLauncherManifestHelper exportManifestUserInterfaceStyle:manifest.userInterfaceStyle];
+      [self _applyUserInterfaceStyle:userInterfaceStyle];
       
       // Fix for the community react-native-appearance.
       // RNC appearance checks the global trait collection and doesn't have another way to override the user interface.
       // So we swap `currentTraitCollection` with one from the root view controller.
       // Note that the root view controller will have the correct value of `userInterfaceStyle`.
       if (@available(iOS 13.0, *)) {
-        if (manifest.userInterfaceStyle != UIUserInterfaceStyleUnspecified) {
+        if (userInterfaceStyle != UIUserInterfaceStyleUnspecified) {
           UITraitCollection.currentTraitCollection = [self.window.rootViewController.traitCollection copy];
         }
       }

package/ios/EXDevLauncherInternal.m

@@ -3,7 +3,12 @@
 #import "EXDevLauncherController.h"
 #import <React/RCTBridge.h>
 
+#if __has_include(<EXDevLauncher/EXDevLauncher-Swift.h>)
+// For cocoapods framework, the generated swift header will be inside EXDevLauncher module
+#import <EXDevLauncher/EXDevLauncher-Swift.h>
+#else
 #import <EXDevLauncher-Swift.h>
+#endif
 
 NSString *ON_NEW_DEEP_LINK_EVENT = @"expo.modules.devlauncher.onnewdeeplink";
 

package/ios/EXDevLauncherMenuDelegate.swift

@@ -48,10 +48,10 @@ private class AppDelegate : DevMenuDelegateProtocol {
     }
     
     return [
-      "appName": manifest.name,
-      "appVersion": manifest.version,
+      "appName": manifest.name(),
+      "appVersion": manifest.version(),
       "appIcon": NSNull(),
-      "hostUrl": manifest.bundleUrl,
+      "hostUrl": manifest.bundleUrl(),
     ]
   }
   

package/ios/Errors/EXDevLauncherRedBox.m

@@ -5,7 +5,12 @@
 #import "EXDevLauncherRedBox.h"
 #import "EXDevLauncherController.h"
 
+#if __has_include(<EXDevLauncher/EXDevLauncher-Swift.h>)
+// For cocoapods framework, the generated swift header will be inside EXDevLauncher module
+#import <EXDevLauncher/EXDevLauncher-Swift.h>
+#else
 #import <EXDevLauncher-Swift.h>
+#endif
 
 @interface EXDevLauncherRedBox ()
 

package/ios/Manifest/EXDevLauncherManifestHelper.swift

@@ -2,8 +2,8 @@
 
 import UIKit
 
-
-class EXDevLauncherManifestHelper {
+@objc
+public class EXDevLauncherManifestHelper: NSObject {
   private static func defaultOrientationForOrientationMask(_ orientationMask: UIInterfaceOrientationMask) -> UIInterfaceOrientation {
     if orientationMask.contains(.portrait) {
       return UIInterfaceOrientation.portrait
@@ -17,19 +17,21 @@ class EXDevLauncherManifestHelper {
     
     return UIInterfaceOrientation.unknown
   }
-  
-  static func exportManifestOrientation(_ orientation: EXDevLauncherOrientation?) -> UIInterfaceOrientation {
+
+  @objc
+  public static func exportManifestOrientation(_ orientation: String?) -> UIInterfaceOrientation {
     var orientationMask = UIInterfaceOrientationMask.all
-    if orientation == EXDevLauncherOrientation.portrait {
+    if orientation == "portrait" {
       orientationMask = .portrait
-    } else if orientation == EXDevLauncherOrientation.landscape {
+    } else if orientation == "landscape" {
       orientationMask = .landscape
     }
     
     return defaultOrientationForOrientationMask(orientationMask)
   }
-  
-  static func hexStringToColor(_ hexString: String?) -> UIColor? {
+
+  @objc
+  public static func hexStringToColor(_ hexString: String?) -> UIColor? {
     guard var hexString = hexString else {
       return nil
     }
@@ -48,13 +50,14 @@ class EXDevLauncherManifestHelper {
                    blue: CGFloat(rgbValue & 0x0000FF) / 255.0,
                    alpha: 1.0)
   }
-  
+
+  @objc
   @available(iOS 12.0, *)
-  static func exportManifestUserInterfaceStyle(_ userInterfaceStyle: EXDevLauncherUserInterfaceStyle?) -> UIUserInterfaceStyle {
+  public static func exportManifestUserInterfaceStyle(_ userInterfaceStyle: String?) -> UIUserInterfaceStyle {
     switch (userInterfaceStyle){
-      case .light:
+      case "light":
         return .light
-      case .dark:
+      case "dark":
         return .dark
       default:
         return .unspecified

package/ios/Manifest/EXDevLauncherManifestParser.h

@@ -1,11 +1,11 @@
 // Copyright 2015-present 650 Industries. All rights reserved.
 
-NS_ASSUME_NONNULL_BEGIN
+#import <EXManifests/EXManifestsManifest.h>
 
-@class EXDevLauncherManifest;
+NS_ASSUME_NONNULL_BEGIN
 
 typedef void (^IsManifestURL)(BOOL isManifestURL);
-typedef void (^OnManifestParsed)(EXDevLauncherManifest *manifest);
+typedef void (^OnManifestParsed)(EXManifestsManifest *manifest);
 typedef void (^OnManifestError)(NSError *error);
 
 @interface EXDevLauncherManifestParser : NSObject

package/ios/Manifest/EXDevLauncherManifestParser.m

@@ -1,7 +1,14 @@
 // Copyright 2015-present 650 Industries. All rights reserved.
 
 #import "EXDevLauncherManifestParser.h"
+#if __has_include(<EXDevLauncher/EXDevLauncher-Swift.h>)
+// For cocoapods framework, the generated swift header will be inside EXDevLauncher module
+#import <EXDevLauncher/EXDevLauncher-Swift.h>
+#else
 #import <EXDevLauncher-Swift.h>
+#endif
+
+#import <EXManifests/EXManifestsManifestFactory.h>
 
 typedef void (^CompletionHandler)(NSData *data, NSURLResponse *response);
 
@@ -63,13 +70,18 @@ typedef void (^CompletionHandler)(NSData *data, NSURLResponse *response);
         return;
       }
     }
-    EXDevLauncherManifest *manifest = [EXDevLauncherManifest fromJsonData:data];
-    if (!manifest) {
-      NSMutableDictionary* details = [NSMutableDictionary dictionary];
-      [details setValue:@"Couldn't parse the manifest." forKey:NSLocalizedDescriptionKey];
-      onError([[NSError alloc] initWithDomain:@"DevelopemntClient" code:1 userInfo:details]);
+    NSError *error;
+    NSDictionary *jsonObject = [NSJSONSerialization JSONObjectWithData:data options:kNilOptions error:&error];
+    if (!jsonObject) {
+      NSMutableDictionary *details = [NSMutableDictionary dictionary];
+      details[NSLocalizedDescriptionKey] = [NSString stringWithFormat:@"Couldn't parse the manifest. %@", (error ? error.localizedDescription : @"")];
+      if (error) {
+        details[NSUnderlyingErrorKey] = error;
+      }
+      onError([[NSError alloc] initWithDomain:@"DevelopmentClient" code:1 userInfo:details]);
       return;
     }
+    EXManifestsManifest *manifest = [EXManifestsManifestFactory manifestForManifestJSON:jsonObject];
     onParsed(manifest);
   }];
 }

package/ios/Tests/EXDevLauncherManifestHelperTests.swift

@@ -0,0 +1,28 @@
+// Copyright 2021-present 650 Industries. All rights reserved.
+
+import XCTest
+
+@testable import EXDevLauncher
+
+class EXDevLauncherManifestHelperTests: XCTestCase {
+  func testExportManifestOrientation() {
+    XCTAssertEqual(UIInterfaceOrientation.portrait, EXDevLauncherManifestHelper.exportManifestOrientation("portrait"))
+    XCTAssertEqual(UIInterfaceOrientation.landscapeLeft, EXDevLauncherManifestHelper.exportManifestOrientation("landscape"))
+    XCTAssertEqual(UIInterfaceOrientation.portrait, EXDevLauncherManifestHelper.exportManifestOrientation("default"))
+    XCTAssertEqual(UIInterfaceOrientation.portrait, EXDevLauncherManifestHelper.exportManifestOrientation("unsupported-value"))
+  }
+
+  func testExportManifestUserInterfaceStyle() {
+    XCTAssertEqual(UIUserInterfaceStyle.light, EXDevLauncherManifestHelper.exportManifestUserInterfaceStyle("light"))
+    XCTAssertEqual(UIUserInterfaceStyle.dark, EXDevLauncherManifestHelper.exportManifestUserInterfaceStyle("dark"))
+    XCTAssertEqual(UIUserInterfaceStyle.unspecified, EXDevLauncherManifestHelper.exportManifestUserInterfaceStyle("automatic"))
+    XCTAssertEqual(UIUserInterfaceStyle.unspecified, EXDevLauncherManifestHelper.exportManifestUserInterfaceStyle("unsupported-value"))
+  }
+
+  func testHexStringToColor() {
+    XCTAssertEqual(UIColor.init(red: 192.0/255.0, green: 1.0, blue: 51.0/255.0, alpha: 1.0), EXDevLauncherManifestHelper.hexStringToColor("#c0ff33"))
+    XCTAssertEqual(UIColor.init(red: 0.0, green: 0.0, blue: 0.0, alpha: 1.0), EXDevLauncherManifestHelper.hexStringToColor("#000000"))
+    XCTAssertNil(EXDevLauncherManifestHelper.hexStringToColor("#000000FF")) // alpha values are not supported
+    XCTAssertNil(EXDevLauncherManifestHelper.hexStringToColor("000000"))
+  }
+}

package/ios/Tests/EXDevLauncherManifestParserTests.m

@@ -4,6 +4,7 @@
 #import <OHHTTPStubs/HTTPStubs.h>
 
 #import <EXDevLauncher/EXDevLauncherManifestParser.h>
+#import <EXManifests/EXManifestsManifest.h>
 
 @interface EXDevLauncherManifestParserTests : XCTestCase
 
@@ -116,4 +117,116 @@
   [self waitForExpectationsWithTimeout:5 handler:nil];
 }
 
+- (void)testParseManifest
+{
+  [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+    return [request.URL.host isEqualToString:@"ohhttpstubs"];
+  } withStubResponse:^HTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
+    NSString *manifestString = @"{\"name\":\"testproject\",\"slug\":\"testproject\",\"version\":\"1.0.0\",\"orientation\":\"portrait\",\"userInterfaceStyle\":\"light\",\"backgroundColor\":\"#c0ff33\",\"sdkVersion\":\"42.0.0\",\"bundleUrl\":\"http://test.io/bundle.js\"}";
+    NSData *jsonData = [manifestString dataUsingEncoding:NSUTF8StringEncoding];
+    return [HTTPStubsResponse responseWithData:jsonData statusCode:200 headers:nil];
+  }];
+
+  NSURL *url = [NSURL URLWithString:@"http://ohhttpstubs"];
+  EXDevLauncherManifestParser *parser = [[EXDevLauncherManifestParser alloc] initWithURL:url session:NSURLSession.sharedSession];
+
+  XCTestExpectation *expectation = [self expectationWithDescription:@"should parse manifest successfully"];
+
+  [parser tryToParseManifest:^(EXManifestsManifest * _Nonnull manifest) {
+    XCTAssertEqualObjects(@"testproject", manifest.name);
+    XCTAssertEqualObjects(@"testproject", manifest.slug);
+    XCTAssertEqualObjects(@"1.0.0", manifest.version);
+    XCTAssertEqualObjects(@"portrait", manifest.orientation);
+    XCTAssertEqualObjects(@"light", manifest.userInterfaceStyle);
+    XCTAssertEqualObjects(@"#c0ff33", manifest.iosOrRootBackgroundColor);
+    XCTAssertEqualObjects(@"http://test.io/bundle.js", manifest.bundleUrl);
+    XCTAssertFalse(manifest.isUsingDeveloperTool);
+    [expectation fulfill];
+  } onError:^(NSError * _Nonnull error) {
+    XCTFail(@"Response should have been successful");
+    [expectation fulfill];
+  }];
+
+  [self waitForExpectationsWithTimeout:5 handler:nil];
+}
+
+- (void)testParseManifest_PlatformSpecificValues
+{
+  [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+    return [request.URL.host isEqualToString:@"ohhttpstubs"];
+  } withStubResponse:^HTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
+    NSString *manifestString = @"{\"name\":\"testproject\",\"slug\":\"testproject\",\"version\":\"1.0.0\",\"orientation\":\"portrait\",\"userInterfaceStyle\":\"light\",\"backgroundColor\":\"#c0ff33\",\"sdkVersion\":\"42.0.0\",\"bundleUrl\":\"http://test.io/bundle.js\",\"ios\":{\"userInterfaceStyle\":\"dark\",\"backgroundColor\":\"#e41c00\"}}";
+    NSData *jsonData = [manifestString dataUsingEncoding:NSUTF8StringEncoding];
+    return [HTTPStubsResponse responseWithData:jsonData statusCode:200 headers:nil];
+  }];
+
+  NSURL *url = [NSURL URLWithString:@"http://ohhttpstubs"];
+  EXDevLauncherManifestParser *parser = [[EXDevLauncherManifestParser alloc] initWithURL:url session:NSURLSession.sharedSession];
+
+  XCTestExpectation *expectation = [self expectationWithDescription:@"should parse manifest successfully"];
+
+  [parser tryToParseManifest:^(EXManifestsManifest * _Nonnull manifest) {
+    XCTAssertEqualObjects(@"dark", manifest.userInterfaceStyle);
+    XCTAssertEqualObjects(@"#e41c00", manifest.iosOrRootBackgroundColor);
+    [expectation fulfill];
+  } onError:^(NSError * _Nonnull error) {
+    XCTFail(@"Response should have been successful");
+    [expectation fulfill];
+  }];
+
+  [self waitForExpectationsWithTimeout:5 handler:nil];
+}
+
+- (void)testParseManifest_DeveloperTool
+{
+  [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+    return [request.URL.host isEqualToString:@"ohhttpstubs"];
+  } withStubResponse:^HTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
+    NSString *manifestString = @"{\"name\":\"testproject\",\"slug\":\"testproject\",\"version\":\"1.0.0\",\"orientation\":\"portrait\",\"userInterfaceStyle\": \"light\",\"backgroundColor\": \"#c0ff33\",\"sdkVersion\":\"42.0.0\",\"bundleUrl\":\"http://test.io/bundle.js\",\"developer\":{\"tool\":\"expo-cli\"}}";
+    NSData *jsonData = [manifestString dataUsingEncoding:NSUTF8StringEncoding];
+    return [HTTPStubsResponse responseWithData:jsonData statusCode:200 headers:nil];
+  }];
+
+  NSURL *url = [NSURL URLWithString:@"http://ohhttpstubs"];
+  EXDevLauncherManifestParser *parser = [[EXDevLauncherManifestParser alloc] initWithURL:url session:NSURLSession.sharedSession];
+
+  XCTestExpectation *expectation = [self expectationWithDescription:@"should parse manifest successfully"];
+
+  [parser tryToParseManifest:^(EXManifestsManifest * _Nonnull manifest) {
+    XCTAssertTrue(manifest.isUsingDeveloperTool);
+    [expectation fulfill];
+  } onError:^(NSError * _Nonnull error) {
+    XCTFail(@"Response should have been successful");
+    [expectation fulfill];
+  }];
+
+  [self waitForExpectationsWithTimeout:5 handler:nil];
+}
+
+- (void)testParseManifest_InvalidJson
+{
+  [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+    return [request.URL.host isEqualToString:@"ohhttpstubs"];
+  } withStubResponse:^HTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
+    NSString *manifestString = @"{invalid json}";
+    NSData *jsonData = [manifestString dataUsingEncoding:NSUTF8StringEncoding];
+    return [HTTPStubsResponse responseWithData:jsonData statusCode:200 headers:nil];
+  }];
+
+  NSURL *url = [NSURL URLWithString:@"http://ohhttpstubs"];
+  EXDevLauncherManifestParser *parser = [[EXDevLauncherManifestParser alloc] initWithURL:url session:NSURLSession.sharedSession];
+
+  XCTestExpectation *expectation = [self expectationWithDescription:@"should fail to parse manifest"];
+
+  [parser tryToParseManifest:^(EXManifestsManifest * _Nonnull manifest) {
+    XCTFail(@"Parsing bad JSON should not have been successful");
+    [expectation fulfill];
+  } onError:^(NSError * _Nonnull error) {
+    XCTAssertNotNil(error);
+    [expectation fulfill];
+  }];
+
+  [self waitForExpectationsWithTimeout:5 handler:nil];
+}
+
 @end

package/ios/Tests/EXDevLauncherModuleTests.m

@@ -5,15 +5,29 @@
 #import <objc/runtime.h>
 #import <EXDevLauncher/EXDevLauncher.h>
 #import <EXDevLauncher/EXDevLauncherController.h>
+#import <EXManifests/EXManifestsManifest.h>
+#import <EXManifests/EXManifestsManifestFactory.h>
 
 @interface EXDevLauncherController (EXDevLauncherModuleTests)
 
+- (EXManifestsManifest * _Nullable)mockAppManifest;
 - (NSURL *)mockAppManifestURL;
 
 @end
 
 @implementation EXDevLauncherController (EXDevLauncherModuleTests)
 
+- (EXManifestsManifest * _Nullable)mockAppManifest
+{
+  return [EXManifestsManifestFactory manifestForManifestJSON:@{
+    @"name": @"testproject",
+    @"slug": @"testproject",
+    @"version": @"1.0.0",
+    @"sdkVersion": @"42.0.0",
+    @"bundleUrl": @"http://test.io/bundle.js"
+  }];
+}
+
 - (NSURL *)mockAppManifestURL
 {
   return [NSURL URLWithString:@"https://exp.host/@test/test?query=param"];
@@ -51,6 +65,31 @@
   }
 }
 
+- (void)testConstantsToExportManifest
+{
+  [self swizzleMethodForClass:[EXDevLauncherController class]
+             originalSelector:@selector(appManifest)
+             swizzledSelector:@selector(mockAppManifest)];
+
+  EXDevLauncher *module = [EXDevLauncher new];
+  NSDictionary *constants = [module constantsToExport];
+
+  NSDictionary *expected = @{
+    @"name": @"testproject",
+    @"slug": @"testproject",
+    @"version": @"1.0.0",
+    @"sdkVersion": @"42.0.0",
+    @"bundleUrl": @"http://test.io/bundle.js"
+  };
+  NSDictionary *actual = [NSJSONSerialization JSONObjectWithData:[constants[@"manifestString"] dataUsingEncoding:NSUTF8StringEncoding] options:kNilOptions error:NULL];
+  XCTAssertEqualObjects(expected, actual);
+
+  // clean up
+  [self swizzleMethodForClass:[EXDevLauncherController class]
+             originalSelector:@selector(appManifest)
+             swizzledSelector:@selector(mockAppManifest)];
+}
+
 - (void)testConstantsToExportManifestURL
 {
   // used by snack