expo-desktop 0.1.6 → 0.1.8

package/build/common/child-process.js

@@ -3,6 +3,7 @@ import fs from "node:fs/promises";
 import path from "node:path";
 import { env } from "node:process";
 import readline from "node:readline";
+import { stripVTControlCharacters } from "node:util";
 /**
  * Clack {@link Task} that runs a subprocess; piped stdout/stderr lines are sent
  * through the task `message` callback (not `log.message`). Lines are also kept in
@@ -74,7 +75,7 @@ function runPromisifiedSpawn({ command, args, options, logLine, debugLogDir, })
             try {
                 await fs.mkdir(logDir, { recursive: true });
                 const body = lineBuffer.length > 0
-                    ? lineBuffer.join("\n")
+                    ? lineBuffer.map((line) => stripVTControlCharacters(line)).join("\n")
                     : "(no stdout/stderr lines were captured; streams may have been inherited or ignored.)";
                 await fs.writeFile(absPath, `${header}${body}\n`, "utf-8");
                 wrotePath = absPath;

package/build/create-app/command.js

@@ -1,13 +1,14 @@
 import { confirm, isCancel, text, log, select } from "@clack/prompts";
 import { default as kleur } from "kleur";
 import { green, grey } from "kleur/colors";
+import { platform } from "node:process";
 import { title } from "../common/clack.js";
-import { createExpoDesktopApp } from "./create-expo-desktop-app.js";
+import { createExpoDesktopApp, localDev } from "./create-expo-desktop-app.js";
 import { previewFileTree } from "./preview-file-tree.js";
 import { promptForVersion } from "./prompt-for-version.js";
 export async function newExpoDesktopProject(args) {
     // A dev-time switch for skipping the questions
-    const skip = true;
+    const skip = localDev;
     if (skip) {
         await createExpoDesktopApp({
             name: {
@@ -40,7 +41,8 @@ export async function newExpoDesktopProject(args) {
             { value: "bun", label: "Bun (recommended)" },
             { value: "pnpm", label: "pnpm" },
         ],
-        initialValue: "bun",
+        // As far as I've found on ARM Windows, Bun just segfaults on install :(
+        initialValue: platform === "win32" ? "pnpm" : "bun",
     });
     if (isCancel(packageManager)) {
         process.exit(0);

package/build/create-app/create-expo-desktop-app.js

@@ -13,11 +13,12 @@ import { packageManagerExec } from "../common/npm.js";
 /**
  * A crude switch to use to help with local development.
  *
+ * - Skips the questionnaire at the start.
  * - Installs the local copy of expo-desktop-config-plugins rather than pinning
  *   to a published release.
  * - Adds the apply-config-plugins.mjs script.
  */
-const localDev = false;
+export const localDev = false;
 export async function createExpoDesktopApp({ name, packageManager, versions, }) {
     const { projectPath } = await createExpoApp({ name, packageManager, versions });
     await appendRootGitignoreSpawnDebugLogs(projectPath);
@@ -76,10 +77,14 @@ export async function createExpoDesktopApp({ name, packageManager, versions, })
 }
 async function createExpoApp({ name, packageManager, versions, }) {
     const command = packageManager;
+    // npm treats flags after `npm create <pkg> <name>` as its own unless we use
+    // `--`; otherwise e.g. `--template` is dropped and the template string becomes
+    // a bogus positional arg (create-expo-app then fails inside `npm pack`).
     const args = [
         "create",
         "expo-app",
         name.filesafeName,
+        ...(packageManager === "npm" ? ["--"] : []),
         "--template",
         `blank-typescript@${versions.expoBlankTypeScript}`,
         "--no-install",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-desktop",
-  "version": "0.1.6",
+  "version": "0.1.8",
   "description": "Best-effort desktop support for Expo",
   "keywords": [
     "android",