expo-desktop 0.1.20 → 0.1.23

package/build/common/child-process.js

@@ -1,14 +1,15 @@
 import { spawn } from "node:child_process";
 import fs from "node:fs/promises";
 import path from "node:path";
-import { env } from "node:process";
+import process from "node:process";
 import readline from "node:readline";
 import { stripVTControlCharacters } from "node:util";
 /**
  * Clack {@link Task} that runs a subprocess; piped stdout/stderr lines are sent
- * through the task `message` callback (not `log.message`). Lines are also kept in
- * an interleaved buffer; on failure they are written under {@link debugLogDir} or
- * {@link SpawnOptions.cwd} or the current working directory.
+ * through the task `message` callback (not `log.message`). Lines are also kept
+ * in an interleaved buffer; on failure they are written under
+ * {@link debugLogDir} or {@link SpawnOptions.cwd} or the current working
+ * directory.
  */
 export function promisifiedSpawnTask({ title, command, args, options = {}, debugLogDir, }) {
     return {
@@ -16,7 +17,16 @@ export function promisifiedSpawnTask({ title, command, args, options = {}, debug
         task: (message) => runPromisifiedSpawn({
             command,
             args,
-            options,
+            options: {
+                // On Windows, Volta-managed package managers are spawned via .cmd
+                // shims which require shell interpretation. Although I've been having
+                // luck with `shell: false` with Volta-managed package managers on
+                // macOS, I'd rather just go with one consistent approach across all
+                // platforms, and `shell: true` will tend to reduce surprises.
+                // https://github.com/shirakaba/expo-desktop/issues/4
+                shell: true,
+                ...options,
+            },
             logLine: message,
             ...(debugLogDir !== undefined ? { debugLogDir } : {}),
         }),
@@ -129,7 +139,7 @@ function envWithForcedColorIfPiped(options) {
     const stdoutMode = Array.isArray(stdio) ? stdio.at(1) : stdio;
     const stderrMode = Array.isArray(stdio) ? stdio.at(2) : stdio;
     const capturesOutput = stdoutMode !== "inherit" || stderrMode !== "inherit";
-    const base = { ...env, ...options?.env };
+    const base = { ...process.env, ...options?.env };
     if (!capturesOutput || base.NO_COLOR !== undefined) {
         return base;
     }

package/build/create-app/create-expo-desktop-app.js

@@ -272,6 +272,9 @@ async function updatePackageJson({ localDev, name, projectPath, task, versions,
             ["expo-desktop-stubs"]: `^${versions.expoMajor}.0.0`,
         };
         for (const [key, value] of Object.entries(monorepoDeps)) {
+            // TODO: Try replacing this `localDev` logic with `linkWorkspacePackages`:
+            // - https://pnpm.io/workspaces#linkworkspacepackages
+            // - https://pnpm.io/workspaces#workspace-protocol-workspace
             packageJson.dependencies[key] = localDev ? `file:../../${key}` : value;
         }
         packageJson.dependencies["react-native-macos"] = versions.macos;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-desktop",
-  "version": "0.1.20",
+  "version": "0.1.23",
   "description": "Best-effort desktop support for Expo",
   "keywords": [
     "android",
@@ -37,12 +37,12 @@
     "@clack/prompts": "^1.2.0",
     "arktype": "^2.2.0",
     "citty": "^0.2.2",
+    "expo-desktop-config-plugins": "^1.1.22",
+    "expo-desktop-prebuild-config": "^1.0.11",
     "glob": "^10.5.0",
     "kleur": "^4.1.5",
     "mustache": "^4.2.0",
-    "toml": "^4.1.1",
-    "expo-desktop-config-plugins": "1.1.20",
-    "expo-desktop-prebuild-config": "1.0.9"
+    "toml": "^4.1.1"
   },
   "devDependencies": {
     "@expo/config": "^12.0.13",