expo-clipboard 4.8.0 → 5.0.1

package/CHANGELOG.md

@@ -10,6 +10,16 @@
 
 ### 💡 Others
 
+## 5.0.1 — 2023-12-19
+
+_This version does not introduce any user-facing changes._
+
+## 5.0.0 — 2023-12-12
+
+### 🐛 Bug fixes
+
+- [Android] Fix path traversal vulnerability in `getFileForUri` function. ([#25549](https://github.com/expo/expo/pull/25549) by [@behenate](https://github.com/behenate))
+
 ## 4.8.0 — 2023-11-14
 
 ### 🛠 Breaking changes

package/android/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'maven-publish'
 
 group = 'host.exp.exponent'
-version = '4.8.0'
+version = '5.0.1'
 
 def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
 if (expoModulesCorePlugin.exists()) {
@@ -94,7 +94,7 @@ android {
   namespace "expo.modules.clipboard"
   defaultConfig {
     versionCode 3
-    versionName '4.8.0'
+    versionName '5.0.1'
   }
 }
 

package/android/src/main/java/expo/modules/clipboard/ClipboardExceptions.kt

@@ -17,7 +17,7 @@ internal class CopyFailureException(cause: Throwable?, kind: String = "item") :
 internal class InvalidImageException(image: String, cause: Throwable?) :
   CodedException(
     "Invalid base64 image: ${
-    image.run { substring(0, minOf(length, 32)) + if (length > 32) "..." else ""}
+      image.run { substring(0, minOf(length, 32)) + if (length > 32) "..." else ""}
     }",
     cause
   )

package/android/src/main/java/expo/modules/clipboard/ClipboardFileProvider.kt

@@ -93,6 +93,7 @@ class ClipboardFileProvider : ContentProvider() {
           columns[i] = OpenableColumns.DISPLAY_NAME
           values[i++] = file.name
         }
+
         OpenableColumns.SIZE -> {
           columns[i] = OpenableColumns.SIZE
           values[i++] = file.length()
@@ -223,10 +224,12 @@ class ClipboardFileProvider : ContentProvider() {
         val externalFilesDirs: Array<File> = context.getExternalFilesDirs(null)
         externalFilesDirs.takeIf { it.isNotEmpty() }?.let { it[0] }
       }
+
       TAG_EXTERNAL_CACHE -> {
         val externalCacheDirs: Array<File> = context.externalCacheDirs
         externalCacheDirs.takeIf { it.isNotEmpty() }?.let { it[0] }
       }
+
       else -> null
     }
 
@@ -309,9 +312,9 @@ class ClipboardFileProvider : ContentProvider() {
       for (root in roots.entries) {
         val rootPath = root.value.path
         if (path.startsWith(rootPath) && (
-          mostSpecific == null ||
-            rootPath.length > mostSpecific.value.path.length
-          )
+            mostSpecific == null ||
+              rootPath.length > mostSpecific.value.path.length
+            )
         ) {
           mostSpecific = root
         }
@@ -348,7 +351,7 @@ class ClipboardFileProvider : ContentProvider() {
       } catch (e: IOException) {
         throw java.lang.IllegalArgumentException("Failed to resolve canonical path for $file")
       }
-      if (!file.path.startsWith(root.path)) {
+      if (!file.startsWith(root)) {
         throw SecurityException("Resolved path jumped beyond configured root")
       }
       return file

package/android/src/main/java/expo/modules/clipboard/ClipboardImage.kt

@@ -32,7 +32,7 @@ data class ImageResult(
     "size" to bundleOf(
       "width" to width,
       "height" to height
-    ),
+    )
   )
 }
 // endregion
@@ -93,7 +93,7 @@ internal suspend fun imageFromContentUri(
 internal suspend fun clipDataFromBase64Image(
   context: Context,
   base64Image: String,
-  clipboardCacheDir: File,
+  clipboardCacheDir: File
 ): ClipData {
   // 1. Get bitmap from base64 string
   val bitmap = bitmapFromBase64String(base64Image)

package/android/src/main/java/expo/modules/clipboard/ClipboardOptions.kt

@@ -24,7 +24,8 @@ internal class SetStringOptions : Record {
 }
 
 internal enum class ImageFormat(val jsName: String) : Enumerable {
-  JPG("jpeg"), PNG("png");
+  JPG("jpeg"),
+  PNG("png");
 
   val compressFormat: Bitmap.CompressFormat
     get() = when (this) {

package/ios/Tests/ClipboardModuleSpec.swift

@@ -6,7 +6,7 @@ import UIKit
 import MobileCoreServices
 
 class ClipboardModuleSpec: ExpoSpec {
-  override func spec() {
+  override class func spec() {
     let appContext = AppContext.create()
     let holder = ModuleHolder(appContext: appContext, module: ClipboardModule(appContext: appContext))
 
@@ -24,7 +24,9 @@ class ClipboardModuleSpec: ExpoSpec {
     func expectModuleFunctionThrows<T>(_ functionName: String, args: [Any], exception: T.Type) where T: Exception {
       waitUntil(timeout: .seconds(3)) { done in
         holder.call(function: functionName, args: args) { result in
-          expect(result).to(beFailure(exception: exception))
+          expect(result).to(beFailure { error in
+            expect(error.rootCause is T).to(beTrue())
+          })
           done()
         }
       }
@@ -304,16 +306,3 @@ class ClipboardModuleSpec: ExpoSpec {
     }
   }
 }
-
-// TODO: (barthap) Replace this with built-in beFailure() when upgraded to Nimble 10.0
-func beFailure<Success, Failure, T: Exception>(exception: T.Type) -> Nimble.Predicate<Result<Success, Failure>> {
-  return Predicate.simple("be \(exception)") { actualExpression in
-    guard let actual = try actualExpression.evaluate(),
-          case let .failure(error) = actual,
-          (error as? Exception)?.rootCause is T
-    else {
-      return .doesNotMatch
-    }
-    return .matches
-  }
-}

package/ios/Tests/MockNSAttributedString.swift

@@ -14,7 +14,10 @@ class MockNSAttributedString: NSAttributedString {
   }
 
   override var rtfData: Data? {
-    return try? self.data(from: NSRange(location: 0, length: self.length))
+    return try? self.data(
+      from: NSRange(location: 0, length: self.length),
+      documentAttributes: [.documentType: NSAttributedString.DocumentType.rtf]
+    )
   }
 
   override var htmlString: String? {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-clipboard",
-  "version": "4.8.0",
+  "version": "5.0.1",
   "description": "ExpoClipboard standalone module",
   "main": "build/Clipboard.js",
   "types": "build/Clipboard.d.ts",
@@ -39,5 +39,5 @@
   "jest": {
     "preset": "expo-module-scripts/universal"
   },
-  "gitHead": "3142a086578deffd8704a8f1b6f0f661527d836c"
+  "gitHead": "43f1b4f8a5a9bca649e4e7ca6e4155482a162431"
 }