expo-camera 13.4.0 → 13.4.2

package/CHANGELOG.md

@@ -10,6 +10,18 @@
 
 ### 💡 Others
 
+## 13.4.2 — 2023-07-04
+
+### 🐛 Bug fixes
+
+- Fix crash when onBarCodeScanned or onFacesDetected callback is removed. ([#23223](https://github.com/expo/expo/pull/23223) by [@thespacemanatee](https://github.com/thespacemanatee))
+
+## 13.4.1 — 2023-06-28
+
+### 🐛 Bug fixes
+
+- Resolved an issue on Android where recording a video, even with the mute: true option, would still result in an audio permission exception. Furthermore, the mute flag was incorrectly referred to as muteValue, causing it to be consistently ignored ([#23145](https://github.com/expo/expo/pull/23145) by [@hirbod](https://github.com/hirbod))
+
 ## 13.4.0 — 2023-06-13
 
 - Fixed `Expo camera - Cannot take landscape photos if screen orientation is locked'` on iOS. ([#21938](https://github.com/expo/expo/issues/21938) by [@chalenascholl](https://github.com/chalenascholl)) ([#21956](https://github.com/expo/expo/pull/21956) by [@chalenascholl](https://github.com/chalenascholl))

package/android/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'maven-publish'
 
 group = 'host.exp.exponent'
-version = '13.4.0'
+version = '13.4.2'
 
 buildscript {
   def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
@@ -67,7 +67,7 @@ android {
     minSdkVersion safeExtGet("minSdkVersion", 21)
     targetSdkVersion safeExtGet("targetSdkVersion", 33)
     versionCode 32
-    versionName "13.4.0"
+    versionName "13.4.2"
   }
 
   lintOptions {

package/android/src/main/java/expo/modules/camera/CameraViewModule.kt

@@ -83,7 +83,7 @@ class CameraViewModule : Module() {
     }.runOnQueue(Queues.MAIN)
 
     AsyncFunction("record") { options: RecordingOptions, viewTag: Int, promise: Promise ->
-      if (!permissionsManager.hasGrantedPermissions(Manifest.permission.RECORD_AUDIO)) {
+      if (!options.mute && !permissionsManager.hasGrantedPermissions(Manifest.permission.RECORD_AUDIO)) {
         throw Exceptions.MissingPermissions(Manifest.permission.RECORD_AUDIO)
       }
 
@@ -238,12 +238,12 @@ class CameraViewModule : Module() {
         view.cameraView.setUsingCamera2Api(useCamera2Api)
       }
 
-      Prop("barCodeScannerEnabled") { view: ExpoCameraView, barCodeScannerEnabled: Boolean ->
-        view.setShouldScanBarCodes(barCodeScannerEnabled)
+      Prop("barCodeScannerEnabled") { view: ExpoCameraView, barCodeScannerEnabled: Boolean? ->
+        view.setShouldScanBarCodes(barCodeScannerEnabled ?: false)
       }
 
-      Prop("faceDetectorEnabled") { view: ExpoCameraView, faceDetectorEnabled: Boolean ->
-        view.setShouldDetectFaces(faceDetectorEnabled)
+      Prop("faceDetectorEnabled") { view: ExpoCameraView, faceDetectorEnabled: Boolean? ->
+        view.setShouldDetectFaces(faceDetectorEnabled ?: false)
       }
 
       Prop("faceDetectorSettings") { view: ExpoCameraView, settings: Map<String, Any>? ->

package/android/src/main/java/expo/modules/camera/ExpoCameraView.kt

@@ -165,7 +165,7 @@ class ExpoCameraView(
       val path = FileSystemUtils.generateOutputPath(cacheDirectory, "Camera", ".mp4")
       val profile = getCamcorderProfile(cameraView.cameraId, options.quality)
       options.videoBitrate?.let { profile.videoBitRate = it }
-      if (cameraView.record(path, options.maxDuration * 1000, options.maxFileSize, !options.muteValue, profile)) {
+      if (cameraView.record(path, options.maxDuration * 1000, options.maxFileSize, !options.mute, profile)) {
         videoRecordedPromise = promise
       } else {
         promise.reject("E_RECORDING_FAILED", "Starting video recording failed. Another recording might be in progress.", null)

package/android/src/main/java/expo/modules/camera/Options.kt

@@ -19,6 +19,6 @@ class RecordingOptions : Record {
   @Field val maxDuration: Int = -1
   @Field val maxFileSize: Int = -1
   @Field val quality: Int = CamcorderProfile.QUALITY_HIGH
-  @Field val muteValue: Boolean = false
+  @Field val mute: Boolean = false
   @Field val videoBitrate: Int? = null
 }

package/ios/EXCamera/CameraViewModule.swift

@@ -126,15 +126,15 @@ public final class CameraViewModule: Module {
         view.updatePictureSize()
       }
 
-      Prop("faceDetectorEnabled") { (view, detectFaces: Bool) in
+      Prop("faceDetectorEnabled") { (view, detectFaces: Bool?) in
         if view.isDetectingFaces != detectFaces {
-          view.isDetectingFaces = detectFaces
+          view.isDetectingFaces = detectFaces ?? false
         }
       }
 
-      Prop("barCodeScannerEnabled") { (view, scanBarCodes: Bool) in
+      Prop("barCodeScannerEnabled") { (view, scanBarCodes: Bool?) in
         if view.isScanningBarCodes != scanBarCodes {
-          view.isScanningBarCodes = scanBarCodes
+          view.isScanningBarCodes = scanBarCodes ?? false
         }
       }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-camera",
-  "version": "13.4.0",
+  "version": "13.4.2",
   "description": "A React component that renders a preview for the device's either front or back camera. Camera's parameters like zoom, auto focus, white balance and flash mode are adjustable. With expo-camera, one can also take photos and record videos that are saved to the app's cache. Morever, the component is also capable of detecting faces and bar codes appearing on the preview.",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -43,5 +43,5 @@
   "peerDependencies": {
     "expo": "*"
   },
-  "gitHead": "3ccd2edee9cbfed217557675cb50f0ba5e55a9e4"
+  "gitHead": "cf90d5c30c2a08a6493ebfa8aa3791aa70666759"
 }