explorbot 0.1.27 → 0.1.28

package/src/ai/tester.ts

@@ -4,7 +4,7 @@ import { tool } from 'ai';
 import dedent from 'dedent';
 import { z } from 'zod';
 import { ActionResult } from '../action-result.ts';
-import { setActivity } from '../activity.ts';
+import { clearActivity, setActivity } from '../activity.ts';
 import { ConfigParser } from '../config.ts';
 import type { ExperienceTracker } from '../experience-tracker.ts';
 import type Explorer from '../explorer.ts';
@@ -13,7 +13,7 @@ import type { StateTransition, WebPageState } from '../state-manager.ts';
 import { Stats } from '../stats.ts';
 import { type Note, type Test, TestResult, type TestResultType } from '../test-plan.ts';
 import { detectFocusArea, extractFocusedElement } from '../utils/aria.ts';
-import { ErrorPageError } from '../utils/error-page.ts';
+import { ErrorPageError, isErrorPage } from '../utils/error-page.ts';
 import { HooksRunner } from '../utils/hooks-runner.ts';
 import { codeToMarkdown } from '../utils/html.ts';
 import { createDebug, tag } from '../utils/logger.ts';
@@ -136,18 +136,13 @@ export class Tester extends TaskAgent implements Agent {
       task.addNote(`Network error: ${r.method} ${r.path} → ${r.status}`, TestResult.FAILED);
     });
 
-    const page = this.explorer.playwrightHelper?.page;
-    const onPageError = (err: Error) => {
-      task.addNote(`Console error: ${err.message}`, TestResult.FAILED);
-    };
-    const onConsoleMessage = (msg: any) => {
-      if (msg.type() !== 'error') return;
-      task.addNote(`Console error: ${msg.text()}`, TestResult.FAILED);
-    };
-    page?.on('pageerror', onPageError);
-    page?.on('console', onConsoleMessage);
-
     const initialState = ActionResult.fromState(state);
+    if (isErrorPage(initialState)) {
+      task.start();
+      await this.explorer.startTest(task);
+      offFailedRequest?.();
+      return await this.abortStartedTestOnErrorPage(task, initialState);
+    }
 
     const conversation = this.provider.startConversation(this.getSystemMessage(), 'tester');
     conversation.markLastMessageCacheable();
@@ -176,20 +171,18 @@ export class Tester extends TaskAgent implements Agent {
           expected: task.expected,
         },
       },
-      async () => this.runTestSession(task, initialState, conversation, { offFailedRequest, page, onPageError, onConsoleMessage })
+      async () => this.runTestSession(task, initialState, conversation, { offFailedRequest })
     );
   }
 
-  private async runTestSession(task: Test, initialState: ActionResult, conversation: Conversation, handlers: { offFailedRequest?: () => void; page: any; onPageError: (err: Error) => void; onConsoleMessage: (msg: any) => void }): Promise<{ success: boolean }> {
-    const { offFailedRequest, page, onPageError, onConsoleMessage } = handlers;
+  private async runTestSession(task: Test, initialState: ActionResult, conversation: Conversation, handlers: TestSessionHandlers): Promise<{ success: boolean }> {
+    const { offFailedRequest } = handlers;
 
     if (this.pilot) {
       try {
         const plan = await this.pilot.planTest(task, initialState);
         if (task.hasFinished) {
           offFailedRequest?.();
-          page?.off('pageerror', onPageError);
-          page?.off('console', onConsoleMessage);
           return { success: task.isSuccessful };
         }
         if (plan) {
@@ -201,22 +194,39 @@ export class Tester extends TaskAgent implements Agent {
         task.addNote(`Planning failed: ${message}`, TestResult.FAILED);
         task.finish(TestResult.FAILED);
         offFailedRequest?.();
-        page?.off('pageerror', onPageError);
-        page?.off('console', onConsoleMessage);
         return { success: false };
       }
     }
 
     debugLog('Starting test execution with tools');
 
-    task.start();
-    await this.explorer.startTest(task);
+    if (!(await this.explorer.startTest(task))) {
+      offFailedRequest?.();
+      await this.cleanupStartedTest(task);
+      return { success: task.isSuccessful };
+    }
 
     debugLog(`Navigating to ${task.startUrl}`);
-    await this.explorer.visit(task.startUrl!);
+    try {
+      await this.explorer.visit(task.startUrl!);
+    } catch (error) {
+      const result = await this.handleLoopError(task, error);
+      if (result === 'stop') {
+        offFailedRequest?.();
+        await this.cleanupStartedTest(task);
+        return { success: task.isSuccessful };
+      }
+    }
 
     const startState = this.explorer.getStateManager().getCurrentState();
-    if (startState) task.addUrlNote(startState);
+    if (startState) {
+      task.addUrlNote(startState);
+      const startActionResult = ActionResult.fromState(startState);
+      if (isErrorPage(startActionResult)) {
+        offFailedRequest?.();
+        return await this.abortStartedTestOnErrorPage(task, startActionResult);
+      }
+    }
     const currentUrl = startState?.url || task.startUrl || '';
     await this.hooksRunner.runBeforeHook('tester', currentUrl);
 
@@ -238,6 +248,12 @@ export class Tester extends TaskAgent implements Agent {
       await loop(
         async ({ stop, pause, iteration, userInput }) => {
           debugLog('iteration', iteration);
+          if (!(await this.explorer.ensurePageAvailable())) {
+            task.addNote('Browser page is unavailable');
+            task.finish(TestResult.FAILED);
+            stop();
+            return;
+          }
           const currentState = this.getCurrentState();
 
           const tools = {
@@ -385,22 +401,16 @@ export class Tester extends TaskAgent implements Agent {
               }
             : undefined,
           catch: async ({ error, stop }) => {
-            tag('error').log(`Test execution error: ${error}`);
-            const message = error instanceof Error ? error.message : String(error);
-            if (!task.hasFinished) {
-              task.addNote(`Execution error: ${message}`);
-            }
-            if (error instanceof Error && error.name === 'AbortError') {
-              stop();
-              return;
-            }
-            conversation.addUserText(`Previous AI call failed: ${message}. Take a different approach on the next step.`);
+            const result = await this.handleLoopError(task, error);
+            if (result === 'stop') stop();
           },
         }
       );
 
       if (task.hasFinished) break;
 
+      if (!(await this.explorer.ensurePageAvailable())) break;
+
       const finalState = this.getCurrentState();
       const wantsContinue = await this.pilot!.finalReview(task, finalState, conversation, this.navigator);
 
@@ -429,14 +439,8 @@ export class Tester extends TaskAgent implements Agent {
 
     offStateChange();
     offFailedRequest?.();
-    page?.off('pageerror', onPageError);
-    page?.off('console', onConsoleMessage);
     await this.finishTest(task);
-    await this.explorer.stopTest(task, {
-      startUrl: task.startUrl,
-      style: task.style,
-      sessionName: task.sessionName,
-    });
+    await this.explorer.stopTest(task, this.buildStopTestMeta(task));
 
     return {
       success: task.isSuccessful,
@@ -689,6 +693,26 @@ export class Tester extends TaskAgent implements Agent {
     }
   }
 
+  private async abortStartedTestOnErrorPage(task: Test, actionResult: ActionResult): Promise<{ success: boolean }> {
+    const error = new ErrorPageError(actionResult.url || task.startUrl || '', actionResult.title, actionResult.httpStatus);
+    tag('warning').log(error.message);
+    task.addNote(error.message, TestResult.FAILED, actionResult.screenshotFile, actionResult.fullUrl || actionResult.url);
+    task.finish(TestResult.FAILED);
+    this.finishTest(task);
+    await this.explorer.stopTest(task, this.buildStopTestMeta(task));
+    clearActivity(true);
+    return { success: false };
+  }
+
+  private buildStopTestMeta(task: Test): Record<string, string> {
+    const meta: Record<string, string> = {
+      startUrl: task.startUrl,
+    };
+    if (task.style) meta.style = task.style;
+    if (task.sessionName) meta.sessionName = task.sessionName;
+    return meta;
+  }
+
   getSystemMessage(): string {
     return dedent`
     <role>
@@ -1093,4 +1117,40 @@ export class Tester extends TaskAgent implements Agent {
       }),
     };
   }
+
+  private async handleLoopError(task: Test, error: unknown): Promise<'continue' | 'stop'> {
+    const message = error instanceof Error ? error.message : String(error);
+    if (!task.hasFinished) task.addNote(`Execution error: ${message}`);
+
+    const result = await this.explorer.handleExecutionError(error);
+    tag('info').log(`Browser supervisor: ${result.action} - ${result.message}`);
+    task.addNote(result.message);
+
+    if (result.action === 'stop') {
+      task.finish(TestResult.FAILED);
+      return 'stop';
+    }
+
+    if (result.recovered) {
+      this.resetFailureCount();
+      this.previousUrl = null;
+      this.previousStateHash = null;
+    }
+
+    this.currentConversation?.addUserText(result.message);
+    return 'continue';
+  }
+
+  private async cleanupStartedTest(task: Test): Promise<void> {
+    await this.finishTest(task);
+    await this.explorer.stopTest(task, {
+      startUrl: task.startUrl,
+      style: task.style,
+      sessionName: task.sessionName,
+    });
+  }
+}
+
+interface TestSessionHandlers {
+  offFailedRequest?: () => void;
 }

package/src/ai/tools.ts

@@ -6,6 +6,7 @@ import type { ExperienceTracker } from '../experience-tracker.ts';
 import type Explorer from '../explorer.ts';
 import { type Task, TestResult } from '../test-plan.js';
 import { extractFocusedElement } from '../utils/aria.ts';
+import { isFatalBrowserError } from '../utils/browser-errors.ts';
 import { createDebug, tag } from '../utils/logger.js';
 import { pause } from '../utils/loop.js';
 import { WebElement } from '../utils/web-element.ts';
@@ -287,6 +288,7 @@ export function createCodeceptJSTools(explorer: Explorer, task: Task) {
             suggestion: 'Verify the key name is correct. For typing text, use form() tool instead.',
           });
         } catch (error) {
+          throwIfFatalBrowserError(error);
           activeNote.commit(TestResult.FAILED);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           return failedToolResult('pressKey', `PressKey tool failed: ${errorMessage}`);
@@ -405,6 +407,7 @@ export function createCodeceptJSTools(explorer: Explorer, task: Task) {
             action
           );
         } catch (error) {
+          throwIfFatalBrowserError(error);
           activeNote.commit(TestResult.FAILED);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           return failedToolResult('form', `Form tool failed: ${errorMessage}`);
@@ -444,8 +447,7 @@ export function createSpecialContextTools(explorer: Explorer, context: 'iframe')
 
           await explorer.switchToMainFrame();
 
-          const action = explorer.createAction();
-          const nextState = await action.capturePageState();
+          const nextState = await explorer.capturePageState();
           const toolResult = await nextState.toToolResult(previousState, 'I.switchTo()');
 
           return successToolResult('exitIframe', {
@@ -454,6 +456,7 @@ export function createSpecialContextTools(explorer: Explorer, context: 'iframe')
             code: 'I.switchTo()',
           });
         } catch (error) {
+          throwIfFatalBrowserError(error);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           return failedToolResult('exitIframe', `Failed to exit iframe: ${errorMessage}`);
         }
@@ -500,8 +503,7 @@ export function createAgentTools({
         }
 
         try {
-          const action = explorer.createAction();
-          const actionResult = await action.caputrePageWithScreenshot();
+          const actionResult = await explorer.capturePageWithScreenshot();
 
           if (!actionResult.screenshot) {
             return failedToolResult('see', 'Failed to capture screenshot for analysis');
@@ -519,6 +521,7 @@ export function createAgentTools({
             suggestion: 'Visual confirmation is valid evidence for test results. Use record() to note the visual findings.',
           });
         } catch (error) {
+          throwIfFatalBrowserError(error);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           visionDisabled = true;
           tag('warning').log('⚠️ Vision model is not available. Visual checks are disabled for this session.');
@@ -600,8 +603,7 @@ export function createAgentTools({
             });
           }
 
-          const action = explorer.createAction();
-          const actionResult = await action.capturePageState();
+          const actionResult = await explorer.capturePageState();
           const result = await navigator.verifyState(assertion, actionResult);
 
           if (result.verified) {
@@ -619,6 +621,7 @@ export function createAgentTools({
             suggestion: 'The assertion could not be verified. Check if the condition is actually present on the page or try a different assertion.',
           });
         } catch (error) {
+          throwIfFatalBrowserError(error);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           return failedToolResult('verify', `Verify tool failed: ${errorMessage}`, {
             error: errorMessage,
@@ -674,6 +677,7 @@ export function createAgentTools({
             `,
           });
         } catch (error) {
+          throwIfFatalBrowserError(error);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           return failedToolResult('research', `Research tool failed: ${errorMessage}`, {
             error: errorMessage,
@@ -718,6 +722,7 @@ export function createAgentTools({
             suggestion: 'The action could not be completed. Try a different instruction or use more specific element descriptions.',
           });
         } catch (error) {
+          throwIfFatalBrowserError(error);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           return failedToolResult('interact', `Interact tool failed: ${errorMessage}`, {
             error: errorMessage,
@@ -756,7 +761,7 @@ export function createAgentTools({
 
           const previousState = ActionResult.fromState(currentState);
           const action = explorer.createAction();
-          const actionResult = await action.caputrePageWithScreenshot();
+          const actionResult = await explorer.capturePageWithScreenshot();
 
           if (!actionResult.screenshot) {
             return failedToolResult('visualClick', 'Failed to capture screenshot for visual analysis');
@@ -797,6 +802,7 @@ export function createAgentTools({
             analysis: locationResult,
           });
         } catch (error) {
+          throwIfFatalBrowserError(error);
           const errorMessage = error instanceof Error ? error.toString() : 'Unknown error occurred';
           visionDisabled = true;
           tag('warning').log('⚠️ Vision model is not available. Visual clicks are disabled for this session.');
@@ -1018,6 +1024,10 @@ function cap(text: string | undefined | null, max: number): string {
   return `${text.slice(0, max)}\n[...truncated; ${text.length - max} chars omitted...]`;
 }
 
+function throwIfFatalBrowserError(error: unknown): void {
+  if (isFatalBrowserError(error)) throw error;
+}
+
 function transformContainsCommand(command: string): string {
   if (!command.includes(':contains(')) return command;
 

package/src/commands/explore-command.ts

@@ -5,7 +5,7 @@ import { normalizeUrl } from '../state-manager.js';
 import { Stats } from '../stats.js';
 import { type Plan, type Test, TestResult } from '../test-plan.js';
 import { getCliName } from '../utils/cli-name.ts';
-import { ErrorPageError } from '../utils/error-page.ts';
+import { ErrorPageError, getStateErrorPageError } from '../utils/error-page.ts';
 import { tag } from '../utils/logger.js';
 import { type NextStepSection, printNextSteps, relativeToCwd } from '../utils/next-steps.ts';
 import { safeFilename } from '../utils/strings.ts';
@@ -56,6 +56,11 @@ export class ExploreCommand extends BaseCommand {
     Stats.mode ??= 'explore';
     Stats.focus ??= feature;
     const mainUrl = this.getCurrentPageUrl();
+    const error = getStateErrorPageError(this.explorBot.getExplorer().getStateManager().getCurrentState());
+    if (error) {
+      tag('warning').log(error.message);
+      return;
+    }
 
     if (cfg.enabled) {
       await this.runReuseMode(mainUrl, feature, cfg);

package/src/components/LogPane.tsx

@@ -121,6 +121,7 @@ const LogPane: React.FC<LogPaneProps> = React.memo(({ verboseMode }) => {
       case 'step':
         return { color: 'cyan' as const, dimColor: true };
       case 'multiline':
+      case 'details':
         return { color: 'gray' as const, dimColor: true };
       case 'html':
         return { color: 'gray' as const };
@@ -143,16 +144,16 @@ const LogPane: React.FC<LogPaneProps> = React.memo(({ verboseMode }) => {
     }
     const styles = getLogStyles(log.type);
 
-    if (log.type === 'multiline') {
+    if (log.type === 'multiline' || log.type === 'details') {
       const cleaned = stripAnsi(dedent(log.content));
       const parsed = parseMarkdownToTerminal(cleaned);
       const lines = parsed.split('\n');
       const maxLines = log.maxLines || 16;
-      const truncated = lines.length > maxLines ? `${lines.slice(0, maxLines).join('\n')}\n... (${lines.length - maxLines} more lines)` : parsed;
+      const content = log.type === 'details' ? parsed : lines.length > maxLines ? `${lines.slice(0, maxLines).join('\n')}\n... (${lines.length - maxLines} more lines)` : parsed;
       return (
         <Box key={index} borderStyle="classic" borderLeft={false} borderRight={false} marginY={1} padding={1} borderColor="dim" overflow="hidden">
           <Text color="gray" dimColor>
-            {truncated}
+            {content}
           </Text>
         </Box>
       );