experimental-ash 0.8.0 → 0.8.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # experimental-ash
 
+## 0.8.1
+
+### Patch Changes
+
+- 1434a11: Add named return types `SlackChannel` and `AshChannel` for `slackChannel(...)` and `ashChannel(...)`. Default-exporting either call from a `channels/*.ts` module now type-checks under `declaration: true` without TypeScript falling back to an internal path (TS2883).
+- da443bb: Fix race condition in Slack channel where `onNewMention` could fire after the request context was cleared, causing "mention received but no request context is active" errors
+- 54e0a2a: Allow overriding the Slack channel webhook route path via the `route` option in `SlackChannelConfig`
+
 ## 0.8.0
 
 ### Minor Changes

package/dist/src/internal/application/package.js

@@ -6,7 +6,7 @@ import { ASH_PACKAGE_NAME } from "#package-name.js";
 let cachedPackageInfo;
 // The package build stamps the published version into `dist` so bundled
 // deployments can still report package metadata without resolving package.json.
-const BUNDLED_FALLBACK_PACKAGE_VERSION = "0.8.0";
+const BUNDLED_FALLBACK_PACKAGE_VERSION = "0.8.1";
 const BUNDLED_FALLBACK_PACKAGE_VERSION_PLACEHOLDER = "__ASH_PACKAGE_VERSION_PLACEHOLDER__";
 const WORKFLOW_MODULE_ALIASES = {
     "workflow/api": "src/compiled/@workflow/core/runtime.js",

package/dist/src/public/channels/ash.d.ts

@@ -5,4 +5,11 @@ export interface AshChannelInput {
     readonly auth: AuthFn<Request>;
     readonly uploadPolicy?: Partial<UploadPolicy>;
 }
-export declare function ashChannel(input: AshChannelInput): Channel;
+/**
+ * Concrete return type of {@link ashChannel}. Named so consumers can
+ * default-export an `ashChannel(...)` call under `declaration: true`
+ * without TypeScript falling back to an internal path for `Channel`.
+ */
+export interface AshChannel extends Channel {
+}
+export declare function ashChannel(input: AshChannelInput): AshChannel;

package/dist/src/public/channels/slack/index.d.ts

@@ -1,4 +1,4 @@
 export { slack, type SlackOptions } from "#public/channels/slack/slack.js";
-export { slackChannel, type SlackApiHandle, type SlackApiResponse, type SlackChannelConfig, type SlackChannelEvents, type SlackChannelCredentials, type SlackChannelState, type SlackContext, type SlackInteractionAction, type SlackReceiveArgs, } from "#public/channels/slack/slackChannel.js";
+export { slackChannel, type SlackApiHandle, type SlackApiResponse, type SlackChannel, type SlackChannelConfig, type SlackChannelEvents, type SlackChannelCredentials, type SlackChannelState, type SlackContext, type SlackInteractionAction, type SlackReceiveArgs, } from "#public/channels/slack/slackChannel.js";
 export { Actions, Button, Card, CardText, Divider, Fields, Image, LinkButton, Modal, RadioSelect, Section, Select, SelectOption, Table, TextInput, } from "#compiled/chat/index.js";
 export type { AdapterPostableMessage, Attachment, Author, CardElement, FileUpload, Message, PostableMessage, SentMessage, Thread, } from "#compiled/chat/index.js";

package/dist/src/public/channels/slack/slackChannel.d.ts

@@ -72,6 +72,10 @@ export interface SlackChannelEvents {
 export interface SlackChannelConfig {
     readonly credentials?: SlackChannelCredentials;
     readonly botName?: string;
+    /**
+     * Override the default webhook route path (`/ash/v1/slack`).
+     */
+    readonly route?: string;
     /**
      * Inbound upload policy applied to file attachments before they
      * reach the harness. Violating attachments are dropped with a
@@ -83,5 +87,12 @@ export interface SlackChannelConfig {
     onInteraction?(action: SlackInteractionAction, ctx: SlackContext): void | Promise<void>;
     readonly events?: SlackChannelEvents;
 }
-export declare function slackChannel(config?: SlackChannelConfig): Channel<SlackChannelState>;
+/**
+ * Concrete return type of {@link slackChannel}. Named so consumers can
+ * default-export a `slackChannel(...)` call under `declaration: true`
+ * without TypeScript falling back to an internal path for `Channel`.
+ */
+export interface SlackChannel extends Channel<SlackChannelState> {
+}
+export declare function slackChannel(config?: SlackChannelConfig): SlackChannel;
 export {};

package/dist/src/public/channels/slack/slackChannel.js

@@ -2,7 +2,7 @@ import { createLogger } from "#internal/logging.js";
 import { buildSlackTurnMessage, collectSlackFileParts, createSlackFetchFile, } from "#public/channels/slack/attachments.js";
 import { deriveHitlResponse, isHitlAction, renderInputRequestBlocks, } from "#public/channels/slack/hitl.js";
 import { mergeUploadPolicy } from "#public/channels/upload-policy.js";
-import { defineChannel, POST, } from "#public/definitions/defineChannel.js";
+import { defineChannel, POST } from "#public/definitions/defineChannel.js";
 const log = createLogger("slack.channel");
 function decodeThreadId(id) {
     const parts = id.replace(/^slack:/u, "").split(":");
@@ -112,7 +112,6 @@ export function slackChannel(config = {}) {
     const slackFetchFile = createSlackFetchFile({
         botToken: config.credentials?.botToken,
     });
-    let activeSend = null;
     let chatPromise = null;
     async function getChat() {
         if (chatPromise)
@@ -139,39 +138,6 @@ export function slackChannel(config = {}) {
                 userName: config.botName ?? "ash-agent",
             });
             await chat.initialize();
-            chat.onNewMention(async (thread, message) => {
-                // Slack sends both `app_mention` and `message.channels` for the same message.
-                // The Chat SDK dedup relies on in-memory state that doesn't survive across
-                // serverless invocations, so both events reach this handler. Only process
-                // `app_mention` to prevent duplicate runs.
-                const rawEvent = message.raw;
-                if (rawEvent?.type !== "app_mention")
-                    return;
-                const send = activeSend;
-                if (!send) {
-                    throw new Error("slackChannel: mention received but no request context is active.");
-                }
-                const teamId = rawEvent.team_id ?? rawEvent.team;
-                const slackCtx = {
-                    thread,
-                    slack: buildSlackApiHandle(thread, config.credentials?.botToken, teamId),
-                };
-                const runOpts = config.run ? config.run(slackCtx, message) : { auth: null };
-                if (runOpts === null)
-                    return;
-                const decoded = decodeThreadId(thread.id ?? "");
-                const continuationToken = `slack:${decoded.channelId}:${decoded.threadTs}`;
-                const fileParts = collectSlackFileParts(message, uploadPolicy);
-                const turnMessage = buildSlackTurnMessage(message.text, fileParts);
-                await send(turnMessage, {
-                    auth: runOpts.auth,
-                    continuationToken,
-                    state: {
-                        serializedThread: thread.toJSON(),
-                        teamId: teamId ?? null,
-                    },
-                });
-            });
             return { chat };
         })();
         chatPromise = promise;
@@ -188,7 +154,7 @@ export function slackChannel(config = {}) {
             return rebuildSlackContext(state, config.credentials?.botToken);
         },
         routes: [
-            POST("/ash/v1/slack", async (req, { send, waitUntil }) => {
+            POST(config.route ?? "/ash/v1/slack", async (req, { send, waitUntil }) => {
                 const { chat } = await getChat();
                 const contentType = req.headers.get("content-type") ?? "";
                 if (contentType.includes("application/x-www-form-urlencoded")) {
@@ -249,16 +215,36 @@ export function slackChannel(config = {}) {
                     }
                     return new Response("ok", { status: 200 });
                 }
-                activeSend = send;
-                try {
-                    const webhookHandler = chat.webhooks.slack;
-                    return await webhookHandler(req, {
-                        waitUntil,
+                chat.onNewMention(async (thread, message) => {
+                    const rawEvent = message.raw;
+                    // Slack sends both `app_mention` and `message.channels` for the same
+                    // utterance. The Chat SDK dedup relies on in-memory state that doesn't
+                    // survive serverless invocations, so both events reach this handler.
+                    // Only process `app_mention` to prevent duplicate runs.
+                    if (rawEvent?.type !== "app_mention")
+                        return;
+                    const teamId = rawEvent.team_id ?? rawEvent.team;
+                    const slackCtx = {
+                        thread,
+                        slack: buildSlackApiHandle(thread, config.credentials?.botToken, teamId),
+                    };
+                    const runOpts = config.run ? config.run(slackCtx, message) : { auth: null };
+                    if (runOpts === null)
+                        return;
+                    const decoded = decodeThreadId(thread.id ?? "");
+                    const continuationToken = `slack:${decoded.channelId}:${decoded.threadTs}`;
+                    const fileParts = collectSlackFileParts(message, uploadPolicy);
+                    const turnMessage = buildSlackTurnMessage(message.text, fileParts);
+                    await send(turnMessage, {
+                        auth: runOpts.auth,
+                        continuationToken,
+                        state: {
+                            serializedThread: thread.toJSON(),
+                            teamId: teamId ?? null,
+                        },
                     });
-                }
-                finally {
-                    activeSend = null;
-                }
+                });
+                return await chat.webhooks.slack(req, { waitUntil });
             }),
         ],
         async receive(input, { send }) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "experimental-ash",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "bin": {
     "ash": "./bin/ash.js",
     "experimental-ash": "./bin/ash.js"