expensify-common 2.0.181 → 2.0.183

package/dist/Func.js

@@ -82,7 +82,9 @@ function invokeAsync(callback, args, scope) {
  * @param {Array} [args]
  */
 function bulkInvoke(callbacks, args) {
-    callbacks.forEach((callback) => invoke(callback, args));
+    for (const callback of callbacks) {
+        invoke(callback, args);
+    }
 }
 /**
  * Throws an uncaught error in an attempt to stop JS execution

package/dist/Log.js

@@ -48,7 +48,7 @@ const Utils = __importStar(require("./utils"));
  * @param {Object} params
  * @param {Object} params.parameters
  * @param {String} params.message
- * @return {Promise}
+ * @returns {Promise}
  */
 function serverLoggingCallback(logger, params) {
     return (0, API_1.default)((0, Network_1.default)('/api/')).logToServer(params);

package/dist/Logger.d.ts

@@ -61,8 +61,8 @@ export default class Logger {
     /**
      * Logs a warn.
      *
-     * @param {String} message The message to warn.
-     * @param {Object|String} parameters The parameters to send along with the message
+     * @param message The message to warn.
+     * @param parameters The parameters to send along with the message
      */
     warn(message: string, parameters?: Parameters): void;
     /**

package/dist/Logger.js

@@ -33,11 +33,13 @@ class Logger {
             return l;
         });
         this.logLines = [];
-        const promise = this.serverLoggingCallback(this, { api_setCookie: false, logPacket: JSON.stringify(linesToLog) });
+        const promise = this.serverLoggingCallback(this, {
+            api_setCookie: false,
+            logPacket: JSON.stringify(linesToLog),
+        });
         if (!promise) {
             return;
         }
-        // eslint-disable-next-line rulesdir/prefer-early-return
         promise.then((response) => {
             if (!response.requestID) {
                 return;
@@ -107,8 +109,8 @@ class Logger {
     /**
      * Logs a warn.
      *
-     * @param {String} message The message to warn.
-     * @param {Object|String} parameters The parameters to send along with the message
+     * @param message The message to warn.
+     * @param parameters The parameters to send along with the message
      */
     warn(message, parameters = '') {
         const msg = `[warn] ${message}`;

package/dist/Network.js

@@ -113,16 +113,16 @@ function Network(endpoint) {
             // Check to see if parameters contains a File or Blob object
             // If it does, we should use formData instead of parameters and update
             // the ajax settings accordingly
-            Object.entries(parameters).forEach(([key, value]) => {
+            for (const [key, value] of Object.entries(parameters)) {
                 if (value === undefined) {
-                    return;
+                    continue;
                 }
                 // Populate formData in case we need it
                 formData.append(key, value);
                 if (value instanceof File || value instanceof Blob) {
                     shouldUseFormData = true;
                 }
-            });
+            }
             if (shouldUseFormData) {
                 settings.processData = false;
                 settings.contentType = false;
@@ -153,26 +153,26 @@ function Network(endpoint) {
             url = addCommandToUrl(parameters.command, url);
             // Add our data as form data
             const formData = new FormData();
-            Object.entries(parameters).forEach(([key, value]) => {
+            for (const [key, value] of Object.entries(parameters)) {
                 if (value === undefined) {
-                    return;
+                    continue;
                 }
                 if (Array.isArray(value)) {
-                    value.forEach((valueItem, i) => {
+                    for (const [i, valueItem] of value.entries()) {
                         if (Utils.isObject(valueItem)) {
-                            Object.entries(valueItem).forEach(([valueItemObjectKey, valueItemObjectValue]) => {
+                            for (const [valueItemObjectKey, valueItemObjectValue] of Object.entries(valueItem)) {
                                 formData.append(`${key}[${i}][${valueItemObjectKey}]`, valueItemObjectValue);
-                            });
+                            }
                         }
                         else {
                             formData.append(`${key}[${i}]`, valueItem);
                         }
-                    });
+                    }
                 }
                 else {
                     formData.append(key, value);
                 }
-            });
+            }
             settings.body = formData;
             // Make our request via the fetch API but return it in the form of a jQuery promise
             // so that our API can be consistent

package/dist/Num.d.ts

@@ -59,7 +59,7 @@ declare namespace _default {
      * Returns how many decimals to display (used for currencies).
      *
      * @param {Number} rate
-     * @return {Number}
+     * @returns {Number}
      */
     function getDisplayDecimals(rate: number): number;
     namespace tax {

package/dist/Num.js

@@ -52,7 +52,8 @@ exports.default = {
         let h = null;
         let i = null;
         let j = null;
-        a = Math.round(a * Math.pow(10, b)) / Math.pow(10, b);
+        const multiplier = Math.pow(10, b);
+        a = Math.round(a * multiplier) / multiplier;
         if (a < 0) {
             a *= -1;
             sign = '-';
@@ -76,7 +77,8 @@ exports.default = {
             h = f[0];
             f[0] = '';
             for (j = 3; j < h.length; j += 3) {
-                i = h.slice(h.length - j, h.length - j + 3);
+                const sliceStart = h.length - j;
+                i = h.slice(sliceStart, sliceStart + 3);
                 f[0] = `${d}${i}${f[0]}`;
             }
             j = h.substr(0, h.length % 3 === 0 ? 3 : h.length % 3);
@@ -141,7 +143,7 @@ exports.default = {
      * Returns how many decimals to display (used for currencies).
      *
      * @param {Number} rate
-     * @return {Number}
+     * @returns {Number}
      */
     getDisplayDecimals(rate) {
         if (rate % 1 === 0) {
@@ -173,7 +175,8 @@ exports.default = {
          * @returns {number} The amount of tax
          */
         calculateTaxFromPercentage(total, percentage) {
-            const divisor = percentage ? str_1.default.percentageStringToNumber(percentage) / 100 + 1 : 1;
+            const percentageAsDecimal = str_1.default.percentageStringToNumber(percentage) / 100;
+            const divisor = percentage ? percentageAsDecimal + 1 : 1;
             return this.calculateTaxFromDivisor(total, divisor);
         },
         /**
@@ -185,7 +188,8 @@ exports.default = {
          * @returns {number} The amount of tax
          */
         calculateTaxFromDivisor(total, divisor) {
-            return parseInt(Math.round(total - total / divisor), 10);
+            const amountExcludingTax = total / divisor;
+            return parseInt(Math.round(total - amountExcludingTax), 10);
         },
     },
 };

package/dist/PageEvent.d.ts

@@ -5,7 +5,7 @@
  *
  * @param {String} eventName Name of the event to listen to
  * @param {Function} callback Function to fire
- * @constructor
+ * @class
  */
 export default function _default(eventName: string, callback: Function): {
     subscribe(scope: any): void;
@@ -19,7 +19,7 @@ export default class _default {
      *
      * @param {String} eventName Name of the event to listen to
      * @param {Function} callback Function to fire
-     * @constructor
+     * @class
      */
     constructor(eventName: string, callback: Function);
 }

package/dist/PageEvent.js

@@ -12,7 +12,7 @@ const PubSub_1 = __importDefault(require("./PubSub"));
  *
  * @param {String} eventName Name of the event to listen to
  * @param {Function} callback Function to fire
- * @constructor
+ * @class
  */
 function default_1(eventName, callback) {
     let id = null;

package/dist/PubSub.js

@@ -51,7 +51,7 @@ let counter = 0;
 /**
  * Create a unique ID for each event subscriber
  * @param {String} eventName Name of the event to listen to
- * @return {String} unique ID
+ * @returns {String} unique ID
  */
 const generateID = (eventName) => {
     counter++;
@@ -60,7 +60,7 @@ const generateID = (eventName) => {
 /**
  * Find the name of the event from the ID
  * @param {string} eventID
- * @return {String}
+ * @returns {String}
  */
 const extractEventName = (eventID = '') => eventID.substring(0, eventID.indexOf('@#@'));
 const PubSubModule = {
@@ -82,12 +82,12 @@ const PubSubModule = {
             // When debugging, we just need to know who called PubSub.publish (so, all next elements in the stack)
             Log_1.default.hmmm('Error published', 0, { tplt: param.tplt, stackTrace: new Error().stack.split(' at ').slice(2) });
         }
-        eventIDs.forEach((eventID) => {
+        for (const eventID of eventIDs) {
             const subscriber = eventMap[eventName][eventID];
             if (subscriber) {
                 subscriber.callback.call(subscriber.scope, param);
             }
-        });
+        }
         return this;
     },
     /**
@@ -113,7 +113,7 @@ const PubSubModule = {
      * @param {String} eventName Name of the event to listen
      * @param {Function} optionalCallback Callback function to call when event occur
      * @param {Object} optionalScope
-     * @return {String} event identifier that should be used to unsubscribe
+     * @returns {String} event identifier that should be used to unsubscribe
      */
     subscribe(eventName, optionalCallback, optionalScope) {
         if (!eventName) {
@@ -138,12 +138,12 @@ const PubSubModule = {
      */
     unsubscribe(bindID) {
         const IDs = Array.isArray(bindID) ? bindID : [bindID];
-        IDs.forEach((id) => {
+        for (const id of IDs) {
             const eventName = extractEventName(id);
             if ((0, has_1.default)(eventMap, `${eventName}.${id}`)) {
                 delete eventMap[eventName][id];
             }
-        });
+        }
     },
 };
 exports.default = Utils.isWindowAvailable() && window.PubSub ? window.PubSub : PubSubModule;

package/dist/ReportHistoryStore.d.ts

@@ -1,71 +1,8 @@
-export default class ReportHistoryStore {
-    constructor(API: any, PubSub: any);
-    API: any;
-    /**
-     * Main report history cache
-     * Map of reportIDs with value of report history items array
-     */
-    cache: {};
-    /**
-     * PubSub instance used for the bindCacheClearingEvents method.
-     *
-     * Since Mobile and Web use different instances of PubSub, this is unfortunately necessary to subscribe to
-     * events in both code bases.
-     */
-    PubSub: any;
-    /**
-     * Filters out actions we never want to display on web or mobile.
-     *
-     * @param {Object[]} historyItems
-     *
-     * @returns {Object[]}
-     */
-    filterHiddenActions: (historyItems: Object[]) => Object[];
-    /**
-     * Merges history items into the cache and creates it if it doesn't yet exist.
-     *
-     * @param {Number} reportID
-     * @param {Object[]} newHistory
-     */
-    mergeItems(reportID: number, newHistory: Object[]): void;
-    /**
-     * Merges history items into the cache and creates it if it doesn't yet exist.
-     *
-     * @param {Number} reportID
-     * @param {Object[]} newHistory
-     */
-    mergeHistoryByTimestamp(reportID: number, newHistory: Object[]): void;
-    /**
-     * Merges history items by reportActionID into the cache and creates it if it doesn't yet exist.
-     *
-     * @param {Number} reportID
-     * @param {Object[]} newHistory
-     */
-    mergeHistoryByReportActionID(reportID: number, newHistory: Object[]): void;
-    /**
-     * Gets the history.
-     *
-     * @param {Number} reportID
-     * @param {Boolean} ignoreCache
-     *
-     * @returns {Deferred}
-     */
-    get(reportID: number, ignoreCache: boolean): Deferred;
-    /**
-     * Gets the history. This flow does not depend on the deprecated sequence number in report actions.
-     *
-     * @param {Number} reportID
-     * @param {Boolean} ignoreCache
-     *
-     * @returns {Deferred}
-     */
-    getFlatHistory(reportID: number, ignoreCache: boolean): Deferred;
-    /**
-     * Gets the history from the cache if it exists. Otherwise fully loads the history.
-     *
-     * @param {Number} reportID
-     *
-     * @return {Deferrred}
-     */
-    getFromCache(reportID: number): Deferrred;
-}
+/**
+ * Creates a report history store with platform-specific API and PubSub implementations.
+ *
+ * @param {Object} API
+ * @param {Object} PubSub
+ * @returns {Object}
+ */
+export default function ReportHistoryStore(API: Object, PubSub: Object): Object;