expensify-common 2.0.146 → 2.0.148

package/dist/ExpensiMark.d.ts

@@ -155,7 +155,7 @@ export default class ExpensiMark {
     /**
      * Replaces HTML with markdown
      */
-    htmlToMarkdown(htmlString: string, extras?: Extras, maxBodyLength?: number): string;
+    htmlToMarkdown(htmlString: string, extras?: Extras): string;
     /**
      * Convert HTML to text
      */

package/dist/ExpensiMark.js

@@ -1051,7 +1051,7 @@ class ExpensiMark {
     /**
      * Replaces HTML with markdown
      */
-    htmlToMarkdown(htmlString, extras = EXTRAS_DEFAULT, maxBodyLength = 0) {
+    htmlToMarkdown(htmlString, extras = EXTRAS_DEFAULT) {
         let generatedMarkdown = htmlString;
         const body = /<(body)(?:"[^"]*"|'[^']*'|[^'"><])*>(?:\n|\r\n)?([\s\S]*?)(?:\n|\r\n)?<\/\1>(?![^<]*(<\/pre>|<\/code>))/im;
         const parseBodyTag = generatedMarkdown.match(body);
@@ -1059,17 +1059,6 @@ class ExpensiMark {
         if (parseBodyTag) {
             generatedMarkdown = parseBodyTag[2];
         }
-        if (maxBodyLength > 0) {
-            /*
-             * Some HTML sources (such as Microsoft Word) have headers larger than the typical maxLength of
-             * 10K even for a small body text. So the text is truncated after extracting the body element, to
-             * maximise the amount of body text that is included while still staying inside the length limit.
-             *
-             * The truncation happens before HTML to Markdown conversion, as the conversion is very slow for
-             * large input especially on mobile devices.
-             */
-            generatedMarkdown = generatedMarkdown.slice(0, maxBodyLength);
-        }
         generatedMarkdown = this.unpackNestedQuotes(generatedMarkdown);
         const processRule = (rule) => {
             // Pre-processes input HTML before applying regex

package/dist/fastMerge.d.ts

@@ -5,5 +5,5 @@
  * On native, when merging an existing value with new changes, SQLite will use JSON_PATCH, which removes top-level nullish values.
  * To be consistent with the behaviour for merge, we'll also want to remove null values for "set" operations.
  */
-declare function fastMerge<TObject>(target: TObject, source: TObject, shouldRemoveNullObjectValues?: boolean): TObject;
+declare function fastMerge<TObject extends Record<string, unknown>>(target: TObject, source: TObject, shouldRemoveNullObjectValues?: boolean): TObject;
 export default fastMerge;

package/dist/fastMerge.js

@@ -11,13 +11,20 @@ function isMergeableObject(value) {
     return nonNullObject && Object.prototype.toString.call(value) !== '[object RegExp]' && Object.prototype.toString.call(value) !== '[object Date]' && !Array.isArray(value);
 }
 /**
- * Merges the source object into the target object.
- * @param target - The target object.
- * @param source - The source object.
- * @param shouldRemoveNestedNulls - If true, null object values will be removed.
- * @returns - The merged object.
+ * Merges two objects and removes null values if "shouldRemoveNullObjectValues" is set to true
+ *
+ * We generally want to remove null values from objects written to disk and cache, because it decreases the amount of data stored in memory and on disk.
+ * On native, when merging an existing value with new changes, SQLite will use JSON_PATCH, which removes top-level nullish values.
+ * To be consistent with the behaviour for merge, we'll also want to remove null values for "set" operations.
  */
-function mergeObject(target, source, shouldRemoveNullObjectValues = true) {
+function fastMerge(target, source, shouldRemoveNullObjectValues = true) {
+    // We have to ignore arrays and nullish values here,
+    // otherwise "mergeObject" will throw an error,
+    // because it expects an object as "source"
+    if (Array.isArray(source) || source === null || source === undefined) {
+        return source;
+    }
+    //  Merges the source object into the target object.
     const destination = {};
     if (isMergeableObject(target)) {
         // lodash adds a small overhead so we don't use it here
@@ -59,20 +66,4 @@ function mergeObject(target, source, shouldRemoveNullObjectValues = true) {
     }
     return destination;
 }
-/**
- * Merges two objects and removes null values if "shouldRemoveNullObjectValues" is set to true
- *
- * We generally want to remove null values from objects written to disk and cache, because it decreases the amount of data stored in memory and on disk.
- * On native, when merging an existing value with new changes, SQLite will use JSON_PATCH, which removes top-level nullish values.
- * To be consistent with the behaviour for merge, we'll also want to remove null values for "set" operations.
- */
-function fastMerge(target, source, shouldRemoveNullObjectValues = true) {
-    // We have to ignore arrays and nullish values here,
-    // otherwise "mergeObject" will throw an error,
-    // because it expects an object as "source"
-    if (Array.isArray(source) || source === null || source === undefined) {
-        return source;
-    }
-    return mergeObject(target, source, shouldRemoveNullObjectValues);
-}
 exports.default = fastMerge;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expensify-common",
-  "version": "2.0.146",
+  "version": "2.0.148",
   "author": "Expensify, Inc.",
   "description": "Expensify libraries and components shared across different repos",
   "homepage": "https://expensify.com",