excalibur 0.32.0-alpha.1561 → 0.32.0-alpha.1563

package/CHANGELOG.md

@@ -38,6 +38,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
+- Fixed issue where clearSchedule during a scheduled callback could cause a cb to be skipped
 - Fixed issue where the Loader could run twice even if already loaded when included in the scene loader.
 - Fixed issue where pixel ratio was accidentally doubled during load if the loader was included in the scene loader.
 - Fixed issue where Slide trasition did not work properly when DisplayMode was FitScreenAndFill

package/build/dist/EntityComponentSystem/Entity.d.ts

@@ -301,7 +301,7 @@ export declare class Entity<TKnownComponents extends Component = any> implements
      */
     onAdd(engine: Engine): void;
     /**
-     * `onRemove` is called when Actor is added to scene. This method is meant to be
+     * `onRemove` is called when Actor is removed from a scene. This method is meant to be
      * overridden.
      *
      * Synonymous with the event handler `.on('remove', (evt) => {...})`

package/build/dist/Util/Clock.d.ts

@@ -63,6 +63,7 @@ export declare abstract class Clock {
      * @returns A unique identifier that can be used to clear the scheduled callback with {@apilink clearSchedule}
      */
     schedule(cb: (elapsed: number) => any, timeoutMs?: number, timing?: ScheduledCallbackTiming): ScheduleId;
+    private _idsToRemove;
     /**
      * Clears a scheduled callback using the ID returned from {@apilink schedule}
      * @param id The ID of the scheduled callback to clear

package/build/dist/excalibur.development.js

@@ -1,4 +1,4 @@
-/*! excalibur - 0.32.0-alpha.1561+0fa0a62 - 2025-11-13
+/*! excalibur - 0.32.0-alpha.1563+eadef91 - 2025-11-24
 https://github.com/excaliburjs/Excalibur
 Copyright (c) 2025 Excalibur.js <https://github.com/excaliburjs/Excalibur/graphs/contributors>
 Licensed BSD-2-Clause
@@ -5296,7 +5296,7 @@ mask:     ${(this.mask >>> 0).toString(2).padStart(32, "0")}
     onAdd(engine) {
     }
     /**
-     * `onRemove` is called when Actor is added to scene. This method is meant to be
+     * `onRemove` is called when Actor is removed from a scene. This method is meant to be
      * overridden.
      *
      * Synonymous with the event handler `.on('remove', (evt) => {...})`
@@ -29173,6 +29173,7 @@ If you want to do custom drawing, use Actor.graphics, or any onPreDraw or onPost
       this._scheduledCbs = [];
       this._totalElapsed = 0;
       this._nextScheduleId = 0;
+      this._idsToRemove = [];
       var _a, _b, _c;
       this._options = options;
       this.tick = options.tick;
@@ -29234,10 +29235,7 @@ If you want to do custom drawing, use Actor.graphics, or any onPreDraw or onPost
      * @param id The ID of the scheduled callback to clear
      */
     clearSchedule(id) {
-      const index = this._scheduledCbs.findIndex(([scheduleId]) => scheduleId === id);
-      if (index !== -1) {
-        this._scheduledCbs.splice(index, 1);
-      }
+      this._idsToRemove.push(id);
     }
     /**
      * Called internally to trigger scheduled callbacks in the clock
@@ -29246,12 +29244,21 @@ If you want to do custom drawing, use Actor.graphics, or any onPreDraw or onPost
      */
     __runScheduledCbs(timing = "preframe") {
       for (let i = this._scheduledCbs.length - 1; i > -1; i--) {
-        const [_, callback, scheduledTime, callbackTiming] = this._scheduledCbs[i];
+        const [scheduleId, callback, scheduledTime, callbackTiming] = this._scheduledCbs[i];
+        if (this._idsToRemove.includes(scheduleId)) {
+          continue;
+        }
         if (timing === callbackTiming && scheduledTime <= this._totalElapsed) {
           callback(this._elapsed);
           this._scheduledCbs.splice(i, 1);
         }
       }
+      for (const id of this._idsToRemove) {
+        const index = this._scheduledCbs.findIndex(([scheduleId]) => scheduleId === id);
+        if (index !== -1) {
+          this._scheduledCbs.splice(index, 1);
+        }
+      }
     }
     update(overrideUpdateMs) {
       try {
@@ -33036,7 +33043,7 @@ Read more about this issue at https://excaliburjs.com/docs/performance`
       this._count += count;
     }
   }
-  const EX_VERSION = "0.32.0-alpha.1561+0fa0a62";
+  const EX_VERSION = "0.32.0-alpha.1563+eadef91";
   polyfill();
   exports2.ActionCompleteEvent = ActionCompleteEvent;
   exports2.ActionContext = ActionContext;

package/build/dist/excalibur.js

@@ -1,4 +1,4 @@
-/*! excalibur - 0.32.0-alpha.1561+0fa0a62 - 2025-11-13
+/*! excalibur - 0.32.0-alpha.1563+eadef91 - 2025-11-24
 https://github.com/excaliburjs/Excalibur
 Copyright (c) 2025 Excalibur.js <https://github.com/excaliburjs/Excalibur/graphs/contributors>
 Licensed BSD-2-Clause
@@ -5296,7 +5296,7 @@ mask:     ${(this.mask >>> 0).toString(2).padStart(32, "0")}
     onAdd(engine) {
     }
     /**
-     * `onRemove` is called when Actor is added to scene. This method is meant to be
+     * `onRemove` is called when Actor is removed from a scene. This method is meant to be
      * overridden.
      *
      * Synonymous with the event handler `.on('remove', (evt) => {...})`
@@ -29173,6 +29173,7 @@ If you want to do custom drawing, use Actor.graphics, or any onPreDraw or onPost
       this._scheduledCbs = [];
       this._totalElapsed = 0;
       this._nextScheduleId = 0;
+      this._idsToRemove = [];
       var _a, _b, _c;
       this._options = options;
       this.tick = options.tick;
@@ -29234,10 +29235,7 @@ If you want to do custom drawing, use Actor.graphics, or any onPreDraw or onPost
      * @param id The ID of the scheduled callback to clear
      */
     clearSchedule(id) {
-      const index = this._scheduledCbs.findIndex(([scheduleId]) => scheduleId === id);
-      if (index !== -1) {
-        this._scheduledCbs.splice(index, 1);
-      }
+      this._idsToRemove.push(id);
     }
     /**
      * Called internally to trigger scheduled callbacks in the clock
@@ -29246,12 +29244,21 @@ If you want to do custom drawing, use Actor.graphics, or any onPreDraw or onPost
      */
     __runScheduledCbs(timing = "preframe") {
       for (let i = this._scheduledCbs.length - 1; i > -1; i--) {
-        const [_, callback, scheduledTime, callbackTiming] = this._scheduledCbs[i];
+        const [scheduleId, callback, scheduledTime, callbackTiming] = this._scheduledCbs[i];
+        if (this._idsToRemove.includes(scheduleId)) {
+          continue;
+        }
         if (timing === callbackTiming && scheduledTime <= this._totalElapsed) {
           callback(this._elapsed);
           this._scheduledCbs.splice(i, 1);
         }
       }
+      for (const id of this._idsToRemove) {
+        const index = this._scheduledCbs.findIndex(([scheduleId]) => scheduleId === id);
+        if (index !== -1) {
+          this._scheduledCbs.splice(index, 1);
+        }
+      }
     }
     update(overrideUpdateMs) {
       try {
@@ -33036,7 +33043,7 @@ Read more about this issue at https://excaliburjs.com/docs/performance`
       this._count += count;
     }
   }
-  const EX_VERSION = "0.32.0-alpha.1561+0fa0a62";
+  const EX_VERSION = "0.32.0-alpha.1563+eadef91";
   polyfill();
   exports2.ActionCompleteEvent = ActionCompleteEvent;
   exports2.ActionContext = ActionContext;