exadev-eslint-config 2.6.2 → 2.7.0

package/README.md

@@ -16,7 +16,7 @@ Consumers need `eslint >=10.0.0` and `typescript-eslint >=8.0.0` as required pee
 pnpm add -D @exadev/eslint-config typescript-eslint eslint
 ```
 
-The default export is the full, type-checked ruleset: typescript-eslint's `recommendedTypeChecked` + `stylisticTypeChecked` presets, `exadev/barrel-policy` at `mode: 'banned'` (see [Barrel policy](#barrel-policy)), `exadev/no-object-assign`, `exadev/no-mutable-union-array-param`, `exadev/no-array-isarray-mutation`, `exadev/no-enum-number-widening`, `exadev/no-enum-reverse-lookup-widening`, `exadev/no-map-instanceof-mutation`, `exadev/no-set-instanceof-mutation`, `exadev/prefer-readonly-array-param`, `exadev/prefer-readonly-object-param`, `exadev/prefer-numeric-sort-compare`, `exadev/no-pointless-reassignment`, `linterOptions.noInlineConfig`, `@typescript-eslint/consistent-type-assertions` banning all type assertions, `@typescript-eslint/consistent-type-imports`, `@typescript-eslint/consistent-type-exports`, `@typescript-eslint/no-non-null-assertion` banning the `!` operator (the same manual-override escape hatch as a type assertion, under a different spelling), `@typescript-eslint/ban-ts-comment` banning `@ts-expect-error` outright, `@typescript-eslint/method-signature-style` set to `'property'` (method-shorthand signatures are checked bivariantly under `strictFunctionTypes`, which is unsound), `@typescript-eslint/no-deprecated`, `@typescript-eslint/no-misused-spread`, `@typescript-eslint/no-mixed-enums`, `@typescript-eslint/no-unnecessary-condition`, `@typescript-eslint/prefer-readonly`, `@typescript-eslint/promise-function-async`, `@typescript-eslint/require-array-sort-compare`, `@typescript-eslint/switch-exhaustiveness-check`, `@typescript-eslint/use-unknown-in-catch-callback-variable`, `@typescript-eslint/strict-boolean-expressions` at the rule's own bare defaults (an unambiguous non-nullable truthy check stays allowed; an ambiguous nullable check does not), and `@typescript-eslint/no-magic-numbers` tuned to exempt array indexes, enum members, readonly class properties, default parameter values, and the handful of universally-idiomatic bare numbers (`-1`, `0`, `1`, `2`) -- the type-assertion and ts-comment rules are relaxed in test files, and `no-magic-numbers` is not (see below). Spread it directly into `tseslint.config(...)`:
+The default export is the full, type-checked ruleset: typescript-eslint's `strictTypeChecked` + `stylisticTypeChecked` presets (`strictTypeChecked` subsumes `recommendedTypeChecked`, so it already includes `no-deprecated`, `no-misused-spread`, `no-mixed-enums`, `no-unnecessary-condition`, `use-unknown-in-catch-callback-variable`, `return-await`, `related-getter-setter-pairs`, `no-unnecessary-type-parameters`, and more -- those are no longer re-listed below), `exadev/barrel-policy` at `mode: 'banned'` (see [Barrel policy](#barrel-policy)), `exadev/no-object-assign`, `exadev/no-mutable-union-array-param`, `exadev/no-array-isarray-mutation`, `exadev/no-enum-number-widening`, `exadev/no-enum-reverse-lookup-widening`, `exadev/no-map-instanceof-mutation`, `exadev/no-set-instanceof-mutation`, `exadev/prefer-readonly-array-param`, `exadev/prefer-readonly-object-param`, `exadev/prefer-numeric-sort-compare`, `exadev/no-pointless-reassignment`, `linterOptions.noInlineConfig`, `@typescript-eslint/consistent-type-assertions` banning all type assertions, `@typescript-eslint/consistent-type-imports`, `@typescript-eslint/consistent-type-exports`, `@typescript-eslint/no-non-null-assertion` banning the `!` operator (the same manual-override escape hatch as a type assertion, under a different spelling), `@typescript-eslint/ban-ts-comment` banning `@ts-expect-error` outright, `@typescript-eslint/method-signature-style` set to `'property'` (method-shorthand signatures are checked bivariantly under `strictFunctionTypes`, which is unsound), `@typescript-eslint/prefer-readonly`, `@typescript-eslint/promise-function-async`, `@typescript-eslint/require-array-sort-compare`, `@typescript-eslint/switch-exhaustiveness-check`, `@typescript-eslint/strict-boolean-expressions` at the rule's own bare defaults (an unambiguous non-nullable truthy check stays allowed; an ambiguous nullable check does not), and `@typescript-eslint/no-magic-numbers` tuned to exempt array indexes, enum members, readonly class properties, default parameter values, and the handful of universally-idiomatic bare numbers (`-1`, `0`, `1`, `2`) -- the type-assertion and ts-comment rules are relaxed in test files, and `no-magic-numbers` is not (see below). Spread it directly into `tseslint.config(...)`:
 
 ```ts
 // eslint.config.ts
@@ -41,7 +41,7 @@ export default tseslint.config(
   { rules: { 'exadev/barrel-policy': ['error', { mode: 'single' }] } }, // this package keeps its barrel
 ```
 
-`recommendedTypeChecked` subsumes typescript-eslint's plain `recommended` outright (every rule in `recommended` is also present in `recommendedTypeChecked`), and its base config registers the `@typescript-eslint` plugin and sets `languageOptions.parser` itself. That is why **you must remove your own `...tseslint.configs.recommended`/`recommendedTypeChecked`/`stylisticTypeChecked` spreads** -- flat config rejects two different plugin object instances registered under the same namespace. You still supply `languageOptions.parserOptions.project`/`projectService` pointing at your own tsconfig(s).
+`strictTypeChecked` subsumes both typescript-eslint's plain `recommended` and `recommendedTypeChecked` outright (every rule in each is also present in `strictTypeChecked`), and its base config registers the `@typescript-eslint` plugin and sets `languageOptions.parser` itself. That is why **you must remove your own `...tseslint.configs.recommended`/`recommendedTypeChecked`/`strictTypeChecked`/`stylisticTypeChecked` spreads** -- flat config rejects two different plugin object instances registered under the same namespace. You still supply `languageOptions.parserOptions.project`/`projectService` pointing at your own tsconfig(s).
 
 **Test files (`**/*.{test,spec}.{ts,tsx,mts,cts,js,jsx,mjs,cjs}`) get two narrow relaxations of this package's own additions, and only those two.** `@ts-expect-error` reverts to `allow-with-description` (a compile-time-only assertion of a type failure is a legitimate test pattern; `@ts-ignore`/`@ts-nocheck` stay banned since `@ts-expect-error` is strictly better). `consistent-type-assertions` relaxes to `assertionStyle: 'as'` (the legacy `<Type>value` form stays banned everywhere). Nothing inherited from the presets is relaxed.
 
@@ -157,7 +157,7 @@ The `lint`/`typecheck`/`test`/`build` npm scripts wrap turbo tasks named `_lint`
 
 `src/plugin.ts` builds an `ESLint.Plugin` (ESLint's own type) combining `src/rules/` into a flat `rules` map. `configs.recommended` and `configs.barrel` are getters in the object literal -- each references the fully-built `plugin` (`plugins: { exadev: plugin }`), which a plain property initializer can't do mid-construction. `recommended` ships `barrel-policy` at `mode: 'banned'`; `barrel` at `mode: 'single'`.
 
-`src/recommended-type-checked.ts` bundles typescript-eslint's `recommendedTypeChecked` + `stylisticTypeChecked` alongside this plugin's rules into a flat config array. Its value is typed as `ConfigArrayValue = Extract<ConfigValue, unknown[]>` (the array-only member of ESLint's own config-value union), because annotating with the wider union broke `...exadev` with `TS2488`.
+`src/recommended-type-checked.ts` bundles typescript-eslint's `strictTypeChecked` + `stylisticTypeChecked` alongside this plugin's rules into a flat config array. Its value is typed as `ConfigArrayValue = Extract<ConfigValue, unknown[]>` (the array-only member of ESLint's own config-value union), because annotating with the wider union broke `...exadev` with `TS2488`.
 
 `src/index.ts` is the entry point: `export { default } from './recommended-type-checked'; export { default as plugin } from './plugin';`. Both exports share one root module, so importing `{ plugin }` alone still resolves `typescript-eslint` via the sibling re-export -- an accepted trade-off (an earlier separate-subpath split proved more awkward in practice).
 

package/dist/index.cjs

@@ -32,7 +32,7 @@ let typescript = require("typescript");
 typescript = __toESM(typescript, 1);
 let ts_api_utils = require("ts-api-utils");
 //#region package.json
-var version = "2.6.2";
+var version = "2.7.0";
 //#endregion
 //#region src/rules/barrel-helpers.ts
 const INDEX_BASENAME$1 = /^index\.[cm]?[tj]sx?$/;
@@ -220,7 +220,9 @@ const barrelPolicy = {
 					});
 				}
 			},
-			ImportDeclaration: (node) => detector.visitImport(node),
+			ImportDeclaration: (node) => {
+				detector.visitImport(node);
+			},
 			ExportNamedDeclaration(node) {
 				detector.visitExportNamed(node);
 				if (hasSource(node)) {
@@ -248,7 +250,9 @@ const barrelPolicy = {
 					data: { source }
 				});
 			},
-			ExportDefaultDeclaration: (node) => detector.visitExportDefault(node),
+			ExportDefaultDeclaration: (node) => {
+				detector.visitExportDefault(node);
+			},
 			"Program:exit"() {
 				for (const violation of detector.violations()) if (isPermittedBarrel(filename, mode)) {
 					if (mode === "siblings") {
@@ -702,9 +706,15 @@ const noNonBarrelReexport = {
 		if (isIndexFile(context.filename)) return {};
 		const detector = createSplitReexportDetector();
 		return {
-			ImportDeclaration: (node) => detector.visitImport(node),
-			ExportNamedDeclaration: (node) => detector.visitExportNamed(node),
-			ExportDefaultDeclaration: (node) => detector.visitExportDefault(node),
+			ImportDeclaration: (node) => {
+				detector.visitImport(node);
+			},
+			ExportNamedDeclaration: (node) => {
+				detector.visitExportNamed(node);
+			},
+			ExportDefaultDeclaration: (node) => {
+				detector.visitExportDefault(node);
+			},
 			"Program:exit"() {
 				const { sourceCode } = context;
 				for (const violation of detector.violations()) if (violation.kind === "named") {
@@ -1245,7 +1255,7 @@ const plugin = {
 //#region src/recommended-type-checked.ts
 const TEST_FILE_PATTERNS = "**/*.{test,spec}.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
 const recommendedTypeChecked = [
-	...typescript_eslint.default.configs.recommendedTypeChecked,
+	...typescript_eslint.default.configs.strictTypeChecked,
 	...typescript_eslint.default.configs.stylisticTypeChecked,
 	{
 		plugins: { exadev: plugin },
@@ -1268,7 +1278,6 @@ const recommendedTypeChecked = [
 			"@typescript-eslint/consistent-type-exports": "error",
 			"@typescript-eslint/consistent-type-imports": "error",
 			"@typescript-eslint/method-signature-style": ["error", "property"],
-			"@typescript-eslint/no-deprecated": "error",
 			"@typescript-eslint/no-magic-numbers": ["error", {
 				ignore: [
 					-1,
@@ -1281,16 +1290,12 @@ const recommendedTypeChecked = [
 				ignoreReadonlyClassProperties: true,
 				ignoreDefaultValues: true
 			}],
-			"@typescript-eslint/no-misused-spread": "error",
-			"@typescript-eslint/no-mixed-enums": "error",
 			"@typescript-eslint/no-non-null-assertion": "error",
-			"@typescript-eslint/no-unnecessary-condition": "error",
 			"@typescript-eslint/prefer-readonly": "error",
 			"@typescript-eslint/promise-function-async": "error",
 			"@typescript-eslint/require-array-sort-compare": "error",
 			"@typescript-eslint/strict-boolean-expressions": "error",
-			"@typescript-eslint/switch-exhaustiveness-check": "error",
-			"@typescript-eslint/use-unknown-in-catch-callback-variable": "error"
+			"@typescript-eslint/switch-exhaustiveness-check": "error"
 		}
 	},
 	{

package/dist/index.js

@@ -4,7 +4,7 @@ import { AST_NODE_TYPES, ESLintUtils, TSESLint } from "@typescript-eslint/utils"
 import * as ts from "typescript";
 import { isPropertyReadonlyInType, isTypeReference } from "ts-api-utils";
 //#region package.json
-var version = "2.6.2";
+var version = "2.7.0";
 //#endregion
 //#region src/rules/barrel-helpers.ts
 const INDEX_BASENAME$1 = /^index\.[cm]?[tj]sx?$/;
@@ -192,7 +192,9 @@ const barrelPolicy = {
 					});
 				}
 			},
-			ImportDeclaration: (node) => detector.visitImport(node),
+			ImportDeclaration: (node) => {
+				detector.visitImport(node);
+			},
 			ExportNamedDeclaration(node) {
 				detector.visitExportNamed(node);
 				if (hasSource(node)) {
@@ -220,7 +222,9 @@ const barrelPolicy = {
 					data: { source }
 				});
 			},
-			ExportDefaultDeclaration: (node) => detector.visitExportDefault(node),
+			ExportDefaultDeclaration: (node) => {
+				detector.visitExportDefault(node);
+			},
 			"Program:exit"() {
 				for (const violation of detector.violations()) if (isPermittedBarrel(filename, mode)) {
 					if (mode === "siblings") {
@@ -674,9 +678,15 @@ const noNonBarrelReexport = {
 		if (isIndexFile(context.filename)) return {};
 		const detector = createSplitReexportDetector();
 		return {
-			ImportDeclaration: (node) => detector.visitImport(node),
-			ExportNamedDeclaration: (node) => detector.visitExportNamed(node),
-			ExportDefaultDeclaration: (node) => detector.visitExportDefault(node),
+			ImportDeclaration: (node) => {
+				detector.visitImport(node);
+			},
+			ExportNamedDeclaration: (node) => {
+				detector.visitExportNamed(node);
+			},
+			ExportDefaultDeclaration: (node) => {
+				detector.visitExportDefault(node);
+			},
 			"Program:exit"() {
 				const { sourceCode } = context;
 				for (const violation of detector.violations()) if (violation.kind === "named") {
@@ -1217,7 +1227,7 @@ const plugin = {
 //#region src/recommended-type-checked.ts
 const TEST_FILE_PATTERNS = "**/*.{test,spec}.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
 const recommendedTypeChecked = [
-	...tseslint.configs.recommendedTypeChecked,
+	...tseslint.configs.strictTypeChecked,
 	...tseslint.configs.stylisticTypeChecked,
 	{
 		plugins: { exadev: plugin },
@@ -1240,7 +1250,6 @@ const recommendedTypeChecked = [
 			"@typescript-eslint/consistent-type-exports": "error",
 			"@typescript-eslint/consistent-type-imports": "error",
 			"@typescript-eslint/method-signature-style": ["error", "property"],
-			"@typescript-eslint/no-deprecated": "error",
 			"@typescript-eslint/no-magic-numbers": ["error", {
 				ignore: [
 					-1,
@@ -1253,16 +1262,12 @@ const recommendedTypeChecked = [
 				ignoreReadonlyClassProperties: true,
 				ignoreDefaultValues: true
 			}],
-			"@typescript-eslint/no-misused-spread": "error",
-			"@typescript-eslint/no-mixed-enums": "error",
 			"@typescript-eslint/no-non-null-assertion": "error",
-			"@typescript-eslint/no-unnecessary-condition": "error",
 			"@typescript-eslint/prefer-readonly": "error",
 			"@typescript-eslint/promise-function-async": "error",
 			"@typescript-eslint/require-array-sort-compare": "error",
 			"@typescript-eslint/strict-boolean-expressions": "error",
-			"@typescript-eslint/switch-exhaustiveness-check": "error",
-			"@typescript-eslint/use-unknown-in-catch-callback-variable": "error"
+			"@typescript-eslint/switch-exhaustiveness-check": "error"
 		}
 	},
 	{

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "exadev-eslint-config",
-  "version": "2.6.2",
+  "version": "2.7.0",
   "description": "Shared custom ESLint rules and plugin for ExaDev projects",
   "type": "module",
   "sideEffects": false,