exadev-eslint-config 2.12.2 → 2.13.0

package/README.md

@@ -170,6 +170,7 @@ Trailing arguments are arbitrary flat-config objects, appended in order after ev
 | `no-non-barrel-reexport` | ✓ | Re-exports belong only in a barrel. Catches the split form across two statements (`import { x } from './y'; export { x };` or `export default x;`) which no AST selector alone can match. Autofix deletes the export and the now-pointless import when it was the import's only use. Self-scopes away from any index file. |
 | `no-side-effects-in-index` | | A barrel file may contain only re-export statements -- nothing that could execute at import time. Self-scopes to any index file. |
 | `barrel-direct-siblings-only` | | A barrel may re-export only from a direct sibling (`./module`), never a nested path, parent, or bare package specifier (mode 3). |
+| `no-control-flow` | | Bans `if`/`switch`/`for`/`for-in`/`for-of`/`while`/`do-while`/the ternary operator outright. Not part of `recommended` or `barrel` -- ordinary code legitimately needs control flow, so this is opt-in, wired via a consumer's own `files` glob for the specific packages that want it (a composition-root package selecting an adapter/strategy by a validated key, say): a lookup table replaces a branch, a declarative array method (`map`/`filter`/`some`/`every`/...) replaces a loop. Requires no type information. |
 | `no-pointless-reassignment` | ✓ | `const foo = bar` where both sides are plain identifiers and the alias adds no transformation. Autofix rewrites every read to the original name and deletes the declaration (including its `export` keyword, when exported). Still reported but deliberately not auto-fixable where collapsing the alias would change meaning: an explicit type annotation (`const exhaustive: never = item` -- the annotation is the point), a read where the original name is shadowed, a read as a shorthand object property, more than one declarator in the statement, or a source that is written to anywhere. |
 | `no-object-assign` | ✓/suggestion | `Object.assign` does not check a source object's properties against the target's declared types, unlike object spread. A fresh object-literal target autofixes to `{ ...target, ...source }`; mutating an existing reassignable binding offers a suggestion only (changes the object's identity); a `const` binding or a non-statement call site gets a plain report with no fix. |
 | `no-mutable-union-array-param` | ✓ | A function parameter typed as an array of a union (`(string \| number)[]`) accepts a narrower caller array (`number[]`) by covariance; calling `push`/`unshift`/`splice`/`fill`/`copyWithin` on it can then insert a value the caller's own array was never declared to hold. Autofix marks the parameter `readonly`, turning the mutating call into a real compile error to resolve deliberately. Requires no type information. |

package/dist/index.cjs

@@ -39,6 +39,7 @@ let typescript = require("typescript");
 typescript = __toESM(typescript, 1);
 let ts_api_utils = require("ts-api-utils");
 //#region src/jsdoc.ts
+const JS_TS_FILE_PATTERNS$1 = "**/*.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
 const jsdocConfig = eslint_plugin_jsdoc.default.configs["flat/recommended-tsdoc-error"];
 const REQUIREMENTS_TIER_RULES = [
 	"jsdoc/require-example",
@@ -61,12 +62,14 @@ const REQUIREMENTS_TIER_RULES = [
 	"jsdoc/require-yields-type"
 ];
 const jsdocAndTsdoc = [{
+	files: [JS_TS_FILE_PATTERNS$1],
 	...jsdocConfig,
 	rules: {
 		...jsdocConfig.rules,
 		...Object.fromEntries(REQUIREMENTS_TIER_RULES.map((rule) => [rule, "off"]))
 	}
 }, {
+	files: [JS_TS_FILE_PATTERNS$1],
 	plugins: { tsdoc: eslint_plugin_tsdoc.default },
 	rules: { "tsdoc/syntax": "error" }
 }];
@@ -156,7 +159,7 @@ function buildReactConfig(options = {}) {
 }
 //#endregion
 //#region package.json
-var version = "2.12.2";
+var version = "2.13.0";
 //#endregion
 //#region src/rules/barrel-helpers.ts
 const INDEX_BASENAME$1 = /^index\.[cm]?[tj]sx?$/;
@@ -513,6 +516,76 @@ const noArrayIsArrayMutation = createRule$7({
 	}
 });
 //#endregion
+//#region src/rules/no-control-flow.ts
+const noControlFlow = {
+	meta: {
+		type: "problem",
+		schema: [],
+		messages: {
+			ifStatement: "Use a lookup table, not an if/else branch.",
+			switchStatement: "Use a lookup table, not a switch branch.",
+			forStatement: "Use a lookup table or a declarative array method, not a for loop.",
+			forInStatement: "Use a lookup table or Object.entries, not a for-in loop.",
+			forOfStatement: "Use a declarative array method, not a for-of loop.",
+			whileStatement: "Use a lookup table or a declarative array method, not a while loop.",
+			doWhileStatement: "Use a lookup table or a declarative array method, not a do-while loop.",
+			conditionalExpression: "Use a lookup table, not a ternary."
+		}
+	},
+	create(context) {
+		return {
+			IfStatement(node) {
+				context.report({
+					node,
+					messageId: "ifStatement"
+				});
+			},
+			SwitchStatement(node) {
+				context.report({
+					node,
+					messageId: "switchStatement"
+				});
+			},
+			ForStatement(node) {
+				context.report({
+					node,
+					messageId: "forStatement"
+				});
+			},
+			ForInStatement(node) {
+				context.report({
+					node,
+					messageId: "forInStatement"
+				});
+			},
+			ForOfStatement(node) {
+				context.report({
+					node,
+					messageId: "forOfStatement"
+				});
+			},
+			WhileStatement(node) {
+				context.report({
+					node,
+					messageId: "whileStatement"
+				});
+			},
+			DoWhileStatement(node) {
+				context.report({
+					node,
+					messageId: "doWhileStatement"
+				});
+			},
+			ConditionalExpression(node) {
+				context.report({
+					node,
+					messageId: "conditionalExpression"
+				});
+			}
+		};
+	}
+};
+//#endregion
 //#region src/rules/no-enum-number-widening.ts
 const noEnumNumberWidening = _typescript_eslint_utils.ESLintUtils.RuleCreator((name) => `https://github.com/ExaDev/eslint-config/blob/main/src/rules/${name}.ts`)({
 	name: "no-enum-number-widening",
@@ -1353,6 +1426,7 @@ const plugin = {
 		"barrel-direct-siblings-only": barrelDirectSiblingsOnly,
 		"barrel-policy": barrelPolicy,
 		"no-array-isarray-mutation": noArrayIsArrayMutation,
+		"no-control-flow": noControlFlow,
 		"no-enum-number-widening": noEnumNumberWidening,
 		"no-enum-reverse-lookup-widening": noEnumReverseLookupWidening,
 		"no-index-files": noIndexFiles,
@@ -1399,11 +1473,22 @@ const plugin = {
 //#endregion
 //#region src/recommended-type-checked.ts
 const TEST_FILE_PATTERNS = "**/*.{test,spec}.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
+const JS_TS_FILE_PATTERNS = "**/*.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
+function scopeToJsTs(configs) {
+	return configs.map((config) => config.files ? config : {
+		...config,
+		files: [JS_TS_FILE_PATTERNS]
+	});
+}
 const recommendedTypeChecked = [
-	_eslint_js.default.configs.recommended,
-	...typescript_eslint.default.configs.strictTypeChecked,
-	...typescript_eslint.default.configs.stylisticTypeChecked,
 	{
+		..._eslint_js.default.configs.recommended,
+		files: [JS_TS_FILE_PATTERNS]
+	},
+	...scopeToJsTs(typescript_eslint.default.configs.strictTypeChecked),
+	...scopeToJsTs(typescript_eslint.default.configs.stylisticTypeChecked),
+	{
+		files: [JS_TS_FILE_PATTERNS],
 		plugins: { exadev: plugin },
 		linterOptions: { noInlineConfig: true },
 		rules: {

package/dist/index.js

@@ -8,6 +8,7 @@ import { AST_NODE_TYPES, ESLintUtils, TSESLint } from "@typescript-eslint/utils"
 import * as ts from "typescript";
 import { isPropertyReadonlyInType, isTypeReference } from "ts-api-utils";
 //#region src/jsdoc.ts
+const JS_TS_FILE_PATTERNS$1 = "**/*.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
 const jsdocConfig = jsdoc.configs["flat/recommended-tsdoc-error"];
 const REQUIREMENTS_TIER_RULES = [
 	"jsdoc/require-example",
@@ -30,12 +31,14 @@ const REQUIREMENTS_TIER_RULES = [
 	"jsdoc/require-yields-type"
 ];
 const jsdocAndTsdoc = [{
+	files: [JS_TS_FILE_PATTERNS$1],
 	...jsdocConfig,
 	rules: {
 		...jsdocConfig.rules,
 		...Object.fromEntries(REQUIREMENTS_TIER_RULES.map((rule) => [rule, "off"]))
 	}
 }, {
+	files: [JS_TS_FILE_PATTERNS$1],
 	plugins: { tsdoc },
 	rules: { "tsdoc/syntax": "error" }
 }];
@@ -125,7 +128,7 @@ function buildReactConfig(options = {}) {
 }
 //#endregion
 //#region package.json
-var version = "2.12.2";
+var version = "2.13.0";
 //#endregion
 //#region src/rules/barrel-helpers.ts
 const INDEX_BASENAME$1 = /^index\.[cm]?[tj]sx?$/;
@@ -482,6 +485,76 @@ const noArrayIsArrayMutation = createRule$7({
 	}
 });
 //#endregion
+//#region src/rules/no-control-flow.ts
+const noControlFlow = {
+	meta: {
+		type: "problem",
+		schema: [],
+		messages: {
+			ifStatement: "Use a lookup table, not an if/else branch.",
+			switchStatement: "Use a lookup table, not a switch branch.",
+			forStatement: "Use a lookup table or a declarative array method, not a for loop.",
+			forInStatement: "Use a lookup table or Object.entries, not a for-in loop.",
+			forOfStatement: "Use a declarative array method, not a for-of loop.",
+			whileStatement: "Use a lookup table or a declarative array method, not a while loop.",
+			doWhileStatement: "Use a lookup table or a declarative array method, not a do-while loop.",
+			conditionalExpression: "Use a lookup table, not a ternary."
+		}
+	},
+	create(context) {
+		return {
+			IfStatement(node) {
+				context.report({
+					node,
+					messageId: "ifStatement"
+				});
+			},
+			SwitchStatement(node) {
+				context.report({
+					node,
+					messageId: "switchStatement"
+				});
+			},
+			ForStatement(node) {
+				context.report({
+					node,
+					messageId: "forStatement"
+				});
+			},
+			ForInStatement(node) {
+				context.report({
+					node,
+					messageId: "forInStatement"
+				});
+			},
+			ForOfStatement(node) {
+				context.report({
+					node,
+					messageId: "forOfStatement"
+				});
+			},
+			WhileStatement(node) {
+				context.report({
+					node,
+					messageId: "whileStatement"
+				});
+			},
+			DoWhileStatement(node) {
+				context.report({
+					node,
+					messageId: "doWhileStatement"
+				});
+			},
+			ConditionalExpression(node) {
+				context.report({
+					node,
+					messageId: "conditionalExpression"
+				});
+			}
+		};
+	}
+};
+//#endregion
 //#region src/rules/no-enum-number-widening.ts
 const noEnumNumberWidening = ESLintUtils.RuleCreator((name) => `https://github.com/ExaDev/eslint-config/blob/main/src/rules/${name}.ts`)({
 	name: "no-enum-number-widening",
@@ -1322,6 +1395,7 @@ const plugin = {
 		"barrel-direct-siblings-only": barrelDirectSiblingsOnly,
 		"barrel-policy": barrelPolicy,
 		"no-array-isarray-mutation": noArrayIsArrayMutation,
+		"no-control-flow": noControlFlow,
 		"no-enum-number-widening": noEnumNumberWidening,
 		"no-enum-reverse-lookup-widening": noEnumReverseLookupWidening,
 		"no-index-files": noIndexFiles,
@@ -1368,11 +1442,22 @@ const plugin = {
 //#endregion
 //#region src/recommended-type-checked.ts
 const TEST_FILE_PATTERNS = "**/*.{test,spec}.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
+const JS_TS_FILE_PATTERNS = "**/*.{ts,tsx,mts,cts,js,jsx,mjs,cjs}";
+function scopeToJsTs(configs) {
+	return configs.map((config) => config.files ? config : {
+		...config,
+		files: [JS_TS_FILE_PATTERNS]
+	});
+}
 const recommendedTypeChecked = [
-	js.configs.recommended,
-	...tseslint.configs.strictTypeChecked,
-	...tseslint.configs.stylisticTypeChecked,
 	{
+		...js.configs.recommended,
+		files: [JS_TS_FILE_PATTERNS]
+	},
+	...scopeToJsTs(tseslint.configs.strictTypeChecked),
+	...scopeToJsTs(tseslint.configs.stylisticTypeChecked),
+	{
+		files: [JS_TS_FILE_PATTERNS],
 		plugins: { exadev: plugin },
 		linterOptions: { noInlineConfig: true },
 		rules: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "exadev-eslint-config",
-  "version": "2.12.2",
+  "version": "2.13.0",
   "description": "Shared custom ESLint rules and plugin for ExaDev projects",
   "type": "module",
   "sideEffects": false,
@@ -63,6 +63,7 @@
     "@arethetypeswrong/cli": "^0.18.5",
     "@commitlint/cli": "^21.2.1",
     "@commitlint/config-conventional": "^21.2.0",
+    "@eslint/json": "2.1.0",
     "@next/eslint-plugin-next": "^16.3.2",
     "@semantic-release/changelog": "^7.0.0",
     "@semantic-release/git": "^11.0.1",
@@ -85,7 +86,7 @@
   },
   "dependencies": {
     "@eslint/js": "^10.0.1",
-    "@typescript-eslint/utils": "^8.67.0",
+    "@typescript-eslint/utils": "8.67.0",
     "eslint-plugin-jsdoc": "64.3.6",
     "eslint-plugin-tsdoc": "^0.5.2",
     "ts-api-utils": "^2.5.0"