exadev-eslint-config 2.1.1 → 2.1.2

package/README.md

@@ -111,7 +111,7 @@ export default tseslint.config(
 | `no-non-barrel-reexport` | ✓ | Re-exports belong only in a barrel. Catches the split form across two statements (`import { x } from './y'; export { x };` or `export default x;`) which no AST selector alone can match. Autofix deletes the export and the now-pointless import when it was the import's only use. Self-scopes away from any index file. |
 | `no-side-effects-in-index` | | A barrel file may contain only re-export statements -- nothing that could execute at import time. Self-scopes to any index file. |
 | `barrel-direct-siblings-only` | | A barrel may re-export only from a direct sibling (`./module`), never a nested path, parent, or bare package specifier (mode 3). |
-| `no-pointless-reassignment` | ✓ | `const foo = bar` where both sides are plain identifiers and the alias adds no transformation. |
+| `no-pointless-reassignment` | ✓ | `const foo = bar` where both sides are plain identifiers and the alias adds no transformation. Autofix rewrites every read to the original name and deletes the declaration (including its `export` keyword, when exported). Still reported but deliberately not auto-fixable where collapsing the alias would change meaning: an explicit type annotation (`const exhaustive: never = item` -- the annotation is the point), a read where the original name is shadowed, a read as a shorthand object property, more than one declarator in the statement, or a source that is written to anywhere. |
 
 ## Barrel policy
 

package/dist/index.cjs

@@ -28,7 +28,7 @@ let typescript_eslint = require("typescript-eslint");
 typescript_eslint = __toESM(typescript_eslint, 1);
 let node_path = require("node:path");
 //#region package.json
-var version = "2.1.1";
+var version = "2.1.2";
 //#endregion
 //#region src/rules/barrel-helpers.ts
 const INDEX_BASENAME$1 = /^index\.[cm]?[tj]sx?$/;
@@ -375,6 +375,15 @@ const noNonBarrelReexport = {
 function isIdentifierReference(reference) {
 	return reference.identifier.type === "Identifier";
 }
+function hasTypeAnnotation(id) {
+	return "typeAnnotation" in id && id.typeAnnotation !== void 0 && id.typeAnnotation !== null;
+}
+function resolveFrom(scope, name) {
+	for (let current = scope; current; current = current.upper) {
+		const found = current.set.get(name);
+		if (found) return found;
+	}
+}
 //#endregion
 //#region src/plugin.ts
 const plugin = {
@@ -405,6 +414,7 @@ const plugin = {
 					if (!sourceVariable || sourceVariable.references.some((reference) => reference.isWrite() && !reference.init)) return;
 					const aliasName = node.id.name;
 					const originalName = node.init.name;
+					const aliasIsAnnotated = hasTypeAnnotation(node.id);
 					context.report({
 						node,
 						messageId: "pointlessReassignment",
@@ -415,6 +425,7 @@ const plugin = {
 						fix(fixer) {
 							const variable = scope.set.get(aliasName);
 							if (!variable) return null;
+							if (aliasIsAnnotated) return null;
 							if (variable.references.filter((reference) => reference.isWrite() && reference.identifier !== node.id).length > 0) return null;
 							const readRefs = variable.references.filter((reference) => reference.isRead() && isIdentifierReference(reference));
 							if (readRefs.some((reference) => {
@@ -430,10 +441,11 @@ const plugin = {
 								}
 								return false;
 							})) return null;
+							if (readRefs.some((reference) => resolveFrom(reference.from, originalName) !== sourceVariable)) return null;
 							const fixes = readRefs.map((reference) => fixer.replaceText(reference.identifier, originalName));
 							const declaration = node.parent;
 							if (declaration.type !== "VariableDeclaration" || declaration.declarations.length !== 1) return null;
-							fixes.push(fixer.remove(declaration));
+							fixes.push(fixer.remove(declaration.parent.type === "ExportNamedDeclaration" ? declaration.parent : declaration));
 							return fixes;
 						}
 					});

package/dist/index.js

@@ -1,7 +1,7 @@
 import tseslint from "typescript-eslint";
 import { posix } from "node:path";
 //#region package.json
-var version = "2.1.1";
+var version = "2.1.2";
 //#endregion
 //#region src/rules/barrel-helpers.ts
 const INDEX_BASENAME$1 = /^index\.[cm]?[tj]sx?$/;
@@ -348,6 +348,15 @@ const noNonBarrelReexport = {
 function isIdentifierReference(reference) {
 	return reference.identifier.type === "Identifier";
 }
+function hasTypeAnnotation(id) {
+	return "typeAnnotation" in id && id.typeAnnotation !== void 0 && id.typeAnnotation !== null;
+}
+function resolveFrom(scope, name) {
+	for (let current = scope; current; current = current.upper) {
+		const found = current.set.get(name);
+		if (found) return found;
+	}
+}
 //#endregion
 //#region src/plugin.ts
 const plugin = {
@@ -378,6 +387,7 @@ const plugin = {
 					if (!sourceVariable || sourceVariable.references.some((reference) => reference.isWrite() && !reference.init)) return;
 					const aliasName = node.id.name;
 					const originalName = node.init.name;
+					const aliasIsAnnotated = hasTypeAnnotation(node.id);
 					context.report({
 						node,
 						messageId: "pointlessReassignment",
@@ -388,6 +398,7 @@ const plugin = {
 						fix(fixer) {
 							const variable = scope.set.get(aliasName);
 							if (!variable) return null;
+							if (aliasIsAnnotated) return null;
 							if (variable.references.filter((reference) => reference.isWrite() && reference.identifier !== node.id).length > 0) return null;
 							const readRefs = variable.references.filter((reference) => reference.isRead() && isIdentifierReference(reference));
 							if (readRefs.some((reference) => {
@@ -403,10 +414,11 @@ const plugin = {
 								}
 								return false;
 							})) return null;
+							if (readRefs.some((reference) => resolveFrom(reference.from, originalName) !== sourceVariable)) return null;
 							const fixes = readRefs.map((reference) => fixer.replaceText(reference.identifier, originalName));
 							const declaration = node.parent;
 							if (declaration.type !== "VariableDeclaration" || declaration.declarations.length !== 1) return null;
-							fixes.push(fixer.remove(declaration));
+							fixes.push(fixer.remove(declaration.parent.type === "ExportNamedDeclaration" ? declaration.parent : declaration));
 							return fixes;
 						}
 					});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "exadev-eslint-config",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "Shared custom ESLint rules and plugin for ExaDev projects",
   "type": "module",
   "sideEffects": false,