ework-web 0.10.18 → 0.10.20

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ework-web",
-  "version": "0.10.18",
+  "version": "0.10.20",
   "type": "module",
   "description": "ework-web — standalone multi-project issue tracker. Local SQLite-backed, no external API dependency. Bun + TypeScript + SSR HTML.",
   "license": "MIT",

package/src/db-admin.ts

@@ -251,13 +251,12 @@ export async function migrateSqliteToMysql(opts: MysqlTargetOpts): Promise<Migra
     // The `config` table is created in db.ts:SqliteDriver.create at boot but
     // is missing from schema-mysql.sql (pre-existing gap — MysqlDriver.create
     // doesn't create it either, so a plain mysql boot has no config table).
-    // Recreate the same shape here so migrate() can copy config rows. `key`
-    // is a MySQL reserved word — must be backticked. VARCHAR(255) on the PK
-    // because MySQL TEXT can't be a PRIMARY KEY without a prefix length.
+    // Recreate the same shape here so migrate() can copy config rows.
     await conn.query(
       applyTargetPrefix(
         "CREATE TABLE IF NOT EXISTS {{config}} (" +
-          "`key` VARCHAR(255) PRIMARY KEY," +
+          "id BIGINT AUTO_INCREMENT PRIMARY KEY," +
+          "akey VARCHAR(255) NOT NULL UNIQUE," +
           "value TEXT NOT NULL," +
           "updated_at VARCHAR(40) NOT NULL" +
           ") ENGINE=InnoDB DEFAULT CHARSET=utf8mb4",
@@ -461,11 +460,10 @@ export async function migrateMysqlToSqlite(targetPath: string): Promise<MigrateR
     target.exec("PRAGMA journal_mode = WAL");
     target.exec("PRAGMA foreign_keys = ON");
 
-    // config table (same shape as db.ts:144 — not in schema.sql).
-    // `key` is NOT reserved in SQLite (unlike MySQL).
+    // config table (same shape as db.ts:158 — not in schema.sql).
     target.exec(
       applyTargetPrefix(
-        "CREATE TABLE IF NOT EXISTS {{config}} (key TEXT PRIMARY KEY, value TEXT NOT NULL, updated_at TEXT NOT NULL)",
+        "CREATE TABLE IF NOT EXISTS {{config}} (id INTEGER PRIMARY KEY AUTOINCREMENT, akey TEXT NOT NULL UNIQUE, value TEXT NOT NULL, updated_at TEXT NOT NULL)",
         ""
       )
     );
@@ -609,12 +607,12 @@ export function generateMysqlDDL(
   }
 
   // config table — created in db.ts:SqliteDriver.create at boot, missing from
-  // schema-mysql.sql. Same shape as migrateSqliteToMysql L257-266. `key` is a
-  // MySQL reserved word → backticked.
+  // schema-mysql.sql. Same shape as migrateSqliteToMysql L257-266.
   lines.push(
     applyTargetPrefix(
       "CREATE TABLE IF NOT EXISTS {{config}} (" +
-        "`key` VARCHAR(255) PRIMARY KEY," +
+        "id BIGINT AUTO_INCREMENT PRIMARY KEY," +
+        "akey VARCHAR(255) NOT NULL UNIQUE," +
         "value TEXT NOT NULL," +
         "updated_at VARCHAR(40) NOT NULL" +
         ") ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;",

package/src/db.ts

@@ -141,6 +141,75 @@ function migrateLabelsTable(db: Database): void {
   }
 }
 
+function migrateConfigTable(db: Database): void {
+  const have = tableColumns(db, "config");
+  if (have.size === 0) return;
+  if (have.has("id") && have.has("akey")) return;
+  db.exec("PRAGMA foreign_keys = OFF");
+  try {
+    const oldKeyCol = have.has("key") ? "key" : "akey";
+    db.exec(applyPrefix("ALTER TABLE {{config}} RENAME TO config_old"));
+    db.exec(applyPrefix(
+      "CREATE TABLE {{config}} (id INTEGER PRIMARY KEY AUTOINCREMENT, akey TEXT NOT NULL UNIQUE, value TEXT NOT NULL, updated_at TEXT NOT NULL)"
+    ));
+    db.exec(applyPrefix(
+      `INSERT INTO {{config}} (akey, value, updated_at) SELECT ${oldKeyCol}, value, updated_at FROM config_old`
+    ));
+    db.exec("DROP TABLE config_old");
+  } finally {
+    db.exec("PRAGMA foreign_keys = ON");
+  }
+}
+
+const SURROGATE_ID_TABLES: Array<{ name: string; createSql: string; dataCols: string }> = [
+  {
+    name: "users",
+    createSql: "CREATE TABLE {{users}} (id INTEGER PRIMARY KEY AUTOINCREMENT, login TEXT NOT NULL UNIQUE, kind TEXT NOT NULL DEFAULT 'human' CHECK (kind IN ('human','bot','system')), display_name TEXT, password_hash TEXT, email TEXT, is_admin INTEGER NOT NULL DEFAULT 0, is_active INTEGER NOT NULL DEFAULT 1, created_at TEXT NOT NULL, updated_at TEXT NOT NULL DEFAULT '')",
+    dataCols: "login, kind, display_name, password_hash, email, is_admin, is_active, created_at, updated_at",
+  },
+  {
+    name: "model_cache",
+    createSql: "CREATE TABLE {{model_cache}} (id INTEGER PRIMARY KEY AUTOINCREMENT, provider_model TEXT NOT NULL UNIQUE, label TEXT NOT NULL, refreshed_at TEXT NOT NULL)",
+    dataCols: "provider_model, label, refreshed_at",
+  },
+  {
+    name: "issue_labels",
+    createSql: "CREATE TABLE {{issue_labels}} (id INTEGER PRIMARY KEY AUTOINCREMENT, issue_id INTEGER NOT NULL REFERENCES {{issues}}(id) ON DELETE CASCADE, label_id INTEGER NOT NULL REFERENCES {{labels}}(id) ON DELETE CASCADE, UNIQUE (issue_id, label_id))",
+    dataCols: "issue_id, label_id",
+  },
+  {
+    name: "reactions",
+    createSql: "CREATE TABLE {{reactions}} (id INTEGER PRIMARY KEY AUTOINCREMENT, comment_id INTEGER NOT NULL REFERENCES {{comments}}(id) ON DELETE CASCADE, user_login TEXT NOT NULL REFERENCES {{users}}(login), content TEXT NOT NULL, UNIQUE (comment_id, user_login, content))",
+    dataCols: "comment_id, user_login, content",
+  },
+  {
+    name: "attachments",
+    createSql: "CREATE TABLE {{attachments}} (id INTEGER PRIMARY KEY AUTOINCREMENT, uuid TEXT NOT NULL UNIQUE, issue_id INTEGER NOT NULL REFERENCES {{issues}}(id) ON DELETE CASCADE, filename TEXT NOT NULL, content_type TEXT NOT NULL DEFAULT 'application/octet-stream', size INTEGER NOT NULL, blob_path TEXT NOT NULL, uploaded_by TEXT NOT NULL REFERENCES {{users}}(login), created_at TEXT NOT NULL)",
+    dataCols: "uuid, issue_id, filename, content_type, size, blob_path, uploaded_by, created_at",
+  },
+  {
+    name: "project_members",
+    createSql: "CREATE TABLE {{project_members}} (id INTEGER PRIMARY KEY AUTOINCREMENT, project_id INTEGER NOT NULL REFERENCES {{projects}}(id) ON DELETE CASCADE, user_login TEXT NOT NULL REFERENCES {{users}}(login) ON DELETE CASCADE, role TEXT NOT NULL DEFAULT 'writer' CHECK (role IN ('reader','writer','admin')), created_at TEXT NOT NULL, UNIQUE (project_id, user_login))",
+    dataCols: "project_id, user_login, role, created_at",
+  },
+];
+
+function migrateAddSurrogateId(db: Database): void {
+  db.exec("PRAGMA foreign_keys = OFF");
+  try {
+    for (const t of SURROGATE_ID_TABLES) {
+      const have = tableColumns(db, t.name);
+      if (have.size === 0 || have.has("id")) continue;
+      db.exec(applyPrefix(`ALTER TABLE {{${t.name}}} RENAME TO ${t.name}_old`));
+      db.exec(applyPrefix(t.createSql));
+      db.exec(applyPrefix(`INSERT INTO {{${t.name}}} (${t.dataCols}) SELECT ${t.dataCols} FROM ${t.name}_old`));
+      db.exec(`DROP TABLE ${t.name}_old`);
+    }
+  } finally {
+    db.exec("PRAGMA foreign_keys = ON");
+  }
+}
+
 // ---- SqliteDriver: wraps bun:sqlite behind AsyncDatabase ----
 class SqliteDriver implements AsyncDatabase {
   readonly dialect = "sqlite" as const;
@@ -155,15 +224,17 @@ class SqliteDriver implements AsyncDatabase {
     db.exec("PRAGMA foreign_keys = ON");
     db.exec(
       applyPrefix(
-        "CREATE TABLE IF NOT EXISTS {{config}} (key TEXT PRIMARY KEY, value TEXT NOT NULL, updated_at TEXT NOT NULL)"
+        "CREATE TABLE IF NOT EXISTS {{config}} (id INTEGER PRIMARY KEY AUTOINCREMENT, akey TEXT NOT NULL UNIQUE, value TEXT NOT NULL, updated_at TEXT NOT NULL)"
       )
     );
     // Migration must run BEFORE schema.sql (same ordering as the original file).
+  migrateConfigTable(db);
   migrateUsersTable(db);
   migratePatTable(db);
   migrateProjectsTable(db);
   migrateIssuesTable(db);
   migrateLabelsTable(db);
+  migrateAddSurrogateId(db);
     db.exec(applyPrefix(readFileSync(join(import.meta.dir, "schema.sql"), "utf8")));
     return new SqliteDriver(db);
   }
@@ -230,6 +301,43 @@ function translateForMysql(sql: string): string {
     .replace(/excluded\.(\w+)/g, "VALUES($1)");
 }
 
+async function migrateMysqlSurrogateId(pool: Pool): Promise<void> {
+  const MYSQL_ALTERS: Array<{ table: string; sql: string }> = [
+    { table: "users", sql: "ALTER TABLE {{users}} DROP PRIMARY KEY, ADD COLUMN id BIGINT AUTO_INCREMENT PRIMARY KEY FIRST, ADD UNIQUE INDEX uk_users_login (login)" },
+    { table: "model_cache", sql: "ALTER TABLE {{model_cache}} DROP PRIMARY KEY, ADD COLUMN id BIGINT AUTO_INCREMENT PRIMARY KEY FIRST, ADD UNIQUE INDEX uk_mc_pm (provider_model)" },
+    { table: "issue_labels", sql: "ALTER TABLE {{issue_labels}} DROP PRIMARY KEY, ADD COLUMN id BIGINT AUTO_INCREMENT PRIMARY KEY FIRST, ADD UNIQUE INDEX uk_il (issue_id, label_id)" },
+    { table: "reactions", sql: "ALTER TABLE {{reactions}} DROP PRIMARY KEY, ADD COLUMN id BIGINT AUTO_INCREMENT PRIMARY KEY FIRST, ADD UNIQUE INDEX uk_react (comment_id, user_login, content)" },
+    { table: "attachments", sql: "ALTER TABLE {{attachments}} DROP PRIMARY KEY, ADD COLUMN id BIGINT AUTO_INCREMENT PRIMARY KEY FIRST, ADD UNIQUE INDEX uk_att_uuid (uuid)" },
+    { table: "project_members", sql: "ALTER TABLE {{project_members}} DROP PRIMARY KEY, ADD COLUMN id BIGINT AUTO_INCREMENT PRIMARY KEY FIRST, ADD UNIQUE INDEX uk_pm (project_id, user_login)" },
+  ];
+  for (const m of MYSQL_ALTERS) {
+    const tbl = DB_PREFIX + m.table;
+    const [cols] = await pool.query(
+      "SELECT COLUMN_NAME FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = ? AND COLUMN_NAME = 'id'",
+      [tbl]
+    );
+    if ((cols as unknown[]).length > 0) continue;
+    try {
+      await pool.query(applyPrefix(m.sql));
+    } catch (e) {
+      const errno = (e as { errno?: number }).errno;
+      if (errno === 1146) continue;
+      console.warn(`[db] MySQL surrogate-id migration for ${m.table} failed (errno ${errno}):`, (e as Error).message);
+    }
+  }
+  const [cfgCols] = await pool.query(
+    "SELECT COLUMN_NAME FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = ? AND COLUMN_NAME = 'key'",
+    [DB_PREFIX + "config"]
+  );
+  if ((cfgCols as unknown[]).length > 0) {
+    try {
+      await pool.query(applyPrefix("ALTER TABLE {{config}} CHANGE `key` akey VARCHAR(255) NOT NULL"));
+    } catch (e) {
+      console.warn("[db] MySQL config key→akey rename failed:", (e as Error).message);
+    }
+  }
+}
+
 class MysqlDriver implements AsyncDatabase {
   readonly dialect = "mysql" as const;
   private readonly pool: Pool;
@@ -271,6 +379,7 @@ class MysqlDriver implements AsyncDatabase {
           throw e;
         }
       }
+      await migrateMysqlSurrogateId(pool);
     }
     return new MysqlDriver(pool);
   }
@@ -347,9 +456,9 @@ export function getDB(): AsyncDatabase {
 export async function getConfigAll(): Promise<Record<string, string>> {
   try {
     const driver = getDB();
-    const rows = await driver.all<{ key: string; value: string }>("SELECT key, value FROM {{config}}");
+    const rows = await driver.all<{ akey: string; value: string }>("SELECT akey, value FROM {{config}}");
     const out: Record<string, string> = {};
-    for (const r of rows) out[r.key] = r.value;
+    for (const r of rows) out[r.akey] = r.value;
     return out;
   } catch {
     return {};
@@ -359,12 +468,12 @@ export async function getConfigAll(): Promise<Record<string, string>> {
 export async function setConfig(key: string, value: string): Promise<void> {
   const now = new Date().toISOString();
   await getDB().run(
-    "INSERT INTO {{config}} (key, value, updated_at) VALUES (?, ?, ?) " +
-      "ON CONFLICT(key) DO UPDATE SET value = excluded.value, updated_at = excluded.updated_at",
+    "INSERT INTO {{config}} (akey, value, updated_at) VALUES (?, ?, ?) " +
+      "ON CONFLICT(akey) DO UPDATE SET value = excluded.value, updated_at = excluded.updated_at",
     [key, value, now]
   );
 }
 
 export async function deleteConfig(key: string): Promise<void> {
-  await getDB().run("DELETE FROM {{config}} WHERE key = ?", [key]);
+  await getDB().run("DELETE FROM {{config}} WHERE akey = ?", [key]);
 }

package/src/index.ts

@@ -1386,6 +1386,38 @@ async function handle(req: Request, url: URL, ip: string, ctx: { authed: boolean
     }
   }
 
+  const issueLabelsApi = url.pathname.match(API_ISSUE_LABELS_RE);
+  if (issueLabelsApi) {
+    const [, owner, repo, numStr] = issueLabelsApi;
+    if (!(owner && repo && numStr)) return html(errorPage("404", "bad path"), 404);
+    const project = await getProject(owner, repo);
+    if (!project) return json({ error: "project not found" }, 404);
+    const issue = await getIssueWithMeta(project.id, Number(numStr));
+    if (!issue) return json({ error: "issue not found" }, 404);
+    if (req.method === "GET") {
+      const [current, available] = await Promise.all([
+        listLabelsForIssue(issue.id),
+        listLabels(project.id),
+      ]);
+      return json({ current, available });
+    }
+    if (req.method === "POST") {
+      if (!ctx.user || !(await canWriteProject(project.id, ctx.user))) {
+        return json({ error: "forbidden: needs writer role on project" }, 403);
+      }
+      const body = await req.json().catch(() => ({}));
+      const labelIds = Array.isArray(body.labelIds) ? body.labelIds.map((n: unknown) => Number(n)).filter((n: number) => Number.isInteger(n) && n > 0) : [];
+      try {
+        await setIssueLabels(issue.id, labelIds);
+        const current = await listLabelsForIssue(issue.id);
+        return json({ current });
+      } catch (e) {
+        return json({ error: errMsg(e) }, e instanceof StoreError ? e.status : 500);
+      }
+    }
+    return json({ error: "method not allowed" }, 405);
+  }
+
   if (req.method === "POST") {
     if (!cfg.writesEnabled) return json({ error: "writes disabled" }, 403);
     const up = url.pathname.match(UPLOAD_RE);
@@ -1765,38 +1797,6 @@ async function handle(req: Request, url: URL, ip: string, ctx: { authed: boolean
     }
   }
 
-  const issueLabelsApi = url.pathname.match(API_ISSUE_LABELS_RE);
-  if (issueLabelsApi) {
-    const [, owner, repo, numStr] = issueLabelsApi;
-    if (!(owner && repo && numStr)) return html(errorPage("404", "bad path"), 404);
-    const project = await getProject(owner, repo);
-    if (!project) return json({ error: "project not found" }, 404);
-    const issue = await getIssueWithMeta(project.id, Number(numStr));
-    if (!issue) return json({ error: "issue not found" }, 404);
-    if (req.method === "GET") {
-      const [current, available] = await Promise.all([
-        listLabelsForIssue(issue.id),
-        listLabels(project.id),
-      ]);
-      return json({ current, available });
-    }
-    if (req.method === "POST") {
-      if (!ctx.user || !(await canWriteProject(project.id, ctx.user))) {
-        return json({ error: "forbidden: needs writer role on project" }, 403);
-      }
-      const body = await req.json().catch(() => ({}));
-      const labelIds = Array.isArray(body.labelIds) ? body.labelIds.map((n: unknown) => Number(n)).filter((n: number) => Number.isInteger(n) && n > 0) : [];
-      try {
-        await setIssueLabels(issue.id, labelIds);
-        const current = await listLabelsForIssue(issue.id);
-        return json({ current });
-      } catch (e) {
-        return json({ error: errMsg(e) }, e instanceof StoreError ? e.status : 500);
-      }
-    }
-    return json({ error: "method not allowed" }, 405);
-  }
-
   const isNew = url.pathname.match(REPO_NEW_RE);
   if (isNew) {
     const [, owner, repo] = isNew;

package/src/schema-mysql.sql

@@ -8,7 +8,8 @@
 -- tables InnoDB + utf8mb4 for FK CASCADE + full Unicode (emoji).
 
 CREATE TABLE IF NOT EXISTS {{users}} (
-  login         VARCHAR(255) PRIMARY KEY,
+  id            BIGINT AUTO_INCREMENT PRIMARY KEY,
+  login         VARCHAR(255) NOT NULL UNIQUE,
   kind          VARCHAR(16) NOT NULL DEFAULT 'human'
                 CHECK (kind IN ('human','bot','system')),
   display_name  VARCHAR(255) DEFAULT NULL,
@@ -33,7 +34,8 @@ CREATE TABLE IF NOT EXISTS {{projects}} (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
 
 CREATE TABLE IF NOT EXISTS {{model_cache}} (
-  provider_model VARCHAR(128) PRIMARY KEY,
+  id             BIGINT AUTO_INCREMENT PRIMARY KEY,
+  provider_model VARCHAR(128) NOT NULL UNIQUE,
   label          VARCHAR(255) NOT NULL,
   refreshed_at   VARCHAR(40) NOT NULL
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
@@ -86,19 +88,21 @@ CREATE TABLE IF NOT EXISTS {{labels}} (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
 
 CREATE TABLE IF NOT EXISTS {{issue_labels}} (
-  issue_id BIGINT NOT NULL,
-  label_id BIGINT NOT NULL,
-  PRIMARY KEY (issue_id, label_id),
+  id        BIGINT AUTO_INCREMENT PRIMARY KEY,
+  issue_id  BIGINT NOT NULL,
+  label_id  BIGINT NOT NULL,
+  UNIQUE (issue_id, label_id),
   CONSTRAINT {{fk_il_issue}} FOREIGN KEY (issue_id) REFERENCES {{issues}}(id) ON DELETE CASCADE,
   CONSTRAINT {{fk_il_label}} FOREIGN KEY (label_id) REFERENCES {{labels}}(id) ON DELETE CASCADE
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
 CREATE INDEX issue_labels_label ON {{issue_labels}} (label_id);
 
 CREATE TABLE IF NOT EXISTS {{reactions}} (
-  comment_id BIGINT NOT NULL,
-  user_login VARCHAR(255) NOT NULL,
-  content    VARCHAR(64) NOT NULL,
-  PRIMARY KEY (comment_id, user_login, content),
+  id          BIGINT AUTO_INCREMENT PRIMARY KEY,
+  comment_id  BIGINT NOT NULL,
+  user_login  VARCHAR(255) NOT NULL,
+  content     VARCHAR(64) NOT NULL,
+  UNIQUE (comment_id, user_login, content),
   CONSTRAINT {{fk_reactions_comment}} FOREIGN KEY (comment_id)  REFERENCES {{comments}}(id) ON DELETE CASCADE,
   CONSTRAINT {{fk_reactions_user}} FOREIGN KEY (user_login)  REFERENCES {{users}}(login)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
@@ -106,14 +110,15 @@ CREATE INDEX reactions_comment ON {{reactions}} (comment_id);
 CREATE INDEX reactions_user   ON {{reactions}} (user_login);
 
 CREATE TABLE IF NOT EXISTS {{attachments}} (
-  uuid         VARCHAR(64) PRIMARY KEY,
-  issue_id     BIGINT NOT NULL,
-  filename     VARCHAR(255) NOT NULL,
-  content_type VARCHAR(128) NOT NULL DEFAULT 'application/octet-stream',
-  size         BIGINT NOT NULL,
-  blob_path    VARCHAR(1024) NOT NULL,
-  uploaded_by  VARCHAR(255) NOT NULL,
-  created_at   VARCHAR(40) NOT NULL,
+  id            BIGINT AUTO_INCREMENT PRIMARY KEY,
+  uuid          VARCHAR(64) NOT NULL UNIQUE,
+  issue_id      BIGINT NOT NULL,
+  filename      VARCHAR(255) NOT NULL,
+  content_type  VARCHAR(128) NOT NULL DEFAULT 'application/octet-stream',
+  size          BIGINT NOT NULL,
+  blob_path     VARCHAR(1024) NOT NULL,
+  uploaded_by   VARCHAR(255) NOT NULL,
+  created_at    VARCHAR(40) NOT NULL,
   CONSTRAINT {{fk_attachments_issue}} FOREIGN KEY (issue_id)    REFERENCES {{issues}}(id) ON DELETE CASCADE,
   CONSTRAINT {{fk_attachments_user}} FOREIGN KEY (uploaded_by) REFERENCES {{users}}(login)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
@@ -169,12 +174,13 @@ CREATE INDEX pat_user         ON {{personal_access_tokens}} (user_login);
 CREATE INDEX pat_last_eight   ON {{personal_access_tokens}} (token_last_eight);
 
 CREATE TABLE IF NOT EXISTS {{project_members}} (
-  project_id BIGINT NOT NULL,
-  user_login VARCHAR(255) NOT NULL,
-  role       VARCHAR(16) NOT NULL DEFAULT 'writer'
-             CHECK (role IN ('reader','writer','admin')),
-  created_at VARCHAR(40) NOT NULL,
-  PRIMARY KEY (project_id, user_login),
+  id          BIGINT AUTO_INCREMENT PRIMARY KEY,
+  project_id  BIGINT NOT NULL,
+  user_login  VARCHAR(255) NOT NULL,
+  role        VARCHAR(16) NOT NULL DEFAULT 'writer'
+              CHECK (role IN ('reader','writer','admin')),
+  created_at  VARCHAR(40) NOT NULL,
+  UNIQUE (project_id, user_login),
   CONSTRAINT {{fk_pm_project}} FOREIGN KEY (project_id) REFERENCES {{projects}}(id) ON DELETE CASCADE,
   CONSTRAINT {{fk_pm_user}} FOREIGN KEY (user_login) REFERENCES {{users}}(login) ON DELETE CASCADE
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

package/src/schema.sql

@@ -1,10 +1,10 @@
 -- ework schema. Applied idempotently on boot (IF NOT EXISTS everywhere).
 -- See db.ts for PRAGMA setup (WAL + foreign_keys = ON).
 
--- login stays PRIMARY KEY intentionally. Renaming users is not supported;
--- swap to INTEGER user_id + UNIQUE(login) if that ever changes.
+-- login is UNIQUE (not PRIMARY KEY) — surrogate id is the PK now.
 CREATE TABLE IF NOT EXISTS {{users}} (
-  login         TEXT PRIMARY KEY,
+  id            INTEGER PRIMARY KEY AUTOINCREMENT,
+  login         TEXT NOT NULL UNIQUE,
   kind          TEXT NOT NULL DEFAULT 'human'
                 CHECK (kind IN ('human','bot','system')),
   display_name  TEXT,
@@ -40,7 +40,8 @@ CREATE TABLE IF NOT EXISTS {{projects}} (
 -- than a single JSON blob so the settings UI can render a select without
 -- parsing JSON in SQL.
 CREATE TABLE IF NOT EXISTS {{model_cache}} (
-  provider_model TEXT PRIMARY KEY,
+  id             INTEGER PRIMARY KEY AUTOINCREMENT,
+  provider_model TEXT NOT NULL UNIQUE,
   label          TEXT NOT NULL,
   refreshed_at   TEXT NOT NULL
 );
@@ -89,29 +90,32 @@ CREATE TABLE IF NOT EXISTS {{labels}} (
 );
 
 CREATE TABLE IF NOT EXISTS {{issue_labels}} (
+  id        INTEGER PRIMARY KEY AUTOINCREMENT,
   issue_id  INTEGER NOT NULL REFERENCES {{issues}}(id) ON DELETE CASCADE,
   label_id  INTEGER NOT NULL REFERENCES {{labels}}(id) ON DELETE CASCADE,
-  PRIMARY KEY (issue_id, label_id)
+  UNIQUE (issue_id, label_id)
 );
 
 CREATE TABLE IF NOT EXISTS {{reactions}} (
-  comment_id INTEGER NOT NULL REFERENCES {{comments}}(id) ON DELETE CASCADE,
-  user_login TEXT NOT NULL REFERENCES {{users}}(login),
-  content    TEXT NOT NULL,
-  PRIMARY KEY (comment_id, user_login, content)
+  id          INTEGER PRIMARY KEY AUTOINCREMENT,
+  comment_id  INTEGER NOT NULL REFERENCES {{comments}}(id) ON DELETE CASCADE,
+  user_login  TEXT NOT NULL REFERENCES {{users}}(login),
+  content     TEXT NOT NULL,
+  UNIQUE (comment_id, user_login, content)
 );
 CREATE INDEX IF NOT EXISTS reactions_comment
   ON {{reactions}} (comment_id);
 
 CREATE TABLE IF NOT EXISTS {{attachments}} (
-  uuid        TEXT PRIMARY KEY,
-  issue_id    INTEGER NOT NULL REFERENCES {{issues}}(id) ON DELETE CASCADE,
-  filename    TEXT NOT NULL,
-  content_type TEXT NOT NULL DEFAULT 'application/octet-stream',
-  size        INTEGER NOT NULL,
-  blob_path   TEXT NOT NULL,
-  uploaded_by TEXT NOT NULL REFERENCES {{users}}(login),
-  created_at  TEXT NOT NULL
+  id            INTEGER PRIMARY KEY AUTOINCREMENT,
+  uuid          TEXT NOT NULL UNIQUE,
+  issue_id      INTEGER NOT NULL REFERENCES {{issues}}(id) ON DELETE CASCADE,
+  filename      TEXT NOT NULL,
+  content_type  TEXT NOT NULL DEFAULT 'application/octet-stream',
+  size          INTEGER NOT NULL,
+  blob_path     TEXT NOT NULL,
+  uploaded_by   TEXT NOT NULL REFERENCES {{users}}(login),
+  created_at    TEXT NOT NULL
 );
 CREATE INDEX IF NOT EXISTS attachments_issue
   ON {{attachments}} (issue_id);
@@ -187,12 +191,13 @@ CREATE INDEX IF NOT EXISTS pat_last_eight
 -- routes through here: a write-scoped PAT can only write where the owning user
 -- has writer+ role on the target project.
 CREATE TABLE IF NOT EXISTS {{project_members}} (
-  project_id INTEGER NOT NULL REFERENCES {{projects}}(id) ON DELETE CASCADE,
-  user_login TEXT NOT NULL REFERENCES {{users}}(login) ON DELETE CASCADE,
-  role       TEXT NOT NULL DEFAULT 'writer'
-             CHECK (role IN ('reader','writer','admin')),
-  created_at TEXT NOT NULL,
-  PRIMARY KEY (project_id, user_login)
+  id          INTEGER PRIMARY KEY AUTOINCREMENT,
+  project_id  INTEGER NOT NULL REFERENCES {{projects}}(id) ON DELETE CASCADE,
+  user_login  TEXT NOT NULL REFERENCES {{users}}(login) ON DELETE CASCADE,
+  role        TEXT NOT NULL DEFAULT 'writer'
+              CHECK (role IN ('reader','writer','admin')),
+  created_at  TEXT NOT NULL,
+  UNIQUE (project_id, user_login)
 );
 CREATE INDEX IF NOT EXISTS project_members_user
   ON {{project_members}} (user_login);

package/src/store.ts

@@ -689,33 +689,41 @@ export async function setIssueLabel(issueId: number, labelId: number, on: boolea
   }
   const label = await getDB().get<LabelRow>("SELECT * FROM {{labels}} WHERE id = ?", [labelId]);
   if (!label) throw new StoreError(404, "标签不存在");
-  if (label.exclusive === 1) {
-    const scope = labelScope(label.name);
-    if (scope) {
-      const current = await listLabelsForIssue(issueId);
-      const siblings = current.filter((l) => l.exclusive === 1 && labelScope(l.name) === scope && l.id !== labelId);
-      for (const s of siblings) {
-        await getDB().run("DELETE FROM {{issue_labels}} WHERE issue_id = ? AND label_id = ?", [issueId, s.id]);
+  // Wrap read-modify-write in a transaction to prevent concurrent callers
+  // from racing on exclusive-scope eviction (read old set → both insert).
+  await getDB().transaction(async () => {
+    if (label.exclusive === 1) {
+      const scope = labelScope(label.name);
+      if (scope) {
+        const current = await listLabelsForIssue(issueId);
+        const siblings = current.filter((l) => l.exclusive === 1 && labelScope(l.name) === scope && l.id !== labelId);
+        for (const s of siblings) {
+          await getDB().run("DELETE FROM {{issue_labels}} WHERE issue_id = ? AND label_id = ?", [issueId, s.id]);
+        }
       }
     }
-  }
-  const dialect = getDB().dialect;
-  const insert = dialect === "sqlite"
-    ? "INSERT OR IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)"
-    : "INSERT IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)";
-  await getDB().run(insert, [issueId, labelId]);
+    const dialect = getDB().dialect;
+    const insert = dialect === "sqlite"
+      ? "INSERT OR IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)"
+      : "INSERT IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)";
+    await getDB().run(insert, [issueId, labelId]);
+  });
 }
 
 export async function setIssueLabels(issueId: number, labelIds: number[]): Promise<void> {
   const dialect = getDB().dialect;
-  await getDB().run("DELETE FROM {{issue_labels}} WHERE issue_id = ?", [issueId]);
-  const ids = Array.from(new Set(labelIds));
-  const insert = dialect === "sqlite"
-    ? "INSERT OR IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)"
-    : "INSERT IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)";
-  for (const id of ids) {
-    await getDB().run(insert, [issueId, id]);
-  }
+  // Wrap DELETE + INSERTs in a transaction so a crash between operations
+  // doesn't leave the issue with zero labels.
+  await getDB().transaction(async () => {
+    await getDB().run("DELETE FROM {{issue_labels}} WHERE issue_id = ?", [issueId]);
+    const ids = Array.from(new Set(labelIds));
+    const insert = dialect === "sqlite"
+      ? "INSERT OR IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)"
+      : "INSERT IGNORE INTO {{issue_labels}} (issue_id, label_id) VALUES (?, ?)";
+    for (const id of ids) {
+      await getDB().run(insert, [issueId, id]);
+    }
+  });
 }
 
 export async function createAttachment(a: Omit<AttachmentRow, "created_at">): Promise<AttachmentRow> {