ework-daemon 0.4.5 → 0.4.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ework-daemon",
-  "version": "0.4.5",
+  "version": "0.4.6",
   "description": "Issue-driven AI development daemon. Spawns opencode subprocesses to resolve Gitea issues.",
   "module": "src/index.ts",
   "type": "module",

package/src/db.ts

@@ -323,6 +323,111 @@ async function runMigrations(db: AsyncDatabase): Promise<void> {
     await db.exec(`ALTER TABLE ${table} ADD COLUMN ${ddl}`);
   };
 
+  // ── uid: surrogate AUTO_INCREMENT PK on issues/op_sessions/messages ──
+  // SQLite cannot ADD PRIMARY KEY via ALTER — must rebuild. Runs before
+  // owner_daemon_id etc. so rebuild only copies base columns; ephemeral
+  // coordination data (owner_daemon_id, nudge state) is re-added below.
+  const tMessages = `${prefix}messages`;
+  if (sqlite) {
+    const UID_REBUILDS: { table: string; createSql: string; dataCols: string }[] = [
+      {
+        table: tIssues,
+        createSql: `CREATE TABLE ${tIssues} (
+  uid INTEGER PRIMARY KEY AUTOINCREMENT,
+  id TEXT NOT NULL UNIQUE,
+  tracker_type TEXT NOT NULL,
+  tracker_scope_key TEXT NOT NULL,
+  tracker_scope TEXT NOT NULL,
+  tracker_issue_id TEXT NOT NULL,
+  state TEXT NOT NULL DEFAULT 'created',
+  title TEXT NOT NULL DEFAULT '',
+  created_at TEXT NOT NULL,
+  updated_at TEXT NOT NULL,
+  UNIQUE(tracker_type, tracker_scope_key, tracker_issue_id)
+)`,
+        dataCols:
+          "id, tracker_type, tracker_scope_key, tracker_scope, tracker_issue_id, state, title, created_at, updated_at",
+      },
+      {
+        table: tSessions,
+        createSql: `CREATE TABLE ${tSessions} (
+  uid INTEGER PRIMARY KEY AUTOINCREMENT,
+  id TEXT NOT NULL UNIQUE,
+  issue_id TEXT NOT NULL REFERENCES ${tIssues}(id) ON DELETE CASCADE,
+  name TEXT NOT NULL,
+  state TEXT NOT NULL DEFAULT 'idle',
+  opencode_session_id TEXT,
+  opencode_pid INTEGER,
+  workdir TEXT,
+  created_at TEXT NOT NULL,
+  started_at INTEGER,
+  progress_comment_id TEXT,
+  reaction_comment_id TEXT,
+  current_prompt TEXT,
+  UNIQUE(issue_id, name)
+)`,
+        dataCols:
+          "id, issue_id, name, state, opencode_session_id, opencode_pid, workdir, created_at, started_at, progress_comment_id, reaction_comment_id, current_prompt",
+      },
+      {
+        table: tMessages,
+        createSql: `CREATE TABLE ${tMessages} (
+  uid INTEGER PRIMARY KEY AUTOINCREMENT,
+  id TEXT NOT NULL UNIQUE,
+  session_id TEXT NOT NULL REFERENCES ${tSessions}(id) ON DELETE CASCADE,
+  content TEXT NOT NULL,
+  source_comment_id TEXT,
+  reaction_comment_id TEXT,
+  status TEXT NOT NULL DEFAULT 'pending',
+  attempts INTEGER NOT NULL DEFAULT 0,
+  error TEXT,
+  created_at TEXT NOT NULL,
+  updated_at TEXT NOT NULL
+)`,
+        dataCols:
+          "id, session_id, content, source_comment_id, reaction_comment_id, status, attempts, error, created_at, updated_at",
+      },
+    ];
+
+    for (const { table, createSql, dataCols } of UID_REBUILDS) {
+      if (await hasColumn(table, "uid")) continue;
+      const exists = await db.get<{ cnt: number }>(
+        `SELECT COUNT(*) AS cnt FROM sqlite_master WHERE type='table' AND name='${table}'`
+      );
+      if (Number(exists?.cnt ?? 0) === 0) continue;
+
+      await db.exec("PRAGMA foreign_keys = OFF");
+      try {
+        await db.transaction(async () => {
+          await db.exec(`ALTER TABLE ${table} RENAME TO ${table}__old_uid`);
+          await db.exec(createSql);
+          await db.exec(
+            `CREATE INDEX IF NOT EXISTS idx_${table}__id ON ${table}(id)`
+          );
+          await db.exec(`INSERT INTO ${table} (${dataCols}) SELECT ${dataCols} FROM ${table}__old_uid`);
+          await db.exec(`DROP TABLE ${table}__old_uid`);
+        });
+      } finally {
+        await db.exec("PRAGMA foreign_keys = ON");
+      }
+    }
+  } else {
+    const uidMySqlTables = [tIssues, tSessions, tMessages];
+    for (const tbl of uidMySqlTables) {
+      if (await hasColumn(tbl, "uid")) continue;
+      try {
+        await db.exec(
+          `ALTER TABLE ${tbl} DROP PRIMARY KEY, ` +
+            `ADD COLUMN uid BIGINT AUTO_INCREMENT PRIMARY KEY FIRST, ` +
+            `ADD UNIQUE INDEX uk_${tbl}_id (id)`
+        );
+      } catch (e) {
+        if (e && typeof e === "object" && "errno" in e && (e as { errno: number }).errno === 1146) continue;
+        throw e;
+      }
+    }
+  }
+
   // issues.owner_daemon_id — points at the leasing daemon (nullable = unclaimed).
   await ensureColumn(
     tIssues,

package/src/opencode.ts

@@ -63,8 +63,9 @@ export function resolveTemplatedWorkdir(
  *  hung scripts. Failures are logged and swallowed — never throws — so a broken
  *  init/destroy never blocks the opencode task flow. */
 const HOOK_SCRIPT_TIMEOUT_MS = 60_000;
-export async function runHookScript(script: string | undefined, workdir: string, label: string, env: Record<string, string> = {}): Promise<void> {
+export async function runHookScript(script: string | undefined, workdir: string, label: string, env: Record<string, string> = {}, timeoutMs?: number): Promise<void> {
   if (!script || !script.trim()) return;
+  const effectiveTimeout = timeoutMs ?? HOOK_SCRIPT_TIMEOUT_MS;
   try {
     mkdirSync(workdir, { recursive: true });
     const proc = Bun.spawn({
@@ -74,7 +75,7 @@ export async function runHookScript(script: string | undefined, workdir: string,
       stderr: "pipe",
       env: { ...process.env, ...env },
     });
-    const timer = setTimeout(() => { try { proc.kill("SIGKILL"); } catch { /* already dead */ } }, HOOK_SCRIPT_TIMEOUT_MS);
+    const timer = setTimeout(() => { try { proc.kill("SIGKILL"); } catch { /* already dead */ } }, effectiveTimeout);
     try {
       const exitCode = await proc.exited;
       const stderr = await new Response(proc.stderr).text().catch(() => "");

package/src/schema-mysql.sql

@@ -8,7 +8,8 @@
 -- tables InnoDB + utf8mb4 for FK CASCADE + full Unicode (emoji).
 
 CREATE TABLE IF NOT EXISTS {{issues}} (
-  id                  VARCHAR(36) PRIMARY KEY,
+  uid                 BIGINT       AUTO_INCREMENT PRIMARY KEY,
+  id                  VARCHAR(36)  NOT NULL UNIQUE,
   tracker_type        VARCHAR(64)  NOT NULL,
   tracker_scope_key   VARCHAR(255) NOT NULL,
   tracker_scope       TEXT         NOT NULL,
@@ -21,7 +22,8 @@ CREATE TABLE IF NOT EXISTS {{issues}} (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
 
 CREATE TABLE IF NOT EXISTS {{op_sessions}} (
-  id                  VARCHAR(36) PRIMARY KEY,
+  uid                 BIGINT       AUTO_INCREMENT PRIMARY KEY,
+  id                  VARCHAR(36)  NOT NULL UNIQUE,
   issue_id            VARCHAR(36) NOT NULL,
   name                VARCHAR(64)  NOT NULL,
   state               VARCHAR(16)  NOT NULL DEFAULT 'idle',
@@ -41,7 +43,8 @@ CREATE TABLE IF NOT EXISTS {{op_sessions}} (
 -- idx_sessions_issue is needed on MySQL.
 
 CREATE TABLE IF NOT EXISTS {{messages}} (
-  id                  VARCHAR(36) PRIMARY KEY,
+  uid                 BIGINT       AUTO_INCREMENT PRIMARY KEY,
+  id                  VARCHAR(36)  NOT NULL UNIQUE,
   session_id          VARCHAR(36) NOT NULL,
   content             LONGTEXT    NOT NULL,
   source_comment_id   VARCHAR(64),

package/src/schema-sqlite.sql

@@ -4,7 +4,8 @@
 -- share one DB across multiple daemon instances.
 
 CREATE TABLE IF NOT EXISTS {{issues}} (
-  id TEXT PRIMARY KEY,
+  uid INTEGER PRIMARY KEY AUTOINCREMENT,
+  id TEXT NOT NULL UNIQUE,
   tracker_type TEXT NOT NULL,
   tracker_scope_key TEXT NOT NULL,
   tracker_scope TEXT NOT NULL,
@@ -17,7 +18,8 @@ CREATE TABLE IF NOT EXISTS {{issues}} (
 );
 
 CREATE TABLE IF NOT EXISTS {{op_sessions}} (
-  id TEXT PRIMARY KEY,
+  uid INTEGER PRIMARY KEY AUTOINCREMENT,
+  id TEXT NOT NULL UNIQUE,
   issue_id TEXT NOT NULL REFERENCES {{issues}}(id) ON DELETE CASCADE,
   name TEXT NOT NULL,
   state TEXT NOT NULL DEFAULT 'idle',
@@ -33,7 +35,8 @@ CREATE TABLE IF NOT EXISTS {{op_sessions}} (
 );
 
 CREATE TABLE IF NOT EXISTS {{messages}} (
-  id TEXT PRIMARY KEY,
+  uid INTEGER PRIMARY KEY AUTOINCREMENT,
+  id TEXT NOT NULL UNIQUE,
   session_id TEXT NOT NULL REFERENCES {{op_sessions}}(id) ON DELETE CASCADE,
   content TEXT NOT NULL,
   source_comment_id TEXT,

package/src/server.ts

@@ -11,10 +11,17 @@ type TrackerMap = Map<string, IssueTracker>;
 
 export function parseGroupConfigHeader(raw: string | null): GroupConfig | undefined {
   if (!raw) return undefined;
+  if (raw.length > 16_384) return undefined;
   try {
     const decoded = Buffer.from(raw, "base64").toString("utf8");
     const parsed = JSON.parse(decoded);
-    if (typeof parsed === "object" && parsed !== null) return parsed as GroupConfig;
+    if (typeof parsed !== "object" || parsed === null) return undefined;
+    const gc = parsed as Record<string, unknown>;
+    if (gc.workdirTemplate !== undefined && typeof gc.workdirTemplate !== "string") return undefined;
+    if (gc.initScript !== undefined && typeof gc.initScript !== "string") return undefined;
+    if (gc.destroyScript !== undefined && typeof gc.destroyScript !== "string") return undefined;
+    if (gc.envInitScript !== undefined && typeof gc.envInitScript !== "string") return undefined;
+    return gc as GroupConfig;
   } catch {
   }
   return undefined;