eve-hub 0.16.23 → 0.16.25

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eve-hub",
-  "version": "0.16.23",
+  "version": "0.16.25",
   "license": "Apache-2.0",
   "description": "Bot-side code shared by every hub agent: registry tools, the roster hook, the eve channel, the host sandbox and browser, and model helpers.",
   "type": "module",

package/prepare.mjs

@@ -77,17 +77,36 @@ const broker: GitHubLeaseBroker = async (sandbox, rules) => {
 // \`-R\` or \`gh repo clone|view|fork\` target differs from the declared repository, nor a \`git\`
 // remote outside it, so this does. \`authorize\` can't read the sandbox, so a remote name such as
 // \`origin\` can't be resolved: authenticated git names the declared repository's URL itself.
+// \`repository\` may be null: eve's tool text tells bots to omit it for \`gh api user\`,
+// \`gh repo list\` and \`gh search\`, and a user token isn't narrowed by it anyway.
 const GIT_REMOTE_COMMANDS = ["fetch", "ls-remote", "pull", "push"];
+const GIT_GLOBAL_VALUE_OPTIONS = ["-C", "-c", "--git-dir", "--work-tree", "--namespace", "--config-env"];
+const GIT_REMOTE_VALUE_OPTIONS = ["--depth", "--deepen", "--shallow-since", "--shallow-exclude", "--upload-pack", "--receive-pack", "--exec", "--refmap", "--negotiation-tip", "-o", "--push-option", "--server-option", "-j", "--jobs", "--filter", "--recurse-submodules-default"];
 const targets = (argv: readonly string[]) => [
   ...argv.flatMap((a, i) => (a === "--repo" || a === "-R" ? [argv[i + 1] ?? ""] : a.startsWith("--repo=") ? [a.slice(7)] : [])),
   ...(argv[0] === "gh" && argv[1] === "repo" && ["clone", "view", "fork"].includes(argv[2] ?? "") && argv[3] && !argv[3].startsWith("-") ? [argv[3]] : []),
 ];
 const GITHUB_URL = /^(?:https:\\/\\/github\\.com\\/|git@github\\.com:|ssh:\\/\\/git@github\\.com\\/)/i;
 const canonical = (repo: string) => repo.toLowerCase().replace(GITHUB_URL, "").replace(/\\/$/, "").replace(/\\.git$/, "");
+const operands = (args: readonly string[], valued: readonly string[]) => {
+  const found: string[] = [];
+  for (let i = 0; i < args.length; i++) {
+    if (valued.includes(args[i])) i++;
+    else if (!args[i].startsWith("-")) found.push(args[i]);
+  }
+  return found;
+};
+const gitRemote = (argv: readonly string[]) => {
+  let i = 1;
+  while (argv[i]?.startsWith("-")) i += GIT_GLOBAL_VALUE_OPTIONS.includes(argv[i]) ? 2 : 1;
+  const remote = operands(argv.slice(i + 1), GIT_REMOTE_VALUE_OPTIONS)[0] ?? "";
+  return GIT_REMOTE_COMMANDS.includes(argv[i] ?? "") && GITHUB_URL.test(remote) ? [remote] : null;
+};
 const commandTargets = (argv: readonly string[]) =>
-  argv[0] === "git" ? (GIT_REMOTE_COMMANDS.includes(argv[1] ?? "") && GITHUB_URL.test(argv[2] ?? "") ? [argv[2]] : null)
+  argv[0] === "git" ? gitRemote(argv)
   : argv[0] === "gh-signed-commit" ? (targets(argv).length ? targets(argv) : null)
   : targets(argv);
+const inOrg = (repo: string) => canonical(repo).startsWith(\`\${ORG}/\`);
 
 export default git({
   github: {
@@ -95,7 +114,8 @@ export default git({
     broker,
     authorize: ({ argv, repository }) => {
       const found = commandTargets(argv);
-      return repository !== null && canonical(repository).startsWith(\`\${ORG}/\`) && found !== null && found.every((t) => canonical(t) === canonical(repository));
+      if (found === null || !found.every(inOrg)) return false;
+      return repository === null || (inOrg(repository) && found.every((t) => canonical(t) === canonical(repository)));
     },
     principalType: "user",
   },

package/templates/engineering.md

@@ -3,12 +3,13 @@
   - Question it again whenever two fixes on one idea fail.
   - Why: a correct fix for the wrong problem costs a full build and review, then a second one.
 - **Brief before building**
-  - The owner posts a brief, scaled to the change (three lines for a copy fix): the required behavior in the human's words, how it works today (file:line), every PR, repo or moving part it adds, and the real-path test.
+  - The owner posts a brief, scaled to the change (three lines for a copy fix). It leads with its impact for the human: the measured change (latency, CPU, cost, steps), or the named work it unblocks with that work's number. Then the required behavior in the human's words, how it works today (file:line), every PR, repo or moving part it adds, and the real-path test.
+  - A step or PR with no measured impact, schema cleanup that only tidies included, is offered to the human as optional, never built by default.
   - Building waits for the human's yes, even while they're offline; meanwhile do the research, the repro and the draft. Picking an option that names what gets built counts as a yes.
   - Build only what the brief names; within it, make the sensible call on details and say which you made.
   - A new PR, repo or subsystem, or a dropped requirement, is a question to the human, never a build step or a review blocker.
   - Small reversible setup (a webhook, a secret, a project setting) isn't building: do it, then say what you set.
-  - Why: the human's yes on scope is cheaper than their no on a finished PR.
+  - Why: the human's yes on scope is cheaper than their no on a finished PR, and a step that changes nothing they can measure still costs a build, a review and the code it leaves behind.
 - **Build it right**
   - Fix the cause at the module that owns the broken invariant, then grep for the same bug elsewhere. No guard, retry, catch or default that hides a failure.
   - Subtract before you add: every new flag, layer, cache, retry or file names the requirement that forces it today. A replacement deletes the old mechanism.