etro 0.8.2 → 0.8.3

package/CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.8.3] - 2022-01-18
+### Fixed
+- Recording not respecting the `type` option.
+- Effects throwing 'empty canvas' errors when the target's width or height is 0.
+
 ## [0.8.2] - 2021-07-08
 ### Fixed
 - `GaussianBlur` effect throwing a `TypeError` when applied to a movie or layer (the problem persisted).
@@ -188,6 +193,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   - Gaussian blur
   - Transform
 
+[0.8.3]: https://github.com/etro-js/etro/compare/v0.8.2...v0.8.3
 [0.8.2]: https://github.com/etro-js/etro/compare/v0.8.1...v0.8.2
 [0.8.1]: https://github.com/etro-js/etro/compare/v0.8.0...v0.8.1
 [0.8.0]: https://github.com/etro-js/etro/compare/v0.7.0...v0.8.0

package/README.md

@@ -10,7 +10,7 @@
 Etro is a typescript framework for programmatically editing videos. Similar
 to GUI-based video-editing software, it lets you layer media and other
 content on a timeline. Audio, image, video and other tracks are supported,
-along with powerful video effectts for existing tracks. Being very flexible
+along with powerful video effects for existing tracks. Being very flexible
 and extendable, you can choose to only use the core components or define your
 own.
 

package/dist/etro-cjs.js

@@ -903,6 +903,11 @@ var Visual = /** @class */ (function (_super) {
      * Render visual output
      */
     Visual.prototype.render = function () {
+        // Prevent empty canvas errors if the width or height is 0
+        var width = val(this, 'width', this.currentTime);
+        var height = val(this, 'height', this.currentTime);
+        if (width === 0 || height === 0)
+            return;
         this.beginRender();
         this.doRender();
         this.endRender();
@@ -8909,6 +8914,9 @@ var Movie = /** @class */ (function () {
             throw new Error('Both video and audio cannot be disabled');
         if (!this.paused)
             throw new Error('Cannot record movie while already playing or recording');
+        var mimeType = options.type || 'video/webm';
+        if (MediaRecorder && MediaRecorder.isTypeSupported && !MediaRecorder.isTypeSupported(mimeType))
+            throw new Error('Please pass a valid MIME type for the exported video');
         return new Promise(function (resolve, reject) {
             var canvasCache = _this.canvas;
             // Record on a temporary canvas context
@@ -8936,7 +8944,8 @@ var Movie = /** @class */ (function () {
                 publish(_this, 'movie.audiodestinationupdate', { movie: _this, destination: audioDestination });
             }
             var stream = new MediaStream(tracks);
-            var mediaRecorder = new MediaRecorder(stream, options.mediaRecorderOptions);
+            var mediaRecorderOptions = __assign(__assign({}, (options.mediaRecorderOptions || {})), { mimeType: mimeType });
+            var mediaRecorder = new MediaRecorder(stream, mediaRecorderOptions);
             mediaRecorder.ondataavailable = function (event) {
                 // if (this._paused) reject(new Error("Recording was interrupted"));
                 if (event.data.size > 0)
@@ -8951,7 +8960,7 @@ var Movie = /** @class */ (function () {
                 _this._mediaRecorder = null;
                 // Construct the exported video out of all the frame blobs.
                 resolve(new Blob(recordedChunks, {
-                    type: options.type || 'video/webm'
+                    type: mimeType
                 }));
             };
             mediaRecorder.onerror = reject;

package/dist/etro-iife.js

@@ -904,6 +904,11 @@ var etro = (function () {
          * Render visual output
          */
         Visual.prototype.render = function () {
+            // Prevent empty canvas errors if the width or height is 0
+            var width = val(this, 'width', this.currentTime);
+            var height = val(this, 'height', this.currentTime);
+            if (width === 0 || height === 0)
+                return;
             this.beginRender();
             this.doRender();
             this.endRender();
@@ -8910,6 +8915,9 @@ var etro = (function () {
                 throw new Error('Both video and audio cannot be disabled');
             if (!this.paused)
                 throw new Error('Cannot record movie while already playing or recording');
+            var mimeType = options.type || 'video/webm';
+            if (MediaRecorder && MediaRecorder.isTypeSupported && !MediaRecorder.isTypeSupported(mimeType))
+                throw new Error('Please pass a valid MIME type for the exported video');
             return new Promise(function (resolve, reject) {
                 var canvasCache = _this.canvas;
                 // Record on a temporary canvas context
@@ -8937,7 +8945,8 @@ var etro = (function () {
                     publish(_this, 'movie.audiodestinationupdate', { movie: _this, destination: audioDestination });
                 }
                 var stream = new MediaStream(tracks);
-                var mediaRecorder = new MediaRecorder(stream, options.mediaRecorderOptions);
+                var mediaRecorderOptions = __assign(__assign({}, (options.mediaRecorderOptions || {})), { mimeType: mimeType });
+                var mediaRecorder = new MediaRecorder(stream, mediaRecorderOptions);
                 mediaRecorder.ondataavailable = function (event) {
                     // if (this._paused) reject(new Error("Recording was interrupted"));
                     if (event.data.size > 0)
@@ -8952,7 +8961,7 @@ var etro = (function () {
                     _this._mediaRecorder = null;
                     // Construct the exported video out of all the frame blobs.
                     resolve(new Blob(recordedChunks, {
-                        type: options.type || 'video/webm'
+                        type: mimeType
                     }));
                 };
                 mediaRecorder.onerror = reject;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "etro",
-  "version": "0.8.2",
+  "version": "0.8.3",
   "description": "An extendable video-editing framework for the browser and Node",
   "browser": "dist/etro-cjs.js",
   "types": "dist/index.d.ts",
@@ -28,8 +28,6 @@
     "ev": "0.0.7",
     "http-server": "^0.12.3",
     "jasmine": "^3.4.0",
-    "jsdoc": "^3.6.3",
-    "jsdoc-export-default-interop": "^0.3.1",
     "karma": "^6.1.1",
     "karma-chrome-launcher": "^3.1.0",
     "karma-es6-shim": "^1.0.0",

package/src/layer/visual.ts

@@ -83,6 +83,12 @@ class Visual extends Base {
    * Render visual output
    */
   render (): void {
+    // Prevent empty canvas errors if the width or height is 0
+    const width = val(this, 'width', this.currentTime)
+    const height = val(this, 'height', this.currentTime)
+    if (width === 0 || height === 0)
+      return
+
     this.beginRender()
     this.doRender()
     this.endRender()

package/src/movie.ts

@@ -255,6 +255,10 @@ export class Movie {
     if (!this.paused)
       throw new Error('Cannot record movie while already playing or recording')
 
+    const mimeType = options.type || 'video/webm'
+    if (MediaRecorder && MediaRecorder.isTypeSupported && !MediaRecorder.isTypeSupported(mimeType))
+      throw new Error('Please pass a valid MIME type for the exported video')
+
     return new Promise((resolve, reject) => {
       const canvasCache = this.canvas
       // Record on a temporary canvas context
@@ -285,7 +289,11 @@ export class Movie {
         )
       }
       const stream = new MediaStream(tracks)
-      const mediaRecorder = new MediaRecorder(stream, options.mediaRecorderOptions)
+      const mediaRecorderOptions = {
+        ...(options.mediaRecorderOptions || {}),
+        mimeType
+      }
+      const mediaRecorder = new MediaRecorder(stream, mediaRecorderOptions)
       mediaRecorder.ondataavailable = event => {
         // if (this._paused) reject(new Error("Recording was interrupted"));
         if (event.data.size > 0)
@@ -303,7 +311,7 @@ export class Movie {
         // Construct the exported video out of all the frame blobs.
         resolve(
           new Blob(recordedChunks, {
-            type: options.type || 'video/webm'
+            type: mimeType
           })
         )
       }