eslint 9.9.0 → 9.9.1

package/README.md

@@ -21,25 +21,26 @@
 
 ESLint is a tool for identifying and reporting on patterns found in ECMAScript/JavaScript code. In many ways, it is similar to JSLint and JSHint with a few exceptions:
 
-* ESLint uses [Espree](https://github.com/eslint/espree) for JavaScript parsing.
+* ESLint uses [Espree](https://github.com/eslint/js/tree/main/packages/espree) for JavaScript parsing.
 * ESLint uses an AST to evaluate patterns in code.
 * ESLint is completely pluggable, every single rule is a plugin and you can add more at runtime.
 
 ## Table of Contents
 
 1. [Installation and Usage](#installation-and-usage)
-2. [Configuration](#configuration)
-3. [Code of Conduct](#code-of-conduct)
-4. [Filing Issues](#filing-issues)
-5. [Frequently Asked Questions](#frequently-asked-questions)
-6. [Releases](#releases)
-7. [Security Policy](#security-policy)
-8. [Semantic Versioning Policy](#semantic-versioning-policy)
-9. [Stylistic Rule Updates](#stylistic-rule-updates)
-10. [License](#license)
-11. [Team](#team)
-12. [Sponsors](#sponsors)
-13. [Technology Sponsors](#technology-sponsors) <!-- markdownlint-disable-line MD051 -->
+1. [Configuration](#configuration)
+1. [Version Support](#version-support)
+1. [Code of Conduct](#code-of-conduct)
+1. [Filing Issues](#filing-issues)
+1. [Frequently Asked Questions](#frequently-asked-questions)
+1. [Releases](#releases)
+1. [Security Policy](#security-policy)
+1. [Semantic Versioning Policy](#semantic-versioning-policy)
+1. [Stylistic Rule Updates](#stylistic-rule-updates)
+1. [License](#license)
+1. [Team](#team)
+1. [Sponsors](#sponsors)
+1. [Technology Sponsors](#technology-sponsors) <!-- markdownlint-disable-line MD051 -->
 
 ## Installation and Usage
 
@@ -54,19 +55,26 @@ npm init @eslint/config@latest
 After that, you can run ESLint on any file or directory like this:
 
 ```shell
-./node_modules/.bin/eslint yourfile.js
+npx eslint yourfile.js
 ```
 
 ## Configuration
 
-After running `npm init @eslint/config`, you'll have an `eslint.config.js` (or `eslint.config.mjs`) file in your directory. In it, you'll see some rules configured like this:
+You can configure rules in your `eslint.config.js` files as in this example:
 
 ```js
-import pluginJs from "@eslint/js";
-export default [ pluginJs.configs.recommended, ];
+export default [
+    {
+        files: ["**/*.js", "**/*.cjs", "**/*.mjs"],
+        rules: {
+            "prefer-const": "warn",
+            "no-constant-binary-expression": "error"
+        }
+    }
+];
 ```
 
-The names `"semi"` and `"quotes"` are the names of [rules](https://eslint.org/docs/rules) in ESLint. The first value is the error level of the rule and can be one of these values:
+The names `"prefer-const"` and `"no-constant-binary-expression"` are the names of [rules](https://eslint.org/docs/rules) in ESLint. The first value is the error level of the rule and can be one of these values:
 
 * `"off"` or `0` - turn the rule off
 * `"warn"` or `1` - turn the rule on as a warning (doesn't affect exit code)
@@ -74,9 +82,17 @@ The names `"semi"` and `"quotes"` are the names of [rules](https://eslint.org/do
 
 The three error levels allow you fine-grained control over how ESLint applies rules (for more configuration options and details, see the [configuration docs](https://eslint.org/docs/latest/use/configure)).
 
+## Version Support
+
+The ESLint team provides ongoing support for the current version and six months of limited support for the previous version. Limited support includes critical bug fixes, security issues, and compatibility issues only.
+
+ESLint offers commercial support for both current and previous versions through our partners, [Tidelift][tidelift] and [HeroDevs][herodevs].
+
+See [Version Support](https://eslint.org/version-support) for more details.
+
 ## Code of Conduct
 
-ESLint adheres to the [JS Foundation Code of Conduct](https://eslint.org/conduct).
+ESLint adheres to the [OpenJS Foundation Code of Conduct](https://eslint.org/conduct).
 
 ## Filing Issues
 
@@ -89,28 +105,14 @@ Before filing an issue, please be sure to read the guidelines for what you're re
 
 ## Frequently Asked Questions
 
-### I'm using JSCS, should I migrate to ESLint?
-
-Yes. [JSCS has reached end of life](https://eslint.org/blog/2016/07/jscs-end-of-life) and is no longer supported.
-
-We have prepared a [migration guide](https://eslint.org/docs/latest/use/migrating-from-jscs) to help you convert your JSCS settings to an ESLint configuration.
+### Does ESLint support JSX?
 
-We are now at or near 100% compatibility with JSCS. If you try ESLint and believe we are not yet compatible with a JSCS rule/configuration, please create an issue (mentioning that it is a JSCS compatibility issue) and we will evaluate it as per our normal process.
+Yes, ESLint natively supports parsing JSX syntax (this must be enabled in [configuration](https://eslint.org/docs/latest/use/configure)). Please note that supporting JSX syntax *is not* the same as supporting React. React applies specific semantics to JSX syntax that ESLint doesn't recognize. We recommend using [eslint-plugin-react](https://www.npmjs.com/package/eslint-plugin-react) if you are using React and want React semantics.
 
 ### Does Prettier replace ESLint?
 
 No, ESLint and Prettier have different jobs: ESLint is a linter (looking for problematic patterns) and Prettier is a code formatter. Using both tools is common, refer to [Prettier's documentation](https://prettier.io/docs/en/install#eslint-and-other-linters) to learn how to configure them to work well with each other.
 
-### Why can't ESLint find my plugins?
-
-* Make sure your plugins (and ESLint) are both in your project's `package.json` as devDependencies (or dependencies, if your project uses ESLint at runtime).
-* Make sure you have run `npm install` and all your dependencies are installed.
-* Make sure your plugins' peerDependencies have been installed as well. You can use `npm view eslint-plugin-myplugin peerDependencies` to see what peer dependencies `eslint-plugin-myplugin` has.
-
-### Does ESLint support JSX?
-
-Yes, ESLint natively supports parsing JSX syntax (this must be enabled in [configuration](https://eslint.org/docs/latest/use/configure)). Please note that supporting JSX syntax *is not* the same as supporting React. React applies specific semantics to JSX syntax that ESLint doesn't recognize. We recommend using [eslint-plugin-react](https://www.npmjs.com/package/eslint-plugin-react) if you are using React and want React semantics.
-
 ### What ECMAScript versions does ESLint support?
 
 ESLint has full support for ECMAScript 3, 5, and every year from 2015 up until the most recent stage 4 specification (the default). You can set your desired ECMAScript syntax and other settings (like global variables) through [configuration](https://eslint.org/docs/latest/use/configure).
@@ -295,7 +297,7 @@ The following companies, organizations, and individuals support ESLint's ongoing
 <!--sponsorsstart-->
 <h3>Platinum Sponsors</h3>
 <p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="128"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="128"></a></p><h3>Gold Sponsors</h3>
-<p><a href="#"><img src="https://images.opencollective.com/guest-bf377e88/avatar.png" alt="Eli Schleifer" height="96"></a></p><h3>Silver Sponsors</h3>
+<p><a href="#"><img src="https://images.opencollective.com/guest-bf377e88/avatar.png" alt="Eli Schleifer" height="96"></a> <a href="https://opensource.siemens.com"><img src="https://avatars.githubusercontent.com/u/624020?v=4" alt="Siemens" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://www.jetbrains.com/"><img src="https://images.opencollective.com/jetbrains/fe76f99/logo.png" alt="JetBrains" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="64"></a> <a href="https://www.workleap.com"><img src="https://avatars.githubusercontent.com/u/53535748?u=d1e55d7661d724bf2281c1bfd33cb8f99fe2465f&v=4" alt="Workleap" height="64"></a></p><h3>Bronze Sponsors</h3>
 <p><a href="https://www.notion.so"><img src="https://images.opencollective.com/notion/bf3b117/logo.png" alt="notion" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104?v=4" alt="Nx" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://usenextbase.com"><img src="https://avatars.githubusercontent.com/u/145838380?v=4" alt="Nextbase Starter Kit" height="32"></a></p>
 <!--sponsorsend-->
@@ -303,4 +305,7 @@ The following companies, organizations, and individuals support ESLint's ongoing
 <!--techsponsorsstart-->
 <h2>Technology Sponsors</h2>
 <p><a href="https://netlify.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/netlify-icon.svg" alt="Netlify" height="32"></a> <a href="https://algolia.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/algolia-icon.svg" alt="Algolia" height="32"></a> <a href="https://1password.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/1password-icon.svg" alt="1Password" height="32"></a></p>
-<!--techsponsorsend-->
+<!--techsponsorsend-->
+
+[tidelift]: https://tidelift.com/funding/github/npm/eslint
+[herodevs]: https://www.herodevs.com/support/eslint-nes?utm_source=ESLintWebsite&utm_medium=ESLintWebsite&utm_campaign=ESLintNES&utm_id=ESLintNES

package/lib/eslint/eslint.js

@@ -646,6 +646,23 @@ function createExtraneousResultsError() {
     return new TypeError("Results object was not created from this ESLint instance.");
 }
 
+/**
+ * Creates a fixer function based on the provided fix, fixTypesSet, and config.
+ * @param {Function|boolean} fix The original fix option.
+ * @param {Set<string>} fixTypesSet A set of fix types to filter messages for fixing.
+ * @param {FlatConfig} config The config for the file that generated the message.
+ * @returns {Function|boolean} The fixer function or the original fix value.
+ */
+function getFixerForFixTypes(fix, fixTypesSet, config) {
+    if (!fix || !fixTypesSet) {
+        return fix;
+    }
+
+    const originalFix = (typeof fix === "function") ? fix : () => true;
+
+    return message => shouldMessageBeFixed(message, config, fixTypesSet) && originalFix(message);
+}
+
 //-----------------------------------------------------------------------------
 // Main API
 //-----------------------------------------------------------------------------
@@ -994,16 +1011,7 @@ class ESLint {
 
 
                 // set up fixer for fixTypes if necessary
-                let fixer = fix;
-
-                if (fix && fixTypesSet) {
-
-                    // save original value of options.fix in case it's a function
-                    const originalFix = (typeof fix === "function")
-                        ? fix : () => true;
-
-                    fixer = message => shouldMessageBeFixed(message, config, fixTypesSet) && originalFix(message);
-                }
+                const fixer = getFixerForFixTypes(fix, fixTypesSet, config);
 
                 return retrier.retry(() => fs.readFile(filePath, { encoding: "utf8", signal: controller.signal })
                     .then(text => {
@@ -1108,13 +1116,18 @@ class ESLint {
             allowInlineConfig,
             cwd,
             fix,
+            fixTypes,
             warnIgnored: constructorWarnIgnored,
             ruleFilter,
             stats
         } = eslintOptions;
         const results = [];
         const startTime = Date.now();
+        const fixTypesSet = fixTypes ? new Set(fixTypes) : null;
         const resolvedFilename = path.resolve(cwd, filePath || "__placeholder__.js");
+        const config = configs.getConfig(resolvedFilename);
+
+        const fixer = getFixerForFixTypes(fix, fixTypesSet, config);
 
         // Clear the last used config arrays.
         if (resolvedFilename && await this.isPathIgnored(resolvedFilename)) {
@@ -1133,7 +1146,7 @@ class ESLint {
                 filePath: resolvedFilename.endsWith("__placeholder__.js") ? "<text>" : resolvedFilename,
                 configs,
                 cwd,
-                fix,
+                fix: fixer,
                 allowInlineConfig,
                 ruleFilter,
                 stats,

package/lib/linter/linter.js

@@ -55,6 +55,7 @@ const DEFAULT_ERROR_LOC = { start: { line: 1, column: 0 }, end: { line: 1, colum
 const parserSymbol = Symbol.for("eslint.RuleTester.parser");
 const { LATEST_ECMA_VERSION } = require("../../conf/ecma-version");
 const { VFile } = require("./vfile");
+const { ParserService } = require("../services/parser-service");
 const STEP_KIND_VISIT = 1;
 const STEP_KIND_CALL = 2;
 
@@ -922,43 +923,6 @@ function analyzeScope(ast, languageOptions, visitorKeys) {
     });
 }
 
-/**
- * Parses file into an AST. Moved out here because the try-catch prevents
- * optimization of functions, so it's best to keep the try-catch as isolated
- * as possible
- * @param {VFile} file The file to parse.
- * @param {Language} language The language to use.
- * @param {LanguageOptions} languageOptions Options to pass to the parser
- * @returns {{success: false, error: LintMessage}|{success: true, sourceCode: SourceCode}}
- * An object containing the AST and parser services if parsing was successful, or the error if parsing failed
- * @private
- */
-function parse(file, language, languageOptions) {
-
-    const result = language.parse(file, { languageOptions });
-
-    if (result.ok) {
-        return {
-            success: true,
-            sourceCode: language.createSourceCode(file, result, { languageOptions })
-        };
-    }
-
-    // if we made it to here there was an error
-    return {
-        success: false,
-        errors: result.errors.map(error => ({
-            ruleId: null,
-            nodeType: null,
-            fatal: true,
-            severity: 2,
-            message: `Parsing error: ${error.message}`,
-            line: error.line,
-            column: error.column
-        }))
-    };
-}
-
 /**
  * Runs a rule, and gets its listeners
  * @param {Rule} rule A rule object
@@ -1407,10 +1371,13 @@ class Linter {
                 t = startTime();
             }
 
-            const parseResult = parse(
+            const parserService = new ParserService();
+            const parseResult = parserService.parseSync(
                 file,
-                jslang,
-                languageOptions
+                {
+                    language: jslang,
+                    languageOptions
+                }
             );
 
             if (options.stats) {
@@ -1420,7 +1387,7 @@ class Linter {
                 storeTime(time, timeOpts, slots);
             }
 
-            if (!parseResult.success) {
+            if (!parseResult.ok) {
                 return parseResult.errors;
             }
 
@@ -1712,10 +1679,10 @@ class Linter {
                 t = startTime();
             }
 
-            const parseResult = parse(
+            const parserService = new ParserService();
+            const parseResult = parserService.parseSync(
                 file,
-                config.language,
-                languageOptions
+                config
             );
 
             if (options.stats) {
@@ -1724,7 +1691,7 @@ class Linter {
                 storeTime(time, { type: "parse" }, slots);
             }
 
-            if (!parseResult.success) {
+            if (!parseResult.ok) {
                 return parseResult.errors;
             }
 

package/lib/services/parser-service.js

@@ -0,0 +1,65 @@
+/**
+ * @fileoverview ESLint Parser
+ * @author Nicholas C. Zakas
+ */
+/* eslint class-methods-use-this: off -- Anticipate future constructor arguments. */
+
+"use strict";
+
+//-----------------------------------------------------------------------------
+// Types
+//-----------------------------------------------------------------------------
+
+/** @typedef {import("../linter/vfile.js").VFile} VFile */
+/** @typedef {import("@eslint/core").Language} Language */
+/** @typedef {import("@eslint/core").LanguageOptions} LanguageOptions */
+
+//-----------------------------------------------------------------------------
+// Exports
+//-----------------------------------------------------------------------------
+
+/**
+ * The parser for ESLint.
+ */
+class ParserService {
+
+    /**
+     * Parses the given file synchronously.
+     * @param {VFile} file The file to parse.
+     * @param {{language:Language,languageOptions:LanguageOptions}} config The configuration to use.
+     * @returns {Object} An object with the parsed source code or errors.
+     * @throws {Error} If the parser returns a promise.
+     */
+    parseSync(file, config) {
+
+        const { language, languageOptions } = config;
+        const result = language.parse(file, { languageOptions });
+
+        if (typeof result.then === "function") {
+            throw new Error("Unsupported: Language parser returned a promise.");
+        }
+
+        if (result.ok) {
+            return {
+                ok: true,
+                sourceCode: language.createSourceCode(file, result, { languageOptions })
+            };
+        }
+
+        // if we made it to here there was an error
+        return {
+            ok: false,
+            errors: result.errors.map(error => ({
+                ruleId: null,
+                nodeType: null,
+                fatal: true,
+                severity: 2,
+                message: `Parsing error: ${error.message}`,
+                line: error.line,
+                column: error.column
+            }))
+        };
+    }
+}
+
+module.exports = { ParserService };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "9.9.0",
+  "version": "9.9.1",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "bin": {
@@ -18,12 +18,12 @@
     "build:webpack": "node Makefile.js webpack",
     "build:readme": "node tools/update-readme.js",
     "build:rules-index": "node Makefile.js generateRuleIndexPage",
-    "lint": "node Makefile.js lint",
-    "lint:docs:js": "node Makefile.js lintDocsJS",
+    "lint": "trunk check --no-fix --ignore=docs/**/*.js -a --filter=eslint && trunk check --no-fix --ignore=docs/**/*.js",
+    "lint:docs:js": "trunk check --no-fix --ignore=** --ignore=!docs/**/*.js -a --filter=eslint && trunk check --no-fix --ignore=** --ignore=!docs/**/*.js",
     "lint:docs:rule-examples": "node Makefile.js checkRuleExamples",
-    "lint:fix": "node Makefile.js lint -- fix",
-    "lint:fix:docs:js": "node Makefile.js lintDocsJS -- fix",
     "lint:unused": "knip",
+    "lint:fix": "trunk check -y --ignore=docs/**/*.js -a --filter=eslint && trunk check -y --ignore=docs/**/*.js",
+    "lint:fix:docs:js": "trunk check -y --ignore=** --ignore=!docs/**/*.js -a --flter=eslint && trunk check -y --ignore=** --ignore=!docs/**/*.js",
     "release:generate:alpha": "node Makefile.js generatePrerelease -- alpha",
     "release:generate:beta": "node Makefile.js generatePrerelease -- beta",
     "release:generate:latest": "node Makefile.js generateRelease",
@@ -40,8 +40,8 @@
     "pre-commit": "lint-staged"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
-    "*.md": "markdownlint --fix",
+    "*.js": "trunk check --fix --filter=eslint",
+    "*.md": "trunk check --fix --filter=markdownlint",
     "lib/rules/*.js": [
       "node tools/update-eslint-all.js",
       "git add packages/js/src/configs/eslint-all.js"
@@ -51,7 +51,7 @@
       "node tools/fetch-docs-links.js",
       "git add docs/src/_data/further_reading_links.json"
     ],
-    "docs/**/*.svg": "npx -y svgo -r --multipass"
+    "docs/**/*.svg": "trunk check --fix --filter=svgo"
   },
   "files": [
     "LICENSE",
@@ -68,9 +68,9 @@
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.2.0",
     "@eslint-community/regexpp": "^4.11.0",
-    "@eslint/config-array": "^0.17.1",
+    "@eslint/config-array": "^0.18.0",
     "@eslint/eslintrc": "^3.1.0",
-    "@eslint/js": "9.9.0",
+    "@eslint/js": "9.9.1",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@humanwhocodes/retry": "^0.3.0",
     "@nodelib/fs.walk": "^1.2.8",
@@ -104,14 +104,15 @@
   "devDependencies": {
     "@babel/core": "^7.4.3",
     "@babel/preset-env": "^7.4.3",
-    "@eslint/core": "^0.3.0",
+    "@eslint/core": "^0.4.0",
     "@eslint/json": "^0.3.0",
+    "@trunkio/launcher": "^1.3.0",
     "@types/estree": "^1.0.5",
     "@types/node": "^20.11.5",
-    "@wdio/browser-runner": "^8.40.1",
-    "@wdio/cli": "^8.40.0",
-    "@wdio/concise-reporter": "^8.39.0",
-    "@wdio/mocha-framework": "^8.40.0",
+    "@wdio/browser-runner": "^9.0.5",
+    "@wdio/cli": "^9.0.5",
+    "@wdio/concise-reporter": "^9.0.4",
+    "@wdio/mocha-framework": "^9.0.5",
     "babel-loader": "^8.0.5",
     "c8": "^7.12.0",
     "chai": "^4.0.1",
@@ -122,6 +123,7 @@
     "eslint": "file:.",
     "eslint-config-eslint": "file:packages/eslint-config-eslint",
     "eslint-plugin-eslint-plugin": "^6.0.0",
+    "eslint-plugin-yml": "^1.14.0",
     "eslint-release": "^3.2.2",
     "eslint-rule-composer": "^0.3.0",
     "eslump": "^3.0.0",
@@ -133,14 +135,11 @@
     "got": "^11.8.3",
     "gray-matter": "^4.0.3",
     "jiti": "^1.21.6",
-    "js-yaml": "^4.1.0",
     "knip": "^5.21.0",
     "lint-staged": "^11.0.0",
     "load-perf": "^0.2.0",
     "markdown-it": "^12.2.0",
     "markdown-it-container": "^3.0.0",
-    "markdownlint": "^0.34.0",
-    "markdownlint-cli": "^0.41.0",
     "marked": "^4.0.8",
     "metascraper": "^5.25.7",
     "metascraper-description": "^5.25.7",