eslint 9.5.0 → 9.7.0

package/README.md

@@ -39,7 +39,7 @@ ESLint is a tool for identifying and reporting on patterns found in ECMAScript/J
 10. [License](#license)
 11. [Team](#team)
 12. [Sponsors](#sponsors)
-13. [Technology Sponsors](#technology-sponsors)
+13. [Technology Sponsors](#technology-sponsors) <!-- markdownlint-disable-line MD051 -->
 
 ## Installation and Usage
 
@@ -294,14 +294,13 @@ The following companies, organizations, and individuals support ESLint's ongoing
 <!-- NOTE: This section is autogenerated. Do not manually edit.-->
 <!--sponsorsstart-->
 <h3>Platinum Sponsors</h3>
-<p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a></p><h3>Gold Sponsors</h3>
-<p><a href="#"><img src="https://images.opencollective.com/guest-bf377e88/avatar.png" alt="Eli Schleifer" height="96"></a> <a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="96"></a></p><h3>Silver Sponsors</h3>
+<p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="128"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="128"></a></p><h3>Gold Sponsors</h3>
+<p><a href="#"><img src="https://images.opencollective.com/guest-bf377e88/avatar.png" alt="Eli Schleifer" height="96"></a> <a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://www.jetbrains.com/"><img src="https://images.opencollective.com/jetbrains/fe76f99/logo.png" alt="JetBrains" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="64"></a> <a href="https://www.workleap.com"><img src="https://avatars.githubusercontent.com/u/53535748?u=d1e55d7661d724bf2281c1bfd33cb8f99fe2465f&v=4" alt="Workleap" height="64"></a></p><h3>Bronze Sponsors</h3>
 <p><a href="https://www.notion.so"><img src="https://images.opencollective.com/notion/bf3b117/logo.png" alt="notion" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104?v=4" alt="Nx" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://usenextbase.com"><img src="https://avatars.githubusercontent.com/u/145838380?v=4" alt="Nextbase Starter Kit" height="32"></a></p>
 <!--sponsorsend-->
 
-## Technology Sponsors
-
-* Site search ([eslint.org](https://eslint.org)) is sponsored by [Algolia](https://www.algolia.com)
-* Hosting for ([eslint.org](https://eslint.org)) is sponsored by [Netlify](https://www.netlify.com)
-* Password management is sponsored by [1Password](https://www.1password.com)
+<!--techsponsorsstart-->
+<h2>Technology Sponsors</h2>
+<p><a href="https://netlify.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/netlify-icon.svg" alt="Netlify" height="32"></a> <a href="https://algolia.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/algolia-icon.svg" alt="Algolia" height="32"></a> <a href="https://1password.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/1password-icon.svg" alt="1Password" height="32"></a></p>
+<!--techsponsorsend-->

package/conf/ecma-version.js

@@ -9,7 +9,7 @@
  * The latest ECMAScript version supported by ESLint.
  * @type {number} year-based ECMAScript version
  */
-const LATEST_ECMA_VERSION = 2024;
+const LATEST_ECMA_VERSION = 2025;
 
 module.exports = {
     LATEST_ECMA_VERSION

package/conf/globals.js

@@ -133,6 +133,10 @@ const es2024 = {
     ...es2023
 };
 
+const es2025 = {
+    ...es2024
+};
+
 
 //-----------------------------------------------------------------------------
 // Exports
@@ -151,5 +155,6 @@ module.exports = {
     es2021,
     es2022,
     es2023,
-    es2024
+    es2024,
+    es2025
 };

package/lib/cli.js

@@ -26,7 +26,7 @@ const fs = require("node:fs"),
     { normalizeSeverityToString } = require("./shared/severity");
 const { Legacy: { naming } } = require("@eslint/eslintrc");
 const { ModuleImporter } = require("@humanwhocodes/module-importer");
-
+const { inactiveFlags, activeFlags } = require("./shared/flags");
 const debug = require("debug")("eslint:cli");
 
 //------------------------------------------------------------------------------
@@ -117,6 +117,7 @@ async function translateOptions({
     fix,
     fixDryRun,
     fixType,
+    flag,
     global,
     ignore,
     ignorePath,
@@ -225,6 +226,7 @@ async function translateOptions({
         options.ignorePatterns = ignorePattern;
         options.stats = stats;
         options.warnIgnored = warnIgnored;
+        options.flags = flag;
 
         /*
          * For performance reasons rules not marked as 'error' are filtered out in quiet mode. As maxWarnings
@@ -485,8 +487,27 @@ const cli = {
         }
 
         const ActiveESLint = usingFlatConfig ? ESLint : LegacyESLint;
+        const eslintOptions = await translateOptions(options, usingFlatConfig ? "flat" : "eslintrc");
+
+        if (eslintOptions.flags) {
+            debug("Checking for inactive flags");
+
+            for (const flag of eslintOptions.flags) {
+                if (inactiveFlags.has(flag)) {
+                    log.warn(`InactiveFlag: The '${flag}' flag is no longer active: ${inactiveFlags.get(flag)}`);
+                    continue;
+                }
+
+                if (activeFlags.has(flag)) {
+                    continue;
+                }
+
+                log.error(`InvalidFlag: The '${flag}' flag is invalid.`);
+                return 2;
+            }
+        }
 
-        const engine = new ActiveESLint(await translateOptions(options, usingFlatConfig ? "flat" : "eslintrc"));
+        const engine = new ActiveESLint(eslintOptions);
         let results;
 
         if (useStdin) {

package/lib/eslint/eslint-helpers.js

@@ -723,6 +723,7 @@ function processOptions({
     errorOnUnmatchedPattern = true,
     fix = false,
     fixTypes = null, // ← should be null by default because if it's an array then it suppresses rules that don't have the `meta.type` property.
+    flags = [],
     globInputPaths = true,
     ignore = true,
     ignorePatterns = null,
@@ -810,6 +811,9 @@ function processOptions({
     if (fixTypes !== null && !isFixTypeArray(fixTypes)) {
         errors.push("'fixTypes' must be an array of any of \"directive\", \"problem\", \"suggestion\", and \"layout\".");
     }
+    if (!isEmptyArrayOrArrayOfNonEmptyString(flags)) {
+        errors.push("'flags' must be an array of non-empty strings.");
+    }
     if (typeof globInputPaths !== "boolean") {
         errors.push("'globInputPaths' must be a boolean.");
     }
@@ -863,6 +867,7 @@ function processOptions({
         errorOnUnmatchedPattern,
         fix,
         fixTypes,
+        flags: [...flags],
         globInputPaths,
         ignore,
         ignorePatterns,

package/lib/eslint/eslint.js

@@ -76,6 +76,7 @@ const { Retrier } = require("@humanwhocodes/retry");
  * @property {boolean} [errorOnUnmatchedPattern] If `false` then `ESLint#lintFiles()` doesn't throw even if no target files found. Defaults to `true`.
  * @property {boolean|Function} [fix] Execute in autofix mode. If a function, should return a boolean.
  * @property {string[]} [fixTypes] Array of rule types to apply fixes for.
+ * @property {string[]} [flags] Array of feature flags to enable.
  * @property {boolean} [globInputPaths] Set to false to skip glob resolution of input file paths to lint (default: true). If false, each input file paths is assumed to be a non-glob path to an existing file.
  * @property {boolean} [ignore] False disables all ignore patterns except for the default ones.
  * @property {string[]} [ignorePatterns] Ignore file patterns to use in addition to config ignores. These patterns are relative to `cwd`.
@@ -421,7 +422,8 @@ async function calculateConfigArray(eslint, {
             relativeIgnorePatterns = ignorePatterns;
         } else {
 
-            const relativeIgnorePath = path.relative(basePath, cwd);
+            // In minimatch patterns, only `/` can be used as path separator
+            const relativeIgnorePath = path.relative(basePath, cwd).replaceAll(path.sep, "/");
 
             relativeIgnorePatterns = ignorePatterns.map(pattern => {
                 const negated = pattern.startsWith("!");
@@ -593,7 +595,8 @@ class ESLint {
         const processedOptions = processOptions(options);
         const linter = new Linter({
             cwd: processedOptions.cwd,
-            configType: "flat"
+            configType: "flat",
+            flags: processedOptions.flags
         });
 
         const cacheFilePath = getCacheFile(
@@ -766,6 +769,17 @@ class ESLint {
         return createRulesMeta(resultRules);
     }
 
+    /**
+     * Indicates if the given feature flag is enabled for this instance.
+     * @param {string} flag The feature flag to check.
+     * @returns {boolean} `true` if the feature flag is enabled, `false` if not.
+     */
+    hasFlag(flag) {
+
+        // note: Linter does validation of the flags
+        return privateMembers.get(this).linter.hasFlag(flag);
+    }
+
     /**
      * Executes the current configuration on an array of file and directory names.
      * @param {string|string[]} patterns An array of file and directory names.

package/lib/eslint/legacy-eslint.js

@@ -171,6 +171,7 @@ function processOptions({
     extensions = null, // ← should be null by default because if it's an array then it suppresses RFC20 feature.
     fix = false,
     fixTypes = null, // ← should be null by default because if it's an array then it suppresses rules that don't have the `meta.type` property.
+    flags, /* eslint-disable-line no-unused-vars -- leaving for compatibility with ESLint#hasFlag */
     globInputPaths = true,
     ignore = true,
     ignorePath = null, // ← should be null by default because if it's a string then it may throw ENOENT.
@@ -310,6 +311,7 @@ function processOptions({
         extensions,
         fix,
         fixTypes,
+        flags: [], // LegacyESLint does not support flags, so just ignore them.
         globInputPaths,
         ignore,
         ignorePath,
@@ -558,6 +560,18 @@ class LegacyESLint {
 
     }
 
+    /* eslint-disable no-unused-vars, class-methods-use-this -- leaving for compatibility with ESLint#hasFlag */
+    /**
+     * Indicates if the given feature flag is enabled for this instance. For this
+     * class, this always returns `false` because it does not support feature flags.
+     * @param {string} flag The feature flag to check.
+     * @returns {boolean} Always false.
+     */
+    hasFlag(flag) {
+        return false;
+    }
+    /* eslint-enable no-unused-vars, class-methods-use-this -- reenable rules for the rest of the file */
+
     /**
      * Executes the current configuration on an array of file and directory names.
      * @param {string[]} patterns An array of file and directory names.

package/lib/languages/js/index.js

@@ -20,7 +20,9 @@ const { validateLanguageOptions } = require("./validate-language-options");
 // Type Definitions
 //-----------------------------------------------------------------------------
 
-/** @typedef {import("../../linter/vfile").VFile} VFile */
+/** @typedef {import("@eslint/core").File} File */
+/** @typedef {import("@eslint/core").Language} Language */
+/** @typedef {import("@eslint/core").OkParseResult} OkParseResult */
 
 //-----------------------------------------------------------------------------
 // Helpers
@@ -56,6 +58,9 @@ function analyzeScope(ast, languageOptions, visitorKeys) {
 // Exports
 //-----------------------------------------------------------------------------
 
+/**
+ * @type {Language}
+ */
 module.exports = {
 
     fileType: "text",
@@ -143,7 +148,7 @@ module.exports = {
 
     /**
      * Parses the given file into an AST.
-     * @param {VFile} file The virtual file to parse.
+     * @param {File} file The virtual file to parse.
      * @param {Object} options Additional options passed from ESLint.
      * @param {LanguageOptions} options.languageOptions The language options.
      * @returns {Object} The result of parsing.
@@ -200,7 +205,7 @@ module.exports = {
         } catch (ex) {
 
             // If the message includes a leading line number, strip it:
-            const message = `Parsing error: ${ex.message.replace(/^line \d+:/iu, "").trim()}`;
+            const message = ex.message.replace(/^line \d+:/iu, "").trim();
 
             debug("%s\n%s", message, ex.stack);
 
@@ -218,8 +223,8 @@ module.exports = {
 
     /**
      * Creates a new `SourceCode` object from the given information.
-     * @param {VFile} file The virtual file to create a `SourceCode` object from.
-     * @param {Object} parseResult The result returned from `parse()`.
+     * @param {File} file The virtual file to create a `SourceCode` object from.
+     * @param {OkParseResult} parseResult The result returned from `parse()`.
      * @param {Object} options Additional options passed from ESLint.
      * @param {LanguageOptions} options.languageOptions The language options.
      * @returns {SourceCode} The new `SourceCode` object.

package/lib/languages/js/source-code/source-code.js

@@ -29,6 +29,10 @@ const
 //------------------------------------------------------------------------------
 
 /** @typedef {import("eslint-scope").Variable} Variable */
+/** @typedef {import("eslint-scope").Scope} Scope */
+/** @typedef {import("@eslint/core").SourceCode} ISourceCode */
+/** @typedef {import("@eslint/core").Directive} IDirective */
+/** @typedef {import("@eslint/core").TraversalStep} ITraversalStep */
 
 //------------------------------------------------------------------------------
 // Private
@@ -373,6 +377,7 @@ class TraversalStep {
 
 /**
  * A class to represent a directive comment.
+ * @implements {IDirective}
  */
 class Directive {
 
@@ -429,12 +434,13 @@ const caches = Symbol("caches");
 
 /**
  * Represents parsed source code.
+ * @implements {ISourceCode}
  */
 class SourceCode extends TokenStore {
 
     /**
      * The cache of steps that were taken while traversing the source code.
-     * @type {Array<TraversalStep>}
+     * @type {Array<ITraversalStep>}
      */
     #steps;
 
@@ -838,7 +844,7 @@ class SourceCode extends TokenStore {
     /**
      * Gets the scope for the given node
      * @param {ASTNode} currentNode The node to get the scope of
-     * @returns {eslint-scope.Scope} The scope information for this node
+     * @returns {Scope} The scope information for this node
      * @throws {TypeError} If the `currentNode` argument is missing.
      */
     getScope(currentNode) {
@@ -1099,7 +1105,7 @@ class SourceCode extends TokenStore {
     /**
      * Applies configuration found inside of the source code. This method is only
      * called when ESLint is running with inline configuration allowed.
-     * @returns {{problems:Array<Problem>,configs:{config:FlatConfigArray,node:ASTNode}}} Information
+     * @returns {{problems:Array<Problem>,configs:{config:FlatConfigArray,loc:Location}}} Information
      *      that ESLint needs to further process the inline configuration.
      */
     applyInlineConfig() {
@@ -1147,17 +1153,21 @@ class SourceCode extends TokenStore {
                     break;
 
                 case "eslint": {
-                    const parseResult = commentParser.parseJsonConfig(directiveValue, comment.loc);
+                    const parseResult = commentParser.parseJsonConfig(directiveValue);
 
                     if (parseResult.success) {
                         configs.push({
                             config: {
                                 rules: parseResult.config
                             },
-                            node: comment
+                            loc: comment.loc
                         });
                     } else {
-                        problems.push(parseResult.error);
+                        problems.push({
+                            ruleId: null,
+                            loc: comment.loc,
+                            message: parseResult.error.message
+                        });
                     }
 
                     break;

package/lib/linter/apply-disable-directives.js

@@ -10,6 +10,9 @@
 //------------------------------------------------------------------------------
 
 /** @typedef {import("../shared/types").LintMessage} LintMessage */
+/** @typedef {import("@eslint/core").Language} Language */
+/** @typedef {import("@eslint/core").Position} Position */
+/** @typedef {import("@eslint/core").RulesConfig} RulesConfig */
 
 //------------------------------------------------------------------------------
 // Module Definition
@@ -24,8 +27,8 @@ const {
 
 /**
  * Compares the locations of two objects in a source file
- * @param {{line: number, column: number}} itemA The first object
- * @param {{line: number, column: number}} itemB The second object
+ * @param {Position} itemA The first object
+ * @param {Position} itemB The second object
  * @returns {number} A value less than 1 if itemA appears before itemB in the source file, greater than 1 if
  * itemA appears after itemB in the source file, or 0 if itemA and itemB have the same location.
  */
@@ -418,7 +421,7 @@ function applyDirectives(options) {
  * @param {{ruleId: (string|null), line: number, column: number}[]} options.problems
  * A list of problems reported by rules, sorted by increasing location in the file, with one-based columns.
  * @param {"off" | "warn" | "error"} options.reportUnusedDisableDirectives If `"warn"` or `"error"`, adds additional problems for unused directives
- * @param {Object} options.configuredRules The rules configuration.
+ * @param {RulesConfig} options.configuredRules The rules configuration.
  * @param {Function} options.ruleFilter A predicate function to filter which rules should be executed.
  * @param {boolean} options.disableFixes If true, it doesn't make `fix` properties.
  * @returns {{ruleId: (string|null), line: number, column: number, suppressions?: {kind: string, justification: string}}[]}

package/lib/linter/config-comment-parser.js

@@ -22,12 +22,6 @@ const levn = require("levn"),
 
 const debug = require("debug")("eslint:config-comment-parser");
 
-//------------------------------------------------------------------------------
-// Typedefs
-//------------------------------------------------------------------------------
-
-/** @typedef {import("../shared/types").LintMessage} LintMessage */
-
 //------------------------------------------------------------------------------
 // Public Interface
 //------------------------------------------------------------------------------
@@ -69,10 +63,9 @@ module.exports = class ConfigCommentParser {
     /**
      * Parses a JSON-like config.
      * @param {string} string The string to parse.
-     * @param {Object} location Start line and column of comments for potential error message.
-     * @returns {({success: true, config: Object}|{success: false, error: LintMessage})} Result map object
+     * @returns {({success: true, config: Object}|{success: false, error: {message: string}})} Result map object
      */
-    parseJsonConfig(string, location) {
+    parseJsonConfig(string) {
         debug("Parsing JSON config");
 
         // Parses a JSON-like comment by the same way as parsing CLI option.
@@ -115,13 +108,7 @@ module.exports = class ConfigCommentParser {
             return {
                 success: false,
                 error: {
-                    ruleId: null,
-                    fatal: true,
-                    severity: 2,
-                    message: `Failed to parse JSON from '${normalizedString}': ${ex.message}`,
-                    line: location.start.line,
-                    column: location.start.column + 1,
-                    nodeType: null
+                    message: `Failed to parse JSON from '${normalizedString}': ${ex.message}`
                 }
             };