eslint 9.5.0 → 9.6.0

package/README.md

@@ -294,8 +294,8 @@ The following companies, organizations, and individuals support ESLint's ongoing
 <!-- NOTE: This section is autogenerated. Do not manually edit.-->
 <!--sponsorsstart-->
 <h3>Platinum Sponsors</h3>
-<p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a></p><h3>Gold Sponsors</h3>
-<p><a href="#"><img src="https://images.opencollective.com/guest-bf377e88/avatar.png" alt="Eli Schleifer" height="96"></a> <a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="96"></a></p><h3>Silver Sponsors</h3>
+<p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="undefined"></a></p><h3>Gold Sponsors</h3>
+<p><a href="#"><img src="https://images.opencollective.com/guest-bf377e88/avatar.png" alt="Eli Schleifer" height="96"></a> <a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://www.jetbrains.com/"><img src="https://images.opencollective.com/jetbrains/fe76f99/logo.png" alt="JetBrains" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="64"></a> <a href="https://www.workleap.com"><img src="https://avatars.githubusercontent.com/u/53535748?u=d1e55d7661d724bf2281c1bfd33cb8f99fe2465f&v=4" alt="Workleap" height="64"></a></p><h3>Bronze Sponsors</h3>
 <p><a href="https://www.notion.so"><img src="https://images.opencollective.com/notion/bf3b117/logo.png" alt="notion" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104?v=4" alt="Nx" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://usenextbase.com"><img src="https://avatars.githubusercontent.com/u/145838380?v=4" alt="Nextbase Starter Kit" height="32"></a></p>
 <!--sponsorsend-->

package/conf/ecma-version.js

@@ -9,7 +9,7 @@
  * The latest ECMAScript version supported by ESLint.
  * @type {number} year-based ECMAScript version
  */
-const LATEST_ECMA_VERSION = 2024;
+const LATEST_ECMA_VERSION = 2025;
 
 module.exports = {
     LATEST_ECMA_VERSION

package/conf/globals.js

@@ -133,6 +133,10 @@ const es2024 = {
     ...es2023
 };
 
+const es2025 = {
+    ...es2024
+};
+
 
 //-----------------------------------------------------------------------------
 // Exports
@@ -151,5 +155,6 @@ module.exports = {
     es2021,
     es2022,
     es2023,
-    es2024
+    es2024,
+    es2025
 };

package/lib/cli.js

@@ -26,7 +26,7 @@ const fs = require("node:fs"),
     { normalizeSeverityToString } = require("./shared/severity");
 const { Legacy: { naming } } = require("@eslint/eslintrc");
 const { ModuleImporter } = require("@humanwhocodes/module-importer");
-
+const { inactiveFlags, activeFlags } = require("./shared/flags");
 const debug = require("debug")("eslint:cli");
 
 //------------------------------------------------------------------------------
@@ -117,6 +117,7 @@ async function translateOptions({
     fix,
     fixDryRun,
     fixType,
+    flag,
     global,
     ignore,
     ignorePath,
@@ -225,6 +226,7 @@ async function translateOptions({
         options.ignorePatterns = ignorePattern;
         options.stats = stats;
         options.warnIgnored = warnIgnored;
+        options.flags = flag;
 
         /*
          * For performance reasons rules not marked as 'error' are filtered out in quiet mode. As maxWarnings
@@ -485,8 +487,27 @@ const cli = {
         }
 
         const ActiveESLint = usingFlatConfig ? ESLint : LegacyESLint;
+        const eslintOptions = await translateOptions(options, usingFlatConfig ? "flat" : "eslintrc");
+
+        if (eslintOptions.flags) {
+            debug("Checking for inactive flags");
+
+            for (const flag of eslintOptions.flags) {
+                if (inactiveFlags.has(flag)) {
+                    log.warn(`InactiveFlag: The '${flag}' flag is no longer active: ${inactiveFlags.get(flag)}`);
+                    continue;
+                }
+
+                if (activeFlags.has(flag)) {
+                    continue;
+                }
+
+                log.error(`InvalidFlag: The '${flag}' flag is invalid.`);
+                return 2;
+            }
+        }
 
-        const engine = new ActiveESLint(await translateOptions(options, usingFlatConfig ? "flat" : "eslintrc"));
+        const engine = new ActiveESLint(eslintOptions);
         let results;
 
         if (useStdin) {

package/lib/eslint/eslint-helpers.js

@@ -723,6 +723,7 @@ function processOptions({
     errorOnUnmatchedPattern = true,
     fix = false,
     fixTypes = null, // ← should be null by default because if it's an array then it suppresses rules that don't have the `meta.type` property.
+    flags = [],
     globInputPaths = true,
     ignore = true,
     ignorePatterns = null,
@@ -810,6 +811,9 @@ function processOptions({
     if (fixTypes !== null && !isFixTypeArray(fixTypes)) {
         errors.push("'fixTypes' must be an array of any of \"directive\", \"problem\", \"suggestion\", and \"layout\".");
     }
+    if (!isEmptyArrayOrArrayOfNonEmptyString(flags)) {
+        errors.push("'flags' must be an array of non-empty strings.");
+    }
     if (typeof globInputPaths !== "boolean") {
         errors.push("'globInputPaths' must be a boolean.");
     }
@@ -863,6 +867,7 @@ function processOptions({
         errorOnUnmatchedPattern,
         fix,
         fixTypes,
+        flags: [...flags],
         globInputPaths,
         ignore,
         ignorePatterns,

package/lib/eslint/eslint.js

@@ -76,6 +76,7 @@ const { Retrier } = require("@humanwhocodes/retry");
  * @property {boolean} [errorOnUnmatchedPattern] If `false` then `ESLint#lintFiles()` doesn't throw even if no target files found. Defaults to `true`.
  * @property {boolean|Function} [fix] Execute in autofix mode. If a function, should return a boolean.
  * @property {string[]} [fixTypes] Array of rule types to apply fixes for.
+ * @property {string[]} [flags] Array of feature flags to enable.
  * @property {boolean} [globInputPaths] Set to false to skip glob resolution of input file paths to lint (default: true). If false, each input file paths is assumed to be a non-glob path to an existing file.
  * @property {boolean} [ignore] False disables all ignore patterns except for the default ones.
  * @property {string[]} [ignorePatterns] Ignore file patterns to use in addition to config ignores. These patterns are relative to `cwd`.
@@ -421,7 +422,8 @@ async function calculateConfigArray(eslint, {
             relativeIgnorePatterns = ignorePatterns;
         } else {
 
-            const relativeIgnorePath = path.relative(basePath, cwd);
+            // In minimatch patterns, only `/` can be used as path separator
+            const relativeIgnorePath = path.relative(basePath, cwd).replaceAll(path.sep, "/");
 
             relativeIgnorePatterns = ignorePatterns.map(pattern => {
                 const negated = pattern.startsWith("!");
@@ -593,7 +595,8 @@ class ESLint {
         const processedOptions = processOptions(options);
         const linter = new Linter({
             cwd: processedOptions.cwd,
-            configType: "flat"
+            configType: "flat",
+            flags: processedOptions.flags
         });
 
         const cacheFilePath = getCacheFile(
@@ -766,6 +769,17 @@ class ESLint {
         return createRulesMeta(resultRules);
     }
 
+    /**
+     * Indicates if the given feature flag is enabled for this instance.
+     * @param {string} flag The feature flag to check.
+     * @returns {boolean} `true` if the feature flag is enabled, `false` if not.
+     */
+    hasFlag(flag) {
+
+        // note: Linter does validation of the flags
+        return privateMembers.get(this).linter.hasFlag(flag);
+    }
+
     /**
      * Executes the current configuration on an array of file and directory names.
      * @param {string|string[]} patterns An array of file and directory names.

package/lib/eslint/legacy-eslint.js

@@ -171,6 +171,7 @@ function processOptions({
     extensions = null, // ← should be null by default because if it's an array then it suppresses RFC20 feature.
     fix = false,
     fixTypes = null, // ← should be null by default because if it's an array then it suppresses rules that don't have the `meta.type` property.
+    flags, /* eslint-disable-line no-unused-vars -- leaving for compatibility with ESLint#hasFlag */
     globInputPaths = true,
     ignore = true,
     ignorePath = null, // ← should be null by default because if it's a string then it may throw ENOENT.
@@ -310,6 +311,7 @@ function processOptions({
         extensions,
         fix,
         fixTypes,
+        flags: [], // LegacyESLint does not support flags, so just ignore them.
         globInputPaths,
         ignore,
         ignorePath,
@@ -558,6 +560,18 @@ class LegacyESLint {
 
     }
 
+    /* eslint-disable no-unused-vars, class-methods-use-this -- leaving for compatibility with ESLint#hasFlag */
+    /**
+     * Indicates if the given feature flag is enabled for this instance. For this
+     * class, this always returns `false` because it does not support feature flags.
+     * @param {string} flag The feature flag to check.
+     * @returns {boolean} Always false.
+     */
+    hasFlag(flag) {
+        return false;
+    }
+    /* eslint-enable no-unused-vars, class-methods-use-this -- reenable rules for the rest of the file */
+
     /**
      * Executes the current configuration on an array of file and directory names.
      * @param {string[]} patterns An array of file and directory names.

package/lib/languages/js/source-code/source-code.js

@@ -1099,7 +1099,7 @@ class SourceCode extends TokenStore {
     /**
      * Applies configuration found inside of the source code. This method is only
      * called when ESLint is running with inline configuration allowed.
-     * @returns {{problems:Array<Problem>,configs:{config:FlatConfigArray,node:ASTNode}}} Information
+     * @returns {{problems:Array<Problem>,configs:{config:FlatConfigArray,loc:Location}}} Information
      *      that ESLint needs to further process the inline configuration.
      */
     applyInlineConfig() {
@@ -1147,17 +1147,21 @@ class SourceCode extends TokenStore {
                     break;
 
                 case "eslint": {
-                    const parseResult = commentParser.parseJsonConfig(directiveValue, comment.loc);
+                    const parseResult = commentParser.parseJsonConfig(directiveValue);
 
                     if (parseResult.success) {
                         configs.push({
                             config: {
                                 rules: parseResult.config
                             },
-                            node: comment
+                            loc: comment.loc
                         });
                     } else {
-                        problems.push(parseResult.error);
+                        problems.push({
+                            ruleId: null,
+                            loc: comment.loc,
+                            message: parseResult.error.message
+                        });
                     }
 
                     break;

package/lib/linter/config-comment-parser.js

@@ -22,12 +22,6 @@ const levn = require("levn"),
 
 const debug = require("debug")("eslint:config-comment-parser");
 
-//------------------------------------------------------------------------------
-// Typedefs
-//------------------------------------------------------------------------------
-
-/** @typedef {import("../shared/types").LintMessage} LintMessage */
-
 //------------------------------------------------------------------------------
 // Public Interface
 //------------------------------------------------------------------------------
@@ -69,10 +63,9 @@ module.exports = class ConfigCommentParser {
     /**
      * Parses a JSON-like config.
      * @param {string} string The string to parse.
-     * @param {Object} location Start line and column of comments for potential error message.
-     * @returns {({success: true, config: Object}|{success: false, error: LintMessage})} Result map object
+     * @returns {({success: true, config: Object}|{success: false, error: {message: string}})} Result map object
      */
-    parseJsonConfig(string, location) {
+    parseJsonConfig(string) {
         debug("Parsing JSON config");
 
         // Parses a JSON-like comment by the same way as parsing CLI option.
@@ -115,13 +108,7 @@ module.exports = class ConfigCommentParser {
             return {
                 success: false,
                 error: {
-                    ruleId: null,
-                    fatal: true,
-                    severity: 2,
-                    message: `Failed to parse JSON from '${normalizedString}': ${ex.message}`,
-                    line: location.start.line,
-                    column: location.start.column + 1,
-                    nodeType: null
+                    message: `Failed to parse JSON from '${normalizedString}': ${ex.message}`
                 }
             };
 

package/lib/linter/linter.js

@@ -45,6 +45,7 @@ const { RuleValidator } = require("../config/rule-validator");
 const { assertIsRuleSeverity } = require("../config/flat-config-schema");
 const { normalizeSeverityToString } = require("../shared/severity");
 const jslang = require("../languages/js");
+const { activeFlags } = require("../shared/flags");
 const debug = require("debug")("eslint:linter");
 const MAX_AUTOFIX_PASSES = 10;
 const DEFAULT_PARSER_NAME = "espree";
@@ -317,9 +318,10 @@ function createLintingProblem(options) {
  * @param {string} options.justification The justification of the directive
  * @param {ASTNode|token} options.node The Comment node/token.
  * @param {function(string): {create: Function}} ruleMapper A map from rule IDs to defined rules
+ * @param {Language} language The language to use to adjust the location information.
  * @returns {Object} Directives and problems from the comment
  */
-function createDisableDirectives({ type, value, justification, node }, ruleMapper) {
+function createDisableDirectives({ type, value, justification, node }, ruleMapper, language) {
     const ruleIds = Object.keys(commentParser.parseListConfig(value));
     const directiveRules = ruleIds.length ? ruleIds : [null];
     const result = {
@@ -333,26 +335,36 @@ function createDisableDirectives({ type, value, justification, node }, ruleMappe
         // push to directives, if the rule is defined(including null, e.g. /*eslint enable*/)
         if (ruleId === null || !!ruleMapper(ruleId)) {
             if (type === "disable-next-line") {
+                const { line, column } = updateLocationInformation(
+                    node.loc.end,
+                    language
+                );
+
                 result.directives.push({
                     parentDirective,
                     type,
-                    line: node.loc.end.line,
-                    column: node.loc.end.column + 1,
+                    line,
+                    column,
                     ruleId,
                     justification
                 });
             } else {
+                const { line, column } = updateLocationInformation(
+                    node.loc.start,
+                    language
+                );
+
                 result.directives.push({
                     parentDirective,
                     type,
-                    line: node.loc.start.line,
-                    column: node.loc.start.column + 1,
+                    line,
+                    column,
                     ruleId,
                     justification
                 });
             }
         } else {
-            result.directiveProblems.push(createLintingProblem({ ruleId, loc: node.loc }));
+            result.directiveProblems.push(createLintingProblem({ ruleId, loc: node.loc, language }));
         }
     }
     return result;
@@ -430,7 +442,7 @@ function getDirectiveComments(sourceCode, ruleMapper, warnInlineConfig, config)
                     value: directiveValue,
                     justification: justificationPart,
                     node: comment
-                }, ruleMapper);
+                }, ruleMapper, jslang);
 
                 disableDirectives.push(...directives);
                 problems.push(...directiveProblems);
@@ -470,7 +482,7 @@ function getDirectiveComments(sourceCode, ruleMapper, warnInlineConfig, config)
                 break;
 
             case "eslint": {
-                const parseResult = commentParser.parseJsonConfig(directiveValue, comment.loc);
+                const parseResult = commentParser.parseJsonConfig(directiveValue);
 
                 if (parseResult.success) {
                     Object.keys(parseResult.config).forEach(name => {
@@ -557,7 +569,14 @@ function getDirectiveComments(sourceCode, ruleMapper, warnInlineConfig, config)
                         configuredRules[name] = ruleOptions;
                     });
                 } else {
-                    problems.push(parseResult.error);
+                    const problem = createLintingProblem({
+                        ruleId: null,
+                        loc: comment.loc,
+                        message: parseResult.error.message
+                    });
+
+                    problem.fatal = true;
+                    problems.push(problem);
                 }
 
                 break;
@@ -588,22 +607,24 @@ function getDirectiveCommentsForFlatConfig(sourceCode, ruleMapper, language) {
     const disableDirectives = [];
     const problems = [];
 
-    const {
-        directives: directivesSources,
-        problems: directivesProblems
-    } = sourceCode.getDisableDirectives();
+    if (sourceCode.getDisableDirectives) {
+        const {
+            directives: directivesSources,
+            problems: directivesProblems
+        } = sourceCode.getDisableDirectives();
 
-    problems.push(...directivesProblems.map(directiveProblem => createLintingProblem({
-        ...directiveProblem,
-        language
-    })));
+        problems.push(...directivesProblems.map(directiveProblem => createLintingProblem({
+            ...directiveProblem,
+            language
+        })));
 
-    directivesSources.forEach(directive => {
-        const { directives, directiveProblems } = createDisableDirectives(directive, ruleMapper);
+        directivesSources.forEach(directive => {
+            const { directives, directiveProblems } = createDisableDirectives(directive, ruleMapper, language);
 
-        disableDirectives.push(...directives);
-        problems.push(...directiveProblems);
-    });
+            disableDirectives.push(...directives);
+            problems.push(...directiveProblems);
+        });
+    }
 
     return {
         problems,
@@ -1122,9 +1143,9 @@ function runRules(
     });
 
     const eventGenerator = new NodeEventGenerator(emitter, {
-        visitorKeys: sourceCode.visitorKeys,
+        visitorKeys: sourceCode.visitorKeys ?? language.visitorKeys,
         fallback: Traverser.getKeys,
-        matchClass: language.matchesSelectorClass,
+        matchClass: language.matchesSelectorClass ?? (() => false),
         nodeTypeKey: language.nodeTypeKey
     });
 
@@ -1253,11 +1274,13 @@ class Linter {
      * Initialize the Linter.
      * @param {Object} [config] the config object
      * @param {string} [config.cwd] path to a directory that should be considered as the current working directory, can be undefined.
+     * @param {Array<string>} [config.flags] the feature flags to enable.
      * @param {"flat"|"eslintrc"} [config.configType="flat"] the type of config used.
      */
-    constructor({ cwd, configType = "flat" } = {}) {
+    constructor({ cwd, configType = "flat", flags = [] } = {}) {
         internalSlotsMap.set(this, {
             cwd: normalizeCwd(cwd),
+            flags: flags.filter(flag => activeFlags.has(flag)),
             lastConfigArray: null,
             lastSourceCode: null,
             lastSuppressedMessages: [],
@@ -1278,6 +1301,15 @@ class Linter {
         return pkg.version;
     }
 
+    /**
+     * Indicates if the given feature flag is enabled for this instance.
+     * @param {string} flag The feature flag to check.
+     * @returns {boolean} `true` if the feature flag is enabled, `false` if not.
+     */
+    hasFlag(flag) {
+        return internalSlotsMap.get(this).flags.includes(flag);
+    }
+
     /**
      * Same as linter.verify, except without support for processors.
      * @param {string|SourceCode} textOrSourceCode The text to parse or a SourceCode object.
@@ -1679,8 +1711,13 @@ class Linter {
             /*
              * If the given source code object as the first argument does not have scopeManager, analyze the scope.
              * This is for backward compatibility (SourceCode is frozen so it cannot rebind).
+             *
+             * We check explicitly for `null` to ensure that this is a JS-flavored language.
+             * For non-JS languages we don't want to do this.
+             *
+             * TODO: Remove this check when we stop exporting the `SourceCode` object.
              */
-            if (!slots.lastSourceCode.scopeManager) {
+            if (slots.lastSourceCode.scopeManager === null) {
                 slots.lastSourceCode = new SourceCode({
                     text: slots.lastSourceCode.text,
                     ast: slots.lastSourceCode.ast,
@@ -1699,7 +1736,7 @@ class Linter {
          * this is primarily about adding variables into the global scope
          * to account for ecmaVersion and configured globals.
          */
-        sourceCode.applyLanguageOptions(languageOptions);
+        sourceCode.applyLanguageOptions?.(languageOptions);
 
         const mergedInlineConfig = {
             rules: {}
@@ -1716,147 +1753,151 @@ class Linter {
 
             // if inline config should warn then add the warnings
             if (options.warnInlineConfig) {
-                sourceCode.getInlineConfigNodes().forEach(node => {
-                    inlineConfigProblems.push(createLintingProblem({
-                        ruleId: null,
-                        message: `'${sourceCode.text.slice(node.range[0], node.range[1])}' has no effect because you have 'noInlineConfig' setting in ${options.warnInlineConfig}.`,
-                        loc: node.loc,
-                        severity: 1,
-                        language: config.language
-                    }));
+                if (sourceCode.getInlineConfigNodes) {
+                    sourceCode.getInlineConfigNodes().forEach(node => {
+                        inlineConfigProblems.push(createLintingProblem({
+                            ruleId: null,
+                            message: `'${sourceCode.text.slice(node.range[0], node.range[1])}' has no effect because you have 'noInlineConfig' setting in ${options.warnInlineConfig}.`,
+                            loc: node.loc,
+                            severity: 1,
+                            language: config.language
+                        }));
 
-                });
+                    });
+                }
             } else {
-                const inlineConfigResult = sourceCode.applyInlineConfig();
-
-                inlineConfigProblems.push(
-                    ...inlineConfigResult.problems
-                        .map(problem => createLintingProblem({ ...problem, language: config.language }))
-                        .map(problem => {
-                            problem.fatal = true;
-                            return problem;
-                        })
-                );
+                const inlineConfigResult = sourceCode.applyInlineConfig?.();
+
+                if (inlineConfigResult) {
+                    inlineConfigProblems.push(
+                        ...inlineConfigResult.problems
+                            .map(problem => createLintingProblem({ ...problem, language: config.language }))
+                            .map(problem => {
+                                problem.fatal = true;
+                                return problem;
+                            })
+                    );
+
+                    // next we need to verify information about the specified rules
+                    const ruleValidator = new RuleValidator();
+
+                    for (const { config: inlineConfig, loc } of inlineConfigResult.configs) {
+
+                        Object.keys(inlineConfig.rules).forEach(ruleId => {
+                            const rule = getRuleFromConfig(ruleId, config);
+                            const ruleValue = inlineConfig.rules[ruleId];
+
+                            if (!rule) {
+                                inlineConfigProblems.push(createLintingProblem({
+                                    ruleId,
+                                    loc,
+                                    language: config.language
+                                }));
+                                return;
+                            }
 
-                // next we need to verify information about the specified rules
-                const ruleValidator = new RuleValidator();
+                            if (Object.hasOwn(mergedInlineConfig.rules, ruleId)) {
+                                inlineConfigProblems.push(createLintingProblem({
+                                    message: `Rule "${ruleId}" is already configured by another configuration comment in the preceding code. This configuration is ignored.`,
+                                    loc,
+                                    language: config.language
+                                }));
+                                return;
+                            }
 
-                for (const { config: inlineConfig, node } of inlineConfigResult.configs) {
+                            try {
 
-                    Object.keys(inlineConfig.rules).forEach(ruleId => {
-                        const rule = getRuleFromConfig(ruleId, config);
-                        const ruleValue = inlineConfig.rules[ruleId];
+                                let ruleOptions = Array.isArray(ruleValue) ? ruleValue : [ruleValue];
 
-                        if (!rule) {
-                            inlineConfigProblems.push(createLintingProblem({
-                                ruleId,
-                                loc: node.loc,
-                                language: config.language
-                            }));
-                            return;
-                        }
+                                assertIsRuleSeverity(ruleId, ruleOptions[0]);
 
-                        if (Object.hasOwn(mergedInlineConfig.rules, ruleId)) {
-                            inlineConfigProblems.push(createLintingProblem({
-                                message: `Rule "${ruleId}" is already configured by another configuration comment in the preceding code. This configuration is ignored.`,
-                                loc: node.loc,
-                                language: config.language
-                            }));
-                            return;
-                        }
+                                /*
+                                 * If the rule was already configured, inline rule configuration that
+                                 * only has severity should retain options from the config and just override the severity.
+                                 *
+                                 * Example:
+                                 *
+                                 *   {
+                                 *       rules: {
+                                 *           curly: ["error", "multi"]
+                                 *       }
+                                 *   }
+                                 *
+                                 *   /* eslint curly: ["warn"] * /
+                                 *
+                                 *   Results in:
+                                 *
+                                 *   curly: ["warn", "multi"]
+                                 */
 
-                        try {
+                                let shouldValidateOptions = true;
 
-                            let ruleOptions = Array.isArray(ruleValue) ? ruleValue : [ruleValue];
+                                if (
 
-                            assertIsRuleSeverity(ruleId, ruleOptions[0]);
+                                    /*
+                                     * If inline config for the rule has only severity
+                                     */
+                                    ruleOptions.length === 1 &&
 
-                            /*
-                             * If the rule was already configured, inline rule configuration that
-                             * only has severity should retain options from the config and just override the severity.
-                             *
-                             * Example:
-                             *
-                             *   {
-                             *       rules: {
-                             *           curly: ["error", "multi"]
-                             *       }
-                             *   }
-                             *
-                             *   /* eslint curly: ["warn"] * /
-                             *
-                             *   Results in:
-                             *
-                             *   curly: ["warn", "multi"]
-                             */
+                                    /*
+                                     * And the rule was already configured
+                                     */
+                                    config.rules && Object.hasOwn(config.rules, ruleId)
+                                ) {
 
-                            let shouldValidateOptions = true;
+                                    /*
+                                     * Then use severity from the inline config and options from the provided config
+                                     */
+                                    ruleOptions = [
+                                        ruleOptions[0], // severity from the inline config
+                                        ...config.rules[ruleId].slice(1) // options from the provided config
+                                    ];
 
-                            if (
+                                    // if the rule was enabled, the options have already been validated
+                                    if (config.rules[ruleId][0] > 0) {
+                                        shouldValidateOptions = false;
+                                    }
+                                }
 
-                                /*
-                                 * If inline config for the rule has only severity
-                                 */
-                                ruleOptions.length === 1 &&
+                                if (shouldValidateOptions) {
+                                    ruleValidator.validate({
+                                        plugins: config.plugins,
+                                        rules: {
+                                            [ruleId]: ruleOptions
+                                        }
+                                    });
+                                }
 
-                                /*
-                                 * And the rule was already configured
-                                 */
-                                config.rules && Object.hasOwn(config.rules, ruleId)
-                            ) {
+                                mergedInlineConfig.rules[ruleId] = ruleOptions;
+                            } catch (err) {
 
                                 /*
-                                 * Then use severity from the inline config and options from the provided config
+                                 * If the rule has invalid `meta.schema`, throw the error because
+                                 * this is not an invalid inline configuration but an invalid rule.
                                  */
-                                ruleOptions = [
-                                    ruleOptions[0], // severity from the inline config
-                                    ...config.rules[ruleId].slice(1) // options from the provided config
-                                ];
-
-                                // if the rule was enabled, the options have already been validated
-                                if (config.rules[ruleId][0] > 0) {
-                                    shouldValidateOptions = false;
+                                if (err.code === "ESLINT_INVALID_RULE_OPTIONS_SCHEMA") {
+                                    throw err;
                                 }
-                            }
 
-                            if (shouldValidateOptions) {
-                                ruleValidator.validate({
-                                    plugins: config.plugins,
-                                    rules: {
-                                        [ruleId]: ruleOptions
-                                    }
-                                });
-                            }
+                                let baseMessage = err.message.slice(
+                                    err.message.startsWith("Key \"rules\":")
+                                        ? err.message.indexOf(":", 12) + 1
+                                        : err.message.indexOf(":") + 1
+                                ).trim();
 
-                            mergedInlineConfig.rules[ruleId] = ruleOptions;
-                        } catch (err) {
-
-                            /*
-                             * If the rule has invalid `meta.schema`, throw the error because
-                             * this is not an invalid inline configuration but an invalid rule.
-                             */
-                            if (err.code === "ESLINT_INVALID_RULE_OPTIONS_SCHEMA") {
-                                throw err;
-                            }
-
-                            let baseMessage = err.message.slice(
-                                err.message.startsWith("Key \"rules\":")
-                                    ? err.message.indexOf(":", 12) + 1
-                                    : err.message.indexOf(":") + 1
-                            ).trim();
+                                if (err.messageTemplate) {
+                                    baseMessage += ` You passed "${ruleValue}".`;
+                                }
 
-                            if (err.messageTemplate) {
-                                baseMessage += ` You passed "${ruleValue}".`;
+                                inlineConfigProblems.push(createLintingProblem({
+                                    ruleId,
+                                    message: `Inline configuration for rule "${ruleId}" is invalid:\n\t${baseMessage}\n`,
+                                    loc,
+                                    language: config.language
+                                }));
                             }
-
-                            inlineConfigProblems.push(createLintingProblem({
-                                ruleId,
-                                message: `Inline configuration for rule "${ruleId}" is invalid:\n\t${baseMessage}\n`,
-                                loc: node.loc,
-                                language: config.language
-                            }));
-                        }
-                    });
+                        });
+                    }
                 }
             }
         }
@@ -1873,7 +1914,7 @@ class Linter {
 
         let lintingProblems;
 
-        sourceCode.finalize();
+        sourceCode.finalize?.();
 
         try {
             lintingProblems = runRules(

package/lib/options.js

@@ -30,6 +30,7 @@ const optionator = require("optionator");
  * @property {boolean} errorOnUnmatchedPattern Prevent errors when pattern is unmatched
  * @property {boolean} eslintrc Disable use of configuration from .eslintrc.*
  * @property {string[]} [ext] Specify JavaScript file extensions
+ * @property {string[]} [flag] Feature flags
  * @property {boolean} fix Automatically fix problems
  * @property {boolean} fixDryRun Automatically fix problems without saving the changes to the file system
  * @property {("directive" | "problem" | "suggestion" | "layout")[]} [fixType] Specify the types of fixes to apply (directive, problem, suggestion, layout)
@@ -176,6 +177,16 @@ module.exports = function(usingFlatConfig) {
         };
     }
 
+    let flagFlag;
+
+    if (usingFlatConfig) {
+        flagFlag = {
+            option: "flag",
+            type: "[String]",
+            description: "Enable a feature flag"
+        };
+    }
+
     return optionator({
         prepend: "eslint [options] file.js [file.js] [dir]",
         defaults: {
@@ -424,7 +435,8 @@ module.exports = function(usingFlatConfig) {
                 type: "path::String",
                 description: "Print the configuration for the given file"
             },
-            statsFlag
+            statsFlag,
+            flagFlag
         ].filter(value => !!value)
     });
 };

package/lib/rules/no-unused-vars.js

@@ -147,6 +147,36 @@ module.exports = {
             }
         }
 
+        /**
+         * Determines what variable type a def is.
+         * @param  {Object} def the declaration to check
+         * @returns {VariableType} a simple name for the types of variables that this rule supports
+         */
+        function defToVariableType(def) {
+
+            /*
+             * This `destructuredArrayIgnorePattern` error report works differently from the catch
+             * clause and parameter error reports. _Both_ the `varsIgnorePattern` and the
+             * `destructuredArrayIgnorePattern` will be checked for array destructuring. However,
+             * for the purposes of the report, the currently defined behavior is to only inform the
+             * user of the `destructuredArrayIgnorePattern` if it's present (regardless of the fact
+             * that the `varsIgnorePattern` would also apply). If it's not present, the user will be
+             * informed of the `varsIgnorePattern`, assuming that's present.
+             */
+            if (config.destructuredArrayIgnorePattern && def.name.parent.type === "ArrayPattern") {
+                return "array-destructure";
+            }
+
+            switch (def.type) {
+                case "CatchClause":
+                    return "catch-clause";
+                case "Parameter":
+                    return "parameter";
+                default:
+                    return "variable";
+            }
+        }
+
         /**
          * Gets a given variable's description and configured ignore pattern
          * based on the provided variableType
@@ -167,7 +197,7 @@ module.exports = {
 
                 case "catch-clause":
                     pattern = config.caughtErrorsIgnorePattern;
-                    variableDescription = "args";
+                    variableDescription = "caught errors";
                     break;
 
                 case "parameter":
@@ -202,28 +232,7 @@ module.exports = {
             let additionalMessageData = "";
 
             if (def) {
-                let pattern;
-                let variableDescription;
-
-                switch (def.type) {
-                    case "CatchClause":
-                        if (config.caughtErrorsIgnorePattern) {
-                            [variableDescription, pattern] = getVariableDescription("catch-clause");
-                        }
-                        break;
-
-                    case "Parameter":
-                        if (config.argsIgnorePattern) {
-                            [variableDescription, pattern] = getVariableDescription("parameter");
-                        }
-                        break;
-
-                    default:
-                        if (config.varsIgnorePattern) {
-                            [variableDescription, pattern] = getVariableDescription("variable");
-                        }
-                        break;
-                }
+                const [variableDescription, pattern] = getVariableDescription(defToVariableType(def));
 
                 if (pattern && variableDescription) {
                     additionalMessageData = `. Allowed unused ${variableDescription} must match ${pattern}`;
@@ -248,14 +257,7 @@ module.exports = {
             let additionalMessageData = "";
 
             if (def) {
-                let pattern;
-                let variableDescription;
-
-                if (def.name.parent.type === "ArrayPattern" && config.destructuredArrayIgnorePattern) {
-                    [variableDescription, pattern] = getVariableDescription("array-destructure");
-                } else if (config.varsIgnorePattern) {
-                    [variableDescription, pattern] = getVariableDescription("variable");
-                }
+                const [variableDescription, pattern] = getVariableDescription(defToVariableType(def));
 
                 if (pattern && variableDescription) {
                     additionalMessageData = `. Allowed unused ${variableDescription} must match ${pattern}`;

package/lib/shared/flags.js

@@ -0,0 +1,26 @@
+/**
+ * @fileoverview Shared flags for ESLint.
+ */
+
+"use strict";
+
+/**
+ * The set of flags that change ESLint behavior with a description.
+ * @type {Map<string, string>}
+ */
+const activeFlags = new Map([
+    ["test_only", "This flag is only used for testing."]
+]);
+
+/**
+ * The set of flags that used to be active but no longer have an effect.
+ * @type {Map<string, string>}
+ */
+const inactiveFlags = new Map([
+    ["test_only_old", "This flag is no longer used for testing."]
+]);
+
+module.exports = {
+    activeFlags,
+    inactiveFlags
+};

package/lib/shared/logging.js

@@ -11,7 +11,7 @@
 module.exports = {
 
     /**
-     * Cover for console.log
+     * Cover for console.info
      * @param {...any} args The elements to log.
      * @returns {void}
      */
@@ -19,6 +19,15 @@ module.exports = {
         console.log(...args);
     },
 
+    /**
+     * Cover for console.warn
+     * @param {...any} args The elements to log.
+     * @returns {void}
+     */
+    warn(...args) {
+        console.warn(...args);
+    },
+
     /**
      * Cover for console.error
      * @param {...any} args The elements to log.

package/lib/shared/types.js

@@ -21,7 +21,7 @@ module.exports = {};
 /**
  * @typedef {Object} ParserOptions
  * @property {EcmaFeatures} [ecmaFeatures] The optional features.
- * @property {3|5|6|7|8|9|10|11|12|13|14|15|2015|2016|2017|2018|2019|2020|2021|2022|2023|2024} [ecmaVersion] The ECMAScript version (or revision number).
+ * @property {3|5|6|7|8|9|10|11|12|13|14|15|16|2015|2016|2017|2018|2019|2020|2021|2022|2023|2024|2025} [ecmaVersion] The ECMAScript version (or revision number).
  * @property {"script"|"module"} [sourceType] The source code type.
  * @property {boolean} [allowReserved] Allowing the use of reserved words as identifiers in ES3.
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "9.5.0",
+  "version": "9.6.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "bin": {
@@ -68,9 +68,9 @@
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.2.0",
     "@eslint-community/regexpp": "^4.6.1",
-    "@eslint/config-array": "^0.16.0",
+    "@eslint/config-array": "^0.17.0",
     "@eslint/eslintrc": "^3.1.0",
-    "@eslint/js": "9.5.0",
+    "@eslint/js": "9.6.0",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@humanwhocodes/retry": "^0.3.0",
     "@nodelib/fs.walk": "^1.2.8",
@@ -81,7 +81,7 @@
     "escape-string-regexp": "^4.0.0",
     "eslint-scope": "^8.0.1",
     "eslint-visitor-keys": "^4.0.0",
-    "espree": "^10.0.1",
+    "espree": "^10.1.0",
     "esquery": "^1.5.0",
     "esutils": "^2.0.2",
     "fast-deep-equal": "^3.1.3",
@@ -104,13 +104,11 @@
   "devDependencies": {
     "@babel/core": "^7.4.3",
     "@babel/preset-env": "^7.4.3",
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
     "@types/estree": "^1.0.5",
     "@types/node": "^20.11.5",
     "@wdio/browser-runner": "^8.38.3",
     "@wdio/cli": "^8.38.2",
     "@wdio/concise-reporter": "^8.38.2",
-    "@wdio/globals": "^8.38.2",
     "@wdio/mocha-framework": "^8.38.2",
     "babel-loader": "^8.0.5",
     "c8": "^7.12.0",
@@ -122,11 +120,8 @@
     "eslint": "file:.",
     "eslint-config-eslint": "file:packages/eslint-config-eslint",
     "eslint-plugin-eslint-plugin": "^6.0.0",
-    "eslint-plugin-internal-rules": "file:tools/internal-rules",
-    "eslint-plugin-jsdoc": "^48.2.3",
-    "eslint-plugin-n": "^17.2.0",
-    "eslint-plugin-unicorn": "^52.0.0",
     "eslint-release": "^3.2.2",
+    "eslint-rule-composer": "^0.3.0",
     "eslump": "^3.0.0",
     "esprima": "^4.0.1",
     "fast-glob": "^3.2.11",
@@ -136,7 +131,7 @@
     "got": "^11.8.3",
     "gray-matter": "^4.0.3",
     "js-yaml": "^4.1.0",
-    "knip": "^5.8.0",
+    "knip": "^5.21.0",
     "lint-staged": "^11.0.0",
     "load-perf": "^0.2.0",
     "markdown-it": "^12.2.0",