eslint 9.4.0 → 9.6.0

package/lib/linter/report-translator.js

@@ -240,15 +240,22 @@ function mapSuggestions(descriptor, sourceCode, messages) {
  * @param {{start: SourceLocation, end: (SourceLocation|null)}} options.loc Start and end location
  * @param {{text: string, range: (number[]|null)}} options.fix The fix object
  * @param {Array<{text: string, range: (number[]|null)}>} options.suggestions The array of suggestions objects
+ * @param {Language} [options.language] The language to use to adjust line and column offsets.
  * @returns {LintMessage} Information about the report
  */
 function createProblem(options) {
+    const { language } = options;
+
+    // calculate offsets based on the language in use
+    const columnOffset = language.columnStart === 1 ? 0 : 1;
+    const lineOffset = language.lineStart === 1 ? 0 : 1;
+
     const problem = {
         ruleId: options.ruleId,
         severity: options.severity,
         message: options.message,
-        line: options.loc.start.line,
-        column: options.loc.start.column + 1,
+        line: options.loc.start.line + lineOffset,
+        column: options.loc.start.column + columnOffset,
         nodeType: options.node && options.node.type || null
     };
 
@@ -261,8 +268,8 @@ function createProblem(options) {
     }
 
     if (options.loc.end) {
-        problem.endLine = options.loc.end.line;
-        problem.endColumn = options.loc.end.column + 1;
+        problem.endLine = options.loc.end.line + lineOffset;
+        problem.endColumn = options.loc.end.column + columnOffset;
     }
 
     if (options.fix) {
@@ -313,8 +320,7 @@ function validateSuggestions(suggest, messages) {
 /**
  * Returns a function that converts the arguments of a `context.report` call from a rule into a reported
  * problem for the Node.js API.
- * @param {{ruleId: string, severity: number, sourceCode: SourceCode, messageIds: Object, disableFixes: boolean}} metadata Metadata for the reported problem
- * @param {SourceCode} sourceCode The `SourceCode` instance for the text being linted
+ * @param {{ruleId: string, severity: number, sourceCode: SourceCode, messageIds: Object, disableFixes: boolean, language:Language}} metadata Metadata for the reported problem
  * @returns {function(...args): LintMessage} Function that returns information about the report
  */
 
@@ -363,7 +369,8 @@ module.exports = function createReportTranslator(metadata) {
             messageId: descriptor.messageId,
             loc: normalizeReportLoc(descriptor),
             fix: metadata.disableFixes ? null : normalizeFixes(descriptor, metadata.sourceCode),
-            suggestions: metadata.disableFixes ? [] : mapSuggestions(descriptor, metadata.sourceCode, messages)
+            suggestions: metadata.disableFixes ? [] : mapSuggestions(descriptor, metadata.sourceCode, messages),
+            language: metadata.language
         });
     };
 };

package/lib/linter/vfile.js

@@ -0,0 +1,104 @@
+/**
+ * @fileoverview Virtual file
+ * @author Nicholas C. Zakas
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+/**
+ * Determines if a given value has a byte order mark (BOM).
+ * @param {string|Uint8Array} value The value to check.
+ * @returns {boolean} `true` if the value has a BOM, `false` otherwise.
+ */
+function hasUnicodeBOM(value) {
+    return typeof value === "string"
+        ? value.charCodeAt(0) === 0xFEFF
+        : value[0] === 0xEF && value[1] === 0xBB && value[2] === 0xBF;
+}
+
+/**
+ * Strips Unicode BOM from the given value.
+ * @param {string|Uint8Array} value The value to remove the BOM from.
+ * @returns {string|Uint8Array} The stripped value.
+ */
+function stripUnicodeBOM(value) {
+
+    if (!hasUnicodeBOM(value)) {
+        return value;
+    }
+
+    if (typeof value === "string") {
+
+        /*
+         * Check Unicode BOM.
+         * In JavaScript, string data is stored as UTF-16, so BOM is 0xFEFF.
+         * http://www.ecma-international.org/ecma-262/6.0/#sec-unicode-format-control-characters
+         */
+        return value.slice(1);
+    }
+
+    /*
+     * In a Uint8Array, the BOM is represented by three bytes: 0xEF, 0xBB, and 0xBF,
+     * so we can just remove the first three bytes.
+     */
+    return value.slice(3);
+}
+
+//------------------------------------------------------------------------------
+// Exports
+//------------------------------------------------------------------------------
+
+/**
+ * Represents a virtual file inside of ESLint.
+ */
+class VFile {
+
+    /**
+     * The file path including any processor-created virtual path.
+     * @type {string}
+     * @readonly
+     */
+    path;
+
+    /**
+     * The file path on disk.
+     * @type {string}
+     * @readonly
+     */
+    physicalPath;
+
+    /**
+     * The file contents.
+     * @type {string|Uint8Array}
+     * @readonly
+     */
+    body;
+
+    /**
+     * Indicates whether the file has a byte order mark (BOM).
+     * @type {boolean}
+     * @readonly
+     */
+    bom;
+
+    /**
+     * Creates a new instance.
+     * @param {string} path The file path.
+     * @param {string|Uint8Array} body The file contents.
+     * @param {Object} [options] Additional options.
+     * @param {string} [options.physicalPath] The file path on disk.
+     */
+    constructor(path, body, { physicalPath } = {}) {
+        this.path = path;
+        this.physicalPath = physicalPath ?? path;
+        this.bom = hasUnicodeBOM(body);
+        this.body = stripUnicodeBOM(body);
+    }
+
+}
+
+module.exports = { VFile };

package/lib/options.js

@@ -30,6 +30,7 @@ const optionator = require("optionator");
  * @property {boolean} errorOnUnmatchedPattern Prevent errors when pattern is unmatched
  * @property {boolean} eslintrc Disable use of configuration from .eslintrc.*
  * @property {string[]} [ext] Specify JavaScript file extensions
+ * @property {string[]} [flag] Feature flags
  * @property {boolean} fix Automatically fix problems
  * @property {boolean} fixDryRun Automatically fix problems without saving the changes to the file system
  * @property {("directive" | "problem" | "suggestion" | "layout")[]} [fixType] Specify the types of fixes to apply (directive, problem, suggestion, layout)
@@ -176,6 +177,16 @@ module.exports = function(usingFlatConfig) {
         };
     }
 
+    let flagFlag;
+
+    if (usingFlatConfig) {
+        flagFlag = {
+            option: "flag",
+            type: "[String]",
+            description: "Enable a feature flag"
+        };
+    }
+
     return optionator({
         prepend: "eslint [options] file.js [file.js] [dir]",
         defaults: {
@@ -424,7 +435,8 @@ module.exports = function(usingFlatConfig) {
                 type: "path::String",
                 description: "Print the configuration for the given file"
             },
-            statsFlag
+            statsFlag,
+            flagFlag
         ].filter(value => !!value)
     });
 };

package/lib/rule-tester/rule-tester.js

@@ -27,10 +27,11 @@ const { defaultConfig } = require("../config/default-config");
 const ajv = require("../shared/ajv")({ strictDefaults: true });
 
 const parserSymbol = Symbol.for("eslint.RuleTester.parser");
-const { SourceCode } = require("../source-code");
 const { ConfigArraySymbol } = require("@eslint/config-array");
 const { isSerializable } = require("../shared/serialization");
 
+const { SourceCode } = require("../languages/js/source-code");
+
 //------------------------------------------------------------------------------
 // Typedefs
 //------------------------------------------------------------------------------
@@ -591,7 +592,8 @@ class RuleTester {
                          * here, just use the default one to keep that performance
                          * enhancement.
                          */
-                        rules: defaultConfig[0].plugins["@"].rules
+                        rules: defaultConfig[0].plugins["@"].rules,
+                        languages: defaultConfig[0].plugins["@"].languages
                     },
                     "rule-to-test": {
                         rules: {
@@ -611,6 +613,7 @@ class RuleTester {
                         }
                     }
                 },
+                language: defaultConfig[0].language,
                 languageOptions: {
                     ...defaultConfig[0].languageOptions
                 }

package/lib/rules/no-sparse-arrays.js

@@ -4,6 +4,8 @@
  */
 "use strict";
 
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -36,11 +38,32 @@ module.exports = {
         return {
 
             ArrayExpression(node) {
+                if (!node.elements.includes(null)) {
+                    return;
+                }
+
+                const { sourceCode } = context;
+                let commaToken;
+
+                for (const [index, element] of node.elements.entries()) {
+                    if (index === node.elements.length - 1 && element) {
+                        return;
+                    }
+
+                    commaToken = sourceCode.getTokenAfter(
+                        element ?? commaToken ?? sourceCode.getFirstToken(node),
+                        astUtils.isCommaToken
+                    );
 
-                const emptySpot = node.elements.includes(null);
+                    if (element) {
+                        continue;
+                    }
 
-                if (emptySpot) {
-                    context.report({ node, messageId: "unexpectedSparseArray" });
+                    context.report({
+                        node,
+                        loc: commaToken.loc,
+                        messageId: "unexpectedSparseArray"
+                    });
                 }
             }
 

package/lib/rules/no-unused-vars.js

@@ -147,6 +147,36 @@ module.exports = {
             }
         }
 
+        /**
+         * Determines what variable type a def is.
+         * @param  {Object} def the declaration to check
+         * @returns {VariableType} a simple name for the types of variables that this rule supports
+         */
+        function defToVariableType(def) {
+
+            /*
+             * This `destructuredArrayIgnorePattern` error report works differently from the catch
+             * clause and parameter error reports. _Both_ the `varsIgnorePattern` and the
+             * `destructuredArrayIgnorePattern` will be checked for array destructuring. However,
+             * for the purposes of the report, the currently defined behavior is to only inform the
+             * user of the `destructuredArrayIgnorePattern` if it's present (regardless of the fact
+             * that the `varsIgnorePattern` would also apply). If it's not present, the user will be
+             * informed of the `varsIgnorePattern`, assuming that's present.
+             */
+            if (config.destructuredArrayIgnorePattern && def.name.parent.type === "ArrayPattern") {
+                return "array-destructure";
+            }
+
+            switch (def.type) {
+                case "CatchClause":
+                    return "catch-clause";
+                case "Parameter":
+                    return "parameter";
+                default:
+                    return "variable";
+            }
+        }
+
         /**
          * Gets a given variable's description and configured ignore pattern
          * based on the provided variableType
@@ -167,7 +197,7 @@ module.exports = {
 
                 case "catch-clause":
                     pattern = config.caughtErrorsIgnorePattern;
-                    variableDescription = "args";
+                    variableDescription = "caught errors";
                     break;
 
                 case "parameter":
@@ -202,28 +232,7 @@ module.exports = {
             let additionalMessageData = "";
 
             if (def) {
-                let pattern;
-                let variableDescription;
-
-                switch (def.type) {
-                    case "CatchClause":
-                        if (config.caughtErrorsIgnorePattern) {
-                            [variableDescription, pattern] = getVariableDescription("catch-clause");
-                        }
-                        break;
-
-                    case "Parameter":
-                        if (config.argsIgnorePattern) {
-                            [variableDescription, pattern] = getVariableDescription("parameter");
-                        }
-                        break;
-
-                    default:
-                        if (config.varsIgnorePattern) {
-                            [variableDescription, pattern] = getVariableDescription("variable");
-                        }
-                        break;
-                }
+                const [variableDescription, pattern] = getVariableDescription(defToVariableType(def));
 
                 if (pattern && variableDescription) {
                     additionalMessageData = `. Allowed unused ${variableDescription} must match ${pattern}`;
@@ -248,14 +257,7 @@ module.exports = {
             let additionalMessageData = "";
 
             if (def) {
-                let pattern;
-                let variableDescription;
-
-                if (def.name.parent.type === "ArrayPattern" && config.destructuredArrayIgnorePattern) {
-                    [variableDescription, pattern] = getVariableDescription("array-destructure");
-                } else if (config.varsIgnorePattern) {
-                    [variableDescription, pattern] = getVariableDescription("variable");
-                }
+                const [variableDescription, pattern] = getVariableDescription(defToVariableType(def));
 
                 if (pattern && variableDescription) {
                     additionalMessageData = `. Allowed unused ${variableDescription} must match ${pattern}`;

package/lib/shared/flags.js

@@ -0,0 +1,26 @@
+/**
+ * @fileoverview Shared flags for ESLint.
+ */
+
+"use strict";
+
+/**
+ * The set of flags that change ESLint behavior with a description.
+ * @type {Map<string, string>}
+ */
+const activeFlags = new Map([
+    ["test_only", "This flag is only used for testing."]
+]);
+
+/**
+ * The set of flags that used to be active but no longer have an effect.
+ * @type {Map<string, string>}
+ */
+const inactiveFlags = new Map([
+    ["test_only_old", "This flag is no longer used for testing."]
+]);
+
+module.exports = {
+    activeFlags,
+    inactiveFlags
+};

package/lib/shared/logging.js

@@ -11,7 +11,7 @@
 module.exports = {
 
     /**
-     * Cover for console.log
+     * Cover for console.info
      * @param {...any} args The elements to log.
      * @returns {void}
      */
@@ -19,6 +19,15 @@ module.exports = {
         console.log(...args);
     },
 
+    /**
+     * Cover for console.warn
+     * @param {...any} args The elements to log.
+     * @returns {void}
+     */
+    warn(...args) {
+        console.warn(...args);
+    },
+
     /**
      * Cover for console.error
      * @param {...any} args The elements to log.

package/lib/shared/types.js

@@ -21,7 +21,7 @@ module.exports = {};
 /**
  * @typedef {Object} ParserOptions
  * @property {EcmaFeatures} [ecmaFeatures] The optional features.
- * @property {3|5|6|7|8|9|10|11|12|13|14|15|2015|2016|2017|2018|2019|2020|2021|2022|2023|2024} [ecmaVersion] The ECMAScript version (or revision number).
+ * @property {3|5|6|7|8|9|10|11|12|13|14|15|16|2015|2016|2017|2018|2019|2020|2021|2022|2023|2024|2025} [ecmaVersion] The ECMAScript version (or revision number).
  * @property {"script"|"module"} [sourceType] The source code type.
  * @property {boolean} [allowReserved] Allowing the use of reserved words as identifiers in ES3.
  */

package/messages/all-matched-files-ignored.js

@@ -0,0 +1,21 @@
+"use strict";
+
+module.exports = function(it) {
+    const { pattern } = it;
+
+    return `
+You are linting "${pattern}", but all of the files matching the glob pattern "${pattern}" are ignored.
+
+If you don't want to lint these files, remove the pattern "${pattern}" from the list of arguments passed to ESLint.
+
+If you do want to lint these files, explicitly list one or more of the files from this glob that you'd like to lint to see more details about why they are ignored.
+
+  * If the file is ignored because of a matching ignore pattern, check global ignores in your config file.
+    https://eslint.org/docs/latest/use/configure/ignore
+
+  * If the file is ignored because no matching configuration was supplied, check file patterns in your config file.
+    https://eslint.org/docs/latest/use/configure/configuration-files#specifying-files-with-arbitrary-extensions
+
+  * If the file is ignored because it is located outside of the base path, change the location of your config file to be in a parent directory.
+`.trimStart();
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "9.4.0",
+  "version": "9.6.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "bin": {
@@ -62,15 +62,15 @@
     "messages"
   ],
   "repository": "eslint/eslint",
-  "funding": "https://opencollective.com/eslint",
+  "funding": "https://eslint.org/donate",
   "homepage": "https://eslint.org",
   "bugs": "https://github.com/eslint/eslint/issues/",
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.2.0",
     "@eslint-community/regexpp": "^4.6.1",
-    "@eslint/config-array": "^0.15.1",
+    "@eslint/config-array": "^0.17.0",
     "@eslint/eslintrc": "^3.1.0",
-    "@eslint/js": "9.4.0",
+    "@eslint/js": "9.6.0",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@humanwhocodes/retry": "^0.3.0",
     "@nodelib/fs.walk": "^1.2.8",
@@ -81,8 +81,8 @@
     "escape-string-regexp": "^4.0.0",
     "eslint-scope": "^8.0.1",
     "eslint-visitor-keys": "^4.0.0",
-    "espree": "^10.0.1",
-    "esquery": "^1.4.2",
+    "espree": "^10.1.0",
+    "esquery": "^1.5.0",
     "esutils": "^2.0.2",
     "fast-deep-equal": "^3.1.3",
     "file-entry-cache": "^8.0.0",
@@ -104,14 +104,12 @@
   "devDependencies": {
     "@babel/core": "^7.4.3",
     "@babel/preset-env": "^7.4.3",
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
     "@types/estree": "^1.0.5",
     "@types/node": "^20.11.5",
-    "@wdio/browser-runner": "^8.14.6",
-    "@wdio/cli": "^8.14.6",
-    "@wdio/concise-reporter": "^8.14.0",
-    "@wdio/globals": "^8.14.6",
-    "@wdio/mocha-framework": "^8.14.0",
+    "@wdio/browser-runner": "^8.38.3",
+    "@wdio/cli": "^8.38.2",
+    "@wdio/concise-reporter": "^8.38.2",
+    "@wdio/mocha-framework": "^8.38.2",
     "babel-loader": "^8.0.5",
     "c8": "^7.12.0",
     "chai": "^4.0.1",
@@ -122,11 +120,8 @@
     "eslint": "file:.",
     "eslint-config-eslint": "file:packages/eslint-config-eslint",
     "eslint-plugin-eslint-plugin": "^6.0.0",
-    "eslint-plugin-internal-rules": "file:tools/internal-rules",
-    "eslint-plugin-jsdoc": "^48.2.3",
-    "eslint-plugin-n": "^17.2.0",
-    "eslint-plugin-unicorn": "^52.0.0",
     "eslint-release": "^3.2.2",
+    "eslint-rule-composer": "^0.3.0",
     "eslump": "^3.0.0",
     "esprima": "^4.0.1",
     "fast-glob": "^3.2.11",
@@ -136,13 +131,13 @@
     "got": "^11.8.3",
     "gray-matter": "^4.0.3",
     "js-yaml": "^4.1.0",
-    "knip": "^5.8.0",
+    "knip": "^5.21.0",
     "lint-staged": "^11.0.0",
     "load-perf": "^0.2.0",
     "markdown-it": "^12.2.0",
     "markdown-it-container": "^3.0.0",
     "markdownlint": "^0.34.0",
-    "markdownlint-cli": "^0.40.0",
+    "markdownlint-cli": "^0.41.0",
     "marked": "^4.0.8",
     "metascraper": "^5.25.7",
     "metascraper-description": "^5.25.7",