eslint 9.39.1 → 10.0.0-alpha.1

package/lib/rules/utils/ast-utils.js

@@ -544,28 +544,6 @@ function negate(f) {
 	return token => !f(token);
 }
 
-/**
- * Checks whether or not a node has a `@this` tag in its comments.
- * @param {ASTNode} node A node to check.
- * @param {SourceCode} sourceCode A SourceCode instance to get comments.
- * @returns {boolean} Whether or not the node has a `@this` tag in its comments.
- */
-function hasJSDocThisTag(node, sourceCode) {
-	const jsdocComment = sourceCode.getJSDocComment(node);
-
-	if (jsdocComment && thisTagPattern.test(jsdocComment.value)) {
-		return true;
-	}
-
-	// Checks `@this` in its leading comments for callbacks,
-	// because callbacks don't have its JSDoc comment.
-	// e.g.
-	//     sinon.test(/* @this sinon.Sandbox */function() { this.spy(); });
-	return sourceCode
-		.getCommentsBefore(node)
-		.some(comment => thisTagPattern.test(comment.value));
-}
-
 /**
  * Determines if a node is surrounded by parentheses.
  * @param {SourceCode} sourceCode The ESLint source code object
@@ -725,6 +703,120 @@ function isKeywordToken(token) {
 	return token.type === "Keyword";
 }
 
+/**
+ * Check to see if its a ES6 export declaration.
+ * @param {ASTNode} astNode An AST node.
+ * @returns {boolean} whether the given node represents an export declaration.
+ * @private
+ */
+function looksLikeExport(astNode) {
+	return (
+		astNode.type === "ExportDefaultDeclaration" ||
+		astNode.type === "ExportNamedDeclaration" ||
+		astNode.type === "ExportAllDeclaration" ||
+		astNode.type === "ExportSpecifier"
+	);
+}
+
+/**
+ * Retrieves the JSDoc comment for a given node.
+ * @param {ASTNode} node The AST node to get the comment for.
+ * @param {SourceCode} sourceCode A SourceCode instance to get comments.
+ * @returns {Token|null} The Block comment token containing the JSDoc comment for the given node or null if not found.
+ * @private
+ */
+function getJSDocComment(node, sourceCode) {
+	/**
+	 * Checks for the presence of a JSDoc comment for the given node and returns it.
+	 * @param {ASTNode} astNode The AST node to get the comment for.
+	 * @returns {Token|null} The Block comment token containing the JSDoc comment for the given node or null if not found.
+	 * @private
+	 */
+	function findJSDocComment(astNode) {
+		const tokenBefore = sourceCode.getTokenBefore(astNode, {
+			includeComments: true,
+		});
+
+		if (
+			tokenBefore &&
+			isCommentToken(tokenBefore) &&
+			tokenBefore.type === "Block" &&
+			tokenBefore.value.charAt(0) === "*" &&
+			astNode.loc.start.line - tokenBefore.loc.end.line <= 1
+		) {
+			return tokenBefore;
+		}
+
+		return null;
+	}
+	let parent = node.parent;
+
+	switch (node.type) {
+		case "ClassDeclaration":
+		case "FunctionDeclaration":
+			return findJSDocComment(looksLikeExport(parent) ? parent : node);
+
+		case "ClassExpression":
+			return findJSDocComment(parent.parent);
+
+		case "ArrowFunctionExpression":
+		case "FunctionExpression":
+			if (
+				parent.type !== "CallExpression" &&
+				parent.type !== "NewExpression"
+			) {
+				while (
+					!sourceCode.getCommentsBefore(parent).length &&
+					!/Function/u.test(parent.type) &&
+					parent.type !== "MethodDefinition" &&
+					parent.type !== "Property"
+				) {
+					parent = parent.parent;
+
+					if (!parent) {
+						break;
+					}
+				}
+
+				if (
+					parent &&
+					parent.type !== "FunctionDeclaration" &&
+					parent.type !== "Program"
+				) {
+					return findJSDocComment(parent);
+				}
+			}
+
+			return findJSDocComment(node);
+
+		// falls through
+		default:
+			return null;
+	}
+}
+
+/**
+ * Checks whether or not a node has a `@this` tag in its comments.
+ * @param {ASTNode} node A node to check.
+ * @param {SourceCode} sourceCode A SourceCode instance to get comments.
+ * @returns {boolean} Whether or not the node has a `@this` tag in its comments.
+ */
+function hasJSDocThisTag(node, sourceCode) {
+	const jsdocComment = getJSDocComment(node, sourceCode);
+
+	if (jsdocComment && thisTagPattern.test(jsdocComment.value)) {
+		return true;
+	}
+
+	// Checks `@this` in its leading comments for callbacks,
+	// because callbacks don't have its JSDoc comment.
+	// e.g.
+	//     sinon.test(/* @this sinon.Sandbox */function() { this.spy(); });
+	return sourceCode
+		.getCommentsBefore(node)
+		.some(comment => thisTagPattern.test(comment.value));
+}
+
 /**
  * Gets the `(` token of the given function node.
  * @param {ASTNode} node The function node to get.

package/lib/rules/yield-star-spacing.js

@@ -96,8 +96,7 @@ module.exports = {
 		 */
 		function checkSpacing(side, leftToken, rightToken) {
 			if (
-				sourceCode.isSpaceBetweenTokens(leftToken, rightToken) !==
-				mode[side]
+				sourceCode.isSpaceBetween(leftToken, rightToken) !== mode[side]
 			) {
 				const after = leftToken.value === "*";
 				const spaceRequired = mode[side];

package/lib/services/parser-service.js

@@ -51,7 +51,6 @@ class ParserService {
 			ok: false,
 			errors: result.errors.map(error => ({
 				ruleId: null,
-				nodeType: null,
 				fatal: true,
 				severity: 2,
 				message: `Parsing error: ${error.message}`,

package/lib/services/processor-service.js

@@ -57,7 +57,6 @@ class ProcessorService {
 						message,
 						line: ex.lineNumber,
 						column: ex.column,
-						nodeType: null,
 					},
 				],
 			};

package/lib/services/warning-service.js

@@ -59,17 +59,6 @@ class WarningService {
 		);
 	}
 
-	/**
-	 * Emits a warning when the ESLINT_USE_FLAT_CONFIG environment variable is set to "false".
-	 * @returns {void}
-	 */
-	emitESLintRCWarning() {
-		this.emitWarning(
-			"You are using an eslintrc configuration file, which is deprecated and support will be removed in v10.0.0. Please migrate to an eslint.config.js file. See https://eslint.org/docs/latest/use/configure/migration-guide for details. An eslintrc configuration file is used because you have the ESLINT_USE_FLAT_CONFIG environment variable set to false. If you want to use an eslint.config.js file, remove the environment variable. If you want to find the location of the eslintrc configuration file, use the --debug flag.",
-			"ESLintRCWarning",
-		);
-	}
-
 	/**
 	 * Emits a warning when an inactive flag is used.
 	 * This method is used by the Linter and is safe to call outside Node.js.

package/lib/shared/flags.js

@@ -28,10 +28,6 @@
 const activeFlags = new Map([
 	["test_only", "Used only for testing."],
 	["test_only_2", "Used only for testing."],
-	[
-		"v10_config_lookup_from_file",
-		"Look up `eslint.config.js` from the file being linted.",
-	],
 	[
 		"unstable_native_nodejs_ts_config",
 		"Use native Node.js to load TypeScript configuration.",
@@ -66,21 +62,6 @@ const inactiveFlags = new Map([
 				"Used only for testing flags whose features have been abandoned.",
 		},
 	],
-	[
-		"unstable_ts_config",
-		{
-			description: "Enable TypeScript configuration files.",
-			replacedBy: null,
-		},
-	],
-	[
-		"unstable_config_lookup_from_file",
-		{
-			description:
-				"Look up `eslint.config.js` from the file being linted.",
-			replacedBy: "v10_config_lookup_from_file",
-		},
-	],
 ]);
 
 /**

package/lib/shared/translate-cli-options.js

@@ -19,7 +19,6 @@ const { ModuleImporter } = require("@humanwhocodes/module-importer");
 //------------------------------------------------------------------------------
 
 /** @typedef {import("../types").ESLint.Options} ESLintOptions */
-/** @typedef {import("../types").ESLint.LegacyOptions} LegacyESLintOptions */
 /** @typedef {import("../types").Linter.LintMessage} LintMessage */
 /** @typedef {import("../options").ParsedCLIOptions} ParsedCLIOptions */
 /** @typedef {import("../types").ESLint.Plugin} Plugin */
@@ -85,196 +84,139 @@ function quietRuleFilter(rule) {
 /**
  * Translates the CLI options into the options expected by the ESLint constructor.
  * @param {ParsedCLIOptions} cliOptions The CLI options to translate.
- * @param {"flat"|"eslintrc"} [configType="eslintrc"] The format of the config to generate.
- * @returns {Promise<ESLintOptions | LegacyESLintOptions>} The options object for the ESLint constructor.
+ * @returns {Promise<ESLintOptions>} The options object for the ESLint constructor.
  */
-async function translateOptions(
-	{
-		cache,
-		cacheFile,
-		cacheLocation,
-		cacheStrategy,
-		concurrency,
-		config,
-		configLookup,
-		env,
-		errorOnUnmatchedPattern,
-		eslintrc,
-		ext,
-		fix,
-		fixDryRun,
-		fixType,
-		flag,
-		global,
-		ignore,
-		ignorePath,
-		ignorePattern,
-		inlineConfig,
-		parser,
-		parserOptions,
-		plugin,
-		quiet,
-		reportUnusedDisableDirectives,
-		reportUnusedDisableDirectivesSeverity,
-		reportUnusedInlineConfigs,
-		resolvePluginsRelativeTo,
-		rule,
-		rulesdir,
-		stats,
-		warnIgnored,
-		passOnNoPatterns,
-		maxWarnings,
-	},
-	configType,
-) {
-	let overrideConfig, overrideConfigFile;
+async function translateOptions({
+	cache,
+	cacheFile,
+	cacheLocation,
+	cacheStrategy,
+	concurrency,
+	config,
+	configLookup,
+	errorOnUnmatchedPattern,
+	ext,
+	fix,
+	fixDryRun,
+	fixType,
+	flag,
+	global,
+	ignore,
+	ignorePattern,
+	inlineConfig,
+	parser,
+	parserOptions,
+	plugin,
+	quiet,
+	reportUnusedDisableDirectives,
+	reportUnusedDisableDirectivesSeverity,
+	reportUnusedInlineConfigs,
+	rule,
+	stats,
+	warnIgnored,
+	passOnNoPatterns,
+	maxWarnings,
+}) {
 	const importer = new ModuleImporter();
 
-	if (configType === "flat") {
-		overrideConfigFile =
-			typeof config === "string" ? config : !configLookup;
-		if (overrideConfigFile === false) {
-			overrideConfigFile = void 0;
-		}
-
-		const languageOptions = {};
-
-		if (global) {
-			languageOptions.globals = global.reduce((obj, name) => {
-				if (name.endsWith(":true")) {
-					obj[name.slice(0, -5)] = "writable";
-				} else {
-					obj[name] = "readonly";
-				}
-				return obj;
-			}, {});
-		}
+	let overrideConfigFile =
+		typeof config === "string" ? config : !configLookup;
+	if (overrideConfigFile === false) {
+		overrideConfigFile = void 0;
+	}
 
-		if (parserOptions) {
-			languageOptions.parserOptions = parserOptions;
-		}
+	const languageOptions = {};
 
-		if (parser) {
-			languageOptions.parser = await importer.import(parser);
-		}
+	if (global) {
+		languageOptions.globals = global.reduce((obj, name) => {
+			if (name.endsWith(":true")) {
+				obj[name.slice(0, -5)] = "writable";
+			} else {
+				obj[name] = "readonly";
+			}
+			return obj;
+		}, {});
+	}
 
-		overrideConfig = [
-			{
-				...(Object.keys(languageOptions).length > 0
-					? { languageOptions }
-					: {}),
-				rules: rule ? rule : {},
-			},
-		];
+	if (parserOptions) {
+		languageOptions.parserOptions = parserOptions;
+	}
 
-		if (
-			reportUnusedDisableDirectives ||
-			reportUnusedDisableDirectivesSeverity !== void 0
-		) {
-			overrideConfig[0].linterOptions = {
-				reportUnusedDisableDirectives: reportUnusedDisableDirectives
-					? "error"
-					: normalizeSeverityToString(
-							reportUnusedDisableDirectivesSeverity,
-						),
-			};
-		}
+	if (parser) {
+		languageOptions.parser = await importer.import(parser);
+	}
 
-		if (reportUnusedInlineConfigs !== void 0) {
-			overrideConfig[0].linterOptions = {
-				...overrideConfig[0].linterOptions,
-				reportUnusedInlineConfigs: normalizeSeverityToString(
-					reportUnusedInlineConfigs,
-				),
-			};
-		}
+	const overrideConfig = [
+		{
+			...(Object.keys(languageOptions).length > 0
+				? { languageOptions }
+				: {}),
+			rules: rule ? rule : {},
+		},
+	];
+
+	if (
+		reportUnusedDisableDirectives ||
+		reportUnusedDisableDirectivesSeverity !== void 0
+	) {
+		overrideConfig[0].linterOptions = {
+			reportUnusedDisableDirectives: reportUnusedDisableDirectives
+				? "error"
+				: normalizeSeverityToString(
+						reportUnusedDisableDirectivesSeverity,
+					),
+		};
+	}
 
-		if (plugin) {
-			overrideConfig[0].plugins = await loadPlugins(importer, plugin);
-		}
+	if (reportUnusedInlineConfigs !== void 0) {
+		overrideConfig[0].linterOptions = {
+			...overrideConfig[0].linterOptions,
+			reportUnusedInlineConfigs: normalizeSeverityToString(
+				reportUnusedInlineConfigs,
+			),
+		};
+	}
 
-		if (ext) {
-			overrideConfig.push({
-				files: ext.map(
-					extension =>
-						`**/*${extension.startsWith(".") ? "" : "."}${extension}`,
-				),
-			});
-		}
-	} else {
-		overrideConfigFile = config;
+	if (plugin) {
+		overrideConfig[0].plugins = await loadPlugins(importer, plugin);
+	}
 
-		overrideConfig = {
-			env:
-				env &&
-				env.reduce((obj, name) => {
-					obj[name] = true;
-					return obj;
-				}, {}),
-			globals:
-				global &&
-				global.reduce((obj, name) => {
-					if (name.endsWith(":true")) {
-						obj[name.slice(0, -5)] = "writable";
-					} else {
-						obj[name] = "readonly";
-					}
-					return obj;
-				}, {}),
-			ignorePatterns: ignorePattern,
-			parser,
-			parserOptions,
-			plugins: plugin,
-			rules: rule,
-		};
+	if (ext) {
+		overrideConfig.push({
+			files: ext.map(
+				extension =>
+					`**/*${extension.startsWith(".") ? "" : "."}${extension}`,
+			),
+		});
 	}
 
+	/*
+	 * For performance reasons rules not marked as 'error' are filtered out in quiet mode. As maxWarnings
+	 * requires rules set to 'warn' to be run, we only filter out 'warn' rules if maxWarnings is not specified.
+	 */
+	const ruleFilter =
+		quiet && maxWarnings === -1 ? quietRuleFilter : () => true;
+
 	const options = {
 		allowInlineConfig: inlineConfig,
 		cache,
 		cacheLocation: cacheLocation || cacheFile,
 		cacheStrategy,
+		concurrency,
 		errorOnUnmatchedPattern,
 		fix: (fix || fixDryRun) && (quiet ? quietFixPredicate : true),
 		fixTypes: fixType,
+		flags: flag,
 		ignore,
+		ignorePatterns: ignorePattern,
 		overrideConfig,
 		overrideConfigFile,
 		passOnNoPatterns,
+		ruleFilter,
+		stats,
+		warnIgnored,
 	};
 
-	if (configType === "flat") {
-		options.concurrency = concurrency;
-		options.flags = flag;
-		options.ignorePatterns = ignorePattern;
-		options.stats = stats;
-		options.warnIgnored = warnIgnored;
-
-		/*
-		 * For performance reasons rules not marked as 'error' are filtered out in quiet mode. As maxWarnings
-		 * requires rules set to 'warn' to be run, we only filter out 'warn' rules if maxWarnings is not specified.
-		 */
-		options.ruleFilter =
-			quiet && maxWarnings === -1 ? quietRuleFilter : () => true;
-	} else {
-		options.resolvePluginsRelativeTo = resolvePluginsRelativeTo;
-		options.rulePaths = rulesdir;
-		options.useEslintrc = eslintrc;
-		options.extensions = ext;
-		options.ignorePath = ignorePath;
-		if (
-			reportUnusedDisableDirectives ||
-			reportUnusedDisableDirectivesSeverity !== void 0
-		) {
-			options.reportUnusedDisableDirectives =
-				reportUnusedDisableDirectives
-					? "error"
-					: normalizeSeverityToString(
-							reportUnusedDisableDirectivesSeverity,
-						);
-		}
-	}
-
 	return options;
 }