eslint 9.39.1 → 10.0.0-alpha.0

package/lib/rules/radix.js

@@ -15,9 +15,6 @@ const astUtils = require("./utils/ast-utils");
 // Helpers
 //------------------------------------------------------------------------------
 
-const MODE_ALWAYS = "always",
-	MODE_AS_NEEDED = "as-needed";
-
 const validRadixValues = new Set(
 	Array.from({ length: 37 - 2 }, (_, index) => index + 2),
 );
@@ -63,15 +60,6 @@ function isValidRadix(radix) {
 	);
 }
 
-/**
- * Checks whether a given node is a default value of radix or not.
- * @param {ASTNode} radix A node of radix to check.
- * @returns {boolean} `true` if the node is the literal node of `10`.
- */
-function isDefaultRadix(radix) {
-	return radix.type === "Literal" && radix.value === 10;
-}
-
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -81,11 +69,9 @@ module.exports = {
 	meta: {
 		type: "suggestion",
 
-		defaultOptions: [MODE_ALWAYS],
-
 		docs: {
 			description:
-				"Enforce the consistent use of the radix argument when using `parseInt()`",
+				"Enforce the use of the radix argument when using `parseInt()`",
 			recommended: false,
 			url: "https://eslint.org/docs/latest/rules/radix",
 		},
@@ -93,6 +79,7 @@ module.exports = {
 		hasSuggestions: true,
 
 		schema: [
+			// deprecated
 			{
 				enum: ["always", "as-needed"],
 			},
@@ -100,7 +87,6 @@ module.exports = {
 
 		messages: {
 			missingParameters: "Missing parameters.",
-			redundantRadix: "Redundant radix parameter.",
 			missingRadix: "Missing radix parameter.",
 			invalidRadix:
 				"Invalid radix parameter, must be an integer between 2 and 36.",
@@ -110,7 +96,6 @@ module.exports = {
 	},
 
 	create(context) {
-		const [mode] = context.options;
 		const sourceCode = context.sourceCode;
 
 		/**
@@ -131,41 +116,33 @@ module.exports = {
 					break;
 
 				case 1:
-					if (mode === MODE_ALWAYS) {
-						context.report({
-							node,
-							messageId: "missingRadix",
-							suggest: [
-								{
-									messageId: "addRadixParameter10",
-									fix(fixer) {
-										const tokens =
-											sourceCode.getTokens(node);
-										const lastToken = tokens.at(-1); // Parenthesis.
-										const secondToLastToken = tokens.at(-2); // May or may not be a comma.
-										const hasTrailingComma =
-											secondToLastToken.type ===
-												"Punctuator" &&
-											secondToLastToken.value === ",";
-
-										return fixer.insertTextBefore(
-											lastToken,
-											hasTrailingComma ? " 10," : ", 10",
-										);
-									},
+					context.report({
+						node,
+						messageId: "missingRadix",
+						suggest: [
+							{
+								messageId: "addRadixParameter10",
+								fix(fixer) {
+									const tokens = sourceCode.getTokens(node);
+									const lastToken = tokens.at(-1); // Parenthesis.
+									const secondToLastToken = tokens.at(-2); // May or may not be a comma.
+									const hasTrailingComma =
+										secondToLastToken.type ===
+											"Punctuator" &&
+										secondToLastToken.value === ",";
+
+									return fixer.insertTextBefore(
+										lastToken,
+										hasTrailingComma ? " 10," : ", 10",
+									);
 								},
-							],
-						});
-					}
+							},
+						],
+					});
 					break;
 
 				default:
-					if (mode === MODE_AS_NEEDED && isDefaultRadix(args[1])) {
-						context.report({
-							node,
-							messageId: "redundantRadix",
-						});
-					} else if (!isValidRadix(args[1])) {
+					if (!isValidRadix(args[1])) {
 						context.report({
 							node,
 							messageId: "invalidRadix",

package/lib/services/parser-service.js

@@ -51,7 +51,6 @@ class ParserService {
 			ok: false,
 			errors: result.errors.map(error => ({
 				ruleId: null,
-				nodeType: null,
 				fatal: true,
 				severity: 2,
 				message: `Parsing error: ${error.message}`,

package/lib/services/processor-service.js

@@ -57,7 +57,6 @@ class ProcessorService {
 						message,
 						line: ex.lineNumber,
 						column: ex.column,
-						nodeType: null,
 					},
 				],
 			};

package/lib/services/warning-service.js

@@ -59,17 +59,6 @@ class WarningService {
 		);
 	}
 
-	/**
-	 * Emits a warning when the ESLINT_USE_FLAT_CONFIG environment variable is set to "false".
-	 * @returns {void}
-	 */
-	emitESLintRCWarning() {
-		this.emitWarning(
-			"You are using an eslintrc configuration file, which is deprecated and support will be removed in v10.0.0. Please migrate to an eslint.config.js file. See https://eslint.org/docs/latest/use/configure/migration-guide for details. An eslintrc configuration file is used because you have the ESLINT_USE_FLAT_CONFIG environment variable set to false. If you want to use an eslint.config.js file, remove the environment variable. If you want to find the location of the eslintrc configuration file, use the --debug flag.",
-			"ESLintRCWarning",
-		);
-	}
-
 	/**
 	 * Emits a warning when an inactive flag is used.
 	 * This method is used by the Linter and is safe to call outside Node.js.

package/lib/shared/flags.js

@@ -28,10 +28,6 @@
 const activeFlags = new Map([
 	["test_only", "Used only for testing."],
 	["test_only_2", "Used only for testing."],
-	[
-		"v10_config_lookup_from_file",
-		"Look up `eslint.config.js` from the file being linted.",
-	],
 	[
 		"unstable_native_nodejs_ts_config",
 		"Use native Node.js to load TypeScript configuration.",
@@ -66,21 +62,6 @@ const inactiveFlags = new Map([
 				"Used only for testing flags whose features have been abandoned.",
 		},
 	],
-	[
-		"unstable_ts_config",
-		{
-			description: "Enable TypeScript configuration files.",
-			replacedBy: null,
-		},
-	],
-	[
-		"unstable_config_lookup_from_file",
-		{
-			description:
-				"Look up `eslint.config.js` from the file being linted.",
-			replacedBy: "v10_config_lookup_from_file",
-		},
-	],
 ]);
 
 /**

package/lib/shared/translate-cli-options.js

@@ -19,7 +19,6 @@ const { ModuleImporter } = require("@humanwhocodes/module-importer");
 //------------------------------------------------------------------------------
 
 /** @typedef {import("../types").ESLint.Options} ESLintOptions */
-/** @typedef {import("../types").ESLint.LegacyOptions} LegacyESLintOptions */
 /** @typedef {import("../types").Linter.LintMessage} LintMessage */
 /** @typedef {import("../options").ParsedCLIOptions} ParsedCLIOptions */
 /** @typedef {import("../types").ESLint.Plugin} Plugin */
@@ -85,196 +84,139 @@ function quietRuleFilter(rule) {
 /**
  * Translates the CLI options into the options expected by the ESLint constructor.
  * @param {ParsedCLIOptions} cliOptions The CLI options to translate.
- * @param {"flat"|"eslintrc"} [configType="eslintrc"] The format of the config to generate.
- * @returns {Promise<ESLintOptions | LegacyESLintOptions>} The options object for the ESLint constructor.
+ * @returns {Promise<ESLintOptions>} The options object for the ESLint constructor.
  */
-async function translateOptions(
-	{
-		cache,
-		cacheFile,
-		cacheLocation,
-		cacheStrategy,
-		concurrency,
-		config,
-		configLookup,
-		env,
-		errorOnUnmatchedPattern,
-		eslintrc,
-		ext,
-		fix,
-		fixDryRun,
-		fixType,
-		flag,
-		global,
-		ignore,
-		ignorePath,
-		ignorePattern,
-		inlineConfig,
-		parser,
-		parserOptions,
-		plugin,
-		quiet,
-		reportUnusedDisableDirectives,
-		reportUnusedDisableDirectivesSeverity,
-		reportUnusedInlineConfigs,
-		resolvePluginsRelativeTo,
-		rule,
-		rulesdir,
-		stats,
-		warnIgnored,
-		passOnNoPatterns,
-		maxWarnings,
-	},
-	configType,
-) {
-	let overrideConfig, overrideConfigFile;
+async function translateOptions({
+	cache,
+	cacheFile,
+	cacheLocation,
+	cacheStrategy,
+	concurrency,
+	config,
+	configLookup,
+	errorOnUnmatchedPattern,
+	ext,
+	fix,
+	fixDryRun,
+	fixType,
+	flag,
+	global,
+	ignore,
+	ignorePattern,
+	inlineConfig,
+	parser,
+	parserOptions,
+	plugin,
+	quiet,
+	reportUnusedDisableDirectives,
+	reportUnusedDisableDirectivesSeverity,
+	reportUnusedInlineConfigs,
+	rule,
+	stats,
+	warnIgnored,
+	passOnNoPatterns,
+	maxWarnings,
+}) {
 	const importer = new ModuleImporter();
 
-	if (configType === "flat") {
-		overrideConfigFile =
-			typeof config === "string" ? config : !configLookup;
-		if (overrideConfigFile === false) {
-			overrideConfigFile = void 0;
-		}
-
-		const languageOptions = {};
-
-		if (global) {
-			languageOptions.globals = global.reduce((obj, name) => {
-				if (name.endsWith(":true")) {
-					obj[name.slice(0, -5)] = "writable";
-				} else {
-					obj[name] = "readonly";
-				}
-				return obj;
-			}, {});
-		}
+	let overrideConfigFile =
+		typeof config === "string" ? config : !configLookup;
+	if (overrideConfigFile === false) {
+		overrideConfigFile = void 0;
+	}
 
-		if (parserOptions) {
-			languageOptions.parserOptions = parserOptions;
-		}
+	const languageOptions = {};
 
-		if (parser) {
-			languageOptions.parser = await importer.import(parser);
-		}
+	if (global) {
+		languageOptions.globals = global.reduce((obj, name) => {
+			if (name.endsWith(":true")) {
+				obj[name.slice(0, -5)] = "writable";
+			} else {
+				obj[name] = "readonly";
+			}
+			return obj;
+		}, {});
+	}
 
-		overrideConfig = [
-			{
-				...(Object.keys(languageOptions).length > 0
-					? { languageOptions }
-					: {}),
-				rules: rule ? rule : {},
-			},
-		];
+	if (parserOptions) {
+		languageOptions.parserOptions = parserOptions;
+	}
 
-		if (
-			reportUnusedDisableDirectives ||
-			reportUnusedDisableDirectivesSeverity !== void 0
-		) {
-			overrideConfig[0].linterOptions = {
-				reportUnusedDisableDirectives: reportUnusedDisableDirectives
-					? "error"
-					: normalizeSeverityToString(
-							reportUnusedDisableDirectivesSeverity,
-						),
-			};
-		}
+	if (parser) {
+		languageOptions.parser = await importer.import(parser);
+	}
 
-		if (reportUnusedInlineConfigs !== void 0) {
-			overrideConfig[0].linterOptions = {
-				...overrideConfig[0].linterOptions,
-				reportUnusedInlineConfigs: normalizeSeverityToString(
-					reportUnusedInlineConfigs,
-				),
-			};
-		}
+	const overrideConfig = [
+		{
+			...(Object.keys(languageOptions).length > 0
+				? { languageOptions }
+				: {}),
+			rules: rule ? rule : {},
+		},
+	];
+
+	if (
+		reportUnusedDisableDirectives ||
+		reportUnusedDisableDirectivesSeverity !== void 0
+	) {
+		overrideConfig[0].linterOptions = {
+			reportUnusedDisableDirectives: reportUnusedDisableDirectives
+				? "error"
+				: normalizeSeverityToString(
+						reportUnusedDisableDirectivesSeverity,
+					),
+		};
+	}
 
-		if (plugin) {
-			overrideConfig[0].plugins = await loadPlugins(importer, plugin);
-		}
+	if (reportUnusedInlineConfigs !== void 0) {
+		overrideConfig[0].linterOptions = {
+			...overrideConfig[0].linterOptions,
+			reportUnusedInlineConfigs: normalizeSeverityToString(
+				reportUnusedInlineConfigs,
+			),
+		};
+	}
 
-		if (ext) {
-			overrideConfig.push({
-				files: ext.map(
-					extension =>
-						`**/*${extension.startsWith(".") ? "" : "."}${extension}`,
-				),
-			});
-		}
-	} else {
-		overrideConfigFile = config;
+	if (plugin) {
+		overrideConfig[0].plugins = await loadPlugins(importer, plugin);
+	}
 
-		overrideConfig = {
-			env:
-				env &&
-				env.reduce((obj, name) => {
-					obj[name] = true;
-					return obj;
-				}, {}),
-			globals:
-				global &&
-				global.reduce((obj, name) => {
-					if (name.endsWith(":true")) {
-						obj[name.slice(0, -5)] = "writable";
-					} else {
-						obj[name] = "readonly";
-					}
-					return obj;
-				}, {}),
-			ignorePatterns: ignorePattern,
-			parser,
-			parserOptions,
-			plugins: plugin,
-			rules: rule,
-		};
+	if (ext) {
+		overrideConfig.push({
+			files: ext.map(
+				extension =>
+					`**/*${extension.startsWith(".") ? "" : "."}${extension}`,
+			),
+		});
 	}
 
+	/*
+	 * For performance reasons rules not marked as 'error' are filtered out in quiet mode. As maxWarnings
+	 * requires rules set to 'warn' to be run, we only filter out 'warn' rules if maxWarnings is not specified.
+	 */
+	const ruleFilter =
+		quiet && maxWarnings === -1 ? quietRuleFilter : () => true;
+
 	const options = {
 		allowInlineConfig: inlineConfig,
 		cache,
 		cacheLocation: cacheLocation || cacheFile,
 		cacheStrategy,
+		concurrency,
 		errorOnUnmatchedPattern,
 		fix: (fix || fixDryRun) && (quiet ? quietFixPredicate : true),
 		fixTypes: fixType,
+		flags: flag,
 		ignore,
+		ignorePatterns: ignorePattern,
 		overrideConfig,
 		overrideConfigFile,
 		passOnNoPatterns,
+		ruleFilter,
+		stats,
+		warnIgnored,
 	};
 
-	if (configType === "flat") {
-		options.concurrency = concurrency;
-		options.flags = flag;
-		options.ignorePatterns = ignorePattern;
-		options.stats = stats;
-		options.warnIgnored = warnIgnored;
-
-		/*
-		 * For performance reasons rules not marked as 'error' are filtered out in quiet mode. As maxWarnings
-		 * requires rules set to 'warn' to be run, we only filter out 'warn' rules if maxWarnings is not specified.
-		 */
-		options.ruleFilter =
-			quiet && maxWarnings === -1 ? quietRuleFilter : () => true;
-	} else {
-		options.resolvePluginsRelativeTo = resolvePluginsRelativeTo;
-		options.rulePaths = rulesdir;
-		options.useEslintrc = eslintrc;
-		options.extensions = ext;
-		options.ignorePath = ignorePath;
-		if (
-			reportUnusedDisableDirectives ||
-			reportUnusedDisableDirectivesSeverity !== void 0
-		) {
-			options.reportUnusedDisableDirectives =
-				reportUnusedDisableDirectives
-					? "error"
-					: normalizeSeverityToString(
-							reportUnusedDisableDirectivesSeverity,
-						);
-		}
-	}
-
 	return options;
 }
 

package/lib/types/index.d.ts

@@ -72,7 +72,6 @@ import type {
 	SuggestedEdit,
 	ViolationReport,
 } from "@eslint/core";
-import { LegacyESLint } from "./use-at-your-own-risk.js";
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -134,6 +133,8 @@ export namespace Scope {
 		acquire(node: ESTree.Node, inner?: boolean): Scope | null;
 
 		getDeclaredVariables(node: ESTree.Node): Variable[];
+
+		addGlobals(names: string[]): void;
 	}
 
 	interface Scope {
@@ -785,7 +786,7 @@ export namespace Rule {
 	type ReportFixer = CoreRuleFixer;
 
 	/** @deprecated Use `ReportDescriptorOptions` instead. */
-	type ReportDescriptorOptionsBase = ViolationReportBase;
+	type ReportDescriptorOptionsBase = Omit<ViolationReportBase, "suggest">;
 
 	type SuggestionReportOptions = SuggestedEditBase;
 	type SuggestionDescriptorMessage = SuggestionMessage;
@@ -794,9 +795,9 @@ export namespace Rule {
 	// redundant with ReportDescriptorOptionsBase but kept for clarity
 	type ReportDescriptorOptions = ViolationReportBase;
 
-	type ReportDescriptor = ViolationReport<ESTree.Node>;
+	type ReportDescriptor = ViolationReport<JSSyntaxElement>;
 	type ReportDescriptorMessage = ViolationMessage;
-	type ReportDescriptorLocation = ViolationLocation<ESTree.Node>;
+	type ReportDescriptorLocation = ViolationLocation<JSSyntaxElement>;
 
 	type RuleFixer = RuleTextEditor<ESTree.Node | AST.Token>;
 	type Fix = RuleTextEdit;
@@ -823,10 +824,7 @@ export class Linter {
 
 	version: string;
 
-	constructor(options?: {
-		cwd?: string | undefined;
-		configType?: "flat" | "eslintrc";
-	});
+	constructor(options?: { cwd?: string | undefined; configType?: "flat" });
 
 	verify(
 		code: SourceCode | string,
@@ -852,14 +850,6 @@ export class Linter {
 
 	getSourceCode(): SourceCode;
 
-	defineRule(name: string, rule: Rule.RuleModule): void;
-
-	defineRules(rules: { [name: string]: Rule.RuleModule }): void;
-
-	getRules(): Map<string, Rule.RuleModule>;
-
-	defineParser(name: string, parser: Linter.Parser): void;
-
 	getTimes(): Linter.Stats["times"];
 
 	getFixPassCount(): Linter.Stats["fixPasses"];
@@ -1233,39 +1223,6 @@ export namespace ESLint {
 		flags?: string[] | undefined;
 	}
 
-	interface LegacyOptions {
-		// File enumeration
-		cwd?: string | undefined;
-		errorOnUnmatchedPattern?: boolean | undefined;
-		extensions?: string[] | undefined;
-		globInputPaths?: boolean | undefined;
-		ignore?: boolean | undefined;
-		ignorePath?: string | undefined;
-
-		// Linting
-		allowInlineConfig?: boolean | undefined;
-		baseConfig?: Linter.LegacyConfig | undefined;
-		overrideConfig?: Linter.LegacyConfig | undefined;
-		overrideConfigFile?: string | undefined;
-		plugins?: Record<string, Plugin> | undefined;
-		reportUnusedDisableDirectives?: Linter.StringSeverity | undefined;
-		resolvePluginsRelativeTo?: string | undefined;
-		rulePaths?: string[] | undefined;
-		useEslintrc?: boolean | undefined;
-
-		// Autofix
-		fix?: boolean | ((message: Linter.LintMessage) => boolean) | undefined;
-		fixTypes?: FixType[] | null | undefined;
-
-		// Cache-related
-		cache?: boolean | undefined;
-		cacheLocation?: string | undefined;
-		cacheStrategy?: CacheStrategy | undefined;
-
-		// Other Options
-		flags?: string[] | undefined;
-	}
-
 	/** A linting result. */
 	interface LintResult {
 		/** The path to the file that was linted. */
@@ -1396,15 +1353,9 @@ export namespace ESLint {
 
 // #endregion
 
-export function loadESLint(options: {
-	useFlatConfig: true;
-}): Promise<typeof ESLint>;
-export function loadESLint(options: {
-	useFlatConfig: false;
-}): Promise<typeof LegacyESLint>;
 export function loadESLint(options?: {
 	useFlatConfig?: boolean | undefined;
-}): Promise<typeof ESLint | typeof LegacyESLint>;
+}): Promise<typeof ESLint>;
 
 // #region RuleTester
 
@@ -1457,10 +1408,6 @@ export namespace RuleTester {
 	interface TestCaseError {
 		message?: string | RegExp;
 		messageId?: string;
-		/**
-		 * @deprecated `type` is deprecated and will be removed in the next major version.
-		 */
-		type?: string | undefined;
 		data?: any;
 		line?: number | undefined;
 		column?: number | undefined;

package/lib/types/rules.d.ts

@@ -3783,7 +3783,7 @@ export interface ESLintRules extends Linter.RulesRecord {
 		[
 			Partial<{
 				/**
-				 * @default false
+				 * @default true
 				 */
 				reportGlobalThis: boolean;
 			}>,
@@ -3914,6 +3914,9 @@ export interface ESLintRules extends Linter.RulesRecord {
 	/**
 	 * Rule to disallow `let` or `var` variables that are read but never assigned.
 	 *
+	 * @remarks
+	 * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
+	 *
 	 * @since 9.27.0
 	 * @see https://eslint.org/docs/latest/rules/no-unassigned-vars
 	 */
@@ -4279,6 +4282,9 @@ export interface ESLintRules extends Linter.RulesRecord {
 	/**
 	 * Rule to disallow variable assignments when the value is not used.
 	 *
+	 * @remarks
+	 * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
+	 *
 	 * @since 9.0.0-alpha.1
 	 * @see https://eslint.org/docs/latest/rules/no-useless-assignment
 	 */
@@ -4944,6 +4950,9 @@ export interface ESLintRules extends Linter.RulesRecord {
 	/**
 	 * Rule to disallow losing originally caught error when re-throwing custom errors.
 	 *
+	 * @remarks
+	 * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
+	 *
 	 * @since 9.35.0
 	 * @see https://eslint.org/docs/latest/rules/preserve-caught-error
 	 */
@@ -5026,7 +5035,7 @@ export interface ESLintRules extends Linter.RulesRecord {
 	>;
 
 	/**
-	 * Rule to enforce the consistent use of the radix argument when using `parseInt()`.
+	 * Rule to enforce the use of the radix argument when using `parseInt()`.
 	 *
 	 * @since 0.0.7
 	 * @see https://eslint.org/docs/latest/rules/radix