eslint 9.37.0 → 9.39.0

package/README.md

@@ -287,6 +287,11 @@ fnx
 Josh Goldberg ✨
 </a>
 </td><td align="center" valign="top" width="11%">
+<a href="https://github.com/SwetaTanwar">
+<img src="https://github.com/SwetaTanwar.png?s=75" width="75" height="75" alt="Sweta Tanwar's Avatar"><br />
+Sweta Tanwar
+</a>
+</td><td align="center" valign="top" width="11%">
 <a href="https://github.com/Tanujkanti4441">
 <img src="https://github.com/Tanujkanti4441.png?s=75" width="75" height="75" alt="Tanuj Kanti's Avatar"><br />
 Tanuj Kanti
@@ -296,6 +301,11 @@ Tanuj Kanti
 <img src="https://github.com/lumirlumir.png?s=75" width="75" height="75" alt="루밀LuMir's Avatar"><br />
 루밀LuMir
 </a>
+</td><td align="center" valign="top" width="11%">
+<a href="https://github.com/Pixel998">
+<img src="https://github.com/Pixel998.png?s=75" width="75" height="75" alt="Pixel998's Avatar"><br />
+Pixel998
+</a>
 </td></tr></tbody></table>
 
 ### Website Team
@@ -332,8 +342,8 @@ to get your logo on our READMEs and [website](https://eslint.org/sponsors).
 <h3>Platinum Sponsors</h3>
 <p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="128"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="128"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://qlty.sh/"><img src="https://images.opencollective.com/qltysh/33d157d/logo.png" alt="Qlty Software" height="96"></a> <a href="https://trunk.io/"><img src="https://images.opencollective.com/trunkio/fb92d60/avatar.png" alt="trunk.io" height="96"></a> <a href="https://shopify.engineering/"><img src="https://avatars.githubusercontent.com/u/8085" alt="Shopify" height="96"></a></p><h3>Silver Sponsors</h3>
-<p><a href="https://vite.dev/"><img src="https://images.opencollective.com/vite/e6d15e1/logo.png" alt="Vite" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301" alt="American Express" height="64"></a> <a href="https://stackblitz.com"><img src="https://avatars.githubusercontent.com/u/28635252" alt="StackBlitz" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
+<p><a href="https://vite.dev/"><img src="https://images.opencollective.com/vite/e6d15e1/logo.png" alt="Vite" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/2d6c3b6/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301" alt="American Express" height="64"></a> <a href="https://stackblitz.com"><img src="https://avatars.githubusercontent.com/u/28635252" alt="StackBlitz" height="64"></a></p><h3>Bronze Sponsors</h3>
+<p><a href="https://syntax.fm"><img src="https://github.com/syntaxfm.png" alt="Syntax" height="32"></a> <a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://sentry.io"><img src="https://github.com/getsentry.png" alt="Sentry" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
 <h3>Technology Sponsors</h3>
 Technology sponsors allow us to use their products and services for free as part of a contribution to the open source ecosystem and our work.
 <p><a href="https://netlify.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/netlify-icon.svg" alt="Netlify" height="32"></a> <a href="https://algolia.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/algolia-icon.svg" alt="Algolia" height="32"></a> <a href="https://1password.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/1password-icon.svg" alt="1Password" height="32"></a></p>

package/lib/eslint/eslint-helpers.js

@@ -506,7 +506,7 @@ async function globMultiSearch({
  * @param {boolean} args.globInputPaths true to interpret glob patterns,
  *      false to not interpret glob patterns.
  * @param {string} args.cwd The current working directory to find from.
- * @param {ConfigLoader|LegacyConfigLoader} args.configLoader The config loeader for the current run.
+ * @param {ConfigLoader|LegacyConfigLoader} args.configLoader The config loader for the current run.
  * @param {boolean} args.errorOnUnmatchedPattern Determines if an unmatched pattern
  *      should throw an error.
  * @returns {Promise<Array<string>>} The fully resolved file paths.

package/lib/eslint/eslint.js

@@ -17,6 +17,7 @@ const { pathToFileURL } = require("node:url");
 const { SHARE_ENV, Worker } = require("node:worker_threads");
 const { version } = require("../../package.json");
 const { defaultConfig } = require("../config/default-config");
+const timing = require("../linter/timing");
 
 const {
 	createDebug,
@@ -503,6 +504,11 @@ async function runWorkers(
 					worstNetLintingRatio,
 					netLintingRatio,
 				);
+
+				if (timing.enabled && indexedResults.timings) {
+					timing.mergeData(indexedResults.timings);
+				}
+
 				for (const result of indexedResults) {
 					const { index } = result;
 					delete result.index;
@@ -522,7 +528,17 @@ async function runWorkers(
 	for (let index = 0; index < workerCount; ++index) {
 		promises[index] = new Promise(workerExecutor);
 	}
-	await Promise.all(promises);
+
+	try {
+		await Promise.all(promises);
+	} catch (error) {
+		/*
+		 * If any worker fails, suppress timing display in the main thread
+		 * to avoid printing partial or misleading timing output.
+		 */
+		timing.disableDisplay();
+		throw error;
+	}
 
 	if (worstNetLintingRatio < LOW_NET_LINTING_RATIO) {
 		warnOnLowNetLintingRatio();

package/lib/eslint/worker.js

@@ -29,6 +29,7 @@ const {
 	processOptions,
 } = require("./eslint-helpers");
 const { WarningService } = require("../services/warning-service");
+const timing = require("../linter/timing");
 
 const depsLoadedTime = hrtimeBigint();
 
@@ -39,7 +40,7 @@ const depsLoadedTime = hrtimeBigint();
 /** @typedef {import("../types").ESLint.LintResult} LintResult */
 /** @typedef {import("../types").ESLint.Options} ESLintOptions */
 /** @typedef {LintResult & { index?: number; }} IndexedLintResult */
-/** @typedef {IndexedLintResult[] & { netLintingDuration: bigint; }} WorkerLintResults */
+/** @typedef {IndexedLintResult[] & { netLintingDuration: bigint; timings?: Record<string, number>; }} WorkerLintResults */
 /**
  * @typedef {Object} WorkerData - Data passed to the worker thread.
  * @property {ESLintOptions | string} eslintOptionsOrURL - The unprocessed ESLint options or the URL of the options module.
@@ -57,6 +58,12 @@ const debug = createDebug(`eslint:worker:thread-${threadId}`);
 // Main
 //------------------------------------------------------------------------------
 
+/*
+ * Prevent timing module from printing profiling output from worker threads.
+ * The main thread is responsible for displaying any aggregated timings.
+ */
+timing.disableDisplay();
+
 debug("Dependencies loaded in %t", depsLoadedTime - startTime);
 
 (async () => {
@@ -158,5 +165,9 @@ debug("Dependencies loaded in %t", depsLoadedTime - startTime);
 	indexedResults.netLintingDuration =
 		lintingDuration - loadConfigTotalDuration - readFileCounter.duration;
 
+	if (timing.enabled) {
+		indexedResults.timings = timing.getData();
+	}
+
 	parentPort.postMessage(indexedResults);
 })();

package/lib/linter/file-report.js

@@ -426,7 +426,7 @@ function validateSuggestions(suggest, messages) {
 
 			if (typeof suggestion.fix !== "function") {
 				throw new TypeError(
-					`context.report() called with a suggest option without a fix function. See: ${suggestion}`,
+					`context.report() called with a suggest option without a fix function. See: ${JSON.stringify(suggestion, null, 2)}`,
 				);
 			}
 		});

package/lib/linter/source-code-traverser.js

@@ -17,8 +17,9 @@ const vk = require("eslint-visitor-keys");
 //-----------------------------------------------------------------------------
 
 /**
- * @import { ESQueryParsedSelector } from "./esquery.js";
  * @import { Language, SourceCode } from "@eslint/core";
+ * @import { ESQueryOptions } from "esquery";
+ * @import { ESQueryParsedSelector } from "./esquery.js";
  * @import { SourceCodeVisitor } from "./source-code-visitor.js";
  */
 
@@ -47,11 +48,10 @@ class ESQueryHelper {
 	 * Creates a new instance.
 	 * @param {SourceCodeVisitor} visitor The visitor containing the functions to call.
 	 * @param {ESQueryOptions} esqueryOptions `esquery` options for traversing custom nodes.
-	 * @returns {NodeEventGenerator} new instance
 	 */
 	constructor(visitor, esqueryOptions) {
 		/**
-		 * The emitter to use during traversal.
+		 * The visitor to use during traversal.
 		 * @type {SourceCodeVisitor}
 		 */
 		this.visitor = visitor;
@@ -288,7 +288,10 @@ class SourceCodeTraverser {
 									false,
 								)
 								.forEach(selector => {
-									visitor.callSync(selector, step.target);
+									visitor.callSync(
+										selector,
+										...(step.args ?? [step.target]),
+									);
 								});
 							currentAncestry.unshift(step.target);
 						} else {
@@ -300,7 +303,10 @@ class SourceCodeTraverser {
 									true,
 								)
 								.forEach(selector => {
-									visitor.callSync(selector, step.target);
+									visitor.callSync(
+										selector,
+										...(step.args ?? [step.target]),
+									);
 								});
 						}
 					} catch (err) {

package/lib/linter/timing.js

@@ -131,6 +131,7 @@ function display(data) {
 /* c8 ignore next */
 module.exports = (function () {
 	const data = Object.create(null);
+	let displayEnabled = true;
 
 	/**
 	 * Time the run
@@ -158,9 +159,42 @@ module.exports = (function () {
 		};
 	}
 
+	/**
+	 * Returns a shallow copy of the collected timings data.
+	 * @returns {Record<string, number>} mapping of ruleId to total time in ms
+	 */
+	function getData() {
+		return { ...data };
+	}
+
+	/**
+	 * Merges rule timing totals collected elsewhere into this process' totals.
+	 * @param {Record<string, number>} dataToMerge mapping of ruleId to total time in ms
+	 * @returns {void}
+	 */
+	function mergeData(dataToMerge) {
+		for (const [key, value] of Object.entries(dataToMerge)) {
+			if (typeof data[key] === "undefined") {
+				data[key] = 0;
+			}
+			data[key] += value;
+		}
+	}
+
+	/**
+	 * Disables printing of timing data on process exit.
+	 * Intended for worker threads or non-main contexts.
+	 * @returns {void}
+	 */
+	function disableDisplay() {
+		displayEnabled = false;
+	}
+
 	if (enabled) {
 		process.on("exit", () => {
-			display(data);
+			if (displayEnabled && Object.keys(data).length > 0) {
+				display(data);
+			}
 		});
 	}
 
@@ -168,5 +202,8 @@ module.exports = (function () {
 		time,
 		enabled,
 		getListSize,
+		getData,
+		mergeData,
+		disableDisplay,
 	};
 })();

package/lib/rules/callback-return.js

@@ -16,7 +16,7 @@ module.exports = {
 			message: "Node.js rules were moved out of ESLint core.",
 			url: "https://eslint.org/docs/latest/use/migrating-to-7.0.0#deprecate-node-rules",
 			deprecatedSince: "7.0.0",
-			availableUntil: null,
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/complexity.js

@@ -68,6 +68,7 @@ module.exports = {
 	},
 
 	create(context) {
+		const sourceCode = context.sourceCode;
 		const option = context.options[0];
 		let threshold = THRESHOLD_DEFAULT;
 		let VARIANT = "classic";
@@ -171,17 +172,21 @@ module.exports = {
 
 				if (complexity > threshold) {
 					let name;
+					let loc = node.loc;
 
 					if (codePath.origin === "class-field-initializer") {
 						name = "class field initializer";
 					} else if (codePath.origin === "class-static-block") {
 						name = "class static block";
+						loc = sourceCode.getFirstToken(node).loc;
 					} else {
 						name = astUtils.getFunctionNameWithKind(node);
+						loc = astUtils.getFunctionHeadLoc(node, sourceCode);
 					}
 
 					context.report({
 						node,
+						loc,
 						messageId: "complex",
 						data: {
 							name: upperCaseFirst(name),

package/lib/rules/for-direction.js

@@ -46,7 +46,10 @@ module.exports = {
 		 */
 		function report(node) {
 			context.report({
-				node,
+				loc: {
+					start: node.loc.start,
+					end: sourceCode.getTokenBefore(node.body).loc.end,
+				},
 				messageId: "incorrectDirection",
 			});
 		}

package/lib/rules/global-require.js

@@ -60,7 +60,7 @@ module.exports = {
 			message: "Node.js rules were moved out of ESLint core.",
 			url: "https://eslint.org/docs/latest/use/migrating-to-7.0.0#deprecate-node-rules",
 			deprecatedSince: "7.0.0",
-			availableUntil: null,
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/handle-callback-err.js

@@ -17,7 +17,7 @@ module.exports = {
 			message: "Node.js rules were moved out of ESLint core.",
 			url: "https://eslint.org/docs/latest/use/migrating-to-7.0.0#deprecate-node-rules",
 			deprecatedSince: "7.0.0",
-			availableUntil: null,
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/id-blacklist.js

@@ -101,7 +101,7 @@ module.exports = {
 			message: "The rule was renamed.",
 			url: "https://eslint.org/blog/2020/07/eslint-v7.5.0-released/#deprecating-id-blacklist",
 			deprecatedSince: "7.5.0",
-			availableUntil: null,
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					rule: {

package/lib/rules/no-buffer-constructor.js

@@ -16,7 +16,7 @@ module.exports = {
 			message: "Node.js rules were moved out of ESLint core.",
 			url: "https://eslint.org/docs/latest/use/migrating-to-7.0.0#deprecate-node-rules",
 			deprecatedSince: "7.0.0",
-			availableUntil: null,
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/no-catch-shadow.js

@@ -32,7 +32,7 @@ module.exports = {
 			message: "This rule was renamed.",
 			url: "https://eslint.org/blog/2018/07/eslint-v5.1.0-released/",
 			deprecatedSince: "5.1.0",
-			availableUntil: null,
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					rule: {

package/lib/rules/no-dupe-args.js

@@ -5,6 +5,12 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -58,10 +64,15 @@ module.exports = {
 
 				// Checks and reports duplications.
 				const defs = variable.defs.filter(isParameter);
+				const loc = {
+					start: astUtils.getOpeningParenOfParams(node, sourceCode)
+						.loc.start,
+					end: sourceCode.getTokenBefore(node.body).loc.end,
+				};
 
 				if (defs.length >= 2) {
 					context.report({
-						node,
+						loc,
 						messageId: "unexpected",
 						data: { name: variable.name },
 					});

package/lib/rules/no-dupe-class-members.js

@@ -106,7 +106,7 @@ module.exports = {
 
 				if (isDuplicate) {
 					context.report({
-						node,
+						loc: node.key.loc,
 						messageId: "unexpected",
 						data: { name },
 					});