eslint 9.35.0 → 9.37.0

package/lib/rules/no-tabs.js

@@ -24,7 +24,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/no-trailing-spaces.js

@@ -30,7 +30,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/no-whitespace-before-property.js

@@ -22,7 +22,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/nonblock-statement-body-position.js

@@ -18,7 +18,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/object-curly-newline.js

@@ -162,7 +162,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/object-curly-spacing.js

@@ -18,7 +18,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/object-property-newline.js

@@ -17,7 +17,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/one-var-declaration-per-line.js

@@ -16,7 +16,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/operator-linebreak.js

@@ -23,7 +23,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/padded-blocks.js

@@ -23,7 +23,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/padding-line-between-statements.js

@@ -393,7 +393,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/preserve-caught-error.js

@@ -10,9 +10,15 @@
 
 const astUtils = require("./utils/ast-utils");
 
-//----------------------------------------------------------------------
+//------------------------------------------------------------------------------
+// Types
+//------------------------------------------------------------------------------
+
+/** @typedef {import("estree").Node} ASTNode */
+
+//------------------------------------------------------------------------------
 // Helpers
-//----------------------------------------------------------------------
+//------------------------------------------------------------------------------
 
 /*
  * This is an indicator of an error cause node, that is too complicated to be detected and fixed.
@@ -32,9 +38,11 @@ const BUILT_IN_ERROR_TYPES = new Set([
 ]);
 
 /**
- * Finds and returns the ASTNode that is used as the `cause` of the Error being thrown
+ * Finds and returns information about the `cause` property of an error being thrown.
  * @param {ASTNode} throwStatement `ThrowStatement` to be checked.
- * @returns {ASTNode | UNKNOWN_CAUSE | null} The `cause` of `Error` being thrown, `null` if not set.
+ * @returns {{ value: ASTNode; multipleDefinitions: boolean; } | UNKNOWN_CAUSE | null}
+ * Information about the `cause` of the error being thrown, such as the value node and
+ * whether there are multiple definitions of `cause`. `null` if there is no `cause`.
  */
 function getErrorCause(throwStatement) {
 	const throwExpression = throwStatement.argument;
@@ -73,15 +81,17 @@ function getErrorCause(throwStatement) {
 				return UNKNOWN_CAUSE;
 			}
 
-			const causeProperty = errorOptions.properties.find(
-				prop =>
-					prop.type === "Property" &&
-					prop.key.type === "Identifier" &&
-					prop.key.name === "cause" &&
-					!prop.computed, // It is hard to accurately identify the value of computed props
+			const causeProperties = errorOptions.properties.filter(
+				prop => astUtils.getStaticPropertyName(prop) === "cause",
 			);
 
-			return causeProperty ? causeProperty.value : null;
+			const causeProperty = causeProperties.at(-1);
+			return causeProperty
+				? {
+						value: causeProperty.value,
+						multipleDefinitions: causeProperties.length > 1,
+					}
+				: null;
 		}
 
 		// Error options exist, but too complicated to be analyzed/fixed
@@ -138,6 +148,13 @@ function findParentCatch(node) {
 module.exports = {
 	meta: {
 		type: "suggestion",
+
+		defaultOptions: [
+			{
+				requireCatchParameter: false,
+			},
+		],
+
 		docs: {
 			description:
 				"Disallow losing originally caught error when re-throwing custom errors",
@@ -158,7 +175,6 @@ module.exports = {
 				properties: {
 					requireCatchParameter: {
 						type: "boolean",
-						default: false,
 						description:
 							"Requires the catch blocks to always have the caught error parameter so it is not discarded.",
 					},
@@ -185,7 +201,7 @@ module.exports = {
 
 	create(context) {
 		const sourceCode = context.sourceCode;
-		const options = context.options[0] || {};
+		const [{ requireCatchParameter }] = context.options;
 
 		//----------------------------------------------------------------------
 		// Helpers
@@ -273,7 +289,7 @@ module.exports = {
 
 					// Check if there are throw statements and caught error is being ignored
 					if (!caughtError) {
-						if (options.requireCatchParameter) {
+						if (requireCatchParameter) {
 							context.report({
 								node: throwStatement,
 								messageId: "missingCatchErrorParam",
@@ -284,14 +300,14 @@ module.exports = {
 					}
 
 					// Check if there is a cause attached to the new error
-					const thrownErrorCause = getErrorCause(throwStatement);
+					const errorCauseInfo = getErrorCause(throwStatement);
 
-					if (thrownErrorCause === UNKNOWN_CAUSE) {
+					if (errorCauseInfo === UNKNOWN_CAUSE) {
 						// Error options exist, but too complicated to be analyzed/fixed
 						return;
 					}
 
-					if (thrownErrorCause === null) {
+					if (errorCauseInfo === null) {
 						// If there is no `cause` attached to the error being thrown.
 						context.report({
 							messageId: "missingCause",
@@ -433,42 +449,52 @@ module.exports = {
 						return;
 					}
 
-					// If there is an attached cause, verify that is matches the caught error
+					const { value: thrownErrorCause } = errorCauseInfo;
+
+					// If there is an attached cause, verify that it matches the caught error
 					if (
 						!(
 							thrownErrorCause.type === "Identifier" &&
 							thrownErrorCause.name === caughtError.name
 						)
 					) {
-						context.report({
-							messageId: "incorrectCause",
-							node: thrownErrorCause,
-							suggest: [
-								{
-									messageId: "includeCause",
-									fix(fixer) {
-										/*
-										 * In case `cause` is attached using object property shorthand or as a method.
-										 * e.g. throw Error("fail", { cause });
-										 *      throw Error("fail", { cause() { // do something } });
-										 */
-										if (
-											thrownErrorCause.parent.method ||
-											thrownErrorCause.parent.shorthand
-										) {
+						const suggest = errorCauseInfo.multipleDefinitions
+							? null // If there are multiple `cause` definitions, a suggestion could be confusing.
+							: [
+									{
+										messageId: "includeCause",
+										fix(fixer) {
+											/*
+											 * In case `cause` is attached using object property shorthand or as a method or accessor.
+											 * e.g. throw Error("fail", { cause });
+											 *      throw Error("fail", { cause() { doSomething(); } });
+											 *      throw Error("fail", { get cause() { return error; } });
+											 */
+											if (
+												thrownErrorCause.parent
+													.method ||
+												thrownErrorCause.parent
+													.shorthand ||
+												thrownErrorCause.parent.kind !==
+													"init"
+											) {
+												return fixer.replaceText(
+													thrownErrorCause.parent,
+													`cause: ${caughtError.name}`,
+												);
+											}
+
 											return fixer.replaceText(
-												thrownErrorCause.parent,
-												`cause: ${caughtError.name}`,
+												thrownErrorCause,
+												caughtError.name,
 											);
-										}
-
-										return fixer.replaceText(
-											thrownErrorCause,
-											caughtError.name,
-										);
+										},
 									},
-								},
-							],
+								];
+						context.report({
+							messageId: "incorrectCause",
+							node: thrownErrorCause,
+							suggest,
 						});
 						return;
 					}

package/lib/rules/quote-props.js

@@ -24,7 +24,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/quotes.js

@@ -101,7 +101,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/require-unicode-regexp.js

@@ -47,6 +47,8 @@ module.exports = {
 	meta: {
 		type: "suggestion",
 
+		defaultOptions: [{}],
+
 		docs: {
 			description:
 				"Enforce the use of `u` or `v` flag on regular expressions",
@@ -79,7 +81,7 @@ module.exports = {
 	create(context) {
 		const sourceCode = context.sourceCode;
 
-		const { requireFlag } = context.options[0] ?? {};
+		const [{ requireFlag }] = context.options;
 
 		return {
 			"Literal[regex]"(node) {

package/lib/rules/rest-spread-spacing.js

@@ -17,7 +17,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/semi-spacing.js

@@ -19,7 +19,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/semi-style.js

@@ -89,7 +89,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/semi.js

@@ -23,7 +23,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/space-before-blocks.js

@@ -42,7 +42,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/space-before-function-paren.js

@@ -22,7 +22,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/space-in-parens.js

@@ -18,7 +18,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/space-infix-ops.js

@@ -18,7 +18,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/space-unary-ops.js

@@ -22,7 +22,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/spaced-comment.js

@@ -147,7 +147,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/switch-colon-spacing.js

@@ -23,7 +23,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/template-curly-spacing.js

@@ -23,7 +23,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/template-tag-spacing.js

@@ -17,7 +17,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/wrap-iife.js

@@ -44,7 +44,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/wrap-regex.js

@@ -17,7 +17,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/rules/yield-star-spacing.js

@@ -17,7 +17,7 @@ module.exports = {
 			message: "Formatting rules are being moved out of ESLint core.",
 			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
 			deprecatedSince: "8.53.0",
-			availableUntil: "10.0.0",
+			availableUntil: "11.0.0",
 			replacedBy: [
 				{
 					message:

package/lib/types/index.d.ts

@@ -47,12 +47,14 @@ export namespace AST {
 		| "Boolean"
 		| "Null"
 		| "Identifier"
+		| "PrivateIdentifier"
 		| "Keyword"
 		| "Punctuator"
 		| "JSXIdentifier"
 		| "JSXText"
 		| "Numeric"
 		| "String"
+		| "Template"
 		| "RegularExpression";
 
 	interface Token {
@@ -92,6 +94,8 @@ export namespace Scope {
 			| "block"
 			| "catch"
 			| "class"
+			| "class-field-initializer"
+			| "class-static-block"
 			| "for"
 			| "function"
 			| "function-expression-name"
@@ -1961,7 +1965,7 @@ export class ESLint {
 
 	calculateConfigForFile(filePath: string): Promise<any>;
 
-	findConfigFile(): Promise<string | undefined>;
+	findConfigFile(filePath?: string): Promise<string | undefined>;
 
 	isPathIgnored(filePath: string): Promise<boolean>;
 
@@ -2043,7 +2047,7 @@ export namespace ESLint {
 
 		// Autofix
 		fix?: boolean | ((message: Linter.LintMessage) => boolean) | undefined;
-		fixTypes?: FixType[] | undefined;
+		fixTypes?: FixType[] | null | undefined;
 
 		// Cache-related
 		cache?: boolean | undefined;
@@ -2077,7 +2081,7 @@ export namespace ESLint {
 
 		// Autofix
 		fix?: boolean | ((message: Linter.LintMessage) => boolean) | undefined;
-		fixTypes?: FixType[] | undefined;
+		fixTypes?: FixType[] | null | undefined;
 
 		// Cache-related
 		cache?: boolean | undefined;
@@ -2166,9 +2170,10 @@ export namespace ESLint {
 
 		/**
 		 * The raw deprecated info provided by the rule.
-		 * Unset if the rule's `meta.deprecated` property is a boolean.
+		 * - Undefined if the rule's `meta.deprecated` property is a boolean.
+		 * - Unset when using the legacy eslintrc configuration.
 		 */
-		info?: DeprecatedInfo;
+		info?: DeprecatedInfo | undefined;
 	}
 
 	/**