eslint 9.34.0 → 9.36.0

package/README.md

@@ -277,6 +277,11 @@ Nitin Kumar
 The people who review and fix bugs and help triage issues.
 
 <table><tbody><tr><td align="center" valign="top" width="11%">
+<a href="https://github.com/DMartens">
+<img src="https://github.com/DMartens.png?s=75" width="75" height="75" alt="fnx's Avatar"><br />
+fnx
+</a>
+</td><td align="center" valign="top" width="11%">
 <a href="https://github.com/JoshuaKGoldberg">
 <img src="https://github.com/JoshuaKGoldberg.png?s=75" width="75" height="75" alt="Josh Goldberg ✨'s Avatar"><br />
 Josh Goldberg ✨
@@ -328,7 +333,7 @@ to get your logo on our READMEs and [website](https://eslint.org/sponsors).
 <p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="128"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="128"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://qlty.sh/"><img src="https://images.opencollective.com/qltysh/33d157d/logo.png" alt="Qlty Software" height="96"></a> <a href="https://trunk.io/"><img src="https://images.opencollective.com/trunkio/fb92d60/avatar.png" alt="trunk.io" height="96"></a> <a href="https://shopify.engineering/"><img src="https://avatars.githubusercontent.com/u/8085" alt="Shopify" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://vite.dev/"><img src="https://images.opencollective.com/vite/e6d15e1/logo.png" alt="Vite" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301" alt="American Express" height="64"></a> <a href="https://stackblitz.com"><img src="https://avatars.githubusercontent.com/u/28635252" alt="StackBlitz" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://sentry.io"><img src="https://github.com/getsentry.png" alt="Sentry" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
+<p><a href="https://syntax.fm"><img src="https://github.com/syntaxfm.png" alt="Syntax" height="32"></a> <a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://sentry.io"><img src="https://github.com/getsentry.png" alt="Sentry" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
 <h3>Technology Sponsors</h3>
 Technology sponsors allow us to use their products and services for free as part of a contribution to the open source ecosystem and our work.
 <p><a href="https://netlify.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/netlify-icon.svg" alt="Netlify" height="32"></a> <a href="https://algolia.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/algolia-icon.svg" alt="Algolia" height="32"></a> <a href="https://1password.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/1password-icon.svg" alt="1Password" height="32"></a></p>

package/lib/eslint/eslint.js

@@ -263,11 +263,15 @@ async function locateConfigFileToUse({ configFile, cwd }) {
 
 /**
  * Creates an error to be thrown when an array of results passed to `getRulesMetaForResults` was not created by the current engine.
+ * @param {Error|undefined} cause The original error that led to this symptom error being thrown. Might not always be available.
  * @returns {TypeError} An error object.
  */
-function createExtraneousResultsError() {
+function createExtraneousResultsError(cause) {
 	return new TypeError(
 		"Results object was not created from this ESLint instance.",
+		{
+			cause,
+		},
 	);
 }
 
@@ -543,7 +547,7 @@ function validateOptionCloneability(options) {
 		})
 		.sort();
 	const error = new TypeError(
-		`The ${uncloneableOptionKeys.length === 1 ? "option" : "options"} ${new Intl.ListFormat("en-US").format(uncloneableOptionKeys.map(key => `"${key}"`))} cannot be cloned. When concurrency is enabled, all options must be cloneable. Remove uncloneable options or use an options module.`,
+		`The ${uncloneableOptionKeys.length === 1 ? "option" : "options"} ${new Intl.ListFormat("en-US").format(uncloneableOptionKeys.map(key => `"${key}"`))} cannot be cloned. When concurrency is enabled, all options must be cloneable values (JSON values). Remove uncloneable options or use an options module.`,
 	);
 	error.code = "ESLINT_UNCLONEABLE_OPTIONS";
 	throw error;
@@ -773,8 +777,8 @@ class ESLint {
 				try {
 					configs =
 						configLoader.getCachedConfigArrayForFile(filePath);
-				} catch {
-					throw createExtraneousResultsError();
+				} catch (err) {
+					throw createExtraneousResultsError(err);
 				}
 
 				const config = configs.getConfig(filePath);

package/lib/linter/esquery.js

@@ -271,6 +271,9 @@ function tryParseSelector(selector) {
 		) {
 			throw new SyntaxError(
 				`Syntax error in selector "${selector}" at position ${err.location.start.offset}: ${err.message}`,
+				{
+					cause: err,
+				},
 			);
 		}
 		throw err;

package/lib/rule-tester/rule-tester.js

@@ -851,6 +851,9 @@ class RuleTester {
 				} catch (err) {
 					throw new Error(
 						`Schema for rule ${ruleName} is invalid: ${err.message}`,
+						{
+							cause: err,
+						},
 					);
 				}
 			}

package/lib/rules/array-callback-return.js

@@ -233,7 +233,6 @@ module.exports = {
 			url: "https://eslint.org/docs/latest/rules/array-callback-return",
 		},
 
-		// eslint-disable-next-line eslint-plugin/require-meta-has-suggestions -- false positive
 		hasSuggestions: true,
 
 		schema: [

package/lib/rules/index.js

@@ -293,6 +293,7 @@ module.exports = new LazyLoadingRuleMap(
 		"prefer-rest-params": () => require("./prefer-rest-params"),
 		"prefer-spread": () => require("./prefer-spread"),
 		"prefer-template": () => require("./prefer-template"),
+		"preserve-caught-error": () => require("./preserve-caught-error"),
 		"quote-props": () => require("./quote-props"),
 		quotes: () => require("./quotes"),
 		radix: () => require("./radix"),

package/lib/rules/no-empty-function.js

@@ -105,6 +105,7 @@ module.exports = {
 	meta: {
 		dialects: ["javascript", "typescript"],
 		language: "javascript",
+		hasSuggestions: true,
 		type: "suggestion",
 
 		defaultOptions: [{ allow: [] }],
@@ -131,6 +132,7 @@ module.exports = {
 
 		messages: {
 			unexpected: "Unexpected empty {{name}}.",
+			suggestComment: "Add comment inside empty {{name}}.",
 		},
 	},
 
@@ -204,6 +206,23 @@ module.exports = {
 					loc: node.body.loc,
 					messageId: "unexpected",
 					data: { name },
+					suggest: [
+						{
+							messageId: "suggestComment",
+							data: { name },
+							fix(fixer) {
+								const range = [
+									node.body.range[0] + 1,
+									node.body.range[1] - 1,
+								];
+
+								return fixer.replaceTextRange(
+									range,
+									" /* empty */ ",
+								);
+							},
+						},
+					],
 				});
 			}
 		}

package/lib/rules/no-empty-static-block.js

@@ -11,6 +11,7 @@
 /** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
+		hasSuggestions: true,
 		type: "suggestion",
 
 		docs: {
@@ -23,6 +24,7 @@ module.exports = {
 
 		messages: {
 			unexpected: "Unexpected empty static block.",
+			suggestComment: "Add comment inside empty static block.",
 		},
 	},
 
@@ -32,14 +34,36 @@ module.exports = {
 		return {
 			StaticBlock(node) {
 				if (node.body.length === 0) {
+					const openingBrace = sourceCode.getFirstToken(node, {
+						skip: 1,
+					});
 					const closingBrace = sourceCode.getLastToken(node);
 
 					if (
 						sourceCode.getCommentsBefore(closingBrace).length === 0
 					) {
 						context.report({
-							node,
+							loc: {
+								start: openingBrace.loc.start,
+								end: closingBrace.loc.end,
+							},
 							messageId: "unexpected",
+							suggest: [
+								{
+									messageId: "suggestComment",
+									fix(fixer) {
+										const range = [
+											openingBrace.range[1],
+											closingBrace.range[0],
+										];
+
+										return fixer.replaceTextRange(
+											range,
+											" /* empty */ ",
+										);
+									},
+								},
+							],
 						});
 					}
 				}

package/lib/rules/no-empty.js

@@ -104,10 +104,47 @@ module.exports = {
 					typeof node.cases === "undefined" ||
 					node.cases.length === 0
 				) {
+					const openingBrace = sourceCode.getTokenAfter(
+						node.discriminant,
+						astUtils.isOpeningBraceToken,
+					);
+
+					const closingBrace = sourceCode.getLastToken(node);
+
+					if (
+						sourceCode.commentsExistBetween(
+							openingBrace,
+							closingBrace,
+						)
+					) {
+						return;
+					}
+
 					context.report({
 						node,
+						loc: {
+							start: openingBrace.loc.start,
+							end: closingBrace.loc.end,
+						},
 						messageId: "unexpected",
 						data: { type: "switch" },
+						suggest: [
+							{
+								messageId: "suggestComment",
+								data: { type: "switch" },
+								fix(fixer) {
+									const range = [
+										openingBrace.range[1],
+										closingBrace.range[0],
+									];
+
+									return fixer.replaceTextRange(
+										range,
+										" /* empty */ ",
+									);
+								},
+							},
+						],
 					});
 				}
 			},

package/lib/rules/no-eval.js

@@ -226,7 +226,9 @@ module.exports = {
 
 			Program(node) {
 				const scope = sourceCode.getScope(node),
-					features = context.parserOptions.ecmaFeatures || {},
+					features =
+						context.languageOptions.parserOptions.ecmaFeatures ||
+						{},
 					strict =
 						scope.isStrict ||
 						node.sourceType === "module" ||

package/lib/rules/no-loss-of-precision.js

@@ -189,7 +189,7 @@ module.exports = {
 		 * @returns {boolean} true if they do not match
 		 */
 		function baseTenLosesPrecision(node) {
-			const rawNumber = getRaw(node);
+			const rawNumber = getRaw(node).toLowerCase();
 
 			/*
 			 * If trailing zeros equal the exponent, this is a valid representation

package/lib/rules/no-misleading-character-class.js

@@ -278,6 +278,12 @@ module.exports = {
 	meta: {
 		type: "problem",
 
+		defaultOptions: [
+			{
+				allowEscape: false,
+			},
+		],
+
 		docs: {
 			description:
 				"Disallow characters which are made with multiple code points in character class syntax",
@@ -293,7 +299,6 @@ module.exports = {
 				properties: {
 					allowEscape: {
 						type: "boolean",
-						default: false,
 					},
 				},
 				additionalProperties: false,
@@ -313,7 +318,7 @@ module.exports = {
 		},
 	},
 	create(context) {
-		const allowEscape = context.options[0]?.allowEscape;
+		const [{ allowEscape }] = context.options;
 		const sourceCode = context.sourceCode;
 		const parser = new RegExpParser();
 		const checkedPatternNodes = new Set();