eslint 9.31.0 → 9.37.0

package/README.md

@@ -13,7 +13,7 @@
 [Contribute to ESLint](https://eslint.org/docs/latest/contribute) |
 [Report Bugs](https://eslint.org/docs/latest/contribute/report-bugs) |
 [Code of Conduct](https://eslint.org/conduct) |
-[Twitter](https://twitter.com/geteslint) |
+[X](https://x.com/geteslint) |
 [Discord](https://eslint.org/chat) |
 [Mastodon](https://fosstodon.org/@eslint) |
 [Bluesky](https://bsky.app/profile/eslint.org)
@@ -277,6 +277,11 @@ Nitin Kumar
 The people who review and fix bugs and help triage issues.
 
 <table><tbody><tr><td align="center" valign="top" width="11%">
+<a href="https://github.com/DMartens">
+<img src="https://github.com/DMartens.png?s=75" width="75" height="75" alt="fnx's Avatar"><br />
+fnx
+</a>
+</td><td align="center" valign="top" width="11%">
 <a href="https://github.com/JoshuaKGoldberg">
 <img src="https://github.com/JoshuaKGoldberg.png?s=75" width="75" height="75" alt="Josh Goldberg ✨'s Avatar"><br />
 Josh Goldberg ✨
@@ -324,12 +329,11 @@ Percy Ma
 The following companies, organizations, and individuals support ESLint's ongoing maintenance and development. [Become a Sponsor](https://eslint.org/donate)
 to get your logo on our READMEs and [website](https://eslint.org/sponsors).
 
-<h3>Diamond Sponsors</h3>
-<p><a href="https://www.ag-grid.com/"><img src="https://images.opencollective.com/ag-grid/bec0580/logo.png" alt="AG Grid" height="128"></a></p><h3>Platinum Sponsors</h3>
+<h3>Platinum Sponsors</h3>
 <p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="128"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="128"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://qlty.sh/"><img src="https://images.opencollective.com/qltysh/33d157d/logo.png" alt="Qlty Software" height="96"></a> <a href="https://trunk.io/"><img src="https://images.opencollective.com/trunkio/fb92d60/avatar.png" alt="trunk.io" height="96"></a> <a href="https://shopify.engineering/"><img src="https://avatars.githubusercontent.com/u/8085" alt="Shopify" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://vite.dev/"><img src="https://images.opencollective.com/vite/e6d15e1/logo.png" alt="Vite" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301" alt="American Express" height="64"></a> <a href="https://stackblitz.com"><img src="https://avatars.githubusercontent.com/u/28635252" alt="StackBlitz" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://sentry.io"><img src="https://github.com/getsentry.png" alt="Sentry" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
+<p><a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
 <h3>Technology Sponsors</h3>
 Technology sponsors allow us to use their products and services for free as part of a contribution to the open source ecosystem and our work.
 <p><a href="https://netlify.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/netlify-icon.svg" alt="Netlify" height="32"></a> <a href="https://algolia.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/algolia-icon.svg" alt="Algolia" height="32"></a> <a href="https://1password.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/1password-icon.svg" alt="1Password" height="32"></a></p>

package/lib/cli-engine/file-enumerator.js

@@ -51,7 +51,7 @@ const debug = require("debug")("eslint:file-enumerator");
 //------------------------------------------------------------------------------
 
 const minimatchOpts = { dot: true, matchBase: true };
-const dotfilesPattern = /(?:(?:^\.)|(?:[/\\]\.))[^/\\.].*/u;
+const dotfilesPattern = /(?:^\.|[/\\]\.)[^/\\.].*/u;
 const NONE = 0;
 const IGNORED_SILENTLY = 1;
 const IGNORED = 2;

package/lib/cli-engine/lint-result-cache.js

@@ -17,6 +17,12 @@ const hash = require("./hash");
 
 const debug = require("debug")("eslint:lint-result-cache");
 
+//------------------------------------------------------------------------------
+// Typedefs
+//------------------------------------------------------------------------------
+
+/** @typedef {import("../types").Linter.Config} Config */
+
 //-----------------------------------------------------------------------------
 // Helpers
 //-----------------------------------------------------------------------------
@@ -40,7 +46,7 @@ function isValidCacheStrategy(cacheStrategy) {
 
 /**
  * Calculates the hash of the config
- * @param {ConfigArray} config The config.
+ * @param {Config} config The config.
  * @returns {string} The hash of the config
  */
 function hashOfConfigFor(config) {
@@ -96,38 +102,13 @@ class LintResultCache {
 	 * cache. If the file is present and has not been changed, rebuild any
 	 * missing result information.
 	 * @param {string} filePath The file for which to retrieve lint results.
-	 * @param {ConfigArray} config The config of the file.
+	 * @param {Config} config The config of the file.
 	 * @returns {Object|null} The rebuilt lint results, or null if the file is
 	 *   changed or not in the filesystem.
 	 */
 	getCachedLintResults(filePath, config) {
-		/*
-		 * Cached lint results are valid if and only if:
-		 * 1. The file is present in the filesystem
-		 * 2. The file has not changed since the time it was previously linted
-		 * 3. The ESLint configuration has not changed since the time the file
-		 *    was previously linted
-		 * If any of these are not true, we will not reuse the lint results.
-		 */
-		const fileDescriptor = this.fileEntryCache.getFileDescriptor(filePath);
-		const hashOfConfig = hashOfConfigFor(config);
-		const changed =
-			fileDescriptor.changed ||
-			fileDescriptor.meta.hashOfConfig !== hashOfConfig;
+		const cachedResults = this.getValidCachedLintResults(filePath, config);
 
-		if (fileDescriptor.notFound) {
-			debug(`File not found on the file system: ${filePath}`);
-			return null;
-		}
-
-		if (changed) {
-			debug(`Cache entry not found or no longer valid: ${filePath}`);
-			return null;
-		}
-
-		const cachedResults = fileDescriptor.meta.results;
-
-		// Just in case, not sure if this can ever happen.
 		if (!cachedResults) {
 			return cachedResults;
 		}
@@ -151,6 +132,43 @@ class LintResultCache {
 		return results;
 	}
 
+	/**
+	 * Retrieve cached lint results for a given file path, if present in the
+	 * cache and still valid.
+	 * @param {string} filePath The file for which to retrieve lint results.
+	 * @param {Config} config The config of the file.
+	 * @returns {Object|null} The cached lint results if present in the cache
+	 * and still valid; null otherwise.
+	 */
+	getValidCachedLintResults(filePath, config) {
+		/*
+		 * Cached lint results are valid if and only if:
+		 * 1. The file is present in the filesystem
+		 * 2. The file has not changed since the time it was previously linted
+		 * 3. The ESLint configuration has not changed since the time the file
+		 *    was previously linted
+		 * If any of these are not true, we will not reuse the lint results.
+		 */
+		const fileDescriptor = this.fileEntryCache.getFileDescriptor(filePath);
+
+		if (fileDescriptor.notFound) {
+			debug(`File not found on the file system: ${filePath}`);
+			return null;
+		}
+
+		const hashOfConfig = hashOfConfigFor(config);
+		const changed =
+			fileDescriptor.changed ||
+			fileDescriptor.meta.hashOfConfig !== hashOfConfig;
+
+		if (changed) {
+			debug(`Cache entry not found or no longer valid: ${filePath}`);
+			return null;
+		}
+
+		return fileDescriptor.meta.results;
+	}
+
 	/**
 	 * Set the cached lint results for a given file path, after removing any
 	 * information that will be both unnecessary and difficult to serialize.
@@ -158,7 +176,7 @@ class LintResultCache {
 	 * applied), to prevent potentially incorrect results if fixes are not
 	 * written to disk.
 	 * @param {string} filePath The file for which to set lint results.
-	 * @param {ConfigArray} config The config of the file.
+	 * @param {Config} config The config of the file.
 	 * @param {Object} result The lint result to be set for the file.
 	 * @returns {void}
 	 */

package/lib/cli.js

@@ -16,8 +16,9 @@
 //------------------------------------------------------------------------------
 
 const fs = require("node:fs"),
+	{ mkdir, stat, writeFile } = require("node:fs/promises"),
 	path = require("node:path"),
-	{ promisify } = require("node:util"),
+	{ pathToFileURL } = require("node:url"),
 	{ LegacyESLint } = require("./eslint"),
 	{
 		ESLint,
@@ -27,282 +28,23 @@ const fs = require("node:fs"),
 	createCLIOptions = require("./options"),
 	log = require("./shared/logging"),
 	RuntimeInfo = require("./shared/runtime-info"),
-	{ normalizeSeverityToString } = require("./shared/severity");
-const { ModuleImporter } = require("@humanwhocodes/module-importer");
+	translateOptions = require("./shared/translate-cli-options");
 const { getCacheFile } = require("./eslint/eslint-helpers");
 const { SuppressionsService } = require("./services/suppressions-service");
 const debug = require("debug")("eslint:cli");
-const {
-	normalizePackageName,
-	getShorthandName,
-} = require("./shared/naming.js");
 
 //------------------------------------------------------------------------------
 // Types
 //------------------------------------------------------------------------------
 
-/** @import { ESLintOptions } from "./eslint/eslint.js" */
-
 /** @typedef {import("./options").ParsedCLIOptions} ParsedCLIOptions */
-/** @typedef {import("./types").Linter.LintMessage} LintMessage */
 /** @typedef {import("./types").ESLint.LintResult} LintResult */
-/** @typedef {import("./types").ESLint.Plugin} Plugin */
 /** @typedef {import("./types").ESLint.ResultsMeta} ResultsMeta */
 
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
 
-const mkdir = promisify(fs.mkdir);
-const stat = promisify(fs.stat);
-const writeFile = promisify(fs.writeFile);
-
-/**
- * Loads plugins with the specified names.
- * @param {{ "import": (name: string) => Promise<any> }} importer An object with an `import` method called once for each plugin.
- * @param {string[]} pluginNames The names of the plugins to be loaded, with or without the "eslint-plugin-" prefix.
- * @returns {Promise<Record<string, Plugin>>} A mapping of plugin short names to implementations.
- */
-async function loadPlugins(importer, pluginNames) {
-	const plugins = {};
-
-	await Promise.all(
-		pluginNames.map(async pluginName => {
-			const longName = normalizePackageName(pluginName, "eslint-plugin");
-			const module = await importer.import(longName);
-
-			if (!("default" in module)) {
-				throw new Error(
-					`"${longName}" cannot be used with the \`--plugin\` option because its default module does not provide a \`default\` export`,
-				);
-			}
-
-			const shortName = getShorthandName(pluginName, "eslint-plugin");
-
-			plugins[shortName] = module.default;
-		}),
-	);
-
-	return plugins;
-}
-
-/**
- * Predicate function for whether or not to apply fixes in quiet mode.
- * If a message is a warning, do not apply a fix.
- * @param {LintMessage} message The lint result.
- * @returns {boolean} True if the lint message is an error (and thus should be
- * autofixed), false otherwise.
- */
-function quietFixPredicate(message) {
-	return message.severity === 2;
-}
-
-/**
- * Predicate function for whether or not to run a rule in quiet mode.
- * If a rule is set to warning, do not run it.
- * @param {{ ruleId: string; severity: number; }} rule The rule id and severity.
- * @returns {boolean} True if the lint rule should run, false otherwise.
- */
-function quietRuleFilter(rule) {
-	return rule.severity === 2;
-}
-
-/**
- * Translates the CLI options into the options expected by the ESLint constructor.
- * @param {ParsedCLIOptions} cliOptions The CLI options to translate.
- * @param {"flat"|"eslintrc"} [configType="eslintrc"] The format of the
- *      config to generate.
- * @returns {Promise<ESLintOptions>} The options object for the ESLint constructor.
- * @private
- */
-async function translateOptions(
-	{
-		cache,
-		cacheFile,
-		cacheLocation,
-		cacheStrategy,
-		config,
-		configLookup,
-		env,
-		errorOnUnmatchedPattern,
-		eslintrc,
-		ext,
-		fix,
-		fixDryRun,
-		fixType,
-		flag,
-		global,
-		ignore,
-		ignorePath,
-		ignorePattern,
-		inlineConfig,
-		parser,
-		parserOptions,
-		plugin,
-		quiet,
-		reportUnusedDisableDirectives,
-		reportUnusedDisableDirectivesSeverity,
-		reportUnusedInlineConfigs,
-		resolvePluginsRelativeTo,
-		rule,
-		rulesdir,
-		stats,
-		warnIgnored,
-		passOnNoPatterns,
-		maxWarnings,
-	},
-	configType,
-) {
-	let overrideConfig, overrideConfigFile;
-	const importer = new ModuleImporter();
-
-	if (configType === "flat") {
-		overrideConfigFile =
-			typeof config === "string" ? config : !configLookup;
-		if (overrideConfigFile === false) {
-			overrideConfigFile = void 0;
-		}
-
-		const languageOptions = {};
-
-		if (global) {
-			languageOptions.globals = global.reduce((obj, name) => {
-				if (name.endsWith(":true")) {
-					obj[name.slice(0, -5)] = "writable";
-				} else {
-					obj[name] = "readonly";
-				}
-				return obj;
-			}, {});
-		}
-
-		if (parserOptions) {
-			languageOptions.parserOptions = parserOptions;
-		}
-
-		if (parser) {
-			languageOptions.parser = await importer.import(parser);
-		}
-
-		overrideConfig = [
-			{
-				...(Object.keys(languageOptions).length > 0
-					? { languageOptions }
-					: {}),
-				rules: rule ? rule : {},
-			},
-		];
-
-		if (
-			reportUnusedDisableDirectives ||
-			reportUnusedDisableDirectivesSeverity !== void 0
-		) {
-			overrideConfig[0].linterOptions = {
-				reportUnusedDisableDirectives: reportUnusedDisableDirectives
-					? "error"
-					: normalizeSeverityToString(
-							reportUnusedDisableDirectivesSeverity,
-						),
-			};
-		}
-
-		if (reportUnusedInlineConfigs !== void 0) {
-			overrideConfig[0].linterOptions = {
-				...overrideConfig[0].linterOptions,
-				reportUnusedInlineConfigs: normalizeSeverityToString(
-					reportUnusedInlineConfigs,
-				),
-			};
-		}
-
-		if (plugin) {
-			overrideConfig[0].plugins = await loadPlugins(importer, plugin);
-		}
-
-		if (ext) {
-			overrideConfig.push({
-				files: ext.map(
-					extension =>
-						`**/*${extension.startsWith(".") ? "" : "."}${extension}`,
-				),
-			});
-		}
-	} else {
-		overrideConfigFile = config;
-
-		overrideConfig = {
-			env:
-				env &&
-				env.reduce((obj, name) => {
-					obj[name] = true;
-					return obj;
-				}, {}),
-			globals:
-				global &&
-				global.reduce((obj, name) => {
-					if (name.endsWith(":true")) {
-						obj[name.slice(0, -5)] = "writable";
-					} else {
-						obj[name] = "readonly";
-					}
-					return obj;
-				}, {}),
-			ignorePatterns: ignorePattern,
-			parser,
-			parserOptions,
-			plugins: plugin,
-			rules: rule,
-		};
-	}
-
-	const options = {
-		allowInlineConfig: inlineConfig,
-		cache,
-		cacheLocation: cacheLocation || cacheFile,
-		cacheStrategy,
-		errorOnUnmatchedPattern,
-		fix: (fix || fixDryRun) && (quiet ? quietFixPredicate : true),
-		fixTypes: fixType,
-		ignore,
-		overrideConfig,
-		overrideConfigFile,
-		passOnNoPatterns,
-	};
-
-	if (configType === "flat") {
-		options.ignorePatterns = ignorePattern;
-		options.stats = stats;
-		options.warnIgnored = warnIgnored;
-		options.flags = flag;
-
-		/*
-		 * For performance reasons rules not marked as 'error' are filtered out in quiet mode. As maxWarnings
-		 * requires rules set to 'warn' to be run, we only filter out 'warn' rules if maxWarnings is not specified.
-		 */
-		options.ruleFilter =
-			quiet && maxWarnings === -1 ? quietRuleFilter : () => true;
-	} else {
-		options.resolvePluginsRelativeTo = resolvePluginsRelativeTo;
-		options.rulePaths = rulesdir;
-		options.useEslintrc = eslintrc;
-		options.extensions = ext;
-		options.ignorePath = ignorePath;
-		if (
-			reportUnusedDisableDirectives ||
-			reportUnusedDisableDirectivesSeverity !== void 0
-		) {
-			options.reportUnusedDisableDirectives =
-				reportUnusedDisableDirectives
-					? "error"
-					: normalizeSeverityToString(
-							reportUnusedDisableDirectivesSeverity,
-						);
-		}
-	}
-
-	return options;
-}
-
 /**
  * Count error messages.
  * @param {LintResult[]} results The lint results.
@@ -322,6 +64,26 @@ function countErrors(results) {
 	return { errorCount, fatalErrorCount, warningCount };
 }
 
+/**
+ * Creates an options module from the provided CLI options and encodes it as a data URL.
+ * @param {ParsedCLIOptions} options The CLI options.
+ * @returns {URL} The URL of the options module.
+ */
+function createOptionsModule(options) {
+	const translateOptionsFileURL = new URL(
+		"./shared/translate-cli-options.js",
+		pathToFileURL(__filename),
+	).href;
+	const optionsSrc =
+		`import translateOptions from ${JSON.stringify(translateOptionsFileURL)};\n` +
+		`export default await translateOptions(${JSON.stringify(options)}, "flat");\n`;
+
+	// Base64 encoding is typically shorter than URL encoding
+	return new URL(
+		`data:text/javascript;base64,${Buffer.from(optionsSrc).toString("base64")}`,
+	);
+}
+
 /**
  * Check if a given file path is a directory or not.
  * @param {string} filePath The path to a file to check.
@@ -385,6 +147,30 @@ async function printResults(engine, results, format, outputFile, resultsMeta) {
 	return true;
 }
 
+/**
+ * Validates the `--concurrency` flag value.
+ * @param {string} concurrency The `--concurrency` flag value to validate.
+ * @returns {void}
+ * @throws {Error} If the `--concurrency` flag value is invalid.
+ */
+function validateConcurrency(concurrency) {
+	if (
+		concurrency === void 0 ||
+		concurrency === "auto" ||
+		concurrency === "off"
+	) {
+		return;
+	}
+
+	const concurrencyValue = Number(concurrency);
+
+	if (!Number.isInteger(concurrencyValue) || concurrencyValue < 1) {
+		throw new Error(
+			`Option concurrency: '${concurrency}' is not a positive integer, 'auto' or 'off'.`,
+		);
+	}
+}
+
 //------------------------------------------------------------------------------
 // Public Interface
 //------------------------------------------------------------------------------
@@ -445,6 +231,7 @@ const cli = {
 
 		try {
 			options = CLIOptions.parse(args);
+			validateConcurrency(options.concurrency);
 		} catch (error) {
 			debug("Error parsing CLI options:", error.message);
 
@@ -614,11 +401,20 @@ const cli = {
 		}
 
 		const ActiveESLint = usingFlatConfig ? ESLint : LegacyESLint;
-		const eslintOptions = await translateOptions(
-			options,
-			usingFlatConfig ? "flat" : "eslintrc",
-		);
-		const engine = new ActiveESLint(eslintOptions);
+
+		/** @type {ESLint|LegacyESLint} */
+		let engine;
+
+		if (options.concurrency && options.concurrency !== "off") {
+			const optionsURL = createOptionsModule(options);
+			engine = await ESLint.fromOptionsModule(optionsURL);
+		} else {
+			const eslintOptions = await translateOptions(
+				options,
+				usingFlatConfig ? "flat" : "eslintrc",
+			);
+			engine = new ActiveESLint(eslintOptions);
+		}
 		let results;
 
 		if (useStdin) {

package/lib/config/flat-config-schema.js

@@ -230,7 +230,7 @@ function assertIsRuleSeverity(ruleId, value) {
  * @throws {TypeError} If the string isn't in the correct format.
  */
 function assertIsPluginMemberName(value) {
-	if (!/[@a-z0-9-_$]+(?:\/(?:[a-z0-9-_$]+))+$/iu.test(value)) {
+	if (!/[\w\-@$]+(?:\/[\w\-$]+)+$/iu.test(value)) {
 		throw new TypeError(
 			`Expected string in the form "pluginName/objectName" but found "${value}".`,
 		);