eslint 9.27.0 → 9.29.0

package/lib/rules/prefer-arrow-callback.js

@@ -151,6 +151,8 @@ function hasDuplicateParams(paramsList) {
 module.exports = {
 	meta: {
 		type: "suggestion",
+		dialects: ["javascript", "typescript"],
+		language: "javascript",
 
 		defaultOptions: [
 			{ allowNamedFunctions: false, allowUnboundThis: true },
@@ -308,6 +310,13 @@ module.exports = {
 								return;
 							}
 
+							if (
+								node.params.length &&
+								node.params[0].name === "this"
+							) {
+								return;
+							}
+
 							// Remove `.bind(this)` if exists.
 							if (callbackInfo.isLexicalThis) {
 								const memberNode = node.parent;

package/lib/rules/prefer-regex-literals.js

@@ -14,7 +14,6 @@ const {
 	CALL,
 	CONSTRUCT,
 	ReferenceTracker,
-	findVariable,
 } = require("@eslint-community/eslint-utils");
 const {
 	RegExpValidator,
@@ -167,22 +166,6 @@ module.exports = {
 		const [{ disallowRedundantWrapping }] = context.options;
 		const sourceCode = context.sourceCode;
 
-		/**
-		 * Determines whether the given identifier node is a reference to a global variable.
-		 * @param {ASTNode} node `Identifier` node to check.
-		 * @returns {boolean} True if the identifier is a reference to a global variable.
-		 */
-		function isGlobalReference(node) {
-			const scope = sourceCode.getScope(node);
-			const variable = findVariable(scope, node);
-
-			return (
-				variable !== null &&
-				variable.scope.type === "global" &&
-				variable.defs.length === 0
-			);
-		}
-
 		/**
 		 * Determines whether the given node is a String.raw`` tagged template expression
 		 * with a static template literal.
@@ -193,7 +176,7 @@ module.exports = {
 			return (
 				node.type === "TaggedTemplateExpression" &&
 				astUtils.isSpecificMemberAccess(node.tag, "String", "raw") &&
-				isGlobalReference(
+				sourceCode.isGlobalReference(
 					astUtils.skipChainExpression(node.tag).object,
 				) &&
 				astUtils.isStaticTemplateLiteral(node.quasi)

package/lib/services/suppressions-service.js

@@ -112,6 +112,14 @@ class SuppressionsService {
 			}
 		}
 
+		for (const file of Object.keys(suppressions)) {
+			const absolutePath = path.resolve(this.cwd, file);
+
+			if (!fs.existsSync(absolutePath)) {
+				delete suppressions[file];
+			}
+		}
+
 		return this.save(suppressions);
 	}
 

package/lib/services/warning-service.js

@@ -0,0 +1,85 @@
+/**
+ * @fileoverview Emits warnings for ESLint.
+ * @author Francesco Trotta
+ */
+
+"use strict";
+
+//-----------------------------------------------------------------------------
+// Exports
+//-----------------------------------------------------------------------------
+
+/**
+ * A service that emits warnings for ESLint.
+ */
+class WarningService {
+	/**
+	 * Creates a new instance of the service.
+	 * @param {{ emitWarning?: ((warning: string, type: string) => void) | undefined }} [options] A function called internally to emit warnings using API provided by the runtime.
+	 */
+	constructor({
+		emitWarning = globalThis.process?.emitWarning ?? (() => {}),
+	} = {}) {
+		this.emitWarning = emitWarning;
+	}
+
+	/**
+	 * Emits a warning when circular fixes are detected while fixing a file.
+	 * This method is used by the Linter and is safe to call outside Node.js.
+	 * @param {string} filename The name of the file being fixed.
+	 * @returns {void}
+	 */
+	emitCircularFixesWarning(filename) {
+		this.emitWarning(
+			`Circular fixes detected while fixing ${filename}. It is likely that you have conflicting rules in your configuration.`,
+			"ESLintCircularFixesWarning",
+		);
+	}
+
+	/**
+	 * Emits a warning when an empty config file has been loaded.
+	 * @param {string} configFilePath The path to the config file.
+	 * @returns {void}
+	 */
+	emitEmptyConfigWarning(configFilePath) {
+		this.emitWarning(
+			`Running ESLint with an empty config (from ${configFilePath}). Please double-check that this is what you want. If you want to run ESLint with an empty config, export [{}] to remove this warning.`,
+			"ESLintEmptyConfigWarning",
+		);
+	}
+
+	/**
+	 * Emits a warning when an ".eslintignore" file is found.
+	 * @returns {void}
+	 */
+	emitESLintIgnoreWarning() {
+		this.emitWarning(
+			'The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files',
+			"ESLintIgnoreWarning",
+		);
+	}
+
+	/**
+	 * Emits a warning when the ESLINT_USE_FLAT_CONFIG environment variable is set to "false".
+	 * @returns {void}
+	 */
+	emitESLintRCWarning() {
+		this.emitWarning(
+			"You are using an eslintrc configuration file, which is deprecated and support will be removed in v10.0.0. Please migrate to an eslint.config.js file. See https://eslint.org/docs/latest/use/configure/migration-guide for details. An eslintrc configuration file is used because you have the ESLINT_USE_FLAT_CONFIG environment variable set to false. If you want to use an eslint.config.js file, remove the environment variable. If you want to find the location of the eslintrc configuration file, use the --debug flag.",
+			"ESLintRCWarning",
+		);
+	}
+
+	/**
+	 * Emits a warning when an inactive flag is used.
+	 * This method is used by the Linter and is safe to call outside Node.js.
+	 * @param {string} flag The name of the flag.
+	 * @param {string} message The warning message.
+	 * @returns {void}
+	 */
+	emitInactiveFlagWarning(flag, message) {
+		this.emitWarning(message, `ESLintInactiveFlag_${flag}`);
+	}
+}
+
+module.exports = { WarningService };

package/lib/shared/naming.js

@@ -0,0 +1,109 @@
+/**
+ * @fileoverview Common helpers for naming of plugins, formatters and configs
+ */
+
+"use strict";
+
+const NAMESPACE_REGEX = /^@.*\//iu;
+
+/**
+ * Brings package name to correct format based on prefix
+ * @param {string} name The name of the package.
+ * @param {string} prefix Can be either "eslint-plugin", "eslint-config" or "eslint-formatter"
+ * @returns {string} Normalized name of the package
+ * @private
+ */
+function normalizePackageName(name, prefix) {
+	let normalizedName = name;
+
+	/**
+	 * On Windows, name can come in with Windows slashes instead of Unix slashes.
+	 * Normalize to Unix first to avoid errors later on.
+	 * https://github.com/eslint/eslint/issues/5644
+	 */
+	if (normalizedName.includes("\\")) {
+		normalizedName = normalizedName.replace(/\\/gu, "/");
+	}
+
+	if (normalizedName.charAt(0) === "@") {
+		/**
+		 * it's a scoped package
+		 * package name is the prefix, or just a username
+		 */
+		const scopedPackageShortcutRegex = new RegExp(
+				`^(@[^/]+)(?:/(?:${prefix})?)?$`,
+				"u",
+			),
+			scopedPackageNameRegex = new RegExp(`^${prefix}(-|$)`, "u");
+
+		if (scopedPackageShortcutRegex.test(normalizedName)) {
+			normalizedName = normalizedName.replace(
+				scopedPackageShortcutRegex,
+				`$1/${prefix}`,
+			);
+		} else if (!scopedPackageNameRegex.test(normalizedName.split("/")[1])) {
+			/**
+			 * for scoped packages, insert the prefix after the first / unless
+			 * the path is already @scope/eslint or @scope/eslint-xxx-yyy
+			 */
+			normalizedName = normalizedName.replace(
+				/^@([^/]+)\/(.*)$/u,
+				`@$1/${prefix}-$2`,
+			);
+		}
+	} else if (!normalizedName.startsWith(`${prefix}-`)) {
+		normalizedName = `${prefix}-${normalizedName}`;
+	}
+
+	return normalizedName;
+}
+
+/**
+ * Removes the prefix from a fullname.
+ * @param {string} fullname The term which may have the prefix.
+ * @param {string} prefix The prefix to remove.
+ * @returns {string} The term without prefix.
+ */
+function getShorthandName(fullname, prefix) {
+	if (fullname[0] === "@") {
+		let matchResult = new RegExp(`^(@[^/]+)/${prefix}$`, "u").exec(
+			fullname,
+		);
+
+		if (matchResult) {
+			return matchResult[1];
+		}
+
+		matchResult = new RegExp(`^(@[^/]+)/${prefix}-(.+)$`, "u").exec(
+			fullname,
+		);
+		if (matchResult) {
+			return `${matchResult[1]}/${matchResult[2]}`;
+		}
+	} else if (fullname.startsWith(`${prefix}-`)) {
+		return fullname.slice(prefix.length + 1);
+	}
+
+	return fullname;
+}
+
+/**
+ * Gets the scope (namespace) of a term.
+ * @param {string} term The term which may have the namespace.
+ * @returns {string} The namespace of the term if it has one.
+ */
+function getNamespaceFromTerm(term) {
+	const match = term.match(NAMESPACE_REGEX);
+
+	return match ? match[0] : "";
+}
+
+//------------------------------------------------------------------------------
+// Public Interface
+//------------------------------------------------------------------------------
+
+module.exports = {
+	normalizePackageName,
+	getShorthandName,
+	getNamespaceFromTerm,
+};

package/lib/shared/relative-module-resolver.js

@@ -0,0 +1,28 @@
+/**
+ * Utility for resolving a module relative to another module
+ * @author Teddy Katz
+ */
+
+"use strict";
+
+const Module = require("node:module");
+
+/*
+ * `Module.createRequire` is added in v12.2.0. It supports URL as well.
+ * We only support the case where the argument is a filepath, not a URL.
+ */
+const createRequire = Module.createRequire;
+
+/**
+ * Resolves a Node module relative to another module
+ * @param {string} moduleName The name of a Node module, or a path to a Node module.
+ * @param {string} relativeToPath An absolute path indicating the module that `moduleName` should be resolved relative to. This must be
+ * a file rather than a directory, but the file need not actually exist.
+ * @returns {string} The absolute path that would result from calling `require.resolve(moduleName)` in a file located at `relativeToPath`
+ * @throws {Error} When the module cannot be resolved.
+ */
+function resolve(moduleName, relativeToPath) {
+	return createRequire(relativeToPath).resolve(moduleName);
+}
+
+exports.resolve = resolve;

package/lib/types/index.d.ts

@@ -289,6 +289,8 @@ export class SourceCode
 		second: ESTree.Node | AST.Token,
 	): boolean;
 
+	isGlobalReference(node: ESTree.Identifier): boolean;
+
 	markVariableAsUsed(name: string, refNode?: ESTree.Node): boolean;
 
 	traverse(): Iterable<TraversalStep>;
@@ -584,6 +586,11 @@ export namespace SourceCode {
 
 // #endregion
 
+export type JSSyntaxElement = {
+	type: string;
+	loc?: ESTree.SourceLocation | null | undefined;
+};
+
 export namespace Rule {
 	interface RuleModule
 		extends RuleDefinition<{
@@ -591,7 +598,7 @@ export namespace Rule {
 			Code: SourceCode;
 			RuleOptions: any[];
 			Visitor: NodeListener;
-			Node: ESTree.Node;
+			Node: JSSyntaxElement;
 			MessageIds: string;
 			ExtRuleDocs: {};
 		}> {
@@ -1159,10 +1166,10 @@ export namespace Rule {
 		/**
 		 * Indicates the type of rule:
 		 * - `"problem"` means the rule is identifying code that either will cause an error or may cause a confusing behavior. Developers should consider this a high priority to resolve.
-		 * - `"suggestion"` means the rule is identifying something that could be done in a better way but no errors will occur if the code isn’t changed.
+		 * - `"suggestion"` means the rule is identifying something that could be done in a better way but no errors will occur if the code isn't changed.
 		 * - `"layout"` means the rule cares primarily about whitespace, semicolons, commas, and parentheses,
 		 *   all the parts of the program that determine how the code looks rather than how it executes.
-		 *   These rules work on parts of the code that aren’t specified in the AST.
+		 *   These rules work on parts of the code that aren't specified in the AST.
 		 */
 		type?: "problem" | "suggestion" | "layout" | undefined;
 		/**
@@ -1177,7 +1184,7 @@ export namespace Rule {
 			LangOptions: Linter.LanguageOptions;
 			Code: SourceCode;
 			RuleOptions: any[];
-			Node: ESTree.Node;
+			Node: JSSyntaxElement;
 			MessageIds: string;
 		}> {
 		/*
@@ -1275,7 +1282,7 @@ export type JSRuleDefinition<
 		LangOptions: Linter.LanguageOptions;
 		Code: SourceCode;
 		Visitor: Rule.NodeListener;
-		Node: ESTree.Node;
+		Node: JSSyntaxElement;
 	} & Required<
 		// Rule specific type options (custom)
 		Options &
@@ -1409,6 +1416,7 @@ export namespace Linter {
 		| 14
 		| 15
 		| 16
+		| 17
 		| 2015
 		| 2016
 		| 2017
@@ -1420,6 +1428,7 @@ export namespace Linter {
 		| 2023
 		| 2024
 		| 2025
+		| 2026
 		| "latest";
 
 	/**
@@ -1619,7 +1628,9 @@ export namespace Linter {
 		postprocess?:
 			| ((problemLists: LintMessage[][]) => LintMessage[])
 			| undefined;
-		filterCodeBlock?: boolean | undefined;
+		filterCodeBlock?:
+			| ((filename: string, text: string) => boolean)
+			| undefined;
 		disableFixes?: boolean | undefined;
 		allowInlineConfig?: boolean | undefined;
 		reportUnusedDisableDirectives?: boolean | undefined;
@@ -1824,7 +1835,7 @@ export namespace Linter {
 	}
 
 	/** @deprecated  Use `Config` instead of `FlatConfig` */
-	type FlatConfig = Config;
+	type FlatConfig<Rules extends RulesRecord = RulesRecord> = Config<Rules>;
 
 	type GlobalConf =
 		| boolean

package/lib/types/rules.d.ts

@@ -619,7 +619,7 @@ export interface ESLintRules extends Linter.RulesRecord {
 	 * @see https://eslint.org/docs/latest/rules/curly
 	 */
 	curly: Linter.RuleEntry<
-		["all" | "multi" | "multi-line" | "multi-or-nest" | "consistent"]
+		["all"] | ["multi" | "multi-line" | "multi-or-nest", "consistent"?]
 	>;
 
 	/**
@@ -807,6 +807,10 @@ export interface ESLintRules extends Linter.RulesRecord {
 				 * @default false
 				 */
 				allowArrowFunctions: boolean;
+				/**
+				 * @default false
+				 */
+				allowTypeAnnotation: boolean;
 				overrides: {
 					namedExports: "declaration" | "expression" | "ignore";
 				};
@@ -2854,6 +2858,22 @@ export interface ESLintRules extends Linter.RulesRecord {
 				 * @default false
 				 */
 				detectObjects: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreEnums: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreNumericLiteralTypes: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreReadonlyClassProperties: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreTypeIndexes: boolean;
 			}>,
 		]
 	>;
@@ -3450,6 +3470,11 @@ export interface ESLintRules extends Linter.RulesRecord {
 						allowObjects?: string[];
 						message?: string | undefined;
 				  }
+				| {
+						object: string;
+						allowProperties?: string[];
+						message?: string | undefined;
+				  }
 			>,
 		]
 	>;
@@ -3562,13 +3587,26 @@ export interface ESLintRules extends Linter.RulesRecord {
 				/**
 				 * @default 'functions'
 				 */
-				hoist: "functions" | "all" | "never";
+				hoist:
+					| "functions"
+					| "all"
+					| "never"
+					| "types"
+					| "functions-and-types";
 				allow: string[];
 				/**
 				 * @since 8.10.0
 				 * @default false
 				 */
 				ignoreOnInitialization: boolean;
+				/**
+				 * @default true
+				 */
+				ignoreTypeValueShadow: boolean;
+				/**
+				 * @default true
+				 */
+				ignoreFunctionTypeParameterNameValueShadow: boolean;
 			}>,
 		]
 	>;
@@ -4057,6 +4095,18 @@ export interface ESLintRules extends Linter.RulesRecord {
 					 * @default false
 					 */
 					allowNamedExports: boolean;
+					/**
+					 * @default true
+					 */
+					enums: boolean;
+					/**
+					 * @default true
+					 */
+					typedefs: boolean;
+					/**
+					 * @default true
+					 */
+					ignoreTypeReferences: boolean;
 			  }>
 			| "nofunc",
 		]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "9.27.0",
+  "version": "9.29.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "type": "commonjs",
@@ -106,11 +106,11 @@
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.2.0",
     "@eslint-community/regexpp": "^4.12.1",
-    "@eslint/config-array": "^0.20.0",
+    "@eslint/config-array": "^0.20.1",
     "@eslint/config-helpers": "^0.2.1",
     "@eslint/core": "^0.14.0",
     "@eslint/eslintrc": "^3.3.1",
-    "@eslint/js": "9.27.0",
+    "@eslint/js": "9.29.0",
     "@eslint/plugin-kit": "^0.3.1",
     "@humanfs/node": "^0.16.6",
     "@humanwhocodes/module-importer": "^1.0.1",
@@ -122,9 +122,9 @@
     "cross-spawn": "^7.0.6",
     "debug": "^4.3.2",
     "escape-string-regexp": "^4.0.0",
-    "eslint-scope": "^8.3.0",
-    "eslint-visitor-keys": "^4.2.0",
-    "espree": "^10.3.0",
+    "eslint-scope": "^8.4.0",
+    "eslint-visitor-keys": "^4.2.1",
+    "espree": "^10.4.0",
     "esquery": "^1.5.0",
     "esutils": "^2.0.2",
     "fast-deep-equal": "^3.1.3",
@@ -170,11 +170,13 @@
     "fast-glob": "^3.2.11",
     "fs-teardown": "^0.1.3",
     "glob": "^10.0.0",
-    "globals": "^15.0.0",
+    "globals": "^16.2.0",
     "got": "^11.8.3",
     "gray-matter": "^4.0.3",
-    "jiti": "^2.1.0",
-    "knip": "^5.32.0",
+    "jiti": "^2.2.0",
+    "jiti-v2.0": "npm:jiti@2.0.x",
+    "jiti-v2.1": "npm:jiti@2.1.x",
+    "knip": "^5.60.2",
     "lint-staged": "^11.0.0",
     "load-perf": "^0.2.0",
     "markdown-it": "^12.2.0",
@@ -195,7 +197,7 @@
     "recast": "^0.23.0",
     "regenerator-runtime": "^0.14.0",
     "semver": "^7.5.3",
-    "shelljs": "^0.9.0",
+    "shelljs": "^0.10.0",
     "sinon": "^11.0.0",
     "typescript": "^5.3.3",
     "webpack": "^5.23.0",