eslint 9.26.0 → 9.27.0

package/lib/rules/no-array-constructor.js

@@ -34,6 +34,8 @@ module.exports = {
 			url: "https://eslint.org/docs/latest/rules/no-array-constructor",
 		},
 
+		fixable: "code",
+
 		hasSuggestions: true,
 
 		schema: [],
@@ -49,6 +51,30 @@ module.exports = {
 	create(context) {
 		const sourceCode = context.sourceCode;
 
+		/**
+		 * Checks if there are comments in Array constructor expressions.
+		 * @param {ASTNode} node A CallExpression or NewExpression node.
+		 * @returns {boolean} True if there are comments, false otherwise.
+		 */
+		function hasCommentsInArrayConstructor(node) {
+			const firstToken = sourceCode.getFirstToken(node);
+			const lastToken = sourceCode.getLastToken(node);
+
+			let lastRelevantToken = sourceCode.getLastToken(node.callee);
+
+			while (
+				lastRelevantToken !== lastToken &&
+				!isOpeningParenToken(lastRelevantToken)
+			) {
+				lastRelevantToken = sourceCode.getTokenAfter(lastRelevantToken);
+			}
+
+			return sourceCode.commentsExistBetween(
+				firstToken,
+				lastRelevantToken,
+			);
+		}
+
 		/**
 		 * Gets the text between the calling parentheses of a CallExpression or NewExpression.
 		 * @param {ASTNode} node A CallExpression or NewExpression node.
@@ -107,6 +133,17 @@ module.exports = {
 				let fixText;
 				let messageId;
 
+				const nonSpreadCount = node.arguments.reduce(
+					(count, arg) =>
+						arg.type !== "SpreadElement" ? count + 1 : count,
+					0,
+				);
+
+				const shouldSuggest =
+					node.optional ||
+					(node.arguments.length > 0 && nonSpreadCount < 2) ||
+					hasCommentsInArrayConstructor(node);
+
 				/*
 				 * Check if the suggested change should include a preceding semicolon or not.
 				 * Due to JavaScript's ASI rules, a missing semicolon may be inserted automatically
@@ -127,10 +164,23 @@ module.exports = {
 				context.report({
 					node,
 					messageId: "preferLiteral",
+					fix(fixer) {
+						if (shouldSuggest) {
+							return null;
+						}
+
+						return fixer.replaceText(node, fixText);
+					},
 					suggest: [
 						{
 							messageId,
-							fix: fixer => fixer.replaceText(node, fixText),
+							fix(fixer) {
+								if (shouldSuggest) {
+									return fixer.replaceText(node, fixText);
+								}
+
+								return null;
+							},
 						},
 					],
 				});

package/lib/rules/no-unassigned-vars.js

@@ -0,0 +1,72 @@
+/**
+ * @fileoverview Rule to flag variables that are never assigned
+ * @author Jacob Bandes-Storch <https://github.com/jtbandes>
+ */
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+/** @type {import('../types').Rule.RuleModule} */
+module.exports = {
+	meta: {
+		type: "problem",
+		dialects: ["typescript", "javascript"],
+		language: "javascript",
+
+		docs: {
+			description:
+				"Disallow `let` or `var` variables that are read but never assigned",
+			recommended: false,
+			url: "https://eslint.org/docs/latest/rules/no-unassigned-vars",
+		},
+
+		schema: [],
+		messages: {
+			unassigned:
+				"'{{name}}' is always 'undefined' because it's never assigned.",
+		},
+	},
+
+	create(context) {
+		const sourceCode = context.sourceCode;
+
+		return {
+			VariableDeclarator(node) {
+				/** @type {import('estree').VariableDeclaration} */
+				const declaration = node.parent;
+				const shouldCheck =
+					!node.init &&
+					node.id.type === "Identifier" &&
+					declaration.kind !== "const" &&
+					!declaration.declare;
+				if (!shouldCheck) {
+					return;
+				}
+				const [variable] = sourceCode.getDeclaredVariables(node);
+				if (!variable) {
+					return;
+				}
+				let hasRead = false;
+				for (const reference of variable.references) {
+					if (reference.isWrite()) {
+						return;
+					}
+					if (reference.isRead()) {
+						hasRead = true;
+					}
+				}
+				if (!hasRead) {
+					// Variables that are never read should be flagged by no-unused-vars instead
+					return;
+				}
+				context.report({
+					node,
+					messageId: "unassigned",
+					data: { name: node.id.name },
+				});
+			},
+		};
+	},
+};

package/lib/rules/no-useless-escape.js

@@ -60,6 +60,12 @@ module.exports = {
 	meta: {
 		type: "suggestion",
 
+		defaultOptions: [
+			{
+				allowRegexCharacters: [],
+			},
+		],
+
 		docs: {
 			description: "Disallow unnecessary escape characters",
 			recommended: true,
@@ -78,11 +84,26 @@ module.exports = {
 				"Replace the `\\` with `\\\\` to include the actual backslash character.",
 		},
 
-		schema: [],
+		schema: [
+			{
+				type: "object",
+				properties: {
+					allowRegexCharacters: {
+						type: "array",
+						items: {
+							type: "string",
+						},
+						uniqueItems: true,
+					},
+				},
+				additionalProperties: false,
+			},
+		],
 	},
 
 	create(context) {
 		const sourceCode = context.sourceCode;
+		const [{ allowRegexCharacters }] = context.options;
 		const parser = new RegExpParser();
 
 		/**
@@ -217,7 +238,8 @@ module.exports = {
 
 					if (
 						escapedChar !==
-						String.fromCodePoint(characterNode.value)
+							String.fromCodePoint(characterNode.value) ||
+						allowRegexCharacters.includes(escapedChar)
 					) {
 						// It's a valid escape.
 						return;

package/lib/rules/prefer-named-capture-group.js

@@ -17,6 +17,12 @@ const {
 } = require("@eslint-community/eslint-utils");
 const regexpp = require("@eslint-community/regexpp");
 
+//------------------------------------------------------------------------------
+// Typedefs
+//------------------------------------------------------------------------------
+
+/** @import { SuggestedEdit } from "@eslint/core"; */
+
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
@@ -29,7 +35,7 @@ const parser = new regexpp.RegExpParser();
  * @param {string} pattern The regular expression pattern to be checked.
  * @param {string} rawText Source text of the regexNode.
  * @param {ASTNode} regexNode AST node which contains the regular expression.
- * @returns {Array<SuggestionResult>} Fixer suggestions for the regex, if statically determinable.
+ * @returns {Array<SuggestedEdit>} Fixer suggestions for the regex, if statically determinable.
  */
 function suggestIfPossible(groupStart, pattern, rawText, regexNode) {
 	switch (regexNode.type) {

package/lib/services/processor-service.js

@@ -17,7 +17,7 @@ const { VFile } = require("../linter/vfile.js");
 // Types
 //-----------------------------------------------------------------------------
 
-/** @typedef {import("../shared/types.js").LintMessage} LintMessage */
+/** @typedef {import("../types").Linter.LintMessage} LintMessage */
 /** @typedef {import("../linter/vfile.js").VFile} VFile */
 /** @typedef {import("@eslint/core").Language} Language */
 /** @typedef {import("eslint").Linter.Processor} Processor */

package/lib/services/suppressions-service.js

@@ -12,14 +12,16 @@
 const fs = require("node:fs");
 const path = require("node:path");
 const { calculateStatsPerFile } = require("../eslint/eslint-helpers");
+const stringify = require("json-stable-stringify-without-jsonify");
 
 //------------------------------------------------------------------------------
 // Typedefs
 //------------------------------------------------------------------------------
 
 // For VSCode IntelliSense
-/** @typedef {import("../shared/types").LintResult} LintResult */
-/** @typedef {import("../shared/types").SuppressedViolations} SuppressedViolations */
+/** @typedef {import("../types").Linter.LintMessage} LintMessage */
+/** @typedef {import("../types").ESLint.LintResult} LintResult */
+/** @typedef {Record<string, Record<string, { count: number; }>>} SuppressedViolations */
 
 //-----------------------------------------------------------------------------
 // Exports
@@ -224,7 +226,7 @@ class SuppressionsService {
 	save(suppressions) {
 		return fs.promises.writeFile(
 			this.filePath,
-			JSON.stringify(suppressions, null, 2),
+			stringify(suppressions, { space: 2 }),
 		);
 	}
 

package/lib/shared/flags.js

@@ -27,6 +27,7 @@
  */
 const activeFlags = new Map([
 	["test_only", "Used only for testing."],
+	["test_only_2", "Used only for testing."],
 	[
 		"unstable_config_lookup_from_file",
 		"Look up `eslint.config.js` from the file being linted.",

package/lib/types/index.d.ts

@@ -1560,9 +1560,16 @@ export namespace Linter {
 	/**
 	 * Parser options.
 	 *
-	 * @see [Specifying Parser Options](https://eslint.org/docs/latest/use/configure/language-options-deprecated#specifying-parser-options)
+	 * @see [Specifying Parser Options](https://eslint.org/docs/latest/use/configure/language-options#specifying-parser-options)
 	 */
 	interface ParserOptions {
+		/**
+		 * Allow the use of reserved words as identifiers (if `ecmaVersion` is 3).
+		 *
+		 * @default false
+		 */
+		allowReserved?: boolean | undefined;
+
 		/**
 		 * Accepts any valid ECMAScript version number or `'latest'`:
 		 *
@@ -1619,26 +1626,54 @@ export namespace Linter {
 	}
 
 	interface LintSuggestion {
+		/** A short description. */
 		desc: string;
+
+		/** Fix result info. */
 		fix: Rule.Fix;
+
+		/** Id referencing a message for the description. */
 		messageId?: string | undefined;
 	}
 
 	interface LintMessage {
+		/** The 1-based column number. */
 		column: number;
+
+		/** The 1-based line number. */
 		line: number;
+
+		/** The 1-based column number of the end location. */
 		endColumn?: number | undefined;
+
+		/** The 1-based line number of the end location. */
 		endLine?: number | undefined;
+
+		/** The ID of the rule which makes this message. */
 		ruleId: string | null;
+
+		/** The reported message. */
 		message: string;
+
+		/** The ID of the message in the rule's meta. */
 		messageId?: string | undefined;
+
 		/**
+		 * Type of node.
 		 * @deprecated `nodeType` is deprecated and will be removed in the next major version.
 		 */
 		nodeType?: string | undefined;
+
+		/** If `true` then this is a fatal error. */
 		fatal?: true | undefined;
+
+		/** The severity of this message. */
 		severity: Exclude<Severity, 0>;
+
+		/** Information for autofix. */
 		fix?: Rule.Fix | undefined;
+
+		/** Information for suggestions. */
 		suggestions?: LintSuggestion[] | undefined;
 	}
 
@@ -1648,6 +1683,7 @@ export namespace Linter {
 	}
 
 	interface SuppressedLintMessage extends LintMessage {
+		/** The suppression info. */
 		suppressions: LintSuppression[];
 	}
 
@@ -1661,8 +1697,8 @@ export namespace Linter {
 		messages: LintMessage[];
 	}
 
-	// Temporarily loosen type for just flat config files (see #68232)
-	type NonESTreeParser = Omit<ESTreeParser, "parseForESLint"> &
+	// Temporarily loosen type for just flat config files (see https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68232)
+	type NonESTreeParser = ESLint.ObjectMetaProperties &
 		(
 			| {
 					parse(text: string, options?: any): unknown;
@@ -1687,9 +1723,16 @@ export namespace Linter {
 	type Parser = NonESTreeParser | ESTreeParser;
 
 	interface ESLintParseResult {
+		/** The AST object. */
 		ast: AST.Program;
-		parserServices?: SourceCode.ParserServices | undefined;
+
+		/** The services that the parser provides. */
+		services?: SourceCode.ParserServices | undefined;
+
+		/** The scope manager of the AST. */
 		scopeManager?: Scope.ScopeManager | undefined;
+
+		/** The visitor keys of the AST. */
 		visitorKeys?: SourceCode.VisitorKeys | undefined;
 	}
 
@@ -1702,8 +1745,13 @@ export namespace Linter {
 	interface Processor<
 		T extends string | ProcessorFile = string | ProcessorFile,
 	> extends ESLint.ObjectMetaProperties {
+		/** If `true` then it means the processor supports autofix. */
 		supportsAutofix?: boolean | undefined;
+
+		/** The function to extract code blocks. */
 		preprocess?(text: string, filename: string): T[];
+
+		/** The function to merge messages. */
 		postprocess?(
 			messages: LintMessage[][],
 			filename: string,
@@ -1844,6 +1892,9 @@ export namespace Linter {
 		reportUnusedInlineConfigs?: Severity | StringSeverity;
 	}
 
+	/**
+	 * Performance statistics.
+	 */
 	interface Stats {
 		/**
 		 * The number of times ESLint has applied at least one fix after linting.
@@ -1857,9 +1908,24 @@ export namespace Linter {
 	}
 
 	interface TimePass {
+		/**
+		 * The parse object containing all parse time information.
+		 */
 		parse: { total: number };
+
+		/**
+		 * The rules object containing all lint time information for each rule.
+		 */
 		rules?: Record<string, { total: number }>;
+
+		/**
+		 * The fix object containing all fix time information.
+		 */
 		fix: { total: number };
+
+		/**
+		 * The total time that is spent on (parsing, fixing, linting) a file.
+		 */
 		total: number;
 	}
 }
@@ -1915,7 +1981,10 @@ export namespace ESLint {
 		Omit<Linter.LegacyConfig<Rules>, "$schema">;
 
 	interface Environment {
+		/** The definition of global variables. */
 		globals?: Linter.Globals | undefined;
+
+		/** The parser options that will be enabled under this environment. */
 		parserOptions?: Linter.ParserOptions | undefined;
 	}
 
@@ -2022,21 +2091,48 @@ export namespace ESLint {
 		flags?: string[] | undefined;
 	}
 
+	/** A linting result. */
 	interface LintResult {
+		/** The path to the file that was linted. */
 		filePath: string;
+
+		/** All of the messages for the result. */
 		messages: Linter.LintMessage[];
+
+		/** All of the suppressed messages for the result. */
 		suppressedMessages: Linter.SuppressedLintMessage[];
+
+		/** Number of errors for the result. */
 		errorCount: number;
+
+		/** Number of fatal errors for the result. */
 		fatalErrorCount: number;
+
+		/** Number of warnings for the result. */
 		warningCount: number;
+
+		/** Number of fixable errors for the result. */
 		fixableErrorCount: number;
+
+		/** Number of fixable warnings for the result. */
 		fixableWarningCount: number;
+
+		/** The source code of the file that was linted, with as many fixes applied as possible. */
 		output?: string | undefined;
+
+		/** The source code of the file that was linted. */
 		source?: string | undefined;
+
+		/** The performance statistics collected with the `stats` flag. */
 		stats?: Linter.Stats | undefined;
+
+		/** The list of used deprecated rules. */
 		usedDeprecatedRules: DeprecatedRuleUse[];
 	}
 
+	/**
+	 * Information provided when the maximum warning threshold is exceeded.
+	 */
 	interface MaxWarningsExceeded {
 		/**
 		 * Number of warnings to trigger nonzero exit code.
@@ -2057,12 +2153,34 @@ export namespace ESLint {
 		};
 	}
 
+	/**
+	 * Information about deprecated rules.
+	 */
 	interface DeprecatedRuleUse {
+		/**
+		 * The rule ID.
+		 */
 		ruleId: string;
+
+		/**
+		 * The rule IDs that replace this deprecated rule.
+		 */
 		replacedBy: string[];
+
+		/**
+		 * The raw deprecated info provided by the rule.
+		 * Unset if the rule's `meta.deprecated` property is a boolean.
+		 */
+		info?: DeprecatedInfo;
 	}
 
+	/**
+	 * Metadata about results for formatters.
+	 */
 	interface ResultsMeta {
+		/**
+		 * Present if the maxWarnings threshold was exceeded.
+		 */
 		maxWarningsExceeded?: MaxWarningsExceeded | undefined;
 	}
 

package/lib/types/rules.d.ts

@@ -1800,6 +1800,10 @@ export interface ESLintRules extends Linter.RulesRecord {
 					 * @default 3
 					 */
 					max: number;
+					/**
+					 * @default false
+					 */
+					countVoidThis: boolean;
 			  }>
 			| number,
 		]
@@ -3710,6 +3714,14 @@ export interface ESLintRules extends Linter.RulesRecord {
 		]
 	>;
 
+	/**
+	 * Rule to disallow `let` or `var` variables that are read but never assigned.
+	 *
+	 * @since 9.27.0
+	 * @see https://eslint.org/docs/latest/rules/no-unassigned-vars
+	 */
+	"no-unassigned-vars": Linter.RuleEntry<[]>;
+
 	/**
 	 * Rule to disallow the use of undeclared variables unless mentioned in \/*global *\/ comments.
 	 *
@@ -4130,7 +4142,13 @@ export interface ESLintRules extends Linter.RulesRecord {
 	 * @since 2.5.0
 	 * @see https://eslint.org/docs/latest/rules/no-useless-escape
 	 */
-	"no-useless-escape": Linter.RuleEntry<[]>;
+	"no-useless-escape": Linter.RuleEntry<
+		[
+			Partial<{
+				allowRegexCharacters: string[];
+			}>,
+		]
+	>;
 
 	/**
 	 * Rule to disallow renaming import, export, and destructured assignments to the same name.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "9.26.0",
+  "version": "9.27.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "type": "commonjs",
@@ -108,14 +108,13 @@
     "@eslint-community/regexpp": "^4.12.1",
     "@eslint/config-array": "^0.20.0",
     "@eslint/config-helpers": "^0.2.1",
-    "@eslint/core": "^0.13.0",
+    "@eslint/core": "^0.14.0",
     "@eslint/eslintrc": "^3.3.1",
-    "@eslint/js": "9.26.0",
-    "@eslint/plugin-kit": "^0.2.8",
+    "@eslint/js": "9.27.0",
+    "@eslint/plugin-kit": "^0.3.1",
     "@humanfs/node": "^0.16.6",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@humanwhocodes/retry": "^0.4.2",
-    "@modelcontextprotocol/sdk": "^1.8.0",
     "@types/estree": "^1.0.6",
     "@types/json-schema": "^7.0.15",
     "ajv": "^6.12.4",
@@ -139,11 +138,10 @@
     "lodash.merge": "^4.6.2",
     "minimatch": "^3.1.2",
     "natural-compare": "^1.4.0",
-    "optionator": "^0.9.3",
-    "zod": "^3.24.2"
+    "optionator": "^0.9.3"
   },
   "devDependencies": {
-    "@arethetypeswrong/cli": "^0.17.0",
+    "@arethetypeswrong/cli": "^0.18.0",
     "@babel/core": "^7.4.3",
     "@babel/preset-env": "^7.4.3",
     "@cypress/webpack-preprocessor": "^6.0.2",