eslint 9.22.0 → 9.24.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +48 -46
- package/bin/eslint.js +92 -90
- package/conf/default-cli-options.js +22 -22
- package/conf/ecma-version.js +1 -1
- package/conf/globals.js +97 -98
- package/conf/replacements.json +24 -20
- package/conf/rule-type-list.json +88 -92
- package/lib/api.js +12 -12
- package/lib/cli-engine/cli-engine.js +830 -810
- package/lib/cli-engine/file-enumerator.js +381 -387
- package/lib/cli-engine/formatters/formatters-meta.json +16 -16
- package/lib/cli-engine/formatters/html.js +107 -99
- package/lib/cli-engine/formatters/json-with-metadata.js +5 -5
- package/lib/cli-engine/formatters/json.js +2 -2
- package/lib/cli-engine/formatters/stylish.js +96 -75
- package/lib/cli-engine/hash.js +1 -1
- package/lib/cli-engine/index.js +1 -1
- package/lib/cli-engine/lint-result-cache.js +144 -145
- package/lib/cli-engine/load-rules.js +16 -16
- package/lib/cli.js +638 -457
- package/lib/config/config-loader.js +726 -622
- package/lib/config/config.js +247 -221
- package/lib/config/default-config.js +54 -45
- package/lib/config/flat-config-array.js +167 -172
- package/lib/config/flat-config-helpers.js +72 -72
- package/lib/config/flat-config-schema.js +375 -368
- package/lib/config/rule-validator.js +139 -144
- package/lib/config-api.js +2 -2
- package/lib/eslint/eslint-helpers.js +756 -681
- package/lib/eslint/eslint.js +934 -912
- package/lib/eslint/index.js +2 -2
- package/lib/eslint/legacy-eslint.js +577 -533
- package/lib/languages/js/index.js +263 -264
- package/lib/languages/js/source-code/index.js +1 -1
- package/lib/languages/js/source-code/source-code.js +1128 -1057
- package/lib/languages/js/source-code/token-store/backward-token-comment-cursor.js +39 -35
- package/lib/languages/js/source-code/token-store/backward-token-cursor.js +35 -36
- package/lib/languages/js/source-code/token-store/cursor.js +36 -36
- package/lib/languages/js/source-code/token-store/cursors.js +80 -52
- package/lib/languages/js/source-code/token-store/decorative-cursor.js +17 -18
- package/lib/languages/js/source-code/token-store/filter-cursor.js +19 -20
- package/lib/languages/js/source-code/token-store/forward-token-comment-cursor.js +40 -32
- package/lib/languages/js/source-code/token-store/forward-token-cursor.js +40 -41
- package/lib/languages/js/source-code/token-store/index.js +592 -498
- package/lib/languages/js/source-code/token-store/limit-cursor.js +17 -18
- package/lib/languages/js/source-code/token-store/padded-token-cursor.js +23 -16
- package/lib/languages/js/source-code/token-store/skip-cursor.js +19 -20
- package/lib/languages/js/source-code/token-store/utils.js +63 -60
- package/lib/languages/js/validate-language-options.js +104 -89
- package/lib/linter/apply-disable-directives.js +467 -383
- package/lib/linter/code-path-analysis/code-path-analyzer.js +650 -672
- package/lib/linter/code-path-analysis/code-path-segment.js +215 -216
- package/lib/linter/code-path-analysis/code-path-state.js +2118 -2096
- package/lib/linter/code-path-analysis/code-path.js +307 -319
- package/lib/linter/code-path-analysis/debug-helpers.js +183 -163
- package/lib/linter/code-path-analysis/fork-context.js +296 -271
- package/lib/linter/code-path-analysis/id-generator.js +22 -23
- package/lib/linter/file-context.js +119 -120
- package/lib/linter/index.js +3 -3
- package/lib/linter/interpolate.js +16 -16
- package/lib/linter/linter.js +2403 -2045
- package/lib/linter/node-event-generator.js +284 -225
- package/lib/linter/report-translator.js +256 -219
- package/lib/linter/rule-fixer.js +122 -124
- package/lib/linter/rules.js +36 -36
- package/lib/linter/safe-emitter.js +18 -18
- package/lib/linter/source-code-fixer.js +94 -92
- package/lib/linter/timing.js +104 -101
- package/lib/linter/vfile.js +70 -73
- package/lib/options.js +404 -361
- package/lib/rule-tester/index.js +1 -1
- package/lib/rule-tester/rule-tester.js +1308 -1046
- package/lib/rules/accessor-pairs.js +298 -263
- package/lib/rules/array-bracket-newline.js +250 -238
- package/lib/rules/array-bracket-spacing.js +263 -224
- package/lib/rules/array-callback-return.js +402 -356
- package/lib/rules/array-element-newline.js +358 -313
- package/lib/rules/arrow-body-style.js +400 -281
- package/lib/rules/arrow-parens.js +206 -173
- package/lib/rules/arrow-spacing.js +169 -163
- package/lib/rules/block-scoped-var.js +125 -123
- package/lib/rules/block-spacing.js +186 -176
- package/lib/rules/brace-style.js +262 -199
- package/lib/rules/callback-return.js +203 -190
- package/lib/rules/camelcase.js +403 -392
- package/lib/rules/capitalized-comments.js +253 -232
- package/lib/rules/class-methods-use-this.js +224 -172
- package/lib/rules/comma-dangle.js +379 -346
- package/lib/rules/comma-spacing.js +193 -195
- package/lib/rules/comma-style.js +375 -316
- package/lib/rules/complexity.js +173 -169
- package/lib/rules/computed-property-spacing.js +236 -211
- package/lib/rules/consistent-return.js +181 -170
- package/lib/rules/consistent-this.js +167 -147
- package/lib/rules/constructor-super.js +412 -404
- package/lib/rules/curly.js +407 -332
- package/lib/rules/default-case-last.js +38 -31
- package/lib/rules/default-case.js +89 -85
- package/lib/rules/default-param-last.js +69 -54
- package/lib/rules/dot-location.js +122 -110
- package/lib/rules/dot-notation.js +192 -156
- package/lib/rules/eol-last.js +122 -120
- package/lib/rules/eqeqeq.js +168 -155
- package/lib/rules/for-direction.js +146 -121
- package/lib/rules/func-call-spacing.js +261 -231
- package/lib/rules/func-name-matching.js +293 -209
- package/lib/rules/func-names.js +165 -164
- package/lib/rules/func-style.js +159 -127
- package/lib/rules/function-call-argument-newline.js +152 -129
- package/lib/rules/function-paren-newline.js +349 -291
- package/lib/rules/generator-star-spacing.js +229 -210
- package/lib/rules/getter-return.js +208 -172
- package/lib/rules/global-require.js +85 -74
- package/lib/rules/grouped-accessor-pairs.js +170 -150
- package/lib/rules/guard-for-in.js +72 -63
- package/lib/rules/handle-callback-err.js +108 -103
- package/lib/rules/id-blacklist.js +182 -199
- package/lib/rules/id-denylist.js +168 -187
- package/lib/rules/id-length.js +197 -171
- package/lib/rules/id-match.js +344 -289
- package/lib/rules/implicit-arrow-linebreak.js +102 -79
- package/lib/rules/indent-legacy.js +1344 -1118
- package/lib/rules/indent.js +2272 -1759
- package/lib/rules/index.js +317 -292
- package/lib/rules/init-declarations.js +137 -107
- package/lib/rules/jsx-quotes.js +94 -82
- package/lib/rules/key-spacing.js +750 -633
- package/lib/rules/keyword-spacing.js +648 -605
- package/lib/rules/line-comment-position.js +142 -128
- package/lib/rules/linebreak-style.js +107 -106
- package/lib/rules/lines-around-comment.js +540 -448
- package/lib/rules/lines-around-directive.js +233 -203
- package/lib/rules/lines-between-class-members.js +305 -234
- package/lib/rules/logical-assignment-operators.js +582 -399
- package/lib/rules/max-classes-per-file.js +69 -68
- package/lib/rules/max-depth.js +146 -143
- package/lib/rules/max-len.js +473 -434
- package/lib/rules/max-lines-per-function.js +201 -176
- package/lib/rules/max-lines.js +158 -162
- package/lib/rules/max-nested-callbacks.js +102 -104
- package/lib/rules/max-params.js +78 -76
- package/lib/rules/max-statements-per-line.js +205 -198
- package/lib/rules/max-statements.js +168 -164
- package/lib/rules/multiline-comment-style.js +637 -479
- package/lib/rules/multiline-ternary.js +241 -176
- package/lib/rules/new-cap.js +233 -213
- package/lib/rules/new-parens.js +88 -79
- package/lib/rules/newline-after-var.js +287 -250
- package/lib/rules/newline-before-return.js +229 -222
- package/lib/rules/newline-per-chained-call.js +142 -127
- package/lib/rules/no-alert.js +90 -79
- package/lib/rules/no-array-constructor.js +125 -113
- package/lib/rules/no-async-promise-executor.js +30 -24
- package/lib/rules/no-await-in-loop.js +69 -71
- package/lib/rules/no-bitwise.js +124 -100
- package/lib/rules/no-buffer-constructor.js +55 -47
- package/lib/rules/no-caller.js +39 -33
- package/lib/rules/no-case-declarations.js +61 -57
- package/lib/rules/no-catch-shadow.js +76 -73
- package/lib/rules/no-class-assign.js +51 -48
- package/lib/rules/no-compare-neg-zero.js +62 -48
- package/lib/rules/no-cond-assign.js +148 -132
- package/lib/rules/no-confusing-arrow.js +98 -81
- package/lib/rules/no-console.js +202 -199
- package/lib/rules/no-const-assign.js +47 -41
- package/lib/rules/no-constant-binary-expression.js +500 -405
- package/lib/rules/no-constant-condition.js +158 -143
- package/lib/rules/no-constructor-return.js +49 -49
- package/lib/rules/no-continue.js +25 -27
- package/lib/rules/no-control-regex.js +125 -121
- package/lib/rules/no-debugger.js +28 -30
- package/lib/rules/no-delete-var.js +29 -29
- package/lib/rules/no-div-regex.js +47 -41
- package/lib/rules/no-dupe-args.js +68 -69
- package/lib/rules/no-dupe-class-members.js +102 -89
- package/lib/rules/no-dupe-else-if.js +100 -77
- package/lib/rules/no-dupe-keys.js +133 -110
- package/lib/rules/no-duplicate-case.js +50 -43
- package/lib/rules/no-duplicate-imports.js +179 -176
- package/lib/rules/no-else-return.js +430 -385
- package/lib/rules/no-empty-character-class.js +57 -50
- package/lib/rules/no-empty-function.js +127 -128
- package/lib/rules/no-empty-pattern.js +63 -58
- package/lib/rules/no-empty-static-block.js +37 -35
- package/lib/rules/no-empty.js +98 -86
- package/lib/rules/no-eq-null.js +37 -32
- package/lib/rules/no-eval.js +256 -250
- package/lib/rules/no-ex-assign.js +42 -39
- package/lib/rules/no-extend-native.js +161 -159
- package/lib/rules/no-extra-bind.js +201 -190
- package/lib/rules/no-extra-boolean-cast.js +398 -348
- package/lib/rules/no-extra-label.js +150 -131
- package/lib/rules/no-extra-parens.js +1654 -1325
- package/lib/rules/no-extra-semi.js +146 -144
- package/lib/rules/no-fallthrough.js +199 -157
- package/lib/rules/no-floating-decimal.js +74 -66
- package/lib/rules/no-func-assign.js +54 -55
- package/lib/rules/no-global-assign.js +78 -73
- package/lib/rules/no-implicit-coercion.js +349 -293
- package/lib/rules/no-implicit-globals.js +158 -135
- package/lib/rules/no-implied-eval.js +140 -112
- package/lib/rules/no-import-assign.js +145 -159
- package/lib/rules/no-inline-comments.js +101 -95
- package/lib/rules/no-inner-declarations.js +115 -101
- package/lib/rules/no-invalid-regexp.js +222 -190
- package/lib/rules/no-invalid-this.js +123 -117
- package/lib/rules/no-irregular-whitespace.js +266 -252
- package/lib/rules/no-iterator.js +29 -33
- package/lib/rules/no-label-var.js +59 -62
- package/lib/rules/no-labels.js +138 -133
- package/lib/rules/no-lone-blocks.js +127 -123
- package/lib/rules/no-lonely-if.js +108 -77
- package/lib/rules/no-loop-func.js +238 -213
- package/lib/rules/no-loss-of-precision.js +218 -201
- package/lib/rules/no-magic-numbers.js +246 -218
- package/lib/rules/no-misleading-character-class.js +499 -446
- package/lib/rules/no-mixed-operators.js +188 -182
- package/lib/rules/no-mixed-requires.js +253 -240
- package/lib/rules/no-mixed-spaces-and-tabs.js +134 -121
- package/lib/rules/no-multi-assign.js +46 -44
- package/lib/rules/no-multi-spaces.js +163 -143
- package/lib/rules/no-multi-str.js +42 -41
- package/lib/rules/no-multiple-empty-lines.js +196 -158
- package/lib/rules/no-native-reassign.js +90 -85
- package/lib/rules/no-negated-condition.js +79 -75
- package/lib/rules/no-negated-in-lhs.js +45 -43
- package/lib/rules/no-nested-ternary.js +33 -32
- package/lib/rules/no-new-func.js +71 -62
- package/lib/rules/no-new-native-nonconstructor.js +43 -39
- package/lib/rules/no-new-object.js +48 -48
- package/lib/rules/no-new-require.js +48 -47
- package/lib/rules/no-new-symbol.js +52 -50
- package/lib/rules/no-new-wrappers.js +43 -41
- package/lib/rules/no-new.js +28 -29
- package/lib/rules/no-nonoctal-decimal-escape.js +141 -121
- package/lib/rules/no-obj-calls.js +66 -53
- package/lib/rules/no-object-constructor.js +104 -97
- package/lib/rules/no-octal-escape.js +40 -43
- package/lib/rules/no-octal.js +32 -32
- package/lib/rules/no-param-reassign.js +235 -217
- package/lib/rules/no-path-concat.js +66 -67
- package/lib/rules/no-plusplus.js +60 -61
- package/lib/rules/no-process-env.js +49 -48
- package/lib/rules/no-process-exit.js +54 -50
- package/lib/rules/no-promise-executor-return.js +214 -182
- package/lib/rules/no-proto.js +26 -29
- package/lib/rules/no-prototype-builtins.js +146 -124
- package/lib/rules/no-redeclare.js +154 -152
- package/lib/rules/no-regex-spaces.js +183 -161
- package/lib/rules/no-restricted-exports.js +208 -185
- package/lib/rules/no-restricted-globals.js +111 -112
- package/lib/rules/no-restricted-imports.js +657 -537
- package/lib/rules/no-restricted-modules.js +222 -202
- package/lib/rules/no-restricted-properties.js +181 -153
- package/lib/rules/no-restricted-syntax.js +56 -52
- package/lib/rules/no-return-assign.js +55 -50
- package/lib/rules/no-return-await.js +148 -124
- package/lib/rules/no-script-url.js +52 -45
- package/lib/rules/no-self-assign.js +148 -146
- package/lib/rules/no-self-compare.js +63 -46
- package/lib/rules/no-sequences.js +135 -116
- package/lib/rules/no-setter-return.js +185 -152
- package/lib/rules/no-shadow-restricted-names.js +61 -46
- package/lib/rules/no-shadow.js +342 -316
- package/lib/rules/no-spaced-func.js +82 -77
- package/lib/rules/no-sparse-arrays.js +54 -59
- package/lib/rules/no-sync.js +61 -60
- package/lib/rules/no-tabs.js +83 -72
- package/lib/rules/no-template-curly-in-string.js +33 -32
- package/lib/rules/no-ternary.js +25 -29
- package/lib/rules/no-this-before-super.js +321 -319
- package/lib/rules/no-throw-literal.js +31 -36
- package/lib/rules/no-trailing-spaces.js +199 -191
- package/lib/rules/no-undef-init.js +76 -61
- package/lib/rules/no-undef.js +51 -48
- package/lib/rules/no-undefined.js +73 -75
- package/lib/rules/no-underscore-dangle.js +370 -327
- package/lib/rules/no-unexpected-multiline.js +112 -102
- package/lib/rules/no-unmodified-loop-condition.js +254 -254
- package/lib/rules/no-unneeded-ternary.js +212 -147
- package/lib/rules/no-unreachable-loop.js +145 -142
- package/lib/rules/no-unreachable.js +255 -248
- package/lib/rules/no-unsafe-finally.js +93 -85
- package/lib/rules/no-unsafe-negation.js +105 -83
- package/lib/rules/no-unsafe-optional-chaining.js +192 -178
- package/lib/rules/no-unused-expressions.js +178 -162
- package/lib/rules/no-unused-labels.js +139 -124
- package/lib/rules/no-unused-private-class-members.js +206 -182
- package/lib/rules/no-unused-vars.js +1669 -1449
- package/lib/rules/no-use-before-define.js +229 -231
- package/lib/rules/no-useless-assignment.js +590 -511
- package/lib/rules/no-useless-backreference.js +212 -193
- package/lib/rules/no-useless-call.js +58 -53
- package/lib/rules/no-useless-catch.js +40 -40
- package/lib/rules/no-useless-computed-key.js +144 -115
- package/lib/rules/no-useless-concat.js +65 -60
- package/lib/rules/no-useless-constructor.js +158 -111
- package/lib/rules/no-useless-escape.js +342 -291
- package/lib/rules/no-useless-rename.js +183 -156
- package/lib/rules/no-useless-return.js +344 -312
- package/lib/rules/no-var.js +233 -212
- package/lib/rules/no-void.js +50 -48
- package/lib/rules/no-warning-comments.js +191 -186
- package/lib/rules/no-whitespace-before-property.js +131 -115
- package/lib/rules/no-with.js +24 -26
- package/lib/rules/nonblock-statement-body-position.js +149 -130
- package/lib/rules/object-curly-newline.js +306 -265
- package/lib/rules/object-curly-spacing.js +360 -314
- package/lib/rules/object-property-newline.js +137 -106
- package/lib/rules/object-shorthand.js +607 -502
- package/lib/rules/one-var-declaration-per-line.js +104 -100
- package/lib/rules/one-var.js +653 -537
- package/lib/rules/operator-assignment.js +219 -161
- package/lib/rules/operator-linebreak.js +295 -251
- package/lib/rules/padded-blocks.js +346 -308
- package/lib/rules/padding-line-between-statements.js +443 -439
- package/lib/rules/prefer-arrow-callback.js +362 -313
- package/lib/rules/prefer-const.js +418 -377
- package/lib/rules/prefer-destructuring.js +301 -279
- package/lib/rules/prefer-exponentiation-operator.js +176 -133
- package/lib/rules/prefer-named-capture-group.js +153 -140
- package/lib/rules/prefer-numeric-literals.js +121 -113
- package/lib/rules/prefer-object-has-own.js +116 -82
- package/lib/rules/prefer-object-spread.js +213 -193
- package/lib/rules/prefer-promise-reject-errors.js +140 -122
- package/lib/rules/prefer-reflect.js +127 -107
- package/lib/rules/prefer-regex-literals.js +578 -466
- package/lib/rules/prefer-rest-params.js +79 -80
- package/lib/rules/prefer-spread.js +47 -44
- package/lib/rules/prefer-template.js +266 -195
- package/lib/rules/quote-props.js +373 -307
- package/lib/rules/quotes.js +374 -326
- package/lib/rules/radix.js +152 -136
- package/lib/rules/require-atomic-updates.js +316 -285
- package/lib/rules/require-await.js +144 -116
- package/lib/rules/require-unicode-regexp.js +282 -177
- package/lib/rules/require-yield.js +53 -54
- package/lib/rules/rest-spread-spacing.js +128 -116
- package/lib/rules/semi-spacing.js +281 -250
- package/lib/rules/semi-style.js +176 -134
- package/lib/rules/semi.js +456 -436
- package/lib/rules/sort-imports.js +306 -233
- package/lib/rules/sort-keys.js +219 -188
- package/lib/rules/sort-vars.js +127 -93
- package/lib/rules/space-before-blocks.js +199 -189
- package/lib/rules/space-before-function-paren.js +186 -166
- package/lib/rules/space-in-parens.js +359 -288
- package/lib/rules/space-infix-ops.js +237 -201
- package/lib/rules/space-unary-ops.js +356 -298
- package/lib/rules/spaced-comment.js +363 -319
- package/lib/rules/strict.js +265 -230
- package/lib/rules/switch-colon-spacing.js +130 -122
- package/lib/rules/symbol-description.js +45 -48
- package/lib/rules/template-curly-spacing.js +148 -142
- package/lib/rules/template-tag-spacing.js +98 -88
- package/lib/rules/unicode-bom.js +54 -56
- package/lib/rules/use-isnan.js +237 -206
- package/lib/rules/utils/ast-utils.js +2039 -1860
- package/lib/rules/utils/char-source.js +162 -155
- package/lib/rules/utils/fix-tracker.js +83 -80
- package/lib/rules/utils/keywords.js +59 -59
- package/lib/rules/utils/lazy-loading-rule-map.js +79 -76
- package/lib/rules/utils/regular-expressions.js +32 -24
- package/lib/rules/utils/unicode/index.js +4 -4
- package/lib/rules/utils/unicode/is-combining-character.js +1 -1
- package/lib/rules/utils/unicode/is-emoji-modifier.js +1 -1
- package/lib/rules/utils/unicode/is-regional-indicator-symbol.js +1 -1
- package/lib/rules/utils/unicode/is-surrogate-pair.js +1 -1
- package/lib/rules/valid-typeof.js +153 -111
- package/lib/rules/vars-on-top.js +152 -145
- package/lib/rules/wrap-iife.js +204 -191
- package/lib/rules/wrap-regex.js +70 -58
- package/lib/rules/yield-star-spacing.js +145 -134
- package/lib/rules/yoda.js +283 -272
- package/lib/services/parser-service.js +35 -35
- package/lib/services/processor-service.js +66 -73
- package/lib/services/suppressions-service.js +289 -0
- package/lib/shared/ajv.js +14 -14
- package/lib/shared/assert.js +3 -4
- package/lib/shared/ast-utils.js +7 -6
- package/lib/shared/deep-merge-arrays.js +24 -22
- package/lib/shared/directives.js +3 -2
- package/lib/shared/flags.js +50 -17
- package/lib/shared/logging.js +24 -25
- package/lib/shared/option-utils.js +43 -36
- package/lib/shared/runtime-info.js +136 -127
- package/lib/shared/serialization.js +27 -27
- package/lib/shared/severity.js +22 -22
- package/lib/shared/stats.js +5 -5
- package/lib/shared/string-utils.js +16 -16
- package/lib/shared/text-table.js +28 -27
- package/lib/shared/traverser.js +153 -146
- package/lib/shared/types.js +4 -27
- package/lib/types/index.d.ts +2010 -1559
- package/lib/types/rules.d.ts +5253 -5140
- package/lib/types/use-at-your-own-risk.d.ts +32 -30
- package/lib/unsupported-api.js +5 -5
- package/messages/all-files-ignored.js +3 -3
- package/messages/all-matched-files-ignored.js +3 -3
- package/messages/config-file-missing.js +2 -2
- package/messages/config-plugin-missing.js +3 -3
- package/messages/config-serialize-function.js +9 -7
- package/messages/eslintrc-incompat.js +13 -15
- package/messages/eslintrc-plugins.js +3 -4
- package/messages/extend-config-missing.js +3 -3
- package/messages/failed-to-read-json.js +3 -3
- package/messages/file-not-found.js +3 -3
- package/messages/invalid-rule-options.js +2 -2
- package/messages/invalid-rule-severity.js +2 -2
- package/messages/no-config-found.js +3 -3
- package/messages/plugin-conflict.js +8 -8
- package/messages/plugin-invalid.js +3 -3
- package/messages/plugin-missing.js +3 -3
- package/messages/print-config-with-directory-path.js +2 -2
- package/messages/shared.js +6 -1
- package/messages/whitespace-found.js +3 -3
- package/package.json +14 -20
@@ -22,14 +22,16 @@ const baseTypes = new Set(["Identifier", "Super", "ThisExpression"]);
|
|
22
22
|
* @returns {boolean} True iff "undefined" or "void ..."
|
23
23
|
*/
|
24
24
|
function isUndefined(expression, scope) {
|
25
|
-
|
26
|
-
|
27
|
-
|
28
|
-
|
29
|
-
|
30
|
-
|
31
|
-
|
32
|
-
|
25
|
+
if (expression.type === "Identifier" && expression.name === "undefined") {
|
26
|
+
return astUtils.isReferenceToGlobalVariable(scope, expression);
|
27
|
+
}
|
28
|
+
|
29
|
+
return (
|
30
|
+
expression.type === "UnaryExpression" &&
|
31
|
+
expression.operator === "void" &&
|
32
|
+
expression.argument.type === "Literal" &&
|
33
|
+
expression.argument.value === 0
|
34
|
+
);
|
33
35
|
}
|
34
36
|
|
35
37
|
/**
|
@@ -38,8 +40,10 @@ function isUndefined(expression, scope) {
|
|
38
40
|
* @returns {boolean} True for identifiers and member expressions
|
39
41
|
*/
|
40
42
|
function isReference(expression) {
|
41
|
-
|
42
|
-
|
43
|
+
return (
|
44
|
+
(expression.type === "Identifier" && expression.name !== "undefined") ||
|
45
|
+
expression.type === "MemberExpression"
|
46
|
+
);
|
43
47
|
}
|
44
48
|
|
45
49
|
/**
|
@@ -50,15 +54,21 @@ function isReference(expression) {
|
|
50
54
|
* @returns {boolean} True iff implicit nullish comparison
|
51
55
|
*/
|
52
56
|
function isImplicitNullishComparison(expression, scope) {
|
53
|
-
|
54
|
-
|
55
|
-
|
56
|
-
|
57
|
-
|
58
|
-
|
59
|
-
|
60
|
-
|
61
|
-
|
57
|
+
if (
|
58
|
+
expression.type !== "BinaryExpression" ||
|
59
|
+
expression.operator !== "=="
|
60
|
+
) {
|
61
|
+
return false;
|
62
|
+
}
|
63
|
+
|
64
|
+
const reference = isReference(expression.left) ? "left" : "right";
|
65
|
+
const nullish = reference === "left" ? "right" : "left";
|
66
|
+
|
67
|
+
return (
|
68
|
+
isReference(expression[reference]) &&
|
69
|
+
(astUtils.isNullLiteral(expression[nullish]) ||
|
70
|
+
isUndefined(expression[nullish], scope))
|
71
|
+
);
|
62
72
|
}
|
63
73
|
|
64
74
|
/**
|
@@ -67,12 +77,14 @@ function isImplicitNullishComparison(expression, scope) {
|
|
67
77
|
* @returns {boolean} True iff matches ? === ? || ? === ?
|
68
78
|
*/
|
69
79
|
function isDoubleComparison(expression) {
|
70
|
-
|
71
|
-
|
72
|
-
|
73
|
-
|
74
|
-
|
75
|
-
|
80
|
+
return (
|
81
|
+
expression.type === "LogicalExpression" &&
|
82
|
+
expression.operator === "||" &&
|
83
|
+
expression.left.type === "BinaryExpression" &&
|
84
|
+
expression.left.operator === "===" &&
|
85
|
+
expression.right.type === "BinaryExpression" &&
|
86
|
+
expression.right.operator === "==="
|
87
|
+
);
|
76
88
|
}
|
77
89
|
|
78
90
|
/**
|
@@ -83,17 +95,26 @@ function isDoubleComparison(expression) {
|
|
83
95
|
* @returns {boolean} True iff explicit nullish comparison
|
84
96
|
*/
|
85
97
|
function isExplicitNullishComparison(expression, scope) {
|
86
|
-
|
87
|
-
|
88
|
-
|
89
|
-
|
90
|
-
|
91
|
-
|
92
|
-
|
93
|
-
|
94
|
-
|
95
|
-
|
96
|
-
|
98
|
+
if (!isDoubleComparison(expression)) {
|
99
|
+
return false;
|
100
|
+
}
|
101
|
+
const leftReference = isReference(expression.left.left) ? "left" : "right";
|
102
|
+
const leftNullish = leftReference === "left" ? "right" : "left";
|
103
|
+
const rightReference = isReference(expression.right.left)
|
104
|
+
? "left"
|
105
|
+
: "right";
|
106
|
+
const rightNullish = rightReference === "left" ? "right" : "left";
|
107
|
+
|
108
|
+
return (
|
109
|
+
astUtils.isSameReference(
|
110
|
+
expression.left[leftReference],
|
111
|
+
expression.right[rightReference],
|
112
|
+
) &&
|
113
|
+
((astUtils.isNullLiteral(expression.left[leftNullish]) &&
|
114
|
+
isUndefined(expression.right[rightNullish], scope)) ||
|
115
|
+
(isUndefined(expression.left[leftNullish], scope) &&
|
116
|
+
astUtils.isNullLiteral(expression.right[rightNullish])))
|
117
|
+
);
|
97
118
|
}
|
98
119
|
|
99
120
|
/**
|
@@ -103,10 +124,12 @@ function isExplicitNullishComparison(expression, scope) {
|
|
103
124
|
* @returns {boolean} Whether the expression is a boolean cast
|
104
125
|
*/
|
105
126
|
function isBooleanCast(expression, scope) {
|
106
|
-
|
107
|
-
|
108
|
-
|
109
|
-
|
127
|
+
return (
|
128
|
+
expression.type === "CallExpression" &&
|
129
|
+
expression.callee.name === "Boolean" &&
|
130
|
+
expression.arguments.length === 1 &&
|
131
|
+
astUtils.isReferenceToGlobalVariable(scope, expression.callee)
|
132
|
+
);
|
110
133
|
}
|
111
134
|
|
112
135
|
/**
|
@@ -119,22 +142,39 @@ function isBooleanCast(expression, scope) {
|
|
119
142
|
* @returns {?{ reference: ASTNode, operator: '??'|'||'|'&&'}} Null if not a known existence
|
120
143
|
*/
|
121
144
|
function getExistence(expression, scope) {
|
122
|
-
|
123
|
-
|
124
|
-
|
125
|
-
|
126
|
-
|
127
|
-
|
128
|
-
|
129
|
-
|
130
|
-
|
131
|
-
|
132
|
-
|
133
|
-
|
134
|
-
|
135
|
-
|
136
|
-
|
137
|
-
|
145
|
+
const isNegated =
|
146
|
+
expression.type === "UnaryExpression" && expression.operator === "!";
|
147
|
+
const base = isNegated ? expression.argument : expression;
|
148
|
+
|
149
|
+
switch (true) {
|
150
|
+
case isReference(base):
|
151
|
+
return { reference: base, operator: isNegated ? "||" : "&&" };
|
152
|
+
case base.type === "UnaryExpression" &&
|
153
|
+
base.operator === "!" &&
|
154
|
+
isReference(base.argument):
|
155
|
+
return { reference: base.argument, operator: "&&" };
|
156
|
+
case isBooleanCast(base, scope) && isReference(base.arguments[0]):
|
157
|
+
return {
|
158
|
+
reference: base.arguments[0],
|
159
|
+
operator: isNegated ? "||" : "&&",
|
160
|
+
};
|
161
|
+
case isImplicitNullishComparison(expression, scope):
|
162
|
+
return {
|
163
|
+
reference: isReference(expression.left)
|
164
|
+
? expression.left
|
165
|
+
: expression.right,
|
166
|
+
operator: "??",
|
167
|
+
};
|
168
|
+
case isExplicitNullishComparison(expression, scope):
|
169
|
+
return {
|
170
|
+
reference: isReference(expression.left.left)
|
171
|
+
? expression.left.left
|
172
|
+
: expression.left.right,
|
173
|
+
operator: "??",
|
174
|
+
};
|
175
|
+
default:
|
176
|
+
return null;
|
177
|
+
}
|
138
178
|
}
|
139
179
|
|
140
180
|
/**
|
@@ -143,11 +183,13 @@ function getExistence(expression, scope) {
|
|
143
183
|
* @returns {boolean} True iff passed node is inside a with block
|
144
184
|
*/
|
145
185
|
function isInsideWithBlock(node) {
|
146
|
-
|
147
|
-
|
148
|
-
|
186
|
+
if (node.type === "Program") {
|
187
|
+
return false;
|
188
|
+
}
|
149
189
|
|
150
|
-
|
190
|
+
return node.parent.type === "WithStatement" && node.parent.body === node
|
191
|
+
? true
|
192
|
+
: isInsideWithBlock(node.parent);
|
151
193
|
}
|
152
194
|
|
153
195
|
/**
|
@@ -157,349 +199,490 @@ function isInsideWithBlock(node) {
|
|
157
199
|
* @returns {Expression} Leftmost operand
|
158
200
|
*/
|
159
201
|
function getLeftmostOperand(sourceCode, node) {
|
160
|
-
|
161
|
-
|
162
|
-
|
163
|
-
|
164
|
-
|
165
|
-
|
166
|
-
|
167
|
-
|
168
|
-
|
169
|
-
|
170
|
-
|
171
|
-
|
172
|
-
|
173
|
-
|
174
|
-
|
175
|
-
|
202
|
+
let left = node.left;
|
203
|
+
|
204
|
+
while (
|
205
|
+
left.type === "LogicalExpression" &&
|
206
|
+
left.operator === node.operator
|
207
|
+
) {
|
208
|
+
if (astUtils.isParenthesised(sourceCode, left)) {
|
209
|
+
/*
|
210
|
+
* It should have associativity,
|
211
|
+
* but ignore it if use parentheses to make the evaluation order clear.
|
212
|
+
*/
|
213
|
+
return left;
|
214
|
+
}
|
215
|
+
left = left.left;
|
216
|
+
}
|
217
|
+
return left;
|
176
218
|
}
|
177
219
|
|
178
220
|
//------------------------------------------------------------------------------
|
179
221
|
// Rule Definition
|
180
222
|
//------------------------------------------------------------------------------
|
181
|
-
/** @type {import('../
|
223
|
+
/** @type {import('../types').Rule.RuleModule} */
|
182
224
|
module.exports = {
|
183
|
-
|
184
|
-
|
185
|
-
|
186
|
-
|
187
|
-
|
188
|
-
|
189
|
-
|
190
|
-
|
191
|
-
|
192
|
-
|
193
|
-
|
194
|
-
|
195
|
-
|
196
|
-
|
197
|
-
|
198
|
-
|
199
|
-
|
200
|
-
|
201
|
-
|
202
|
-
|
203
|
-
|
204
|
-
|
205
|
-
|
206
|
-
|
207
|
-
|
208
|
-
|
209
|
-
|
210
|
-
|
211
|
-
|
212
|
-
|
213
|
-
|
214
|
-
|
215
|
-
|
216
|
-
|
217
|
-
|
218
|
-
|
219
|
-
|
220
|
-
|
221
|
-
|
222
|
-
|
223
|
-
|
224
|
-
|
225
|
-
|
226
|
-
|
227
|
-
|
228
|
-
|
229
|
-
|
230
|
-
|
231
|
-
|
232
|
-
|
233
|
-
|
234
|
-
|
235
|
-
|
236
|
-
|
237
|
-
|
238
|
-
|
239
|
-
|
240
|
-
|
241
|
-
|
242
|
-
|
243
|
-
|
244
|
-
|
245
|
-
|
246
|
-
|
247
|
-
|
248
|
-
|
249
|
-
|
250
|
-
|
251
|
-
|
252
|
-
|
253
|
-
|
254
|
-
|
255
|
-
|
256
|
-
|
257
|
-
|
258
|
-
|
259
|
-
|
260
|
-
|
261
|
-
|
262
|
-
|
263
|
-
|
264
|
-
|
265
|
-
|
266
|
-
|
267
|
-
|
268
|
-
|
269
|
-
|
270
|
-
|
271
|
-
|
272
|
-
|
273
|
-
|
274
|
-
|
275
|
-
|
276
|
-
|
277
|
-
|
278
|
-
|
279
|
-
|
280
|
-
|
281
|
-
|
282
|
-
|
283
|
-
|
284
|
-
|
285
|
-
|
286
|
-
|
287
|
-
|
288
|
-
|
289
|
-
|
290
|
-
|
291
|
-
|
292
|
-
|
293
|
-
|
294
|
-
|
295
|
-
|
296
|
-
|
297
|
-
|
298
|
-
|
299
|
-
|
300
|
-
|
301
|
-
|
302
|
-
|
303
|
-
|
304
|
-
|
305
|
-
|
306
|
-
|
307
|
-
|
308
|
-
|
309
|
-
|
310
|
-
|
311
|
-
|
312
|
-
|
313
|
-
|
314
|
-
|
315
|
-
|
316
|
-
|
317
|
-
|
318
|
-
|
319
|
-
|
320
|
-
|
321
|
-
|
322
|
-
|
323
|
-
|
324
|
-
|
325
|
-
|
326
|
-
|
327
|
-
|
328
|
-
|
329
|
-
|
330
|
-
|
331
|
-
|
332
|
-
|
333
|
-
|
334
|
-
|
335
|
-
|
336
|
-
|
337
|
-
|
338
|
-
|
339
|
-
|
340
|
-
|
341
|
-
|
342
|
-
|
343
|
-
|
344
|
-
|
345
|
-
|
346
|
-
|
347
|
-
|
348
|
-
|
349
|
-
|
350
|
-
|
351
|
-
|
352
|
-
|
353
|
-
|
354
|
-
|
355
|
-
|
356
|
-
|
357
|
-
|
358
|
-
|
359
|
-
|
360
|
-
|
361
|
-
|
362
|
-
|
363
|
-
|
364
|
-
|
365
|
-
|
366
|
-
|
367
|
-
|
368
|
-
|
369
|
-
|
370
|
-
|
371
|
-
|
372
|
-
|
373
|
-
|
374
|
-
|
375
|
-
|
376
|
-
|
377
|
-
|
378
|
-
|
379
|
-
|
380
|
-
|
381
|
-
|
382
|
-
|
383
|
-
|
384
|
-
|
385
|
-
|
386
|
-
|
387
|
-
|
388
|
-
|
389
|
-
|
390
|
-
|
391
|
-
|
392
|
-
|
393
|
-
|
394
|
-
|
395
|
-
|
396
|
-
|
397
|
-
|
398
|
-
|
399
|
-
|
400
|
-
|
401
|
-
|
402
|
-
|
403
|
-
|
404
|
-
|
405
|
-
|
406
|
-
|
407
|
-
|
408
|
-
|
409
|
-
|
410
|
-
|
411
|
-
|
412
|
-
|
413
|
-
|
414
|
-
|
415
|
-
|
416
|
-
|
417
|
-
|
418
|
-
|
419
|
-
|
420
|
-
|
421
|
-
|
422
|
-
|
423
|
-
|
424
|
-
|
425
|
-
|
426
|
-
|
427
|
-
|
428
|
-
|
429
|
-
|
430
|
-
|
431
|
-
|
432
|
-
|
433
|
-
|
434
|
-
|
435
|
-
|
436
|
-
|
437
|
-
|
438
|
-
|
439
|
-
|
440
|
-
|
441
|
-
|
442
|
-
|
443
|
-
|
444
|
-
|
445
|
-
|
446
|
-
|
447
|
-
|
448
|
-
|
449
|
-
|
450
|
-
|
451
|
-
|
452
|
-
|
453
|
-
|
454
|
-
|
455
|
-
|
456
|
-
|
457
|
-
|
458
|
-
|
459
|
-
|
460
|
-
|
461
|
-
|
462
|
-
|
463
|
-
|
464
|
-
|
465
|
-
|
466
|
-
|
467
|
-
|
468
|
-
|
469
|
-
|
470
|
-
|
471
|
-
|
472
|
-
|
473
|
-
|
474
|
-
|
475
|
-
|
476
|
-
|
477
|
-
|
478
|
-
|
479
|
-
|
480
|
-
|
481
|
-
|
482
|
-
|
483
|
-
|
484
|
-
|
485
|
-
|
486
|
-
|
487
|
-
|
488
|
-
|
489
|
-
|
490
|
-
|
491
|
-
|
492
|
-
|
493
|
-
|
494
|
-
|
495
|
-
|
496
|
-
|
497
|
-
|
498
|
-
|
499
|
-
|
500
|
-
|
501
|
-
|
502
|
-
|
503
|
-
|
504
|
-
|
225
|
+
meta: {
|
226
|
+
type: "suggestion",
|
227
|
+
|
228
|
+
docs: {
|
229
|
+
description:
|
230
|
+
"Require or disallow logical assignment operator shorthand",
|
231
|
+
recommended: false,
|
232
|
+
frozen: true,
|
233
|
+
url: "https://eslint.org/docs/latest/rules/logical-assignment-operators",
|
234
|
+
},
|
235
|
+
|
236
|
+
schema: {
|
237
|
+
type: "array",
|
238
|
+
oneOf: [
|
239
|
+
{
|
240
|
+
items: [
|
241
|
+
{ const: "always" },
|
242
|
+
{
|
243
|
+
type: "object",
|
244
|
+
properties: {
|
245
|
+
enforceForIfStatements: {
|
246
|
+
type: "boolean",
|
247
|
+
},
|
248
|
+
},
|
249
|
+
additionalProperties: false,
|
250
|
+
},
|
251
|
+
],
|
252
|
+
minItems: 0, // 0 for allowing passing no options
|
253
|
+
maxItems: 2,
|
254
|
+
},
|
255
|
+
{
|
256
|
+
items: [{ const: "never" }],
|
257
|
+
minItems: 1,
|
258
|
+
maxItems: 1,
|
259
|
+
},
|
260
|
+
],
|
261
|
+
},
|
262
|
+
fixable: "code",
|
263
|
+
hasSuggestions: true,
|
264
|
+
messages: {
|
265
|
+
assignment:
|
266
|
+
"Assignment (=) can be replaced with operator assignment ({{operator}}).",
|
267
|
+
useLogicalOperator:
|
268
|
+
"Convert this assignment to use the operator {{ operator }}.",
|
269
|
+
logical:
|
270
|
+
"Logical expression can be replaced with an assignment ({{ operator }}).",
|
271
|
+
convertLogical:
|
272
|
+
"Replace this logical expression with an assignment with the operator {{ operator }}.",
|
273
|
+
if: "'if' statement can be replaced with a logical operator assignment with operator {{ operator }}.",
|
274
|
+
convertIf:
|
275
|
+
"Replace this 'if' statement with a logical assignment with operator {{ operator }}.",
|
276
|
+
unexpected:
|
277
|
+
"Unexpected logical operator assignment ({{operator}}) shorthand.",
|
278
|
+
separate:
|
279
|
+
"Separate the logical assignment into an assignment with a logical operator.",
|
280
|
+
},
|
281
|
+
},
|
282
|
+
|
283
|
+
create(context) {
|
284
|
+
const mode = context.options[0] === "never" ? "never" : "always";
|
285
|
+
const checkIf =
|
286
|
+
mode === "always" &&
|
287
|
+
context.options.length > 1 &&
|
288
|
+
context.options[1].enforceForIfStatements;
|
289
|
+
const sourceCode = context.sourceCode;
|
290
|
+
const isStrict = sourceCode.getScope(sourceCode.ast).isStrict;
|
291
|
+
|
292
|
+
/**
|
293
|
+
* Returns false if the access could be a getter
|
294
|
+
* @param {ASTNode} node Assignment expression
|
295
|
+
* @returns {boolean} True iff the fix is safe
|
296
|
+
*/
|
297
|
+
function cannotBeGetter(node) {
|
298
|
+
return (
|
299
|
+
node.type === "Identifier" &&
|
300
|
+
(isStrict || !isInsideWithBlock(node))
|
301
|
+
);
|
302
|
+
}
|
303
|
+
|
304
|
+
/**
|
305
|
+
* Check whether only a single property is accessed
|
306
|
+
* @param {ASTNode} node reference
|
307
|
+
* @returns {boolean} True iff a single property is accessed
|
308
|
+
*/
|
309
|
+
function accessesSingleProperty(node) {
|
310
|
+
if (!isStrict && isInsideWithBlock(node)) {
|
311
|
+
return node.type === "Identifier";
|
312
|
+
}
|
313
|
+
|
314
|
+
return (
|
315
|
+
node.type === "MemberExpression" &&
|
316
|
+
baseTypes.has(node.object.type) &&
|
317
|
+
(!node.computed ||
|
318
|
+
(node.property.type !== "MemberExpression" &&
|
319
|
+
node.property.type !== "ChainExpression"))
|
320
|
+
);
|
321
|
+
}
|
322
|
+
|
323
|
+
/**
|
324
|
+
* Adds a fixer or suggestion whether on the fix is safe.
|
325
|
+
* @param {{ messageId: string, node: ASTNode }} descriptor Report descriptor without fix or suggest
|
326
|
+
* @param {{ messageId: string, fix: Function }} suggestion Adds the fix or the whole suggestion as only element in "suggest" to suggestion
|
327
|
+
* @param {boolean} shouldBeFixed Fix iff the condition is true
|
328
|
+
* @returns {Object} Descriptor with either an added fix or suggestion
|
329
|
+
*/
|
330
|
+
function createConditionalFixer(descriptor, suggestion, shouldBeFixed) {
|
331
|
+
if (shouldBeFixed) {
|
332
|
+
return {
|
333
|
+
...descriptor,
|
334
|
+
fix: suggestion.fix,
|
335
|
+
};
|
336
|
+
}
|
337
|
+
|
338
|
+
return {
|
339
|
+
...descriptor,
|
340
|
+
suggest: [suggestion],
|
341
|
+
};
|
342
|
+
}
|
343
|
+
|
344
|
+
/**
|
345
|
+
* Returns the operator token for assignments and binary expressions
|
346
|
+
* @param {ASTNode} node AssignmentExpression or BinaryExpression
|
347
|
+
* @returns {import('eslint').AST.Token} Operator token between the left and right expression
|
348
|
+
*/
|
349
|
+
function getOperatorToken(node) {
|
350
|
+
return sourceCode.getFirstTokenBetween(
|
351
|
+
node.left,
|
352
|
+
node.right,
|
353
|
+
token => token.value === node.operator,
|
354
|
+
);
|
355
|
+
}
|
356
|
+
|
357
|
+
if (mode === "never") {
|
358
|
+
return {
|
359
|
+
// foo ||= bar
|
360
|
+
AssignmentExpression(assignment) {
|
361
|
+
if (
|
362
|
+
!astUtils.isLogicalAssignmentOperator(
|
363
|
+
assignment.operator,
|
364
|
+
)
|
365
|
+
) {
|
366
|
+
return;
|
367
|
+
}
|
368
|
+
|
369
|
+
const descriptor = {
|
370
|
+
messageId: "unexpected",
|
371
|
+
node: assignment,
|
372
|
+
data: { operator: assignment.operator },
|
373
|
+
};
|
374
|
+
const suggestion = {
|
375
|
+
messageId: "separate",
|
376
|
+
*fix(ruleFixer) {
|
377
|
+
if (
|
378
|
+
sourceCode.getCommentsInside(assignment)
|
379
|
+
.length > 0
|
380
|
+
) {
|
381
|
+
return;
|
382
|
+
}
|
383
|
+
|
384
|
+
const operatorToken = getOperatorToken(assignment);
|
385
|
+
|
386
|
+
// -> foo = bar
|
387
|
+
yield ruleFixer.replaceText(operatorToken, "=");
|
388
|
+
|
389
|
+
const assignmentText = sourceCode.getText(
|
390
|
+
assignment.left,
|
391
|
+
);
|
392
|
+
const operator = assignment.operator.slice(0, -1);
|
393
|
+
|
394
|
+
// -> foo = foo || bar
|
395
|
+
yield ruleFixer.insertTextAfter(
|
396
|
+
operatorToken,
|
397
|
+
` ${assignmentText} ${operator}`,
|
398
|
+
);
|
399
|
+
|
400
|
+
const precedence =
|
401
|
+
astUtils.getPrecedence(assignment.right) <=
|
402
|
+
astUtils.getPrecedence({
|
403
|
+
type: "LogicalExpression",
|
404
|
+
operator,
|
405
|
+
});
|
406
|
+
|
407
|
+
// ?? and || / && cannot be mixed but have same precedence
|
408
|
+
const mixed =
|
409
|
+
assignment.operator === "??=" &&
|
410
|
+
astUtils.isLogicalExpression(assignment.right);
|
411
|
+
|
412
|
+
if (
|
413
|
+
!astUtils.isParenthesised(
|
414
|
+
sourceCode,
|
415
|
+
assignment.right,
|
416
|
+
) &&
|
417
|
+
(precedence || mixed)
|
418
|
+
) {
|
419
|
+
// -> foo = foo || (bar)
|
420
|
+
yield ruleFixer.insertTextBefore(
|
421
|
+
assignment.right,
|
422
|
+
"(",
|
423
|
+
);
|
424
|
+
yield ruleFixer.insertTextAfter(
|
425
|
+
assignment.right,
|
426
|
+
")",
|
427
|
+
);
|
428
|
+
}
|
429
|
+
},
|
430
|
+
};
|
431
|
+
|
432
|
+
context.report(
|
433
|
+
createConditionalFixer(
|
434
|
+
descriptor,
|
435
|
+
suggestion,
|
436
|
+
cannotBeGetter(assignment.left),
|
437
|
+
),
|
438
|
+
);
|
439
|
+
},
|
440
|
+
};
|
441
|
+
}
|
442
|
+
|
443
|
+
return {
|
444
|
+
// foo = foo || bar
|
445
|
+
"AssignmentExpression[operator='='][right.type='LogicalExpression']"(
|
446
|
+
assignment,
|
447
|
+
) {
|
448
|
+
const leftOperand = getLeftmostOperand(
|
449
|
+
sourceCode,
|
450
|
+
assignment.right,
|
451
|
+
);
|
452
|
+
|
453
|
+
if (!astUtils.isSameReference(assignment.left, leftOperand)) {
|
454
|
+
return;
|
455
|
+
}
|
456
|
+
|
457
|
+
const descriptor = {
|
458
|
+
messageId: "assignment",
|
459
|
+
node: assignment,
|
460
|
+
data: { operator: `${assignment.right.operator}=` },
|
461
|
+
};
|
462
|
+
const suggestion = {
|
463
|
+
messageId: "useLogicalOperator",
|
464
|
+
data: { operator: `${assignment.right.operator}=` },
|
465
|
+
*fix(ruleFixer) {
|
466
|
+
if (
|
467
|
+
sourceCode.getCommentsInside(assignment).length > 0
|
468
|
+
) {
|
469
|
+
return;
|
470
|
+
}
|
471
|
+
|
472
|
+
// No need for parenthesis around the assignment based on precedence as the precedence stays the same even with changed operator
|
473
|
+
const assignmentOperatorToken =
|
474
|
+
getOperatorToken(assignment);
|
475
|
+
|
476
|
+
// -> foo ||= foo || bar
|
477
|
+
yield ruleFixer.insertTextBefore(
|
478
|
+
assignmentOperatorToken,
|
479
|
+
assignment.right.operator,
|
480
|
+
);
|
481
|
+
|
482
|
+
// -> foo ||= bar
|
483
|
+
const logicalOperatorToken = getOperatorToken(
|
484
|
+
leftOperand.parent,
|
485
|
+
);
|
486
|
+
const firstRightOperandToken =
|
487
|
+
sourceCode.getTokenAfter(logicalOperatorToken);
|
488
|
+
|
489
|
+
yield ruleFixer.removeRange([
|
490
|
+
leftOperand.parent.range[0],
|
491
|
+
firstRightOperandToken.range[0],
|
492
|
+
]);
|
493
|
+
},
|
494
|
+
};
|
495
|
+
|
496
|
+
context.report(
|
497
|
+
createConditionalFixer(
|
498
|
+
descriptor,
|
499
|
+
suggestion,
|
500
|
+
cannotBeGetter(assignment.left),
|
501
|
+
),
|
502
|
+
);
|
503
|
+
},
|
504
|
+
|
505
|
+
// foo || (foo = bar)
|
506
|
+
'LogicalExpression[right.type="AssignmentExpression"][right.operator="="]'(
|
507
|
+
logical,
|
508
|
+
) {
|
509
|
+
// Right side has to be parenthesized, otherwise would be parsed as (foo || foo) = bar which is illegal
|
510
|
+
if (
|
511
|
+
isReference(logical.left) &&
|
512
|
+
astUtils.isSameReference(logical.left, logical.right.left)
|
513
|
+
) {
|
514
|
+
const descriptor = {
|
515
|
+
messageId: "logical",
|
516
|
+
node: logical,
|
517
|
+
data: { operator: `${logical.operator}=` },
|
518
|
+
};
|
519
|
+
const suggestion = {
|
520
|
+
messageId: "convertLogical",
|
521
|
+
data: { operator: `${logical.operator}=` },
|
522
|
+
*fix(ruleFixer) {
|
523
|
+
if (
|
524
|
+
sourceCode.getCommentsInside(logical).length > 0
|
525
|
+
) {
|
526
|
+
return;
|
527
|
+
}
|
528
|
+
|
529
|
+
const parentPrecedence = astUtils.getPrecedence(
|
530
|
+
logical.parent,
|
531
|
+
);
|
532
|
+
const requiresOuterParenthesis =
|
533
|
+
logical.parent.type !== "ExpressionStatement" &&
|
534
|
+
(parentPrecedence === -1 ||
|
535
|
+
astUtils.getPrecedence({
|
536
|
+
type: "AssignmentExpression",
|
537
|
+
}) < parentPrecedence);
|
538
|
+
|
539
|
+
if (
|
540
|
+
!astUtils.isParenthesised(
|
541
|
+
sourceCode,
|
542
|
+
logical,
|
543
|
+
) &&
|
544
|
+
requiresOuterParenthesis
|
545
|
+
) {
|
546
|
+
yield ruleFixer.insertTextBefore(logical, "(");
|
547
|
+
yield ruleFixer.insertTextAfter(logical, ")");
|
548
|
+
}
|
549
|
+
|
550
|
+
// Also removes all opening parenthesis
|
551
|
+
yield ruleFixer.removeRange([
|
552
|
+
logical.range[0],
|
553
|
+
logical.right.range[0],
|
554
|
+
]); // -> foo = bar)
|
555
|
+
|
556
|
+
// Also removes all ending parenthesis
|
557
|
+
yield ruleFixer.removeRange([
|
558
|
+
logical.right.range[1],
|
559
|
+
logical.range[1],
|
560
|
+
]); // -> foo = bar
|
561
|
+
|
562
|
+
const operatorToken = getOperatorToken(
|
563
|
+
logical.right,
|
564
|
+
);
|
565
|
+
|
566
|
+
yield ruleFixer.insertTextBefore(
|
567
|
+
operatorToken,
|
568
|
+
logical.operator,
|
569
|
+
); // -> foo ||= bar
|
570
|
+
},
|
571
|
+
};
|
572
|
+
const fix =
|
573
|
+
cannotBeGetter(logical.left) ||
|
574
|
+
accessesSingleProperty(logical.left);
|
575
|
+
|
576
|
+
context.report(
|
577
|
+
createConditionalFixer(descriptor, suggestion, fix),
|
578
|
+
);
|
579
|
+
}
|
580
|
+
},
|
581
|
+
|
582
|
+
// if (foo) foo = bar
|
583
|
+
"IfStatement[alternate=null]"(ifNode) {
|
584
|
+
if (!checkIf) {
|
585
|
+
return;
|
586
|
+
}
|
587
|
+
|
588
|
+
const hasBody = ifNode.consequent.type === "BlockStatement";
|
589
|
+
|
590
|
+
if (hasBody && ifNode.consequent.body.length !== 1) {
|
591
|
+
return;
|
592
|
+
}
|
593
|
+
|
594
|
+
const body = hasBody
|
595
|
+
? ifNode.consequent.body[0]
|
596
|
+
: ifNode.consequent;
|
597
|
+
const scope = sourceCode.getScope(ifNode);
|
598
|
+
const existence = getExistence(ifNode.test, scope);
|
599
|
+
|
600
|
+
if (
|
601
|
+
body.type === "ExpressionStatement" &&
|
602
|
+
body.expression.type === "AssignmentExpression" &&
|
603
|
+
body.expression.operator === "=" &&
|
604
|
+
existence !== null &&
|
605
|
+
astUtils.isSameReference(
|
606
|
+
existence.reference,
|
607
|
+
body.expression.left,
|
608
|
+
)
|
609
|
+
) {
|
610
|
+
const descriptor = {
|
611
|
+
messageId: "if",
|
612
|
+
node: ifNode,
|
613
|
+
data: { operator: `${existence.operator}=` },
|
614
|
+
};
|
615
|
+
const suggestion = {
|
616
|
+
messageId: "convertIf",
|
617
|
+
data: { operator: `${existence.operator}=` },
|
618
|
+
*fix(ruleFixer) {
|
619
|
+
if (
|
620
|
+
sourceCode.getCommentsInside(ifNode).length > 0
|
621
|
+
) {
|
622
|
+
return;
|
623
|
+
}
|
624
|
+
|
625
|
+
const firstBodyToken =
|
626
|
+
sourceCode.getFirstToken(body);
|
627
|
+
const prevToken = sourceCode.getTokenBefore(ifNode);
|
628
|
+
|
629
|
+
if (
|
630
|
+
prevToken !== null &&
|
631
|
+
prevToken.value !== ";" &&
|
632
|
+
prevToken.value !== "{" &&
|
633
|
+
firstBodyToken.type !== "Identifier" &&
|
634
|
+
firstBodyToken.type !== "Keyword"
|
635
|
+
) {
|
636
|
+
// Do not fix if the fixed statement could be part of the previous statement (eg. fn() if (a == null) (a) = b --> fn()(a) ??= b)
|
637
|
+
return;
|
638
|
+
}
|
639
|
+
|
640
|
+
const operatorToken = getOperatorToken(
|
641
|
+
body.expression,
|
642
|
+
);
|
643
|
+
|
644
|
+
yield ruleFixer.insertTextBefore(
|
645
|
+
operatorToken,
|
646
|
+
existence.operator,
|
647
|
+
); // -> if (foo) foo ||= bar
|
648
|
+
|
649
|
+
yield ruleFixer.removeRange([
|
650
|
+
ifNode.range[0],
|
651
|
+
body.range[0],
|
652
|
+
]); // -> foo ||= bar
|
653
|
+
|
654
|
+
yield ruleFixer.removeRange([
|
655
|
+
body.range[1],
|
656
|
+
ifNode.range[1],
|
657
|
+
]); // -> foo ||= bar, only present if "if" had a body
|
658
|
+
|
659
|
+
const nextToken = sourceCode.getTokenAfter(
|
660
|
+
body.expression,
|
661
|
+
);
|
662
|
+
|
663
|
+
if (
|
664
|
+
hasBody &&
|
665
|
+
nextToken !== null &&
|
666
|
+
nextToken.value !== ";"
|
667
|
+
) {
|
668
|
+
yield ruleFixer.insertTextAfter(ifNode, ";");
|
669
|
+
}
|
670
|
+
},
|
671
|
+
};
|
672
|
+
const shouldBeFixed =
|
673
|
+
cannotBeGetter(existence.reference) ||
|
674
|
+
(ifNode.test.type !== "LogicalExpression" &&
|
675
|
+
accessesSingleProperty(existence.reference));
|
676
|
+
|
677
|
+
context.report(
|
678
|
+
createConditionalFixer(
|
679
|
+
descriptor,
|
680
|
+
suggestion,
|
681
|
+
shouldBeFixed,
|
682
|
+
),
|
683
|
+
);
|
684
|
+
}
|
685
|
+
},
|
686
|
+
};
|
687
|
+
},
|
505
688
|
};
|