eslint 9.2.0 → 9.4.0

package/README.md

@@ -296,8 +296,8 @@ The following companies, organizations, and individuals support ESLint's ongoing
 <h3>Platinum Sponsors</h3>
 <p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="96"></a></p><h3>Silver Sponsors</h3>
-<p><a href="https://www.jetbrains.com/"><img src="https://images.opencollective.com/jetbrains/eb04ddc/logo.png" alt="JetBrains" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="64"></a> <a href="https://www.workleap.com"><img src="https://avatars.githubusercontent.com/u/53535748?u=d1e55d7661d724bf2281c1bfd33cb8f99fe2465f&v=4" alt="Workleap" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://www.notion.so"><img src="https://images.opencollective.com/notion/bf3b117/logo.png" alt="notion" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://transloadit.com/"><img src="https://avatars.githubusercontent.com/u/125754?v=4" alt="Transloadit" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104?v=4" alt="Nx" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://usenextbase.com"><img src="https://avatars.githubusercontent.com/u/145838380?v=4" alt="Nextbase Starter Kit" height="32"></a></p>
+<p><a href="https://www.jetbrains.com/"><img src="https://images.opencollective.com/jetbrains/fe76f99/logo.png" alt="JetBrains" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="64"></a> <a href="https://www.workleap.com"><img src="https://avatars.githubusercontent.com/u/53535748?u=d1e55d7661d724bf2281c1bfd33cb8f99fe2465f&v=4" alt="Workleap" height="64"></a></p><h3>Bronze Sponsors</h3>
+<p><a href="https://www.notion.so"><img src="https://images.opencollective.com/notion/bf3b117/logo.png" alt="notion" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104?v=4" alt="Nx" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://usenextbase.com"><img src="https://avatars.githubusercontent.com/u/145838380?v=4" alt="Nextbase Starter Kit" height="32"></a></p>
 <!--sponsorsend-->
 
 ## Technology Sponsors

package/bin/eslint.js

@@ -64,7 +64,7 @@ function readStdin() {
 function getErrorMessage(error) {
 
     // Lazy loading because this is used only if an error happened.
-    const util = require("util");
+    const util = require("node:util");
 
     // Foolproof -- third-party module might throw non-object.
     if (typeof error !== "object" || error === null) {

package/lib/cli-engine/cli-engine.js

@@ -15,8 +15,8 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const fs = require("fs");
-const path = require("path");
+const fs = require("node:fs");
+const path = require("node:path");
 const defaultOptions = require("../../conf/default-cli-options");
 const pkg = require("../../package.json");
 

package/lib/cli-engine/file-enumerator.js

@@ -34,8 +34,8 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const fs = require("fs");
-const path = require("path");
+const fs = require("node:fs");
+const path = require("node:path");
 const getGlobParent = require("glob-parent");
 const isGlob = require("is-glob");
 const escapeRegExp = require("escape-string-regexp");

package/lib/cli-engine/lint-result-cache.js

@@ -8,8 +8,8 @@
 // Requirements
 //-----------------------------------------------------------------------------
 
-const assert = require("assert");
-const fs = require("fs");
+const assert = require("node:assert");
+const fs = require("node:fs");
 const fileEntryCache = require("file-entry-cache");
 const stringify = require("json-stable-stringify-without-jsonify");
 const pkg = require("../../package.json");

package/lib/cli-engine/load-rules.js

@@ -9,8 +9,8 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const fs = require("fs"),
-    path = require("path");
+const fs = require("node:fs"),
+    path = require("node:path");
 
 const rulesDirCache = {};
 

package/lib/cli.js

@@ -15,9 +15,9 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const fs = require("fs"),
-    path = require("path"),
-    { promisify } = require("util"),
+const fs = require("node:fs"),
+    path = require("node:path"),
+    { promisify } = require("node:util"),
     { LegacyESLint } = require("./eslint"),
     { ESLint, shouldUseFlatConfig, locateConfigFileToUse } = require("./eslint/eslint"),
     createCLIOptions = require("./options"),
@@ -448,14 +448,14 @@ const cli = {
 
         if (options.inspectConfig) {
 
-            log.info("You can also run this command directly using 'npx @eslint/config-inspector' in the same directory as your configuration file.");
+            log.info("You can also run this command directly using 'npx @eslint/config-inspector@latest' in the same directory as your configuration file.");
 
             try {
                 const flatOptions = await translateOptions(options, "flat");
                 const spawn = require("cross-spawn");
                 const flags = await cli.calculateInspectConfigFlags(flatOptions.overrideConfigFile);
 
-                spawn.sync("npx", ["@eslint/config-inspector", ...flags], { encoding: "utf8", stdio: "inherit" });
+                spawn.sync("npx", ["@eslint/config-inspector@latest", ...flags], { encoding: "utf8", stdio: "inherit" });
             } catch (error) {
                 log.error(error);
                 return 2;

package/lib/config/flat-config-array.js

@@ -9,7 +9,7 @@
 // Requirements
 //-----------------------------------------------------------------------------
 
-const { ConfigArray, ConfigArraySymbol } = require("@humanwhocodes/config-array");
+const { ConfigArray, ConfigArraySymbol } = require("@eslint/config-array");
 const { flatConfigSchema } = require("./flat-config-schema");
 const { RuleValidator } = require("./rule-validator");
 const { defaultConfig } = require("./default-config");

package/lib/eslint/eslint-helpers.js

@@ -9,8 +9,8 @@
 // Requirements
 //-----------------------------------------------------------------------------
 
-const path = require("path");
-const fs = require("fs");
+const path = require("node:path");
+const fs = require("node:fs");
 const fsp = fs.promises;
 const isGlob = require("is-glob");
 const hash = require("../cli-engine/hash");
@@ -335,15 +335,15 @@ async function globSearch({
 
                             /*
                              * We updated the unmatched patterns set only if the path
-                             * matches and the file isn't ignored. If the file is
-                             * ignored, that means there wasn't a match for the
+                             * matches and the file has a config. If the file has no
+                             * config, that means there wasn't a match for the
                              * pattern so it should not be removed.
                              *
-                             * Performance note: isFileIgnored() aggressively caches
+                             * Performance note: `getConfig()` aggressively caches
                              * results so there is no performance penalty for calling
-                             * it twice with the same argument.
+                             * it multiple times with the same argument.
                              */
-                            if (pathMatches && !configs.isFileIgnored(entry.path)) {
+                            if (pathMatches && configs.getConfig(entry.path)) {
                                 unmatchedPatterns.delete(matcher.pattern);
                             }
 
@@ -351,7 +351,7 @@ async function globSearch({
                         }, false)
                         : matchers.some(matcher => matcher.match(relativePath));
 
-                    return matchesPattern && !configs.isFileIgnored(entry.path);
+                    return matchesPattern && configs.getConfig(entry.path) !== void 0;
                 })
             },
             (error, entries) => {
@@ -545,7 +545,7 @@ async function findFiles({
             if (stat.isFile()) {
                 results.push({
                     filePath,
-                    ignored: configs.isFileIgnored(filePath)
+                    ignored: !configs.getConfig(filePath)
                 });
             }
 

package/lib/eslint/eslint.js

@@ -9,10 +9,9 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-// Note: Node.js 12 does not support fs/promises.
-const fs = require("fs").promises;
-const { existsSync } = require("fs");
-const path = require("path");
+const fs = require("node:fs/promises");
+const { existsSync } = require("node:fs");
+const path = require("node:path");
 const findUp = require("find-up");
 const { version } = require("../../package.json");
 const { Linter } = require("../linter");
@@ -39,7 +38,7 @@ const {
 
     processOptions
 } = require("./eslint-helpers");
-const { pathToFileURL } = require("url");
+const { pathToFileURL } = require("node:url");
 const { FlatConfigArray } = require("../config/flat-config-array");
 const LintResultCache = require("../cli-engine/lint-result-cache");
 const { Retrier } = require("@humanwhocodes/retry");
@@ -348,6 +347,7 @@ async function locateConfigFileToUse({ configFile, cwd }) {
             basePath = path.resolve(path.dirname(configFilePath));
         } else {
             error = new Error("Could not find config file.");
+            error.messageTemplate = "config-file-missing";
         }
 
     }
@@ -509,7 +509,7 @@ function verifyText({
              * @returns {boolean} `true` if the linter should adopt the code block.
              */
             filterCodeBlock(blockFilename) {
-                return configs.isExplicitMatch(blockFilename);
+                return configs.getConfig(blockFilename) !== void 0;
             }
         }
     );
@@ -881,15 +881,6 @@ class ESLint {
 
                 const config = configs.getConfig(filePath);
 
-                /*
-                 * Sometimes a file found through a glob pattern will
-                 * be ignored. In this case, `config` will be undefined
-                 * and we just silently ignore the file.
-                 */
-                if (!config) {
-                    return void 0;
-                }
-
                 // Skip if there is cached result.
                 if (lintResultCache) {
                     const cachedResult =

package/lib/eslint/legacy-eslint.js

@@ -10,9 +10,9 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const path = require("path");
-const fs = require("fs");
-const { promisify } = require("util");
+const path = require("node:path");
+const fs = require("node:fs");
+const { promisify } = require("node:util");
 const { CLIEngine, getCLIEngineInternalSlots } = require("../cli-engine/cli-engine");
 const BuiltinRules = require("../rules");
 const {

package/lib/linter/code-path-analysis/code-path-analyzer.js

@@ -9,7 +9,7 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const assert = require("assert"),
+const assert = require("node:assert"),
     { breakableTypePattern } = require("../../shared/ast-utils"),
     CodePath = require("./code-path"),
     CodePathSegment = require("./code-path-segment"),

package/lib/linter/code-path-analysis/fork-context.js

@@ -13,7 +13,7 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const assert = require("assert"),
+const assert = require("node:assert"),
     CodePathSegment = require("./code-path-segment");
 
 //------------------------------------------------------------------------------

package/lib/linter/linter.js

@@ -11,7 +11,7 @@
 //------------------------------------------------------------------------------
 
 const
-    path = require("path"),
+    path = require("node:path"),
     eslintScope = require("eslint-scope"),
     evk = require("eslint-visitor-keys"),
     espree = require("espree"),

package/lib/linter/report-translator.js

@@ -9,7 +9,7 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const assert = require("assert");
+const assert = require("node:assert");
 const ruleFixer = require("./rule-fixer");
 const { interpolate } = require("./interpolate");
 

package/lib/rule-tester/rule-tester.js

@@ -11,9 +11,9 @@
 //------------------------------------------------------------------------------
 
 const
-    assert = require("assert"),
-    util = require("util"),
-    path = require("path"),
+    assert = require("node:assert"),
+    util = require("node:util"),
+    path = require("node:path"),
     equal = require("fast-deep-equal"),
     Traverser = require("../shared/traverser"),
     { getRuleOptionsSchema } = require("../config/flat-config-helpers"),
@@ -28,7 +28,7 @@ const ajv = require("../shared/ajv")({ strictDefaults: true });
 
 const parserSymbol = Symbol.for("eslint.RuleTester.parser");
 const { SourceCode } = require("../source-code");
-const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
+const { ConfigArraySymbol } = require("@eslint/config-array");
 const { isSerializable } = require("../shared/serialization");
 
 //------------------------------------------------------------------------------

package/lib/rules/func-style.js

@@ -14,7 +14,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "Enforce the consistent use of either `function` declarations or expressions",
+            description: "Enforce the consistent use of either `function` declarations or expressions assigned to variables",
             recommended: false,
             url: "https://eslint.org/docs/latest/rules/func-style"
         },
@@ -29,6 +29,15 @@ module.exports = {
                     allowArrowFunctions: {
                         type: "boolean",
                         default: false
+                    },
+                    overrides: {
+                        type: "object",
+                        properties: {
+                            namedExports: {
+                                enum: ["declaration", "expression", "ignore"]
+                            }
+                        },
+                        additionalProperties: false
                     }
                 },
                 additionalProperties: false
@@ -46,13 +55,22 @@ module.exports = {
         const style = context.options[0],
             allowArrowFunctions = context.options[1] && context.options[1].allowArrowFunctions,
             enforceDeclarations = (style === "declaration"),
+            exportFunctionStyle = context.options[1] && context.options[1].overrides && context.options[1].overrides.namedExports,
             stack = [];
 
         const nodesToCheck = {
             FunctionDeclaration(node) {
                 stack.push(false);
 
-                if (!enforceDeclarations && node.parent.type !== "ExportDefaultDeclaration") {
+                if (
+                    !enforceDeclarations &&
+                    node.parent.type !== "ExportDefaultDeclaration" &&
+                    (typeof exportFunctionStyle === "undefined" || node.parent.type !== "ExportNamedDeclaration")
+                ) {
+                    context.report({ node, messageId: "expression" });
+                }
+
+                if (node.parent.type === "ExportNamedDeclaration" && exportFunctionStyle === "expression") {
                     context.report({ node, messageId: "expression" });
                 }
             },
@@ -63,7 +81,18 @@ module.exports = {
             FunctionExpression(node) {
                 stack.push(false);
 
-                if (enforceDeclarations && node.parent.type === "VariableDeclarator") {
+                if (
+                    enforceDeclarations &&
+                    node.parent.type === "VariableDeclarator" &&
+                    (typeof exportFunctionStyle === "undefined" || node.parent.parent.parent.type !== "ExportNamedDeclaration")
+                ) {
+                    context.report({ node: node.parent, messageId: "declaration" });
+                }
+
+                if (
+                    node.parent.type === "VariableDeclarator" && node.parent.parent.parent.type === "ExportNamedDeclaration" &&
+                    exportFunctionStyle === "declaration"
+                ) {
                     context.report({ node: node.parent, messageId: "declaration" });
                 }
             },
@@ -71,7 +100,7 @@ module.exports = {
                 stack.pop();
             },
 
-            ThisExpression() {
+            "ThisExpression, Super"() {
                 if (stack.length > 0) {
                     stack[stack.length - 1] = true;
                 }
@@ -84,10 +113,19 @@ module.exports = {
             };
 
             nodesToCheck["ArrowFunctionExpression:exit"] = function(node) {
-                const hasThisExpr = stack.pop();
+                const hasThisOrSuperExpr = stack.pop();
+
+                if (!hasThisOrSuperExpr && node.parent.type === "VariableDeclarator") {
+                    if (
+                        enforceDeclarations &&
+                        (typeof exportFunctionStyle === "undefined" || node.parent.parent.parent.type !== "ExportNamedDeclaration")
+                    ) {
+                        context.report({ node: node.parent, messageId: "declaration" });
+                    }
 
-                if (enforceDeclarations && !hasThisExpr && node.parent.type === "VariableDeclarator") {
-                    context.report({ node: node.parent, messageId: "declaration" });
+                    if (node.parent.parent.parent.type === "ExportNamedDeclaration" && exportFunctionStyle === "declaration") {
+                        context.report({ node: node.parent, messageId: "declaration" });
+                    }
                 }
             };
         }

package/lib/rules/line-comment-position.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Rule to enforce the position of line comments
  * @author Alberto Rodríguez
+ * @deprecated in ESLint v9.3.0
  */
 "use strict";
 
@@ -13,6 +14,8 @@ const astUtils = require("./utils/ast-utils");
 /** @type {import('../shared/types').Rule} */
 module.exports = {
     meta: {
+        deprecated: true,
+        replacedBy: [],
         type: "layout",
 
         docs: {

package/lib/rules/multiline-comment-style.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview enforce a particular style for multiline comments
  * @author Teddy Katz
+ * @deprecated in ESLint v9.3.0
  */
 "use strict";
 
@@ -13,8 +14,9 @@ const astUtils = require("./utils/ast-utils");
 /** @type {import('../shared/types').Rule} */
 module.exports = {
     meta: {
+        deprecated: true,
+        replacedBy: [],
         type: "suggestion",
-
         docs: {
             description: "Enforce a particular style for multiline comments",
             recommended: false,

package/lib/rules/no-constant-binary-expression.js

@@ -148,7 +148,7 @@ function isStaticBoolean(scope, node) {
  * truthiness.
  * https://262.ecma-international.org/5.1/#sec-11.9.3
  *
- * Javascript `==` operator works by converting the boolean to `1` (true) or
+ * JavaScript `==` operator works by converting the boolean to `1` (true) or
  * `+0` (false) and then checks the values `==` equality to that number.
  * @param {Scope} scope The scope in which node was found.
  * @param {ASTNode} node The node to test.

package/lib/rules/no-constructor-return.js

@@ -49,7 +49,7 @@ module.exports = {
                 if (
                     last.parent.type === "MethodDefinition" &&
                     last.parent.kind === "constructor" &&
-                    (node.parent.parent === last || node.argument)
+                    node.argument
                 ) {
                     context.report({
                         node,

package/lib/rules/no-extra-boolean-cast.js

@@ -30,14 +30,28 @@ module.exports = {
         },
 
         schema: [{
-            type: "object",
-            properties: {
-                enforceForLogicalOperands: {
-                    type: "boolean",
-                    default: false
+            anyOf: [
+                {
+                    type: "object",
+                    properties: {
+                        enforceForInnerExpressions: {
+                            type: "boolean"
+                        }
+                    },
+                    additionalProperties: false
+                },
+
+                // deprecated
+                {
+                    type: "object",
+                    properties: {
+                        enforceForLogicalOperands: {
+                            type: "boolean"
+                        }
+                    },
+                    additionalProperties: false
                 }
-            },
-            additionalProperties: false
+            ]
         }],
         fixable: "code",
 
@@ -49,6 +63,9 @@ module.exports = {
 
     create(context) {
         const sourceCode = context.sourceCode;
+        const enforceForLogicalOperands = context.options[0]?.enforceForLogicalOperands === true;
+        const enforceForInnerExpressions = context.options[0]?.enforceForInnerExpressions === true;
+
 
         // Node types which have a test which will coerce values to booleans.
         const BOOLEAN_NODE_TYPES = new Set([
@@ -72,19 +89,6 @@ module.exports = {
                         node.callee.name === "Boolean";
         }
 
-        /**
-         * Checks whether the node is a logical expression and that the option is enabled
-         * @param {ASTNode} node the node
-         * @returns {boolean} if the node is a logical expression and option is enabled
-         */
-        function isLogicalContext(node) {
-            return node.type === "LogicalExpression" &&
-            (node.operator === "||" || node.operator === "&&") &&
-            (context.options.length && context.options[0].enforceForLogicalOperands === true);
-
-        }
-
-
         /**
          * Check if a node is in a context where its value would be coerced to a boolean at runtime.
          * @param {ASTNode} node The node
@@ -115,12 +119,51 @@ module.exports = {
                 return isInFlaggedContext(node.parent);
             }
 
-            return isInBooleanContext(node) ||
-            (isLogicalContext(node.parent) &&
+            /*
+             * legacy behavior - enforceForLogicalOperands will only recurse on
+             * logical expressions, not on other contexts.
+             * enforceForInnerExpressions will recurse on logical expressions
+             * as well as the other recursive syntaxes.
+             */
+
+            if (enforceForLogicalOperands || enforceForInnerExpressions) {
+                if (node.parent.type === "LogicalExpression") {
+                    if (node.parent.operator === "||" || node.parent.operator === "&&") {
+                        return isInFlaggedContext(node.parent);
+                    }
 
-            // For nested logical statements
-            isInFlaggedContext(node.parent)
-            );
+                    // Check the right hand side of a `??` operator.
+                    if (enforceForInnerExpressions &&
+                        node.parent.operator === "??" &&
+                        node.parent.right === node
+                    ) {
+                        return isInFlaggedContext(node.parent);
+                    }
+                }
+            }
+
+            if (enforceForInnerExpressions) {
+                if (
+                    node.parent.type === "ConditionalExpression" &&
+                    (node.parent.consequent === node || node.parent.alternate === node)
+                ) {
+                    return isInFlaggedContext(node.parent);
+                }
+
+                /*
+                 * Check last expression only in a sequence, i.e. if ((1, 2, Boolean(3))) {}, since
+                 * the others don't affect the result of the expression.
+                 */
+                if (
+                    node.parent.type === "SequenceExpression" &&
+                    node.parent.expressions.at(-1) === node
+                ) {
+                    return isInFlaggedContext(node.parent);
+                }
+
+            }
+
+            return isInBooleanContext(node);
         }
 
 
@@ -147,7 +190,6 @@ module.exports = {
          * Determines whether the given node needs to be parenthesized when replacing the previous node.
          * It assumes that `previousNode` is the node to be reported by this rule, so it has a limited list
          * of possible parent node types. By the same assumption, the node's role in a particular parent is already known.
-         * For example, if the parent is `ConditionalExpression`, `previousNode` must be its `test` child.
          * @param {ASTNode} previousNode Previous node.
          * @param {ASTNode} node The node to check.
          * @throws {Error} (Unreachable.)
@@ -157,6 +199,7 @@ module.exports = {
             if (previousNode.parent.type === "ChainExpression") {
                 return needsParens(previousNode.parent, node);
             }
+
             if (isParenthesized(previousNode)) {
 
                 // parentheses around the previous node will stay, so there is no need for an additional pair
@@ -174,9 +217,18 @@ module.exports = {
                 case "DoWhileStatement":
                 case "WhileStatement":
                 case "ForStatement":
+                case "SequenceExpression":
                     return false;
                 case "ConditionalExpression":
-                    return precedence(node) <= precedence(parent);
+                    if (previousNode === parent.test) {
+                        return precedence(node) <= precedence(parent);
+                    }
+                    if (previousNode === parent.consequent || previousNode === parent.alternate) {
+                        return precedence(node) < precedence({ type: "AssignmentExpression" });
+                    }
+
+                    /* c8 ignore next */
+                    throw new Error("Ternary child must be test, consequent, or alternate.");
                 case "UnaryExpression":
                     return precedence(node) < precedence(parent);
                 case "LogicalExpression":