eslint 9.14.0 → 9.16.0

package/lib/rules/new-cap.js

@@ -29,23 +29,6 @@ const CAPS_ALLOWED = [
     "BigInt"
 ];
 
-/**
- * Ensure that if the key is provided, it must be an array.
- * @param {Object} obj Object to check with `key`.
- * @param {string} key Object key to check on `obj`.
- * @param {any} fallback If obj[key] is not present, this will be returned.
- * @throws {TypeError} If key is not an own array type property of `obj`.
- * @returns {string[]} Returns obj[key] if it's an Array, otherwise `fallback`
- */
-function checkArray(obj, key, fallback) {
-
-    /* c8 ignore start */
-    if (Object.hasOwn(obj, key) && !Array.isArray(obj[key])) {
-        throw new TypeError(`${key}, if provided, must be an Array`);
-    }/* c8 ignore stop */
-    return obj[key] || fallback;
-}
-
 /**
  * A reducer function to invert an array to an Object mapping the string form of the key, to `true`.
  * @param {Object} map Accumulator object for the reduce.
@@ -63,11 +46,7 @@ function invert(map, key) {
  * @returns {Object} Object with cap is new exceptions.
  */
 function calculateCapIsNewExceptions(config) {
-    let capIsNewExceptions = checkArray(config, "capIsNewExceptions", CAPS_ALLOWED);
-
-    if (capIsNewExceptions !== CAPS_ALLOWED) {
-        capIsNewExceptions = capIsNewExceptions.concat(CAPS_ALLOWED);
-    }
+    const capIsNewExceptions = Array.from(new Set([...config.capIsNewExceptions, ...CAPS_ALLOWED]));
 
     return capIsNewExceptions.reduce(invert, {});
 }
@@ -92,12 +71,10 @@ module.exports = {
                 type: "object",
                 properties: {
                     newIsCap: {
-                        type: "boolean",
-                        default: true
+                        type: "boolean"
                     },
                     capIsNew: {
-                        type: "boolean",
-                        default: true
+                        type: "boolean"
                     },
                     newIsCapExceptions: {
                         type: "array",
@@ -118,13 +95,21 @@ module.exports = {
                         type: "string"
                     },
                     properties: {
-                        type: "boolean",
-                        default: true
+                        type: "boolean"
                     }
                 },
                 additionalProperties: false
             }
         ],
+
+        defaultOptions: [{
+            capIsNew: true,
+            capIsNewExceptions: CAPS_ALLOWED,
+            newIsCap: true,
+            newIsCapExceptions: [],
+            properties: true
+        }],
+
         messages: {
             upper: "A function with a name starting with an uppercase letter should only be used as a constructor.",
             lower: "A constructor name should not start with a lowercase letter."
@@ -132,14 +117,10 @@ module.exports = {
     },
 
     create(context) {
+        const [config] = context.options;
+        const skipProperties = !config.properties;
 
-        const config = Object.assign({}, context.options[0]);
-
-        config.newIsCap = config.newIsCap !== false;
-        config.capIsNew = config.capIsNew !== false;
-        const skipProperties = config.properties === false;
-
-        const newIsCapExceptions = checkArray(config, "newIsCapExceptions", []).reduce(invert, {});
+        const newIsCapExceptions = config.newIsCapExceptions.reduce(invert, {});
         const newIsCapExceptionPattern = config.newIsCapExceptionPattern ? new RegExp(config.newIsCapExceptionPattern, "u") : null;
 
         const capIsNewExceptions = calculateCapIsNewExceptions(config);

package/lib/rules/no-bitwise.js

@@ -25,6 +25,11 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{
+            allow: [],
+            int32Hint: false
+        }],
+
         docs: {
             description: "Disallow bitwise operators",
             recommended: false,
@@ -43,8 +48,7 @@ module.exports = {
                         uniqueItems: true
                     },
                     int32Hint: {
-                        type: "boolean",
-                        default: false
+                        type: "boolean"
                     }
                 },
                 additionalProperties: false
@@ -57,9 +61,7 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {};
-        const allowed = options.allow || [];
-        const int32Hint = options.int32Hint === true;
+        const [{ allow: allowed, int32Hint }] = context.options;
 
         /**
          * Reports an unexpected use of a bitwise operator.

package/lib/rules/no-compare-neg-zero.js

@@ -14,7 +14,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "Disallow comparing against -0",
+            description: "Disallow comparing against `-0`",
             recommended: true,
             url: "https://eslint.org/docs/latest/rules/no-compare-neg-zero"
         },

package/lib/rules/no-cond-assign.js

@@ -33,6 +33,8 @@ module.exports = {
     meta: {
         type: "problem",
 
+        defaultOptions: ["except-parens"],
+
         docs: {
             description: "Disallow assignment operators in conditional expressions",
             recommended: true,
@@ -54,9 +56,7 @@ module.exports = {
     },
 
     create(context) {
-
-        const prohibitAssign = (context.options[0] || "except-parens");
-
+        const [prohibitAssign] = context.options;
         const sourceCode = context.sourceCode;
 
         /**

package/lib/rules/no-console.js

@@ -20,6 +20,8 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{}],
+
         docs: {
             description: "Disallow the use of `console`",
             recommended: false,
@@ -52,8 +54,7 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {};
-        const allowed = options.allow || [];
+        const [{ allow: allowed = [] }] = context.options;
         const sourceCode = context.sourceCode;
 
         /**

package/lib/rules/no-constant-condition.js

@@ -20,6 +20,8 @@ module.exports = {
     meta: {
         type: "problem",
 
+        defaultOptions: [{ checkLoops: "allExceptWhileTrue" }],
+
         docs: {
             description: "Disallow constant expressions in conditions",
             recommended: true,
@@ -44,14 +46,13 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {};
-        let checkLoops = options.checkLoops ?? "allExceptWhileTrue";
         const loopSetStack = [];
         const sourceCode = context.sourceCode;
+        let [{ checkLoops }] = context.options;
 
-        if (options.checkLoops === true) {
+        if (checkLoops === true) {
             checkLoops = "all";
-        } else if (options.checkLoops === false) {
+        } else if (checkLoops === false) {
             checkLoops = "none";
         }
 

package/lib/rules/no-duplicate-imports.js

@@ -232,6 +232,10 @@ module.exports = {
     meta: {
         type: "problem",
 
+        defaultOptions: [{
+            includeExports: false
+        }],
+
         docs: {
             description: "Disallow duplicate module imports",
             recommended: false,
@@ -243,8 +247,7 @@ module.exports = {
                 type: "object",
                 properties: {
                     includeExports: {
-                        type: "boolean",
-                        default: false
+                        type: "boolean"
                     }
                 },
                 additionalProperties: false
@@ -260,8 +263,8 @@ module.exports = {
     },
 
     create(context) {
-        const includeExports = (context.options[0] || {}).includeExports,
-            modules = new Map();
+        const [{ includeExports }] = context.options;
+        const modules = new Map();
         const handlers = {
             ImportDeclaration: handleImportsExports(
                 context,

package/lib/rules/no-else-return.js

@@ -21,6 +21,8 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{ allowElseIf: true }],
+
         docs: {
             description: "Disallow `else` blocks after `return` statements in `if` statements",
             recommended: false,
@@ -31,8 +33,7 @@ module.exports = {
             type: "object",
             properties: {
                 allowElseIf: {
-                    type: "boolean",
-                    default: true
+                    type: "boolean"
                 }
             },
             additionalProperties: false
@@ -46,7 +47,7 @@ module.exports = {
     },
 
     create(context) {
-
+        const [{ allowElseIf }] = context.options;
         const sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
@@ -389,8 +390,6 @@ module.exports = {
             }
         }
 
-        const allowElseIf = !(context.options[0] && context.options[0].allowElseIf === false);
-
         //--------------------------------------------------------------------------
         // Public API
         //--------------------------------------------------------------------------

package/lib/rules/no-empty-function.js

@@ -94,6 +94,8 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{ allow: [] }],
+
         docs: {
             description: "Disallow empty functions",
             recommended: false,
@@ -120,9 +122,7 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {};
-        const allowed = options.allow || [];
-
+        const [{ allow }] = context.options;
         const sourceCode = context.sourceCode;
 
         /**
@@ -144,7 +144,7 @@ module.exports = {
                 filter: astUtils.isCommentToken
             });
 
-            if (!allowed.includes(kind) &&
+            if (!allow.includes(kind) &&
                 node.body.type === "BlockStatement" &&
                 node.body.body.length === 0 &&
                 innerComments.length === 0

package/lib/rules/no-empty-pattern.js

@@ -15,6 +15,10 @@ module.exports = {
     meta: {
         type: "problem",
 
+        defaultOptions: [{
+            allowObjectPatternsAsParameters: false
+        }],
+
         docs: {
             description: "Disallow empty destructuring patterns",
             recommended: true,
@@ -26,8 +30,7 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowObjectPatternsAsParameters: {
-                        type: "boolean",
-                        default: false
+                        type: "boolean"
                     }
                 },
                 additionalProperties: false
@@ -40,8 +43,7 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {},
-            allowObjectPatternsAsParameters = options.allowObjectPatternsAsParameters || false;
+        const [{ allowObjectPatternsAsParameters }] = context.options;
 
         return {
             ObjectPattern(node) {

package/lib/rules/no-empty.js

@@ -20,6 +20,10 @@ module.exports = {
         hasSuggestions: true,
         type: "suggestion",
 
+        defaultOptions: [{
+            allowEmptyCatch: false
+        }],
+
         docs: {
             description: "Disallow empty block statements",
             recommended: true,
@@ -31,8 +35,7 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowEmptyCatch: {
-                        type: "boolean",
-                        default: false
+                        type: "boolean"
                     }
                 },
                 additionalProperties: false
@@ -46,9 +49,7 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {},
-            allowEmptyCatch = options.allowEmptyCatch || false;
-
+        const [{ allowEmptyCatch }] = context.options;
         const sourceCode = context.sourceCode;
 
         return {

package/lib/rules/no-eval.js

@@ -42,6 +42,10 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{
+            allowIndirect: false
+        }],
+
         docs: {
             description: "Disallow the use of `eval()`",
             recommended: false,
@@ -52,7 +56,7 @@ module.exports = {
             {
                 type: "object",
                 properties: {
-                    allowIndirect: { type: "boolean", default: false }
+                    allowIndirect: { type: "boolean" }
                 },
                 additionalProperties: false
             }
@@ -64,10 +68,7 @@ module.exports = {
     },
 
     create(context) {
-        const allowIndirect = Boolean(
-            context.options[0] &&
-            context.options[0].allowIndirect
-        );
+        const [{ allowIndirect }] = context.options;
         const sourceCode = context.sourceCode;
         let funcInfo = null;
 

package/lib/rules/no-extend-native.js

@@ -20,6 +20,8 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{ exceptions: [] }],
+
         docs: {
             description: "Disallow extending native types",
             recommended: false,
@@ -48,10 +50,8 @@ module.exports = {
     },
 
     create(context) {
-
-        const config = context.options[0] || {};
         const sourceCode = context.sourceCode;
-        const exceptions = new Set(config.exceptions || []);
+        const exceptions = new Set(context.options[0].exceptions);
         const modifiedBuiltins = new Set(
             Object.keys(astUtils.ECMASCRIPT_GLOBALS)
                 .filter(builtin => builtin[0].toUpperCase() === builtin[0])

package/lib/rules/no-extra-boolean-cast.js

@@ -23,6 +23,8 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{}],
+
         docs: {
             description: "Disallow unnecessary boolean casts",
             recommended: true,
@@ -63,9 +65,7 @@ module.exports = {
 
     create(context) {
         const sourceCode = context.sourceCode;
-        const enforceForLogicalOperands = context.options[0]?.enforceForLogicalOperands === true;
-        const enforceForInnerExpressions = context.options[0]?.enforceForInnerExpressions === true;
-
+        const [{ enforceForLogicalOperands, enforceForInnerExpressions }] = context.options;
 
         // Node types which have a test which will coerce values to booleans.
         const BOOLEAN_NODE_TYPES = new Set([

package/lib/rules/no-fallthrough.js

@@ -90,6 +90,11 @@ module.exports = {
     meta: {
         type: "problem",
 
+        defaultOptions: [{
+            allowEmptyCase: false,
+            reportUnusedFallthroughComment: false
+        }],
+
         docs: {
             description: "Disallow fallthrough of `case` statements",
             recommended: true,
@@ -101,16 +106,13 @@ module.exports = {
                 type: "object",
                 properties: {
                     commentPattern: {
-                        type: "string",
-                        default: ""
+                        type: "string"
                     },
                     allowEmptyCase: {
-                        type: "boolean",
-                        default: false
+                        type: "boolean"
                     },
                     reportUnusedFallthroughComment: {
-                        type: "boolean",
-                        default: false
+                        type: "boolean"
                     }
                 },
                 additionalProperties: false
@@ -124,25 +126,20 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {};
         const codePathSegments = [];
         let currentCodePathSegments = new Set();
         const sourceCode = context.sourceCode;
-        const allowEmptyCase = options.allowEmptyCase || false;
-        const reportUnusedFallthroughComment = options.reportUnusedFallthroughComment || false;
+        const [{ allowEmptyCase, commentPattern, reportUnusedFallthroughComment }] = context.options;
+        const fallthroughCommentPattern = commentPattern
+            ? new RegExp(commentPattern, "u")
+            : DEFAULT_FALLTHROUGH_COMMENT;
 
         /*
          * We need to use leading comments of the next SwitchCase node because
          * trailing comments is wrong if semicolons are omitted.
          */
         let previousCase = null;
-        let fallthroughCommentPattern = null;
 
-        if (options.commentPattern) {
-            fallthroughCommentPattern = new RegExp(options.commentPattern, "u");
-        } else {
-            fallthroughCommentPattern = DEFAULT_FALLTHROUGH_COMMENT;
-        }
         return {
 
             onCodePathStart() {

package/lib/rules/no-global-assign.js

@@ -14,6 +14,8 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{ exceptions: [] }],
+
         docs: {
             description: "Disallow assignments to native objects or read-only global variables",
             recommended: true,
@@ -40,9 +42,8 @@ module.exports = {
     },
 
     create(context) {
-        const config = context.options[0];
         const sourceCode = context.sourceCode;
-        const exceptions = (config && config.exceptions) || [];
+        const [{ exceptions }] = context.options;
 
         /**
          * Reports write references.

package/lib/rules/no-implicit-coercion.js

@@ -14,21 +14,6 @@ const astUtils = require("./utils/ast-utils");
 const INDEX_OF_PATTERN = /^(?:i|lastI)ndexOf$/u;
 const ALLOWABLE_OPERATORS = ["~", "!!", "+", "- -", "-", "*"];
 
-/**
- * Parses and normalizes an option object.
- * @param {Object} options An option object to parse.
- * @returns {Object} The parsed and normalized option object.
- */
-function parseOptions(options) {
-    return {
-        boolean: "boolean" in options ? options.boolean : true,
-        number: "number" in options ? options.number : true,
-        string: "string" in options ? options.string : true,
-        disallowTemplateShorthand: "disallowTemplateShorthand" in options ? options.disallowTemplateShorthand : false,
-        allow: options.allow || []
-    };
-}
-
 /**
  * Checks whether or not a node is a double logical negating.
  * @param {ASTNode} node An UnaryExpression node to check.
@@ -203,20 +188,16 @@ module.exports = {
             type: "object",
             properties: {
                 boolean: {
-                    type: "boolean",
-                    default: true
+                    type: "boolean"
                 },
                 number: {
-                    type: "boolean",
-                    default: true
+                    type: "boolean"
                 },
                 string: {
-                    type: "boolean",
-                    default: true
+                    type: "boolean"
                 },
                 disallowTemplateShorthand: {
-                    type: "boolean",
-                    default: false
+                    type: "boolean"
                 },
                 allow: {
                     type: "array",
@@ -229,6 +210,14 @@ module.exports = {
             additionalProperties: false
         }],
 
+        defaultOptions: [{
+            allow: [],
+            boolean: true,
+            disallowTemplateShorthand: false,
+            number: true,
+            string: true
+        }],
+
         messages: {
             implicitCoercion: "Unexpected implicit coercion encountered. Use `{{recommendation}}` instead.",
             useRecommendation: "Use `{{recommendation}}` instead."
@@ -236,7 +225,7 @@ module.exports = {
     },
 
     create(context) {
-        const options = parseOptions(context.options[0] || {});
+        const [options] = context.options;
         const sourceCode = context.sourceCode;
 
         /**

package/lib/rules/no-implicit-globals.js

@@ -14,6 +14,10 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{
+            lexicalBindings: false
+        }],
+
         docs: {
             description: "Disallow declarations in the global scope",
             recommended: false,
@@ -24,8 +28,7 @@ module.exports = {
             type: "object",
             properties: {
                 lexicalBindings: {
-                    type: "boolean",
-                    default: false
+                    type: "boolean"
                 }
             },
             additionalProperties: false
@@ -41,8 +44,7 @@ module.exports = {
     },
 
     create(context) {
-
-        const checkLexicalBindings = context.options[0] && context.options[0].lexicalBindings === true;
+        const [{ lexicalBindings: checkLexicalBindings }] = context.options;
         const sourceCode = context.sourceCode;
 
         /**

package/lib/rules/no-inline-comments.js

@@ -15,6 +15,8 @@ module.exports = {
     meta: {
         type: "suggestion",
 
+        defaultOptions: [{}],
+
         docs: {
             description: "Disallow inline comments after code",
             recommended: false,
@@ -40,12 +42,8 @@ module.exports = {
 
     create(context) {
         const sourceCode = context.sourceCode;
-        const options = context.options[0];
-        let customIgnoreRegExp;
-
-        if (options && options.ignorePattern) {
-            customIgnoreRegExp = new RegExp(options.ignorePattern, "u");
-        }
+        const [{ ignorePattern }] = context.options;
+        const customIgnoreRegExp = ignorePattern && new RegExp(ignorePattern, "u");
 
         /**
          * Will check that comments are not on lines starting with or ending with code