eslint 9.11.1 → 9.13.0

package/lib/rule-tester/rule-tester.js

@@ -30,6 +30,7 @@ const parserSymbol = Symbol.for("eslint.RuleTester.parser");
 const { ConfigArraySymbol } = require("@eslint/config-array");
 const { isSerializable } = require("../shared/serialization");
 
+const jslang = require("../languages/js");
 const { SourceCode } = require("../languages/js/source-code");
 
 //------------------------------------------------------------------------------
@@ -47,6 +48,8 @@ const { SourceCode } = require("../languages/js/source-code");
  * @property {string} [name] Name for the test case.
  * @property {string} code Code for the test case.
  * @property {any[]} [options] Options for the test case.
+ * @property {Function} [before] Function to execute before testing the case.
+ * @property {Function} [after] Function to execute after testing the case regardless of its result.
  * @property {LanguageOptions} [languageOptions] The language options to use in the test case.
  * @property {{ [name: string]: any }} [settings] Settings for the test case.
  * @property {string} [filename] The fake filename for the test case. Useful for rules that make assertion about filenames.
@@ -61,6 +64,8 @@ const { SourceCode } = require("../languages/js/source-code");
  * @property {number | Array<TestCaseError | string | RegExp>} errors Expected errors.
  * @property {string | null} [output] The expected code after autofixes are applied. If set to `null`, the test runner will assert that no autofix is suggested.
  * @property {any[]} [options] Options for the test case.
+ * @property {Function} [before] Function to execute before testing the case.
+ * @property {Function} [after] Function to execute after testing the case regardless of its result.
  * @property {{ [name: string]: any }} [settings] Settings for the test case.
  * @property {string} [filename] The fake filename for the test case. Useful for rules that make assertion about filenames.
  * @property {LanguageOptions} [languageOptions] The language options to use in the test case.
@@ -105,6 +110,8 @@ const RuleTesterParameters = [
     "code",
     "filename",
     "options",
+    "before",
+    "after",
     "errors",
     "output",
     "only"
@@ -613,14 +620,26 @@ class RuleTester {
                         }
                     }
                 },
-                language: defaultConfig[0].language,
-                languageOptions: {
-                    ...defaultConfig[0].languageOptions
-                }
+                language: defaultConfig[0].language
             },
             ...defaultConfig.slice(1)
         ];
 
+        /**
+         * Runs a hook on the given item when it's assigned to the given property
+         * @param {string|Object} item Item to run the hook on
+         * @param {string} prop The property having the hook assigned to
+         * @throws {Error} If the property is not a function or that function throws an error
+         * @returns {void}
+         * @private
+         */
+        function runHook(item, prop) {
+            if (typeof item === "object" && hasOwnProperty(item, prop)) {
+                assert.strictEqual(typeof item[prop], "function", `Optional test case property '${prop}' must be a function`);
+                item[prop]();
+            }
+        }
+
         /**
          * Run the rule for the given item
          * @param {string|Object} item Item to run the rule against
@@ -652,7 +671,10 @@ class RuleTester {
                 const calculatedConfig = proto[ConfigArraySymbol.finalizeConfig].apply(this, args);
 
                 // wrap the parser to catch start/end property access
-                calculatedConfig.languageOptions.parser = wrapParser(calculatedConfig.languageOptions.parser);
+                if (calculatedConfig.language === jslang) {
+                    calculatedConfig.languageOptions.parser = wrapParser(calculatedConfig.languageOptions.parser);
+                }
+
                 return calculatedConfig;
             };
 
@@ -673,17 +695,6 @@ class RuleTester {
                     delete itemConfig[parameter];
                 }
 
-                // wrap any parsers
-                if (itemConfig.languageOptions && itemConfig.languageOptions.parser) {
-
-                    const parser = itemConfig.languageOptions.parser;
-
-                    if (parser && typeof parser !== "object") {
-                        throw new Error("Parser must be an object with a parse() or parseForESLint() method.");
-                    }
-
-                }
-
                 /*
                  * Create the config object from the tester config and this item
                  * specific configurations.
@@ -1258,7 +1269,12 @@ class RuleTester {
                         this.constructor[valid.only ? "itOnly" : "it"](
                             sanitize(typeof valid === "object" ? valid.name || valid.code : valid),
                             () => {
-                                testValidTemplate(valid);
+                                try {
+                                    runHook(valid, "before");
+                                    testValidTemplate(valid);
+                                } finally {
+                                    runHook(valid, "after");
+                                }
                             }
                         );
                     });
@@ -1271,7 +1287,12 @@ class RuleTester {
                         this.constructor[invalid.only ? "itOnly" : "it"](
                             sanitize(invalid.name || invalid.code),
                             () => {
-                                testInvalidTemplate(invalid);
+                                try {
+                                    runHook(invalid, "before");
+                                    testInvalidTemplate(invalid);
+                                } finally {
+                                    runHook(invalid, "after");
+                                }
                             }
                         );
                     });

package/lib/rules/complexity.js

@@ -45,6 +45,9 @@ module.exports = {
                             max: {
                                 type: "integer",
                                 minimum: 0
+                            },
+                            variant: {
+                                enum: ["classic", "modified"]
                             }
                         },
                         additionalProperties: false
@@ -61,16 +64,22 @@ module.exports = {
     create(context) {
         const option = context.options[0];
         let THRESHOLD = 20;
+        let VARIANT = "classic";
+
+        if (typeof option === "object") {
+            if (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max")) {
+                THRESHOLD = option.maximum || option.max;
+            }
 
-        if (
-            typeof option === "object" &&
-            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
-        ) {
-            THRESHOLD = option.maximum || option.max;
+            if (Object.hasOwn(option, "variant")) {
+                VARIANT = option.variant;
+            }
         } else if (typeof option === "number") {
             THRESHOLD = option;
         }
 
+        const IS_MODIFIED_COMPLEXITY = VARIANT === "modified";
+
         //--------------------------------------------------------------------------
         // Helpers
         //--------------------------------------------------------------------------
@@ -112,7 +121,8 @@ module.exports = {
             AssignmentPattern: increaseComplexity,
 
             // Avoid `default`
-            "SwitchCase[test]": increaseComplexity,
+            "SwitchCase[test]": () => IS_MODIFIED_COMPLEXITY || increaseComplexity(),
+            SwitchStatement: () => IS_MODIFIED_COMPLEXITY && increaseComplexity(),
 
             // Logical assignment operators have short-circuiting behavior
             AssignmentExpression(node) {

package/lib/shared/flags.js

@@ -10,6 +10,7 @@
  */
 const activeFlags = new Map([
     ["test_only", "Used only for testing."],
+    ["unstable_config_lookup_from_file", "Look up eslint.config.js from the file being linted."],
     ["unstable_ts_config", "Enable TypeScript configuration files."]
 ]);
 

package/lib/types/index.d.ts

@@ -1179,6 +1179,9 @@ export namespace Linter {
         ruleId: string | null;
         message: string;
         messageId?: string | undefined;
+        /**
+         * @deprecated `nodeType` is deprecated and will be removed in the next major version.
+         */
         nodeType?: string | undefined;
         fatal?: true | undefined;
         severity: Exclude<Severity, 0>;
@@ -1396,6 +1399,12 @@ export class ESLint {
 
     static readonly version: string;
 
+    /**
+     * The default configuration that ESLint uses internally. This is provided for tooling that wants to calculate configurations using the same defaults as ESLint.
+     * Keep in mind that the default configuration may change from version to version, so you shouldn't rely on any particular keys or values to be present.
+     */
+    static readonly defaultConfig: Linter.Config[];
+
     static outputFixes(results: ESLint.LintResult[]): Promise<void>;
 
     static getErrorResults(results: ESLint.LintResult[]): ESLint.LintResult[];
@@ -1655,6 +1664,9 @@ export namespace RuleTester {
     interface TestCaseError {
         message?: string | RegExp;
         messageId?: string;
+        /**
+         * @deprecated `type` is deprecated and will be removed in the next major version.
+         */
         type?: string | undefined;
         data?: any;
         line?: number | undefined;

package/lib/types/rules/best-practices.d.ts

@@ -118,6 +118,11 @@ export interface BestPractices extends Linter.RulesRecord {
                  * @default 20
                  */
                 maximum: number;
+                /**
+                 * @default "classic"
+                 * @since 9.12.0
+                 */
+                variant: "classic" | "modified";
             }>
             | number,
         ]
@@ -185,6 +190,7 @@ export interface BestPractices extends Linter.RulesRecord {
      * Rule to enforce consistent newlines before and after dots.
      *
      * @since 0.21.0
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/dot-location) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/dot-location
      */
     "dot-location": Linter.RuleEntry<["object" | "property"]>;
@@ -417,6 +423,10 @@ export interface BestPractices extends Linter.RulesRecord {
                  * @default false
                  */
                 allowEmptyCase: boolean;
+                /**
+                 * @default false
+                 */
+                reportUnusedFallthroughComment: boolean;
             }>,
         ]
     >;
@@ -425,6 +435,7 @@ export interface BestPractices extends Linter.RulesRecord {
      * Rule to disallow leading or trailing decimal points in numeric literals.
      *
      * @since 0.0.6
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/no-floating-decimal) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/no-floating-decimal
      */
     "no-floating-decimal": Linter.RuleEntry<[]>;
@@ -601,6 +612,7 @@ export interface BestPractices extends Linter.RulesRecord {
      * Rule to disallow multiple spaces.
      *
      * @since 0.9.0
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/no-multi-spaces) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/no-multi-spaces
      */
     "no-multi-spaces": Linter.RuleEntry<
@@ -872,6 +884,15 @@ export interface BestPractices extends Linter.RulesRecord {
      */
     "no-unused-labels": Linter.RuleEntry<[]>;
 
+    /**
+     * Disallow variable assignments when the value is not used
+     *
+     *
+     * @since 9.0.0-alpha.1
+     * @see https://eslint.org/docs/latest/rules/no-useless-assignment
+     */
+    "no-useless-assignment": Linter.RuleEntry<[]>;
+
     /**
      * Disallow useless backreferences in regular expressions
      *
@@ -1045,12 +1066,21 @@ export interface BestPractices extends Linter.RulesRecord {
     "require-await": Linter.RuleEntry<[]>;
 
     /**
-     * Rule to enforce the use of `u` flag on RegExp.
+     * Enforce the use of `u` or `v` flag on RegExp
      *
      * @since 5.3.0
      * @see https://eslint.org/docs/rules/require-unicode-regexp
      */
-    "require-unicode-regexp": Linter.RuleEntry<[]>;
+    "require-unicode-regexp": Linter.RuleEntry<
+        [
+            Partial<{
+                /**
+                 * @default false
+                 */
+                requireFlag: "u" | "v";
+            }>,
+        ]
+    >;
 
     /**
      * Rule to require `var` declarations be placed at the top of their containing scope.
@@ -1064,6 +1094,7 @@ export interface BestPractices extends Linter.RulesRecord {
      * Rule to require parentheses around immediate `function` invocations.
      *
      * @since 0.0.9
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/wrap-iife) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/wrap-iife
      */
     "wrap-iife": Linter.RuleEntry<

package/lib/types/rules/deprecated.d.ts

@@ -191,6 +191,24 @@ export interface Deprecated extends Linter.RulesRecord {
      */
     "no-negated-in-lhs": Linter.RuleEntry<[]>;
 
+    /**
+     * Rule to disallow `Object` constructors.
+     *
+     * @since 0.0.9
+     * @deprecated since 8.50.0, use [`no-object-constructor`](https://eslint.org/docs/rules/no-object-constructor) instead.
+     * @see https://eslint.org/docs/rules/no-object-constructor
+     */
+    "no-new-object": Linter.RuleEntry<[]>;
+
+    /**
+     * Rule to disallow `new` operators with the `Symbol` object.
+     *
+     * @since 2.0.0-beta.1
+     * @deprecated since 8.27.0, use [`no-new-native-nonconstructor`](https://eslint.org/docs/rules/no-new-native-nonconstructor) instead.
+     * @see https://eslint.org/docs/rules/no-new-symbol
+     */
+    "no-new-symbol": Linter.RuleEntry<[]>;
+
     /**
      * Rule to disallow spacing between function identifiers and their applications.
      *
@@ -214,81 +232,4 @@ export interface Deprecated extends Linter.RulesRecord {
             }>,
         ]
     >;
-
-    /**
-     * Rule to require JSDoc comments.
-     *
-     * @since 1.4.0
-     * @deprecated since 5.10.0
-     * @see https://eslint.org/docs/rules/require-jsdoc
-     */
-    "require-jsdoc": Linter.RuleEntry<
-        [
-            Partial<{
-                require: Partial<{
-                    /**
-                     * @default true
-                     */
-                    FunctionDeclaration: boolean;
-                    /**
-                     * @default false
-                     */
-                    MethodDefinition: boolean;
-                    /**
-                     * @default false
-                     */
-                    ClassDeclaration: boolean;
-                    /**
-                     * @default false
-                     */
-                    ArrowFunctionExpression: boolean;
-                    /**
-                     * @default false
-                     */
-                    FunctionExpression: boolean;
-                }>;
-            }>,
-        ]
-    >;
-
-    /**
-     * Rule to enforce valid JSDoc comments.
-     *
-     * @since 0.4.0
-     * @deprecated since 5.10.0
-     * @see https://eslint.org/docs/rules/valid-jsdoc
-     */
-    "valid-jsdoc": Linter.RuleEntry<
-        [
-            Partial<{
-                prefer: Record<string, string>;
-                preferType: Record<string, string>;
-                /**
-                 * @default true
-                 */
-                requireReturn: boolean;
-                /**
-                 * @default true
-                 */
-                requireReturnType: boolean;
-                /**
-                 * @remarks
-                 * Also accept for regular expression pattern
-                 */
-                matchDescription: string;
-                /**
-                 * @default true
-                 */
-                requireParamDescription: boolean;
-                /**
-                 * @default true
-                 */
-                requireReturnDescription: boolean;
-                /**
-                 * @default true
-                 */
-                requireParamType: boolean;
-            }>,
-        ]
-    >;
 }

package/lib/types/rules/ecmascript-6.d.ts

@@ -52,6 +52,7 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * Rule to require parentheses around arrow function arguments.
      *
      * @since 1.0.0-rc-1
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/arrow-parens) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/arrow-parens
      */
     "arrow-parens":
@@ -72,6 +73,7 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * Rule to enforce consistent spacing before and after the arrow in arrow functions.
      *
      * @since 1.0.0-rc-1
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/arrow-spacing) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/arrow-spacing
      */
     "arrow-spacing": Linter.RuleEntry<[]>;
@@ -91,6 +93,7 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * Rule to enforce consistent spacing around `*` operators in generator functions.
      *
      * @since 0.17.0
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/generator-star-spacing) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/generator-star-spacing
      */
     "generator-star-spacing": Linter.RuleEntry<
@@ -168,6 +171,7 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * Rule to disallow arrow functions where they could be confused with comparisons.
      *
      * @since 2.0.0-alpha-2
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/no-confusing-arrow) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/no-confusing-arrow
      */
     "no-confusing-arrow": Linter.RuleEntry<
@@ -221,15 +225,15 @@ export interface ECMAScript6 extends Linter.RulesRecord {
     >;
 
     /**
-     * Rule to disallow `new` operators with the `Symbol` object.
-     *
+     * Rule to disallow `new` operator with global non-constructor functions
+     * 
      * @remarks
      * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
      *
-     * @since 2.0.0-beta.1
-     * @see https://eslint.org/docs/rules/no-new-symbol
+     * @since 8.27.0
+     * @see https://eslint.org/docs/rules/no-new-native-nonconstructor
      */
-    "no-new-symbol": Linter.RuleEntry<[]>;
+    "no-new-native-nonconstructor": Linter.RuleEntry<[]>;
 
     /**
      * Rule to disallow specified names in exports.
@@ -324,7 +328,16 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * @since 2.9.0
      * @see https://eslint.org/docs/rules/no-useless-computed-key
      */
-    "no-useless-computed-key": Linter.RuleEntry<[]>;
+    "no-useless-computed-key": Linter.RuleEntry<
+        [
+            Partial<{
+                /**
+                 * @default true
+                 */
+                enforceForClassMembers: boolean;
+            }>,
+        ]
+    >;
 
     /**
      * Rule to disallow unnecessary constructors.
@@ -537,6 +550,7 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * Rule to enforce spacing between rest and spread operators and their expressions.
      *
      * @since 2.12.0
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/rest-spread-spacing) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/rest-spread-spacing
      */
     "rest-spread-spacing": Linter.RuleEntry<["never" | "always"]>;
@@ -586,6 +600,7 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * Rule to require or disallow spacing around embedded expressions of template strings.
      *
      * @since 2.0.0-rc.0
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/template-curly-spacing) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/template-curly-spacing
      */
     "template-curly-spacing": Linter.RuleEntry<["never" | "always"]>;
@@ -594,6 +609,7 @@ export interface ECMAScript6 extends Linter.RulesRecord {
      * Rule to require or disallow spacing around the `*` in `yield*` expressions.
      *
      * @since 2.0.0-alpha-1
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/yield-star-spacing) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/yield-star-spacing
      */
     "yield-star-spacing": Linter.RuleEntry<

package/lib/types/rules/possible-errors.d.ts

@@ -280,6 +280,7 @@ export interface PossibleErrors extends Linter.RulesRecord {
      * Rule to disallow unnecessary parentheses.
      *
      * @since 0.1.4
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/no-extra-parens) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/no-extra-parens
      */
     "no-extra-parens":
@@ -319,6 +320,7 @@ export interface PossibleErrors extends Linter.RulesRecord {
      * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
      *
      * @since 0.0.9
+     * @deprecated since 8.53.0, please use the [corresponding rule](https://eslint.style/rules/js/no-extra-semi) in `@stylistic/eslint-plugin-js`.
      * @see https://eslint.org/docs/rules/no-extra-semi
      */
     "no-extra-semi": Linter.RuleEntry<[]>;