eslint 9.0.0-beta.0 → 9.0.0-beta.2

package/README.md

@@ -103,7 +103,7 @@ We are now at or near 100% compatibility with JSCS. If you try ESLint and believ
 
 ### Does Prettier replace ESLint?
 
-No, ESLint and Prettier have diffent jobs: ESLint is a linter (looking for problematic patterns) and Prettier is a code formatter. Using both tools is common, refer to [Prettier's documentation](https://prettier.io/docs/en/install#eslint-and-other-linters) to learn how to configure them to work well with each other.
+No, ESLint and Prettier have different jobs: ESLint is a linter (looking for problematic patterns) and Prettier is a code formatter. Using both tools is common, refer to [Prettier's documentation](https://prettier.io/docs/en/install#eslint-and-other-linters) to learn how to configure them to work well with each other.
 
 ### Why can't ESLint find my plugins?
 
@@ -127,6 +127,18 @@ In other cases (including if rules need to warn on more or fewer cases due to ne
 
 Once a language feature has been adopted into the ECMAScript standard (stage 4 according to the [TC39 process](https://tc39.github.io/process-document/)), we will accept issues and pull requests related to the new feature, subject to our [contributing guidelines](https://eslint.org/docs/latest/contribute). Until then, please use the appropriate parser and plugin(s) for your experimental feature.
 
+### Which Node.js versions does ESLint support?
+
+ESLint updates the supported Node.js versions with each major release of ESLint. At that time, ESLint's supported Node.js versions are updated to be:
+
+1. The most recent maintenance release of Node.js
+1. The lowest minor version of the Node.js LTS release that includes the features the ESLint team wants to use.
+1. The Node.js Current release
+
+ESLint is also expected to work with Node.js versions released after the Node.js Current release.
+
+Refer to the [Quick Start Guide](https://eslint.org/docs/latest/use/getting-started#prerequisites) for the officially supported Node.js versions for a given ESLint release.
+
 ### Where to ask for help?
 
 Open a [discussion](https://github.com/eslint/eslint/discussions) or stop by our [Discord server](https://eslint.org/chat).
@@ -213,6 +225,11 @@ The people who manage releases, review feature requests, and meet regularly to e
 Nicholas C. Zakas
 </a>
 </td><td align="center" valign="top" width="11%">
+<a href="https://github.com/fasttime">
+<img src="https://github.com/fasttime.png?s=75" width="75" height="75" alt="Francesco Trotta's Avatar"><br />
+Francesco Trotta
+</a>
+</td><td align="center" valign="top" width="11%">
 <a href="https://github.com/mdjermanovic">
 <img src="https://github.com/mdjermanovic.png?s=75" width="75" height="75" alt="Milos Djermanovic's Avatar"><br />
 Milos Djermanovic
@@ -250,11 +267,6 @@ Bryan Mishkin
 Josh Goldberg ✨
 </a>
 </td><td align="center" valign="top" width="11%">
-<a href="https://github.com/fasttime">
-<img src="https://github.com/fasttime.png?s=75" width="75" height="75" alt="Francesco Trotta's Avatar"><br />
-Francesco Trotta
-</a>
-</td><td align="center" valign="top" width="11%">
 <a href="https://github.com/Tanujkanti4441">
 <img src="https://github.com/Tanujkanti4441.png?s=75" width="75" height="75" alt="Tanuj Kanti's Avatar"><br />
 Tanuj Kanti
@@ -294,7 +306,7 @@ The following companies, organizations, and individuals support ESLint's ongoing
 <p><a href="#"><img src="https://images.opencollective.com/2021-frameworks-fund/logo.png" alt="Chrome Frameworks Fund" height="undefined"></a> <a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://www.jetbrains.com/"><img src="https://images.opencollective.com/jetbrains/eb04ddc/logo.png" alt="JetBrains" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="64"></a> <a href="https://www.workleap.com"><img src="https://avatars.githubusercontent.com/u/53535748?u=d1e55d7661d724bf2281c1bfd33cb8f99fe2465f&v=4" alt="Workleap" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://themeisle.com"><img src="https://images.opencollective.com/themeisle/d5592fe/logo.png" alt="ThemeIsle" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://transloadit.com/"><img src="https://avatars.githubusercontent.com/u/125754?v=4" alt="Transloadit" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104?v=4" alt="Nx" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://usenextbase.com"><img src="https://avatars.githubusercontent.com/u/145838380?v=4" alt="Nextbase Starter Kit" height="32"></a></p>
+<p><a href="https://www.notion.so"><img src="https://images.opencollective.com/notion/bf3b117/logo.png" alt="notion" height="32"></a> <a href="https://themeisle.com"><img src="https://images.opencollective.com/themeisle/d5592fe/logo.png" alt="ThemeIsle" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://transloadit.com/"><img src="https://avatars.githubusercontent.com/u/125754?v=4" alt="Transloadit" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104?v=4" alt="Nx" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://usenextbase.com"><img src="https://avatars.githubusercontent.com/u/145838380?v=4" alt="Nextbase Starter Kit" height="32"></a></p>
 <!--sponsorsend-->
 
 ## Technology Sponsors

package/lib/config/rule-validator.js

@@ -167,9 +167,22 @@ class RuleValidator {
                 validateRule(ruleOptions.slice(1));
 
                 if (validateRule.errors) {
-                    throw new Error(`Key "rules": Key "${ruleId}": ${
+                    throw new Error(`Key "rules": Key "${ruleId}":\n${
                         validateRule.errors.map(
-                            error => `\tValue ${JSON.stringify(error.data)} ${error.message}.\n`
+                            error => {
+                                if (
+                                    error.keyword === "additionalProperties" &&
+                                    error.schema === false &&
+                                    typeof error.parentSchema?.properties === "object" &&
+                                    typeof error.params?.additionalProperty === "string"
+                                ) {
+                                    const expectedProperties = Object.keys(error.parentSchema.properties).map(property => `"${property}"`);
+
+                                    return `\tValue ${JSON.stringify(error.data)} ${error.message}.\n\t\tUnexpected property "${error.params.additionalProperty}". Expected properties: ${expectedProperties.join(", ")}.\n`;
+                                }
+
+                                return `\tValue ${JSON.stringify(error.data)} ${error.message}.\n`;
+                            }
                         ).join("")
                     }`);
                 }

package/lib/eslint/eslint.js

@@ -838,6 +838,7 @@ class ESLint {
             configs,
             errorOnUnmatchedPattern
         });
+        const controller = new AbortController();
 
         debug(`${filePaths.length} files found in: ${Date.now() - startTime}ms`);
 
@@ -906,9 +907,12 @@ class ESLint {
                     fixer = message => shouldMessageBeFixed(message, config, fixTypesSet) && originalFix(message);
                 }
 
-                return fs.readFile(filePath, "utf8")
+                return fs.readFile(filePath, { encoding: "utf8", signal: controller.signal })
                     .then(text => {
 
+                        // fail immediately if an error occurred in another file
+                        controller.signal.throwIfAborted();
+
                         // do the linting
                         const result = verifyText({
                             text,
@@ -932,6 +936,9 @@ class ESLint {
                         }
 
                         return result;
+                    }).catch(error => {
+                        controller.abort(error);
+                        throw error;
                     });
 
             })

package/lib/linter/linter.js

@@ -43,7 +43,7 @@ const
 const { getRuleFromConfig } = require("../config/flat-config-helpers");
 const { FlatConfigArray } = require("../config/flat-config-array");
 const { RuleValidator } = require("../config/rule-validator");
-const { assertIsRuleOptions, assertIsRuleSeverity } = require("../config/flat-config-schema");
+const { assertIsRuleSeverity } = require("../config/flat-config-schema");
 const { normalizeSeverityToString } = require("../shared/severity");
 const debug = require("debug")("eslint:linter");
 const MAX_AUTOFIX_PASSES = 10;
@@ -326,10 +326,11 @@ function createDisableDirectives(options) {
  * @param {SourceCode} sourceCode The SourceCode object to get comments from.
  * @param {function(string): {create: Function}} ruleMapper A map from rule IDs to defined rules
  * @param {string|null} warnInlineConfig If a string then it should warn directive comments as disabled. The string value is the config name what the setting came from.
+ * @param {ConfigData} config Provided config.
  * @returns {{configuredRules: Object, enabledGlobals: {value:string,comment:Token}[], exportedVariables: Object, problems: LintMessage[], disableDirectives: DisableDirective[]}}
  * A collection of the directive comments that were found, along with any problems that occurred when parsing
  */
-function getDirectiveComments(sourceCode, ruleMapper, warnInlineConfig) {
+function getDirectiveComments(sourceCode, ruleMapper, warnInlineConfig, config) {
     const configuredRules = {};
     const enabledGlobals = Object.create(null);
     const exportedVariables = {};
@@ -438,8 +439,58 @@ function getDirectiveComments(sourceCode, ruleMapper, warnInlineConfig) {
                             return;
                         }
 
+                        if (Object.hasOwn(configuredRules, name)) {
+                            problems.push(createLintingProblem({
+                                message: `Rule "${name}" is already configured by another configuration comment in the preceding code. This configuration is ignored.`,
+                                loc: comment.loc
+                            }));
+                            return;
+                        }
+
+                        let ruleOptions = Array.isArray(ruleValue) ? ruleValue : [ruleValue];
+
+                        /*
+                         * If the rule was already configured, inline rule configuration that
+                         * only has severity should retain options from the config and just override the severity.
+                         *
+                         * Example:
+                         *
+                         *   {
+                         *       rules: {
+                         *           curly: ["error", "multi"]
+                         *       }
+                         *   }
+                         *
+                         *   /* eslint curly: ["warn"] * /
+                         *
+                         *   Results in:
+                         *
+                         *   curly: ["warn", "multi"]
+                         */
+                        if (
+
+                            /*
+                             * If inline config for the rule has only severity
+                             */
+                            ruleOptions.length === 1 &&
+
+                            /*
+                             * And the rule was already configured
+                             */
+                            config.rules && Object.hasOwn(config.rules, name)
+                        ) {
+
+                            /*
+                             * Then use severity from the inline config and options from the provided config
+                             */
+                            ruleOptions = [
+                                ruleOptions[0], // severity from the inline config
+                                ...Array.isArray(config.rules[name]) ? config.rules[name].slice(1) : [] // options from the provided config
+                            ];
+                        }
+
                         try {
-                            validator.validateRuleOptions(rule, name, ruleValue);
+                            validator.validateRuleOptions(rule, name, ruleOptions);
                         } catch (err) {
 
                             /*
@@ -460,7 +511,7 @@ function getDirectiveComments(sourceCode, ruleMapper, warnInlineConfig) {
                             return;
                         }
 
-                        configuredRules[name] = ruleValue;
+                        configuredRules[name] = ruleOptions;
                     });
                 } else {
                     problems.push(parseResult.error);
@@ -1322,7 +1373,7 @@ class Linter {
 
         const sourceCode = slots.lastSourceCode;
         const commentDirectives = options.allowInlineConfig
-            ? getDirectiveComments(sourceCode, ruleId => getRule(slots, ruleId), options.warnInlineConfig)
+            ? getDirectiveComments(sourceCode, ruleId => getRule(slots, ruleId), options.warnInlineConfig, config)
             : { configuredRules: {}, enabledGlobals: {}, exportedVariables: {}, problems: [], disableDirectives: [] };
 
         // augment global scope with declared global variables
@@ -1332,56 +1383,8 @@ class Linter {
             { exportedVariables: commentDirectives.exportedVariables, enabledGlobals: commentDirectives.enabledGlobals }
         );
 
-        /*
-         * Now we determine the final configurations for rules.
-         * First, let all inline rule configurations override those from the config.
-         * Then, check for a special case: if a rule is configured in both places,
-         * inline rule configuration that only has severity should retain options from
-         * the config and just override the severity.
-         *
-         * Example:
-         *
-         *   {
-         *       rules: {
-         *           curly: ["error", "multi"]
-         *       }
-         *   }
-         *
-         *   /* eslint curly: ["warn"] * /
-         *
-         *   Results in:
-         *
-         *   curly: ["warn", "multi"]
-         */
         const configuredRules = Object.assign({}, config.rules, commentDirectives.configuredRules);
 
-        if (config.rules) {
-            for (const [ruleId, ruleInlineConfig] of Object.entries(commentDirectives.configuredRules)) {
-                if (
-
-                    /*
-                     * If inline config for the rule has only severity
-                     */
-                    (!Array.isArray(ruleInlineConfig) || ruleInlineConfig.length === 1) &&
-
-                    /*
-                     * And provided config for the rule has options
-                     */
-                    Object.hasOwn(config.rules, ruleId) &&
-                    (Array.isArray(config.rules[ruleId]) && config.rules[ruleId].length > 1)
-                ) {
-
-                    /*
-                     * Then use severity from the inline config and options from the provided config
-                     */
-                    configuredRules[ruleId] = [
-                        Array.isArray(ruleInlineConfig) ? ruleInlineConfig[0] : ruleInlineConfig, // severity from the inline config
-                        ...config.rules[ruleId].slice(1) // options from the provided config
-                    ];
-                }
-            }
-        }
-
         let lintingProblems;
 
         try {
@@ -1711,19 +1714,77 @@ class Linter {
                             return;
                         }
 
+                        if (Object.hasOwn(mergedInlineConfig.rules, ruleId)) {
+                            inlineConfigProblems.push(createLintingProblem({
+                                message: `Rule "${ruleId}" is already configured by another configuration comment in the preceding code. This configuration is ignored.`,
+                                loc: node.loc
+                            }));
+                            return;
+                        }
+
                         try {
 
-                            const ruleOptions = Array.isArray(ruleValue) ? ruleValue : [ruleValue];
+                            let ruleOptions = Array.isArray(ruleValue) ? ruleValue : [ruleValue];
 
-                            assertIsRuleOptions(ruleId, ruleValue);
                             assertIsRuleSeverity(ruleId, ruleOptions[0]);
 
-                            ruleValidator.validate({
-                                plugins: config.plugins,
-                                rules: {
-                                    [ruleId]: ruleOptions
+                            /*
+                             * If the rule was already configured, inline rule configuration that
+                             * only has severity should retain options from the config and just override the severity.
+                             *
+                             * Example:
+                             *
+                             *   {
+                             *       rules: {
+                             *           curly: ["error", "multi"]
+                             *       }
+                             *   }
+                             *
+                             *   /* eslint curly: ["warn"] * /
+                             *
+                             *   Results in:
+                             *
+                             *   curly: ["warn", "multi"]
+                             */
+
+                            let shouldValidateOptions = true;
+
+                            if (
+
+                                /*
+                                 * If inline config for the rule has only severity
+                                 */
+                                ruleOptions.length === 1 &&
+
+                                /*
+                                 * And the rule was already configured
+                                 */
+                                config.rules && Object.hasOwn(config.rules, ruleId)
+                            ) {
+
+                                /*
+                                 * Then use severity from the inline config and options from the provided config
+                                 */
+                                ruleOptions = [
+                                    ruleOptions[0], // severity from the inline config
+                                    ...config.rules[ruleId].slice(1) // options from the provided config
+                                ];
+
+                                // if the rule was enabled, the options have already been validated
+                                if (config.rules[ruleId][0] > 0) {
+                                    shouldValidateOptions = false;
                                 }
-                            });
+                            }
+
+                            if (shouldValidateOptions) {
+                                ruleValidator.validate({
+                                    plugins: config.plugins,
+                                    rules: {
+                                        [ruleId]: ruleOptions
+                                    }
+                                });
+                            }
+
                             mergedInlineConfig.rules[ruleId] = ruleOptions;
                         } catch (err) {
 
@@ -1763,58 +1824,8 @@ class Linter {
             )
             : { problems: [], disableDirectives: [] };
 
-        /*
-         * Now we determine the final configurations for rules.
-         * First, let all inline rule configurations override those from the config.
-         * Then, check for a special case: if a rule is configured in both places,
-         * inline rule configuration that only has severity should retain options from
-         * the config and just override the severity.
-         *
-         * Example:
-         *
-         *   {
-         *       rules: {
-         *           curly: ["error", "multi"]
-         *       }
-         *   }
-         *
-         *   /* eslint curly: ["warn"] * /
-         *
-         *   Results in:
-         *
-         *   curly: ["warn", "multi"]
-         *
-         * At this point, all rule configurations are normalized to arrays.
-         */
         const configuredRules = Object.assign({}, config.rules, mergedInlineConfig.rules);
 
-        if (config.rules) {
-            for (const [ruleId, ruleInlineConfig] of Object.entries(mergedInlineConfig.rules)) {
-                if (
-
-                    /*
-                     * If inline config for the rule has only severity
-                     */
-                    ruleInlineConfig.length === 1 &&
-
-                    /*
-                     * And provided config for the rule has options
-                     */
-                    Object.hasOwn(config.rules, ruleId) &&
-                    config.rules[ruleId].length > 1
-                ) {
-
-                    /*
-                     * Then use severity from the inline config and options from the provided config
-                     */
-                    configuredRules[ruleId] = [
-                        ruleInlineConfig[0], // severity from the inline config
-                        ...config.rules[ruleId].slice(1) // options from the provided config
-                    ];
-                }
-            }
-        }
-
         let lintingProblems;
 
         sourceCode.finalize();

package/lib/rules/complexity.js

@@ -109,6 +109,7 @@ module.exports = {
             IfStatement: increaseComplexity,
             WhileStatement: increaseComplexity,
             DoWhileStatement: increaseComplexity,
+            AssignmentPattern: increaseComplexity,
 
             // Avoid `default`
             "SwitchCase[test]": increaseComplexity,
@@ -120,6 +121,18 @@ module.exports = {
                 }
             },
 
+            MemberExpression(node) {
+                if (node.optional === true) {
+                    increaseComplexity();
+                }
+            },
+
+            CallExpression(node) {
+                if (node.optional === true) {
+                    increaseComplexity();
+                }
+            },
+
             onCodePathEnd(codePath, node) {
                 const complexity = complexities.pop();
 

package/lib/rules/no-constant-binary-expression.js

@@ -5,8 +5,7 @@
 
 "use strict";
 
-const globals = require("globals");
-const { isNullLiteral, isConstant, isReferenceToGlobalVariable, isLogicalAssignmentOperator } = require("./utils/ast-utils");
+const { isNullLiteral, isConstant, isReferenceToGlobalVariable, isLogicalAssignmentOperator, ECMASCRIPT_GLOBALS } = require("./utils/ast-utils");
 
 const NUMERIC_OR_STRING_BINARY_OPERATORS = new Set(["+", "-", "*", "/", "%", "|", "^", "&", "**", "<<", ">>", ">>>"]);
 
@@ -376,7 +375,7 @@ function isAlwaysNew(scope, node) {
              * Catching these is especially useful for primitive constructors
              * which return boxed values, a surprising gotcha' in JavaScript.
              */
-            return Object.hasOwn(globals.builtin, node.callee.name) &&
+            return Object.hasOwn(ECMASCRIPT_GLOBALS, node.callee.name) &&
               isReferenceToGlobalVariable(scope, node.callee);
         }
         case "Literal":

package/lib/rules/no-extend-native.js

@@ -10,7 +10,6 @@
 //------------------------------------------------------------------------------
 
 const astUtils = require("./utils/ast-utils");
-const globals = require("globals");
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -54,7 +53,7 @@ module.exports = {
         const sourceCode = context.sourceCode;
         const exceptions = new Set(config.exceptions || []);
         const modifiedBuiltins = new Set(
-            Object.keys(globals.builtin)
+            Object.keys(astUtils.ECMASCRIPT_GLOBALS)
                 .filter(builtin => builtin[0].toUpperCase() === builtin[0])
                 .filter(builtin => !exceptions.has(builtin))
         );