eslint 9.0.0-alpha.0 → 9.0.0-alpha.1

package/lib/rules/indent.js

@@ -1077,7 +1077,7 @@ module.exports = {
             "ObjectExpression, ObjectPattern"(node) {
                 const openingCurly = sourceCode.getFirstToken(node);
                 const closingCurly = sourceCode.getTokenAfter(
-                    node.properties.length ? node.properties[node.properties.length - 1] : openingCurly,
+                    node.properties.length ? node.properties.at(-1) : openingCurly,
                     astUtils.isClosingBraceToken
                 );
 
@@ -1407,7 +1407,7 @@ module.exports = {
             PropertyDefinition(node) {
                 const firstToken = sourceCode.getFirstToken(node);
                 const maybeSemicolonToken = sourceCode.getLastToken(node);
-                let keyLastToken = null;
+                let keyLastToken;
 
                 // Indent key.
                 if (node.computed) {
@@ -1458,7 +1458,7 @@ module.exports = {
 
                 if (node.cases.length) {
                     sourceCode.getTokensBetween(
-                        node.cases[node.cases.length - 1],
+                        node.cases.at(-1),
                         closingCurly,
                         { includeComments: true, filter: astUtils.isCommentToken }
                     ).forEach(token => offsets.ignoreToken(token));
@@ -1488,7 +1488,7 @@ module.exports = {
             },
 
             VariableDeclaration(node) {
-                let variableIndent = Object.prototype.hasOwnProperty.call(options.VariableDeclarator, node.kind)
+                let variableIndent = Object.hasOwn(options.VariableDeclarator, node.kind)
                     ? options.VariableDeclarator[node.kind]
                     : DEFAULT_VARIABLE_INDENT;
 
@@ -1509,7 +1509,7 @@ module.exports = {
                     variableIndent = DEFAULT_VARIABLE_INDENT;
                 }
 
-                if (node.declarations[node.declarations.length - 1].loc.start.line > node.loc.start.line) {
+                if (node.declarations.at(-1).loc.start.line > node.loc.start.line) {
 
                     /*
                      * VariableDeclarator indentation is a bit different from other forms of indentation, in that the

package/lib/rules/index.js

@@ -229,6 +229,7 @@ module.exports = new LazyLoadingRuleMap(Object.entries({
     "no-unused-private-class-members": () => require("./no-unused-private-class-members"),
     "no-unused-vars": () => require("./no-unused-vars"),
     "no-use-before-define": () => require("./no-use-before-define"),
+    "no-useless-assignment": () => require("./no-useless-assignment"),
     "no-useless-backreference": () => require("./no-useless-backreference"),
     "no-useless-call": () => require("./no-useless-call"),
     "no-useless-catch": () => require("./no-useless-catch"),

package/lib/rules/key-spacing.js

@@ -28,7 +28,7 @@ function containsLineTerminator(str) {
  * @returns {any} Last element of arr.
  */
 function last(arr) {
-    return arr[arr.length - 1];
+    return arr.at(-1);
 }
 
 /**
@@ -489,7 +489,7 @@ module.exports = {
                     }
                 }
 
-                let messageId = "";
+                let messageId;
 
                 if (isExtra) {
                     messageId = side === "key" ? "extraKey" : "extraValue";

package/lib/rules/line-comment-position.js

@@ -68,7 +68,7 @@ module.exports = {
             above = !options.position || options.position === "above";
             ignorePattern = options.ignorePattern;
 
-            if (Object.prototype.hasOwnProperty.call(options, "applyDefaultIgnorePatterns")) {
+            if (Object.hasOwn(options, "applyDefaultIgnorePatterns")) {
                 applyDefaultIgnorePatterns = options.applyDefaultIgnorePatterns;
             } else {
                 applyDefaultIgnorePatterns = options.applyDefaultPatterns !== false;

package/lib/rules/lines-around-directive.js

@@ -166,7 +166,7 @@ module.exports = {
                 reportError(firstDirective, "before", false);
             }
 
-            const lastDirective = directives[directives.length - 1];
+            const lastDirective = directives.at(-1);
             const statements = node.type === "Program" ? node.body : node.body.body;
 
             /*
@@ -174,7 +174,7 @@ module.exports = {
              * contains a directive prologue and isn't followed by a comment to ensure
              * this rule behaves well with padded-blocks.
              */
-            if (lastDirective === statements[statements.length - 1] && !lastDirective.trailingComments) {
+            if (lastDirective === statements.at(-1) && !lastDirective.trailingComments) {
                 return;
             }
 

package/lib/rules/max-depth.js

@@ -61,7 +61,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             maxDepth = option.maximum || option.max;
         }

package/lib/rules/max-len.js

@@ -124,7 +124,7 @@ module.exports = {
         }
 
         // The options object must be the last option specified…
-        const options = Object.assign({}, context.options[context.options.length - 1]);
+        const options = Object.assign({}, context.options.at(-1));
 
         // …but max code length…
         if (typeof context.options[0] === "number") {
@@ -290,7 +290,7 @@ module.exports = {
                     if (isJSXEmptyExpressionInSingleLineContainer(containingNode)) {
 
                         // push a unique node only
-                        if (comments[comments.length - 1] !== containingNode.parent) {
+                        if (comments.at(-1) !== containingNode.parent) {
                             comments.push(containingNode.parent);
                         }
                     } else {
@@ -344,7 +344,7 @@ module.exports = {
                  * comments to check.
                  */
                 if (commentsIndex < comments.length) {
-                    let comment = null;
+                    let comment;
 
                     // iterate over comments until we find one past the current line
                     do {

package/lib/rules/max-lines.js

@@ -77,7 +77,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            Object.prototype.hasOwnProperty.call(option, "max")
+            Object.hasOwn(option, "max")
         ) {
             max = option.max;
         } else if (typeof option === "number") {
@@ -148,7 +148,7 @@ module.exports = {
                  * If file ends with a linebreak, `sourceCode.lines` will have one extra empty line at the end.
                  * That isn't a real line, so we shouldn't count it.
                  */
-                if (lines.length > 1 && lines[lines.length - 1].text === "") {
+                if (lines.length > 1 && lines.at(-1).text === "") {
                     lines.pop();
                 }
 
@@ -174,7 +174,7 @@ module.exports = {
                         },
                         end: {
                             line: sourceCode.lines.length,
-                            column: sourceCode.lines[sourceCode.lines.length - 1].length
+                            column: sourceCode.lines.at(-1).length
                         }
                     };
 

package/lib/rules/max-nested-callbacks.js

@@ -59,7 +59,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             THRESHOLD = option.maximum || option.max;
         } else if (typeof option === "number") {

package/lib/rules/max-params.js

@@ -63,7 +63,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             numParams = option.maximum || option.max;
         }

package/lib/rules/max-statements.js

@@ -79,7 +79,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             maxStatements = option.maximum || option.max;
         } else if (typeof option === "number") {

package/lib/rules/multiline-comment-style.js

@@ -113,7 +113,7 @@ module.exports = {
 
             return /^\*\s*$/u.test(lines[0]) &&
                 lines.slice(1, -1).every(line => /^\s* /u.test(line)) &&
-                /^\s*$/u.test(lines[lines.length - 1]);
+                /^\s*$/u.test(lines.at(-1));
         }
 
         /**
@@ -272,11 +272,11 @@ module.exports = {
                     context.report({
                         loc: {
                             start: firstComment.loc.start,
-                            end: commentGroup[commentGroup.length - 1].loc.end
+                            end: commentGroup.at(-1).loc.end
                         },
                         messageId: "expectedBlock",
                         fix(fixer) {
-                            const range = [firstComment.range[0], commentGroup[commentGroup.length - 1].range[1]];
+                            const range = [firstComment.range[0], commentGroup.at(-1).range[1]];
 
                             return commentLines.some(value => value.startsWith("/"))
                                 ? null
@@ -301,7 +301,7 @@ module.exports = {
                         });
                     }
 
-                    if (!/^\s*$/u.test(lines[lines.length - 1])) {
+                    if (!/^\s*$/u.test(lines.at(-1))) {
                         context.report({
                             loc: {
                                 start: { line: firstComment.loc.end.line, column: firstComment.loc.end.column - 2 },
@@ -408,12 +408,12 @@ module.exports = {
                     context.report({
                         loc: {
                             start: firstComment.loc.start,
-                            end: commentGroup[commentGroup.length - 1].loc.end
+                            end: commentGroup.at(-1).loc.end
                         },
                         messageId: "expectedBlock",
                         fix(fixer) {
                             return fixer.replaceTextRange(
-                                [firstComment.range[0], commentGroup[commentGroup.length - 1].range[1]],
+                                [firstComment.range[0], commentGroup.at(-1).range[1]],
                                 convertToBlock(firstComment, commentLines)
                             );
                         }
@@ -459,7 +459,7 @@ module.exports = {
                             tokenBefore && tokenBefore.loc.end.line === comment.loc.start.line - 1 &&
                             tokenBefore === commentList[index - 1]
                         ) {
-                            commentGroups[commentGroups.length - 1].push(comment);
+                            commentGroups.at(-1).push(comment);
                         } else {
                             commentGroups.push([comment]);
                         }

package/lib/rules/new-cap.js

@@ -40,7 +40,7 @@ const CAPS_ALLOWED = [
 function checkArray(obj, key, fallback) {
 
     /* c8 ignore start */
-    if (Object.prototype.hasOwnProperty.call(obj, key) && !Array.isArray(obj[key])) {
+    if (Object.hasOwn(obj, key) && !Array.isArray(obj[key])) {
         throw new TypeError(`${key}, if provided, must be an Array`);
     }/* c8 ignore stop */
     return obj[key] || fallback;

package/lib/rules/newline-after-var.js

@@ -215,7 +215,7 @@ module.exports = {
                     fix(fixer) {
                         const linesBetween = sourceCode.getText().slice(lastToken.range[1], nextToken.range[0]).split(astUtils.LINEBREAK_MATCHER);
 
-                        return fixer.replaceTextRange([lastToken.range[1], nextToken.range[0]], `${linesBetween.slice(0, -1).join("")}\n${linesBetween[linesBetween.length - 1]}`);
+                        return fixer.replaceTextRange([lastToken.range[1], nextToken.range[0]], `${linesBetween.slice(0, -1).join("")}\n${linesBetween.at(-1)}`);
                     }
                 });
             }

package/lib/rules/newline-before-return.js

@@ -166,7 +166,7 @@ module.exports = {
          */
         function canFix(node) {
             const leadingComments = sourceCode.getCommentsBefore(node);
-            const lastLeadingComment = leadingComments[leadingComments.length - 1];
+            const lastLeadingComment = leadingComments.at(-1);
             const tokenBefore = sourceCode.getTokenBefore(node);
 
             if (leadingComments.length === 0) {

package/lib/rules/no-constant-binary-expression.js

@@ -103,7 +103,7 @@ function hasConstantNullishness(scope, node, nonNullish) {
 
             return true;
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return hasConstantNullishness(scope, last, nonNullish);
         }
@@ -248,7 +248,7 @@ function hasConstantLooseBooleanComparison(scope, node) {
              */
             return false;
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return hasConstantLooseBooleanComparison(scope, last);
         }
@@ -299,7 +299,7 @@ function hasConstantStrictBooleanComparison(scope, node) {
             return true;
         }
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return hasConstantStrictBooleanComparison(scope, last);
         }
@@ -376,7 +376,7 @@ function isAlwaysNew(scope, node) {
              * Catching these is especially useful for primitive constructors
              * which return boxed values, a surprising gotcha' in JavaScript.
              */
-            return Object.hasOwnProperty.call(globals.builtin, node.callee.name) &&
+            return Object.hasOwn(globals.builtin, node.callee.name) &&
               isReferenceToGlobalVariable(scope, node.callee);
         }
         case "Literal":
@@ -384,7 +384,7 @@ function isAlwaysNew(scope, node) {
             // Regular expressions are objects, and thus always new
             return typeof node.regex === "object";
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return isAlwaysNew(scope, last);
         }

package/lib/rules/no-constructor-return.js

@@ -40,7 +40,7 @@ module.exports = {
                 stack.pop();
             },
             ReturnStatement(node) {
-                const last = stack[stack.length - 1];
+                const last = stack.at(-1);
 
                 if (!last.parent) {
                     return;

package/lib/rules/no-dupe-class-members.js

@@ -42,7 +42,7 @@ module.exports = {
          *   - retv.set {boolean} A flag which shows the name is declared as setter.
          */
         function getState(name, isStatic) {
-            const stateMap = stack[stack.length - 1];
+            const stateMap = stack.at(-1);
             const key = `$${name}`; // to avoid "__proto__".
 
             if (!stateMap[key]) {
@@ -82,7 +82,7 @@ module.exports = {
                 }
 
                 const state = getState(name, node.static);
-                let isDuplicate = false;
+                let isDuplicate;
 
                 if (kind === "get") {
                     isDuplicate = (state.init || state.get);

package/lib/rules/no-else-return.js

@@ -270,7 +270,7 @@ module.exports = {
         function naiveHasReturn(node) {
             if (node.type === "BlockStatement") {
                 const body = node.body,
-                    lastChildNode = body[body.length - 1];
+                    lastChildNode = body.at(-1);
 
                 return lastChildNode && checkForReturn(lastChildNode);
             }

package/lib/rules/no-empty-function.js

@@ -40,7 +40,7 @@ const ALLOW_OPTIONS = Object.freeze([
  */
 function getKind(node) {
     const parent = node.parent;
-    let kind = "";
+    let kind;
 
     if (node.type === "ArrowFunctionExpression") {
         return "arrowFunctions";
@@ -73,7 +73,7 @@ function getKind(node) {
     }
 
     // Detects prefix.
-    let prefix = "";
+    let prefix;
 
     if (node.generator) {
         prefix = "generator";

package/lib/rules/no-fallthrough.js

@@ -187,7 +187,7 @@ module.exports = {
                  */
                 if (isAnySegmentReachable(currentCodePathSegments) &&
                     (node.consequent.length > 0 || (!allowEmptyCase && hasBlankLinesBetween(node, nextToken))) &&
-                    node.parent.cases[node.parent.cases.length - 1] !== node) {
+                    node.parent.cases.at(-1) !== node) {
                     fallthroughCase = node;
                 }
             }

package/lib/rules/no-inner-declarations.js

@@ -56,6 +56,15 @@ module.exports = {
         schema: [
             {
                 enum: ["functions", "both"]
+            },
+            {
+                type: "object",
+                properties: {
+                    blockScopedFunctions: {
+                        enum: ["allow", "disallow"]
+                    }
+                },
+                additionalProperties: false
             }
         ],
 
@@ -66,6 +75,10 @@ module.exports = {
 
     create(context) {
 
+        const sourceCode = context.sourceCode;
+        const ecmaVersion = context.languageOptions.ecmaVersion;
+        const blockScopedFunctions = context.options[1]?.blockScopedFunctions ?? "allow";
+
         /**
          * Ensure that a given node is at a program or function body's root.
          * @param {ASTNode} node Declaration node to check.
@@ -97,7 +110,15 @@ module.exports = {
 
         return {
 
-            FunctionDeclaration: check,
+            FunctionDeclaration(node) {
+                const isInStrictCode = sourceCode.getScope(node).upper.isStrict;
+
+                if (blockScopedFunctions === "allow" && ecmaVersion >= 2015 && isInStrictCode) {
+                    return;
+                }
+
+                check(node);
+            },
             VariableDeclaration(node) {
                 if (context.options[0] === "both" && node.kind === "var") {
                     check(node);

package/lib/rules/no-invalid-this.js

@@ -74,7 +74,7 @@ module.exports = {
          *   an object which has a flag that whether or not `this` keyword is valid.
          */
         stack.getCurrent = function() {
-            const current = this[this.length - 1];
+            const current = this.at(-1);
 
             if (!current.init) {
                 current.init = true;

package/lib/rules/no-lone-blocks.js

@@ -78,7 +78,7 @@ module.exports = {
 
             const block = node.parent;
 
-            if (loneBlocks[loneBlocks.length - 1] === block) {
+            if (loneBlocks.at(-1) === block) {
                 loneBlocks.pop();
             }
         }
@@ -101,7 +101,7 @@ module.exports = {
                     }
                 },
                 "BlockStatement:exit"(node) {
-                    if (loneBlocks.length > 0 && loneBlocks[loneBlocks.length - 1] === node) {
+                    if (loneBlocks.length > 0 && loneBlocks.at(-1) === node) {
                         loneBlocks.pop();
                         report(node);
                     } else if (

package/lib/rules/no-loss-of-precision.js

@@ -64,7 +64,7 @@ module.exports = {
          */
         function notBaseTenLosesPrecision(node) {
             const rawString = getRaw(node).toUpperCase();
-            let base = 0;
+            let base;
 
             if (rawString.startsWith("0B")) {
                 base = 2;