eslint 8.56.0 → 9.0.0-alpha.1

package/lib/rules/one-var.js

@@ -109,12 +109,12 @@ module.exports = {
             options.var = { uninitialized: mode.var, initialized: mode.var };
             options.let = { uninitialized: mode.let, initialized: mode.let };
             options.const = { uninitialized: mode.const, initialized: mode.const };
-            if (Object.prototype.hasOwnProperty.call(mode, "uninitialized")) {
+            if (Object.hasOwn(mode, "uninitialized")) {
                 options.var.uninitialized = mode.uninitialized;
                 options.let.uninitialized = mode.uninitialized;
                 options.const.uninitialized = mode.uninitialized;
             }
-            if (Object.prototype.hasOwnProperty.call(mode, "initialized")) {
+            if (Object.hasOwn(mode, "initialized")) {
                 options.var.initialized = mode.initialized;
                 options.let.initialized = mode.initialized;
                 options.const.initialized = mode.initialized;
@@ -216,11 +216,11 @@ module.exports = {
             let currentScope;
 
             if (statementType === "var") {
-                currentScope = functionStack[functionStack.length - 1];
+                currentScope = functionStack.at(-1);
             } else if (statementType === "let") {
-                currentScope = blockStack[blockStack.length - 1].let;
+                currentScope = blockStack.at(-1).let;
             } else if (statementType === "const") {
-                currentScope = blockStack[blockStack.length - 1].const;
+                currentScope = blockStack.at(-1).const;
             }
             return currentScope;
         }

package/lib/rules/padded-blocks.js

@@ -84,18 +84,18 @@ module.exports = {
             options.switches = shouldHavePadding;
             options.classes = shouldHavePadding;
         } else {
-            if (Object.prototype.hasOwnProperty.call(typeOptions, "blocks")) {
+            if (Object.hasOwn(typeOptions, "blocks")) {
                 options.blocks = typeOptions.blocks === "always";
             }
-            if (Object.prototype.hasOwnProperty.call(typeOptions, "switches")) {
+            if (Object.hasOwn(typeOptions, "switches")) {
                 options.switches = typeOptions.switches === "always";
             }
-            if (Object.prototype.hasOwnProperty.call(typeOptions, "classes")) {
+            if (Object.hasOwn(typeOptions, "classes")) {
                 options.classes = typeOptions.classes === "always";
             }
         }
 
-        if (Object.prototype.hasOwnProperty.call(exceptOptions, "allowSingleLineBlocks")) {
+        if (Object.hasOwn(exceptOptions, "allowSingleLineBlocks")) {
             options.allowSingleLineBlocks = exceptOptions.allowSingleLineBlocks === true;
         }
 
@@ -277,7 +277,7 @@ module.exports = {
 
         const rule = {};
 
-        if (Object.prototype.hasOwnProperty.call(options, "switches")) {
+        if (Object.hasOwn(options, "switches")) {
             rule.SwitchStatement = function(node) {
                 if (node.cases.length === 0) {
                     return;
@@ -286,7 +286,7 @@ module.exports = {
             };
         }
 
-        if (Object.prototype.hasOwnProperty.call(options, "blocks")) {
+        if (Object.hasOwn(options, "blocks")) {
             rule.BlockStatement = function(node) {
                 if (node.body.length === 0) {
                     return;
@@ -296,7 +296,7 @@ module.exports = {
             rule.StaticBlock = rule.BlockStatement;
         }
 
-        if (Object.prototype.hasOwnProperty.call(options, "classes")) {
+        if (Object.hasOwn(options, "classes")) {
             rule.ClassBody = function(node) {
                 if (node.body.length === 0) {
                     return;

package/lib/rules/prefer-arrow-callback.js

@@ -220,7 +220,7 @@ module.exports = {
 
             // If there are below, it cannot replace with arrow functions merely.
             ThisExpression() {
-                const info = stack[stack.length - 1];
+                const info = stack.at(-1);
 
                 if (info) {
                     info.this = true;
@@ -228,7 +228,7 @@ module.exports = {
             },
 
             Super() {
-                const info = stack[stack.length - 1];
+                const info = stack.at(-1);
 
                 if (info) {
                     info.super = true;
@@ -236,7 +236,7 @@ module.exports = {
             },
 
             MetaProperty(node) {
-                const info = stack[stack.length - 1];
+                const info = stack.at(-1);
 
                 if (info && checkMetaProperty(node, "new", "target")) {
                     info.meta = true;

package/lib/rules/prefer-reflect.js

@@ -105,7 +105,7 @@ module.exports = {
             CallExpression(node) {
                 const methodName = (node.callee.property || {}).name;
                 const isReflectCall = (node.callee.object || {}).name === "Reflect";
-                const hasReflectSubstitute = Object.prototype.hasOwnProperty.call(reflectSubstitutes, methodName);
+                const hasReflectSubstitute = Object.hasOwn(reflectSubstitutes, methodName);
                 const userConfiguredException = exceptions.includes(methodName);
 
                 if (hasReflectSubstitute && !isReflectCall && !userConfiguredException) {

package/lib/rules/prefer-regex-literals.js

@@ -34,7 +34,7 @@ function isStringLiteral(node) {
  * @returns {boolean} True if the node is a regex literal.
  */
 function isRegexLiteral(node) {
-    return node.type === "Literal" && Object.prototype.hasOwnProperty.call(node, "regex");
+    return node.type === "Literal" && Object.hasOwn(node, "regex");
 }
 
 const validPrecedingTokens = new Set([

package/lib/rules/prefer-template.js

@@ -113,7 +113,7 @@ function endsWithTemplateCurly(node) {
         return startsWithTemplateCurly(node.right);
     }
     if (node.type === "TemplateLiteral") {
-        return node.expressions.length && node.quasis.length && node.quasis[node.quasis.length - 1].range[0] === node.quasis[node.quasis.length - 1].range[1];
+        return node.expressions.length && node.quasis.length && node.quasis.at(-1).range[0] === node.quasis.at(-1).range[1];
     }
     return node.type !== "Literal" || typeof node.value !== "string";
 }

package/lib/rules/radix.js

@@ -133,8 +133,8 @@ module.exports = {
                                     messageId: "addRadixParameter10",
                                     fix(fixer) {
                                         const tokens = sourceCode.getTokens(node);
-                                        const lastToken = tokens[tokens.length - 1]; // Parenthesis.
-                                        const secondToLastToken = tokens[tokens.length - 2]; // May or may not be a comma.
+                                        const lastToken = tokens.at(-1); // Parenthesis.
+                                        const secondToLastToken = tokens.at(-2); // May or may not be a comma.
                                         const hasTrailingComma = secondToLastToken.type === "Punctuator" && secondToLastToken.value === ",";
 
                                         return fixer.insertTextBefore(lastToken, hasTrailingComma ? " 10," : ", 10");

package/lib/rules/semi-style.js

@@ -65,7 +65,7 @@ function isLastChild(node) {
     }
     const nodeList = getChildren(node.parent);
 
-    return nodeList !== null && nodeList[nodeList.length - 1] === node; // before `}` or etc.
+    return nodeList !== null && nodeList.at(-1) === node; // before `}` or etc.
 }
 
 /** @type {import('../shared/types').Rule} */

package/lib/rules/sort-imports.js

@@ -208,7 +208,7 @@ module.exports = {
                                 }
 
                                 return fixer.replaceTextRange(
-                                    [importSpecifiers[0].range[0], importSpecifiers[importSpecifiers.length - 1].range[1]],
+                                    [importSpecifiers[0].range[0], importSpecifiers.at(-1).range[1]],
                                     importSpecifiers
 
                                         // Clone the importSpecifiers array to avoid mutating it

package/lib/rules/sort-keys.js

@@ -185,7 +185,7 @@ module.exports = {
                     });
 
                     // check blank line between the current node and the last token
-                    if (!isBlankLineBetweenNodes && (node.loc.start.line - tokens[tokens.length - 1].loc.end.line > 1)) {
+                    if (!isBlankLineBetweenNodes && (node.loc.start.line - tokens.at(-1).loc.end.line > 1)) {
                         isBlankLineBetweenNodes = true;
                     }
 

package/lib/rules/sort-vars.js

@@ -66,7 +66,7 @@ module.exports = {
                                     return null;
                                 }
                                 return fixer.replaceTextRange(
-                                    [idDeclarations[0].range[0], idDeclarations[idDeclarations.length - 1].range[1]],
+                                    [idDeclarations[0].range[0], idDeclarations.at(-1).range[1]],
                                     idDeclarations
 
                                         // Clone the idDeclarations array to avoid mutating it

package/lib/rules/space-unary-ops.js

@@ -87,7 +87,7 @@ module.exports = {
          * @returns {boolean} Whether or not an override has been provided for the operator
          */
         function overrideExistsForOperator(operator) {
-            return options.overrides && Object.prototype.hasOwnProperty.call(options.overrides, operator);
+            return options.overrides && Object.hasOwn(options.overrides, operator);
         }
 
         /**

package/lib/rules/strict.js

@@ -173,7 +173,7 @@ module.exports = {
         function enterFunctionInFunctionMode(node, useStrictDirectives) {
             const isInClass = classScopes.length > 0,
                 isParentGlobal = scopes.length === 0 && classScopes.length === 0,
-                isParentStrict = scopes.length > 0 && scopes[scopes.length - 1],
+                isParentStrict = scopes.length > 0 && scopes.at(-1),
                 isStrict = useStrictDirectives.length > 0;
 
             if (isStrict) {

package/lib/rules/utils/ast-utils.js

@@ -969,7 +969,7 @@ function isConstant(scope, node, inBooleanPosition) {
             return false;
 
         case "SequenceExpression":
-            return isConstant(scope, node.expressions[node.expressions.length - 1], inBooleanPosition);
+            return isConstant(scope, node.expressions.at(-1), inBooleanPosition);
         case "SpreadElement":
             return isConstant(scope, node.argument, inBooleanPosition);
         case "CallExpression":
@@ -1231,7 +1231,7 @@ module.exports = {
      * @private
      */
     isSurroundedBy(val, character) {
-        return val[0] === character && val[val.length - 1] === character;
+        return val[0] === character && val.at(-1) === character;
     },
 
     /**
@@ -1909,8 +1909,8 @@ module.exports = {
      */
     getFunctionHeadLoc(node, sourceCode) {
         const parent = node.parent;
-        let start = null;
-        let end = null;
+        let start;
+        let end;
 
         if (parent.type === "Property" || parent.type === "MethodDefinition" || parent.type === "PropertyDefinition") {
             start = parent.loc.start;
@@ -2055,7 +2055,7 @@ module.exports = {
             case "SequenceExpression": {
                 const exprs = node.expressions;
 
-                return exprs.length !== 0 && module.exports.couldBeError(exprs[exprs.length - 1]);
+                return exprs.length !== 0 && module.exports.couldBeError(exprs.at(-1));
             }
 
             case "LogicalExpression":
@@ -2119,9 +2119,9 @@ module.exports = {
 
             const comments = tokens.comments;
 
-            leftToken = tokens[tokens.length - 1];
+            leftToken = tokens.at(-1);
             if (comments.length) {
-                const lastComment = comments[comments.length - 1];
+                const lastComment = comments.at(-1);
 
                 if (!leftToken || lastComment.range[0] > leftToken.range[0]) {
                     leftToken = lastComment;

package/lib/rules/yield-star-spacing.js

@@ -79,7 +79,7 @@ module.exports = {
                 const after = leftToken.value === "*";
                 const spaceRequired = mode[side];
                 const node = after ? leftToken : rightToken;
-                let messageId = "";
+                let messageId;
 
                 if (spaceRequired) {
                     messageId = side === "before" ? "missingBefore" : "missingAfter";

package/lib/shared/types.js

@@ -168,7 +168,7 @@ module.exports = {};
  * @property {Record<string, ConfigData>} [configs] The definition of plugin configs.
  * @property {Record<string, Environment>} [environments] The definition of plugin environments.
  * @property {Record<string, Processor>} [processors] The definition of plugin processors.
- * @property {Record<string, Function | Rule>} [rules] The definition of plugin rules.
+ * @property {Record<string, Rule>} [rules] The definition of plugin rules.
  */
 
 /**

package/lib/source-code/source-code.js

@@ -415,13 +415,10 @@ class SourceCode extends TokenStore {
          * and uses match.index to get the correct line start indices.
          */
         while ((match = lineEndingPattern.exec(this.text))) {
-            this.lines.push(this.text.slice(this.lineStartIndices[this.lineStartIndices.length - 1], match.index));
+            this.lines.push(this.text.slice(this.lineStartIndices.at(-1), match.index));
             this.lineStartIndices.push(match.index + match[0].length);
         }
-        this.lines.push(this.text.slice(this.lineStartIndices[this.lineStartIndices.length - 1]));
-
-        // Cache for comments found using getComments().
-        this._commentCache = new WeakMap();
+        this.lines.push(this.text.slice(this.lineStartIndices.at(-1)));
 
         // don't allow further modification of this object
         Object.freeze(this);
@@ -472,81 +469,6 @@ class SourceCode extends TokenStore {
         return this.ast.comments;
     }
 
-    /**
-     * Gets all comments for the given node.
-     * @param {ASTNode} node The AST node to get the comments for.
-     * @returns {Object} An object containing a leading and trailing array
-     *      of comments indexed by their position.
-     * @public
-     * @deprecated replaced by getCommentsBefore(), getCommentsAfter(), and getCommentsInside().
-     */
-    getComments(node) {
-        if (this._commentCache.has(node)) {
-            return this._commentCache.get(node);
-        }
-
-        const comments = {
-            leading: [],
-            trailing: []
-        };
-
-        /*
-         * Return all comments as leading comments of the Program node when
-         * there is no executable code.
-         */
-        if (node.type === "Program") {
-            if (node.body.length === 0) {
-                comments.leading = node.comments;
-            }
-        } else {
-
-            /*
-             * Return comments as trailing comments of nodes that only contain
-             * comments (to mimic the comment attachment behavior present in Espree).
-             */
-            if ((node.type === "BlockStatement" || node.type === "ClassBody") && node.body.length === 0 ||
-                node.type === "ObjectExpression" && node.properties.length === 0 ||
-                node.type === "ArrayExpression" && node.elements.length === 0 ||
-                node.type === "SwitchStatement" && node.cases.length === 0
-            ) {
-                comments.trailing = this.getTokens(node, {
-                    includeComments: true,
-                    filter: isCommentToken
-                });
-            }
-
-            /*
-             * Iterate over tokens before and after node and collect comment tokens.
-             * Do not include comments that exist outside of the parent node
-             * to avoid duplication.
-             */
-            let currentToken = this.getTokenBefore(node, { includeComments: true });
-
-            while (currentToken && isCommentToken(currentToken)) {
-                if (node.parent && node.parent.type !== "Program" && (currentToken.start < node.parent.start)) {
-                    break;
-                }
-                comments.leading.push(currentToken);
-                currentToken = this.getTokenBefore(currentToken, { includeComments: true });
-            }
-
-            comments.leading.reverse();
-
-            currentToken = this.getTokenAfter(node, { includeComments: true });
-
-            while (currentToken && isCommentToken(currentToken)) {
-                if (node.parent && node.parent.type !== "Program" && (currentToken.end > node.parent.end)) {
-                    break;
-                }
-                comments.trailing.push(currentToken);
-                currentToken = this.getTokenAfter(currentToken, { includeComments: true });
-            }
-        }
-
-        this._commentCache.set(node, comments);
-        return comments;
-    }
-
     /**
      * Retrieves the JSDoc comment for a given node.
      * @param {ASTNode} node The AST node to get the comment for.
@@ -701,14 +623,14 @@ class SourceCode extends TokenStore {
          * See getIndexFromLoc for the motivation for this special case.
          */
         if (index === this.text.length) {
-            return { line: this.lines.length, column: this.lines[this.lines.length - 1].length };
+            return { line: this.lines.length, column: this.lines.at(-1).length };
         }
 
         /*
          * To figure out which line index is on, determine the last place at which index could
          * be inserted into lineStartIndices to keep the list sorted.
          */
-        const lineNumber = index >= this.lineStartIndices[this.lineStartIndices.length - 1]
+        const lineNumber = index >= this.lineStartIndices.at(-1)
             ? this.lineStartIndices.length
             : this.lineStartIndices.findIndex(el => index < el);
 
@@ -963,7 +885,7 @@ class SourceCode extends TokenStore {
 
             switch (directiveText) {
                 case "exported":
-                    Object.assign(exportedVariables, commentParser.parseStringConfig(directiveValue, comment));
+                    Object.assign(exportedVariables, commentParser.parseListConfig(directiveValue, comment));
                     break;
 
                 case "globals":

package/lib/source-code/token-store/index.js

@@ -37,8 +37,8 @@ function createIndexMap(tokens, comments) {
     const map = Object.create(null);
     let tokenIndex = 0;
     let commentIndex = 0;
-    let nextStart = 0;
-    let range = null;
+    let nextStart;
+    let range;
 
     while (tokenIndex < tokens.length || commentIndex < comments.length) {
         nextStart = (commentIndex < comments.length) ? comments[commentIndex].range[0] : Number.MAX_SAFE_INTEGER;

package/lib/unsupported-api.js

@@ -12,9 +12,8 @@
 //-----------------------------------------------------------------------------
 
 const { FileEnumerator } = require("./cli-engine/file-enumerator");
-const { FlatESLint, shouldUseFlatConfig } = require("./eslint/flat-eslint");
-const FlatRuleTester = require("./rule-tester/flat-rule-tester");
-const { ESLint } = require("./eslint/eslint");
+const { ESLint: FlatESLint, shouldUseFlatConfig } = require("./eslint/eslint");
+const { LegacyESLint } = require("./eslint/legacy-eslint");
 
 //-----------------------------------------------------------------------------
 // Exports
@@ -24,7 +23,6 @@ module.exports = {
     builtinRules: require("./rules"),
     FlatESLint,
     shouldUseFlatConfig,
-    FlatRuleTester,
     FileEnumerator,
-    LegacyESLint: ESLint
+    LegacyESLint
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "8.56.0",
+  "version": "9.0.0-alpha.1",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "bin": {
@@ -17,6 +17,7 @@
     "build:site": "node Makefile.js gensite",
     "build:webpack": "node Makefile.js webpack",
     "build:readme": "node tools/update-readme.js",
+    "build:rules-index": "node Makefile.js generateRuleIndexPage",
     "lint": "node Makefile.js lint",
     "lint:docs:js": "node Makefile.js lintDocsJS",
     "lint:docs:rule-examples": "node Makefile.js checkRuleExamples",
@@ -64,19 +65,17 @@
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.2.0",
     "@eslint-community/regexpp": "^4.6.1",
-    "@eslint/eslintrc": "^2.1.4",
-    "@eslint/js": "8.56.0",
-    "@humanwhocodes/config-array": "^0.11.13",
+    "@eslint/eslintrc": "^3.0.0",
+    "@eslint/js": "9.0.0-alpha.0",
+    "@humanwhocodes/config-array": "^0.11.14",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@nodelib/fs.walk": "^1.2.8",
-    "@ungap/structured-clone": "^1.2.0",
     "ajv": "^6.12.4",
     "chalk": "^4.0.0",
     "cross-spawn": "^7.0.2",
     "debug": "^4.3.2",
-    "doctrine": "^3.0.0",
     "escape-string-regexp": "^4.0.0",
-    "eslint-scope": "^7.2.2",
+    "eslint-scope": "^8.0.0",
     "eslint-visitor-keys": "^3.4.3",
     "espree": "^9.6.1",
     "esquery": "^1.4.2",
@@ -91,7 +90,6 @@
     "imurmurhash": "^0.1.4",
     "is-glob": "^4.0.0",
     "is-path-inside": "^3.0.3",
-    "js-yaml": "^4.1.0",
     "json-stable-stringify-without-jsonify": "^1.0.1",
     "levn": "^0.4.1",
     "lodash.merge": "^4.6.2",
@@ -121,23 +119,24 @@
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-eslint-plugin": "^5.2.1",
     "eslint-plugin-internal-rules": "file:tools/internal-rules",
-    "eslint-plugin-jsdoc": "^46.2.5",
-    "eslint-plugin-n": "^16.4.0",
+    "eslint-plugin-jsdoc": "^46.9.0",
+    "eslint-plugin-n": "^16.6.0",
     "eslint-plugin-unicorn": "^49.0.0",
     "eslint-release": "^3.2.0",
     "eslump": "^3.0.0",
     "esprima": "^4.0.1",
     "fast-glob": "^3.2.11",
     "fs-teardown": "^0.1.3",
-    "glob": "^7.1.6",
+    "glob": "^10.0.0",
     "got": "^11.8.3",
     "gray-matter": "^4.0.3",
+    "js-yaml": "^4.1.0",
     "lint-staged": "^11.0.0",
     "load-perf": "^0.2.0",
     "markdown-it": "^12.2.0",
     "markdown-it-container": "^3.0.0",
     "markdownlint": "^0.32.0",
-    "markdownlint-cli": "^0.37.0",
+    "markdownlint-cli": "^0.38.0",
     "marked": "^4.0.8",
     "memfs": "^3.0.1",
     "metascraper": "^5.25.7",
@@ -147,7 +146,6 @@
     "metascraper-logo-favicon": "^5.25.7",
     "metascraper-title": "^5.25.7",
     "mocha": "^8.3.2",
-    "mocha-junit-reporter": "^2.0.0",
     "node-polyfill-webpack-plugin": "^1.0.3",
     "npm-license": "^0.3.3",
     "pirates": "^4.0.5",
@@ -174,6 +172,6 @@
   ],
   "license": "MIT",
   "engines": {
-    "node": "^12.22.0 || ^14.17.0 || >=16.0.0"
+    "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
   }
 }

package/conf/config-schema.js

@@ -1,93 +0,0 @@
-/*
- * STOP!!! DO NOT MODIFY.
- *
- * This file is part of the ongoing work to move the eslintrc-style config
- * system into the @eslint/eslintrc package. This file needs to remain
- * unchanged in order for this work to proceed.
- *
- * If you think you need to change this file, please contact @nzakas first.
- *
- * Thanks in advance for your cooperation.
- */
-
-/**
- * @fileoverview Defines a schema for configs.
- * @author Sylvan Mably
- */
-
-"use strict";
-
-const baseConfigProperties = {
-    $schema: { type: "string" },
-    env: { type: "object" },
-    extends: { $ref: "#/definitions/stringOrStrings" },
-    globals: { type: "object" },
-    overrides: {
-        type: "array",
-        items: { $ref: "#/definitions/overrideConfig" },
-        additionalItems: false
-    },
-    parser: { type: ["string", "null"] },
-    parserOptions: { type: "object" },
-    plugins: { type: "array" },
-    processor: { type: "string" },
-    rules: { type: "object" },
-    settings: { type: "object" },
-    noInlineConfig: { type: "boolean" },
-    reportUnusedDisableDirectives: { type: "boolean" },
-
-    ecmaFeatures: { type: "object" } // deprecated; logs a warning when used
-};
-
-const configSchema = {
-    definitions: {
-        stringOrStrings: {
-            oneOf: [
-                { type: "string" },
-                {
-                    type: "array",
-                    items: { type: "string" },
-                    additionalItems: false
-                }
-            ]
-        },
-        stringOrStringsRequired: {
-            oneOf: [
-                { type: "string" },
-                {
-                    type: "array",
-                    items: { type: "string" },
-                    additionalItems: false,
-                    minItems: 1
-                }
-            ]
-        },
-
-        // Config at top-level.
-        objectConfig: {
-            type: "object",
-            properties: {
-                root: { type: "boolean" },
-                ignorePatterns: { $ref: "#/definitions/stringOrStrings" },
-                ...baseConfigProperties
-            },
-            additionalProperties: false
-        },
-
-        // Config in `overrides`.
-        overrideConfig: {
-            type: "object",
-            properties: {
-                excludedFiles: { $ref: "#/definitions/stringOrStrings" },
-                files: { $ref: "#/definitions/stringOrStringsRequired" },
-                ...baseConfigProperties
-            },
-            required: ["files"],
-            additionalProperties: false
-        }
-    },
-
-    $ref: "#/definitions/objectConfig"
-};
-
-module.exports = configSchema;