eslint 8.43.0 → 8.45.0

package/README.md

@@ -117,7 +117,7 @@ Yes, ESLint natively supports parsing JSX syntax (this must be enabled in [confi
 
 ### What ECMAScript versions does ESLint support?
 
-ESLint has full support for ECMAScript 3, 5 (default), 2015, 2016, 2017, 2018, 2019, 2020, 2021 and 2022. You can set your desired ECMAScript syntax (and other settings, like global variables or your target environments) through [configuration](https://eslint.org/docs/latest/use/configure).
+ESLint has full support for ECMAScript 3, 5 (default), 2015, 2016, 2017, 2018, 2019, 2020, 2021, 2022, and 2023. You can set your desired ECMAScript syntax (and other settings, like global variables or your target environments) through [configuration](https://eslint.org/docs/latest/use/configure).
 
 ### What about experimental features?
 
@@ -284,7 +284,7 @@ The following companies, organizations, and individuals support ESLint's ongoing
 <p><a href="#"><img src="https://images.opencollective.com/2021-frameworks-fund/logo.png" alt="Chrome Frameworks Fund" height="undefined"></a> <a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://sentry.io"><img src="https://avatars.githubusercontent.com/u/1396951?v=4" alt="Sentry" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://themeisle.com"><img src="https://images.opencollective.com/themeisle/d5592fe/logo.png" alt="ThemeIsle" height="32"></a> <a href="https://nx.dev"><img src="https://images.opencollective.com/nx/0efbe42/logo.png" alt="Nx (by Nrwl)" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8: free icons, photos, illustrations, and music" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://transloadit.com/"><img src="https://avatars.githubusercontent.com/u/125754?v=4" alt="Transloadit" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://quickbookstoolhub.com"><img src="https://avatars.githubusercontent.com/u/95090305?u=e5bc398ef775c9ed19f955c675cdc1fb6abf01df&v=4" alt="QuickBooks Tool hub" height="32"></a></p>
+<p><a href="https://iboysoft.com/"><img src="https://images.opencollective.com/iboysoft-software/7f9d60e/avatar.png" alt="iBoysoft" height="32"></a> <a href="https://themeisle.com"><img src="https://images.opencollective.com/themeisle/d5592fe/logo.png" alt="ThemeIsle" height="32"></a> <a href="https://nx.dev"><img src="https://images.opencollective.com/nx/0efbe42/logo.png" alt="Nx (by Nrwl)" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8: free icons, photos, illustrations, and music" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://transloadit.com/"><img src="https://avatars.githubusercontent.com/u/125754?v=4" alt="Transloadit" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465?v=4" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://quickbookstoolhub.com"><img src="https://avatars.githubusercontent.com/u/95090305?u=e5bc398ef775c9ed19f955c675cdc1fb6abf01df&v=4" alt="QuickBooks Tool hub" height="32"></a></p>
 <!--sponsorsend-->
 
 ## Technology Sponsors

package/conf/globals.js

@@ -128,6 +128,10 @@ const es2023 = {
     ...es2022
 };
 
+const es2024 = {
+    ...es2023
+};
+
 
 //-----------------------------------------------------------------------------
 // Exports
@@ -145,5 +149,6 @@ module.exports = {
     es2020,
     es2021,
     es2022,
-    es2023
+    es2023,
+    es2024
 };

package/lib/cli-engine/cli-engine.js

@@ -158,7 +158,17 @@ function validateFixTypes(fixTypes) {
  * @private
  */
 function calculateStatsPerFile(messages) {
-    return messages.reduce((stat, message) => {
+    const stat = {
+        errorCount: 0,
+        fatalErrorCount: 0,
+        warningCount: 0,
+        fixableErrorCount: 0,
+        fixableWarningCount: 0
+    };
+
+    for (let i = 0; i < messages.length; i++) {
+        const message = messages[i];
+
         if (message.fatal || message.severity === 2) {
             stat.errorCount++;
             if (message.fatal) {
@@ -173,14 +183,8 @@ function calculateStatsPerFile(messages) {
                 stat.fixableWarningCount++;
             }
         }
-        return stat;
-    }, {
-        errorCount: 0,
-        fatalErrorCount: 0,
-        warningCount: 0,
-        fixableErrorCount: 0,
-        fixableWarningCount: 0
-    });
+    }
+    return stat;
 }
 
 /**
@@ -190,20 +194,25 @@ function calculateStatsPerFile(messages) {
  * @private
  */
 function calculateStatsPerRun(results) {
-    return results.reduce((stat, result) => {
-        stat.errorCount += result.errorCount;
-        stat.fatalErrorCount += result.fatalErrorCount;
-        stat.warningCount += result.warningCount;
-        stat.fixableErrorCount += result.fixableErrorCount;
-        stat.fixableWarningCount += result.fixableWarningCount;
-        return stat;
-    }, {
+    const stat = {
         errorCount: 0,
         fatalErrorCount: 0,
         warningCount: 0,
         fixableErrorCount: 0,
         fixableWarningCount: 0
-    });
+    };
+
+    for (let i = 0; i < results.length; i++) {
+        const result = results[i];
+
+        stat.errorCount += result.errorCount;
+        stat.fatalErrorCount += result.fatalErrorCount;
+        stat.warningCount += result.warningCount;
+        stat.fixableErrorCount += result.fixableErrorCount;
+        stat.fixableWarningCount += result.fixableWarningCount;
+    }
+
+    return stat;
 }
 
 /**

package/lib/eslint/flat-eslint.js

@@ -103,7 +103,17 @@ const importedConfigFileModificationTime = new Map();
  * @private
  */
 function calculateStatsPerFile(messages) {
-    return messages.reduce((stat, message) => {
+    const stat = {
+        errorCount: 0,
+        fatalErrorCount: 0,
+        warningCount: 0,
+        fixableErrorCount: 0,
+        fixableWarningCount: 0
+    };
+
+    for (let i = 0; i < messages.length; i++) {
+        const message = messages[i];
+
         if (message.fatal || message.severity === 2) {
             stat.errorCount++;
             if (message.fatal) {
@@ -118,37 +128,8 @@ function calculateStatsPerFile(messages) {
                 stat.fixableWarningCount++;
             }
         }
-        return stat;
-    }, {
-        errorCount: 0,
-        fatalErrorCount: 0,
-        warningCount: 0,
-        fixableErrorCount: 0,
-        fixableWarningCount: 0
-    });
-}
-
-/**
- * It will calculate the error and warning count for collection of results from all files
- * @param {LintResult[]} results Collection of messages from all the files
- * @returns {Object} Contains the stats
- * @private
- */
-function calculateStatsPerRun(results) {
-    return results.reduce((stat, result) => {
-        stat.errorCount += result.errorCount;
-        stat.fatalErrorCount += result.fatalErrorCount;
-        stat.warningCount += result.warningCount;
-        stat.fixableErrorCount += result.fixableErrorCount;
-        stat.fixableWarningCount += result.fixableWarningCount;
-        return stat;
-    }, {
-        errorCount: 0,
-        fatalErrorCount: 0,
-        warningCount: 0,
-        fixableErrorCount: 0,
-        fixableWarningCount: 0
-    });
+    }
+    return stat;
 }
 
 /**
@@ -550,43 +531,6 @@ function shouldMessageBeFixed(message, config, fixTypes) {
     return Boolean(rule && rule.meta && fixTypes.has(rule.meta.type));
 }
 
-/**
- * Collect used deprecated rules.
- * @param {Array<FlatConfig>} configs The configs to evaluate.
- * @returns {IterableIterator<DeprecatedRuleInfo>} Used deprecated rules.
- */
-function *iterateRuleDeprecationWarnings(configs) {
-    const processedRuleIds = new Set();
-
-    for (const config of configs) {
-        for (const [ruleId, ruleConfig] of Object.entries(config.rules)) {
-
-            // Skip if it was processed.
-            if (processedRuleIds.has(ruleId)) {
-                continue;
-            }
-            processedRuleIds.add(ruleId);
-
-            // Skip if it's not used.
-            if (!getRuleSeverity(ruleConfig)) {
-                continue;
-            }
-            const rule = getRuleFromConfig(ruleId, config);
-
-            // Skip if it's not deprecated.
-            if (!(rule && rule.meta && rule.meta.deprecated)) {
-                continue;
-            }
-
-            // This rule was used and deprecated.
-            yield {
-                ruleId,
-                replacedBy: rule.meta.replacedBy || []
-            };
-        }
-    }
-}
-
 /**
  * Creates an error to be thrown when an array of results passed to `getRulesMetaForResults` was not created by the current engine.
  * @returns {TypeError} An error object.
@@ -632,7 +576,6 @@ class FlatESLint {
             cacheFilePath,
             lintResultCache,
             defaultConfigs,
-            defaultIgnores: () => false,
             configs: null
         });
 
@@ -811,7 +754,6 @@ class FlatESLint {
             errorOnUnmatchedPattern
         } = eslintOptions;
         const startTime = Date.now();
-        const usedConfigs = [];
         const fixTypesSet = fixTypes ? new Set(fixTypes) : null;
 
         // Delete cache file; should this be done here?
@@ -869,15 +811,6 @@ class FlatESLint {
                     return void 0;
                 }
 
-                /*
-                 * Store used configs for:
-                 * - this method uses to collect used deprecated rules.
-                 * - `--fix-type` option uses to get the loaded rule's meta data.
-                 */
-                if (!usedConfigs.includes(config)) {
-                    usedConfigs.push(config);
-                }
-
                 // Skip if there is cached result.
                 if (lintResultCache) {
                     const cachedResult =
@@ -946,22 +879,10 @@ class FlatESLint {
             lintResultCache.reconcile();
         }
 
-        let usedDeprecatedRules;
         const finalResults = results.filter(result => !!result);
 
         return processLintReport(this, {
-            results: finalResults,
-            ...calculateStatsPerRun(finalResults),
-
-            // Initialize it lazily because CLI and `ESLint` API don't use it.
-            get usedDeprecatedRules() {
-                if (!usedDeprecatedRules) {
-                    usedDeprecatedRules = Array.from(
-                        iterateRuleDeprecationWarnings(usedConfigs)
-                    );
-                }
-                return usedDeprecatedRules;
-            }
+            results: finalResults
         });
     }
 
@@ -1023,7 +944,6 @@ class FlatESLint {
         const results = [];
         const startTime = Date.now();
         const resolvedFilename = path.resolve(cwd, filePath || "__placeholder__.js");
-        let config;
 
         // Clear the last used config arrays.
         if (resolvedFilename && await this.isPathIgnored(resolvedFilename)) {
@@ -1032,9 +952,6 @@ class FlatESLint {
             }
         } else {
 
-            // TODO: Needed?
-            config = configs.getConfig(resolvedFilename);
-
             // Do lint.
             results.push(verifyText({
                 text: code,
@@ -1049,21 +966,9 @@ class FlatESLint {
         }
 
         debug(`Linting complete in: ${Date.now() - startTime}ms`);
-        let usedDeprecatedRules;
 
         return processLintReport(this, {
-            results,
-            ...calculateStatsPerRun(results),
-
-            // Initialize it lazily because CLI and `ESLint` API don't use it.
-            get usedDeprecatedRules() {
-                if (!usedDeprecatedRules) {
-                    usedDeprecatedRules = Array.from(
-                        iterateRuleDeprecationWarnings(config)
-                    );
-                }
-                return usedDeprecatedRules;
-            }
+            results
         });
 
     }

package/lib/linter/report-translator.js

@@ -100,6 +100,22 @@ function normalizeReportLoc(descriptor) {
     return descriptor.node.loc;
 }
 
+/**
+ * Clones the given fix object.
+ * @param {Fix|null} fix The fix to clone.
+ * @returns {Fix|null} Deep cloned fix object or `null` if `null` or `undefined` was passed in.
+ */
+function cloneFix(fix) {
+    if (!fix) {
+        return null;
+    }
+
+    return {
+        range: [fix.range[0], fix.range[1]],
+        text: fix.text
+    };
+}
+
 /**
  * Check that a fix has a valid range.
  * @param {Fix|null} fix The fix to validate.
@@ -137,7 +153,7 @@ function mergeFixes(fixes, sourceCode) {
         return null;
     }
     if (fixes.length === 1) {
-        return fixes[0];
+        return cloneFix(fixes[0]);
     }
 
     fixes.sort(compareFixesByRange);
@@ -183,7 +199,7 @@ function normalizeFixes(descriptor, sourceCode) {
     }
 
     assertValidFix(fix);
-    return fix;
+    return cloneFix(fix);
 }
 
 /**

package/lib/rule-tester/flat-rule-tester.js

@@ -33,7 +33,7 @@ const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
 /** @typedef {import("../shared/types").Parser} Parser */
 /** @typedef {import("../shared/types").LanguageOptions} LanguageOptions */
 
-/* eslint-disable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
+
 /**
  * A test case that is expected to pass lint.
  * @typedef {Object} ValidTestCase
@@ -72,7 +72,6 @@ const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
  * @property {number} [endLine] The 1-based line number of the reported end location.
  * @property {number} [endColumn] The 1-based column number of the reported end location.
  */
-/* eslint-enable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
 
 //------------------------------------------------------------------------------
 // Private Members

package/lib/rule-tester/rule-tester.js

@@ -63,7 +63,7 @@ const { SourceCode } = require("../source-code");
 
 /** @typedef {import("../shared/types").Parser} Parser */
 
-/* eslint-disable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
+
 /**
  * A test case that is expected to pass lint.
  * @typedef {Object} ValidTestCase
@@ -108,7 +108,6 @@ const { SourceCode } = require("../source-code");
  * @property {number} [endLine] The 1-based line number of the reported end location.
  * @property {number} [endColumn] The 1-based column number of the reported end location.
  */
-/* eslint-enable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
 
 //------------------------------------------------------------------------------
 // Private Members

package/lib/rules/accessor-pairs.js

@@ -223,43 +223,6 @@ module.exports = {
             }
         }
 
-        /**
-         * Creates a new `AccessorData` object for the given getter or setter node.
-         * @param {ASTNode} node A getter or setter node.
-         * @returns {AccessorData} New `AccessorData` object that contains the given node.
-         * @private
-         */
-        function createAccessorData(node) {
-            const name = astUtils.getStaticPropertyName(node);
-            const key = (name !== null) ? name : sourceCode.getTokens(node.key);
-
-            return {
-                key,
-                getters: node.kind === "get" ? [node] : [],
-                setters: node.kind === "set" ? [node] : []
-            };
-        }
-
-        /**
-         * Merges the given `AccessorData` object into the given accessors list.
-         * @param {AccessorData[]} accessors The list to merge into.
-         * @param {AccessorData} accessorData The object to merge.
-         * @returns {AccessorData[]} The same instance with the merged object.
-         * @private
-         */
-        function mergeAccessorData(accessors, accessorData) {
-            const equalKeyElement = accessors.find(a => areEqualKeys(a.key, accessorData.key));
-
-            if (equalKeyElement) {
-                equalKeyElement.getters.push(...accessorData.getters);
-                equalKeyElement.setters.push(...accessorData.setters);
-            } else {
-                accessors.push(accessorData);
-            }
-
-            return accessors;
-        }
-
         /**
          * Checks accessor pairs in the given list of nodes.
          * @param {ASTNode[]} nodes The list to check.
@@ -267,10 +230,39 @@ module.exports = {
          * @private
          */
         function checkList(nodes) {
-            const accessors = nodes
-                .filter(isAccessorKind)
-                .map(createAccessorData)
-                .reduce(mergeAccessorData, []);
+            const accessors = [];
+            let found = false;
+
+            for (let i = 0; i < nodes.length; i++) {
+                const node = nodes[i];
+
+                if (isAccessorKind(node)) {
+
+                    // Creates a new `AccessorData` object for the given getter or setter node.
+                    const name = astUtils.getStaticPropertyName(node);
+                    const key = (name !== null) ? name : sourceCode.getTokens(node.key);
+
+                    // Merges the given `AccessorData` object into the given accessors list.
+                    for (let j = 0; j < accessors.length; j++) {
+                        const accessor = accessors[j];
+
+                        if (areEqualKeys(accessor.key, key)) {
+                            accessor.getters.push(...node.kind === "get" ? [node] : []);
+                            accessor.setters.push(...node.kind === "set" ? [node] : []);
+                            found = true;
+                            break;
+                        }
+                    }
+                    if (!found) {
+                        accessors.push({
+                            key,
+                            getters: node.kind === "get" ? [node] : [],
+                            setters: node.kind === "set" ? [node] : []
+                        });
+                    }
+                    found = false;
+                }
+            }
 
             for (const { getters, setters } of accessors) {
                 if (checkSetWithoutGet && setters.length && !getters.length) {

package/lib/rules/array-element-newline.js

@@ -240,19 +240,25 @@ module.exports = {
                     .some(element => element.loc.start.line !== element.loc.end.line);
             }
 
-            const linebreaksCount = node.elements.map((element, i) => {
+            let linebreaksCount = 0;
+
+            for (let i = 0; i < node.elements.length; i++) {
+                const element = node.elements[i];
+
                 const previousElement = elements[i - 1];
 
                 if (i === 0 || element === null || previousElement === null) {
-                    return false;
+                    continue;
                 }
 
                 const commaToken = sourceCode.getFirstTokenBetween(previousElement, element, astUtils.isCommaToken);
                 const lastTokenOfPreviousElement = sourceCode.getTokenBefore(commaToken);
                 const firstTokenOfCurrentElement = sourceCode.getTokenAfter(commaToken);
 
-                return !astUtils.isTokenOnSameLine(lastTokenOfPreviousElement, firstTokenOfCurrentElement);
-            }).filter(isBreak => isBreak === true).length;
+                if (!astUtils.isTokenOnSameLine(lastTokenOfPreviousElement, firstTokenOfCurrentElement)) {
+                    linebreaksCount++;
+                }
+            }
 
             const needsLinebreaks = (
                 elements.length >= options.minItems ||

package/lib/rules/dot-notation.js

@@ -133,8 +133,7 @@ module.exports = {
                 }
                 if (
                     node.computed &&
-                    node.property.type === "TemplateLiteral" &&
-                    node.property.expressions.length === 0
+                    astUtils.isStaticTemplateLiteral(node.property)
                 ) {
                     checkComputedProperty(node, node.property.quasis[0].value.cooked);
                 }

package/lib/rules/grouped-accessor-pairs.js

@@ -137,43 +137,6 @@ module.exports = {
             });
         }
 
-        /**
-         * Creates a new `AccessorData` object for the given getter or setter node.
-         * @param {ASTNode} node A getter or setter node.
-         * @returns {AccessorData} New `AccessorData` object that contains the given node.
-         * @private
-         */
-        function createAccessorData(node) {
-            const name = astUtils.getStaticPropertyName(node);
-            const key = (name !== null) ? name : sourceCode.getTokens(node.key);
-
-            return {
-                key,
-                getters: node.kind === "get" ? [node] : [],
-                setters: node.kind === "set" ? [node] : []
-            };
-        }
-
-        /**
-         * Merges the given `AccessorData` object into the given accessors list.
-         * @param {AccessorData[]} accessors The list to merge into.
-         * @param {AccessorData} accessorData The object to merge.
-         * @returns {AccessorData[]} The same instance with the merged object.
-         * @private
-         */
-        function mergeAccessorData(accessors, accessorData) {
-            const equalKeyElement = accessors.find(a => areEqualKeys(a.key, accessorData.key));
-
-            if (equalKeyElement) {
-                equalKeyElement.getters.push(...accessorData.getters);
-                equalKeyElement.setters.push(...accessorData.setters);
-            } else {
-                accessors.push(accessorData);
-            }
-
-            return accessors;
-        }
-
         /**
          * Checks accessor pairs in the given list of nodes.
          * @param {ASTNode[]} nodes The list to check.
@@ -182,11 +145,39 @@ module.exports = {
          * @private
          */
         function checkList(nodes, shouldCheck) {
-            const accessors = nodes
-                .filter(shouldCheck)
-                .filter(isAccessorKind)
-                .map(createAccessorData)
-                .reduce(mergeAccessorData, []);
+            const accessors = [];
+            let found = false;
+
+            for (let i = 0; i < nodes.length; i++) {
+                const node = nodes[i];
+
+                if (shouldCheck(node) && isAccessorKind(node)) {
+
+                    // Creates a new `AccessorData` object for the given getter or setter node.
+                    const name = astUtils.getStaticPropertyName(node);
+                    const key = (name !== null) ? name : sourceCode.getTokens(node.key);
+
+                    // Merges the given `AccessorData` object into the given accessors list.
+                    for (let j = 0; j < accessors.length; j++) {
+                        const accessor = accessors[j];
+
+                        if (areEqualKeys(accessor.key, key)) {
+                            accessor.getters.push(...node.kind === "get" ? [node] : []);
+                            accessor.setters.push(...node.kind === "set" ? [node] : []);
+                            found = true;
+                            break;
+                        }
+                    }
+                    if (!found) {
+                        accessors.push({
+                            key,
+                            getters: node.kind === "get" ? [node] : [],
+                            setters: node.kind === "set" ? [node] : []
+                        });
+                    }
+                    found = false;
+                }
+            }
 
             for (const { getters, setters } of accessors) {