eslint 8.36.0 → 8.37.0

package/lib/config/default-config.js

@@ -19,9 +19,6 @@ exports.defaultConfig = [
     {
         plugins: {
             "@": {
-                parsers: {
-                    espree: require("espree")
-                },
 
                 /*
                  * Because we try to delay loading rules until absolutely
@@ -43,7 +40,7 @@ exports.defaultConfig = [
         languageOptions: {
             sourceType: "module",
             ecmaVersion: "latest",
-            parser: "@/espree",
+            parser: require("espree"),
             parserOptions: {}
         }
     },

package/lib/config/flat-config-array.js

@@ -192,17 +192,7 @@ class FlatConfigArray extends ConfigArray {
         if (languageOptions && languageOptions.parser) {
             const { parser } = languageOptions;
 
-            if (typeof parser === "string") {
-                const { pluginName, objectName: localParserName } = splitPluginIdentifier(parser);
-
-                parserName = parser;
-
-                if (!plugins || !plugins[pluginName] || !plugins[pluginName].parsers || !plugins[pluginName].parsers[localParserName]) {
-                    throw new TypeError(`Key "parser": Could not find "${localParserName}" in plugin "${pluginName}".`);
-                }
-
-                languageOptions.parser = plugins[pluginName].parsers[localParserName];
-            } else if (typeof parser === "object") {
+            if (typeof parser === "object") {
                 parserName = getObjectId(parser);
 
                 if (!parserName) {
@@ -255,7 +245,16 @@ class FlatConfigArray extends ConfigArray {
 
                 return {
                     ...this,
-                    plugins: Object.keys(plugins),
+                    plugins: Object.entries(plugins).map(([namespace, plugin]) => {
+
+                        const pluginId = getObjectId(plugin);
+
+                        if (!pluginId) {
+                            return namespace;
+                        }
+
+                        return `${namespace}:${pluginId}`;
+                    }),
                     languageOptions: {
                         ...languageOptions,
                         parser: parserName

package/lib/config/flat-config-schema.js

@@ -179,18 +179,6 @@ function assertIsObject(value) {
     }
 }
 
-/**
- * Validates that a value is an object or a string.
- * @param {any} value The value to check.
- * @returns {void}
- * @throws {TypeError} If the value isn't an object or a string.
- */
-function assertIsObjectOrString(value) {
-    if ((!value || typeof value !== "object") && typeof value !== "string") {
-        throw new TypeError("Expected an object or string.");
-    }
-}
-
 //-----------------------------------------------------------------------------
 // Low-Level Schemas
 //-----------------------------------------------------------------------------
@@ -242,15 +230,13 @@ const globalsSchema = {
 const parserSchema = {
     merge: "replace",
     validate(value) {
-        assertIsObjectOrString(value);
 
-        if (typeof value === "object" && typeof value.parse !== "function" && typeof value.parseForESLint !== "function") {
-            throw new TypeError("Expected object to have a parse() or parseForESLint() method.");
+        if (!value || typeof value !== "object" ||
+            (typeof value.parse !== "function" && typeof value.parseForESLint !== "function")
+        ) {
+            throw new TypeError("Expected object with parse() or parseForESLint() method.");
         }
 
-        if (typeof value === "string") {
-            assertIsPluginMemberName(value);
-        }
     }
 };
 

package/lib/linter/linter.js

@@ -857,47 +857,22 @@ function parse(text, languageOptions, filePath) {
     }
 }
 
-/**
- * Gets the scope for the current node
- * @param {ScopeManager} scopeManager The scope manager for this AST
- * @param {ASTNode} currentNode The node to get the scope of
- * @returns {eslint-scope.Scope} The scope information for this node
- */
-function getScope(scopeManager, currentNode) {
-
-    // On Program node, get the outermost scope to avoid return Node.js special function scope or ES modules scope.
-    const inner = currentNode.type !== "Program";
-
-    for (let node = currentNode; node; node = node.parent) {
-        const scope = scopeManager.acquire(node, inner);
-
-        if (scope) {
-            if (scope.type === "function-expression-name") {
-                return scope.childScopes[0];
-            }
-            return scope;
-        }
-    }
-
-    return scopeManager.scopes[0];
-}
-
 /**
  * Marks a variable as used in the current scope
- * @param {ScopeManager} scopeManager The scope manager for this AST. The scope may be mutated by this function.
+ * @param {SourceCode} sourceCode The source code for the currently linted file.
  * @param {ASTNode} currentNode The node currently being traversed
  * @param {LanguageOptions} languageOptions The options used to parse this text
  * @param {string} name The name of the variable that should be marked as used.
  * @returns {boolean} True if the variable was found and marked as used, false if not.
  */
-function markVariableAsUsed(scopeManager, currentNode, languageOptions, name) {
+function markVariableAsUsed(sourceCode, currentNode, languageOptions, name) {
     const parserOptions = languageOptions.parserOptions;
     const sourceType = languageOptions.sourceType;
     const hasGlobalReturn =
         (parserOptions.ecmaFeatures && parserOptions.ecmaFeatures.globalReturn) ||
         sourceType === "commonjs";
     const specialScope = hasGlobalReturn || sourceType === "module";
-    const currentScope = getScope(scopeManager, currentNode);
+    const currentScope = sourceCode.getScope(currentNode);
 
     // Special Node.js scope means we need to start one level deeper
     const initialScope = currentScope.type === "global" && specialScope ? currentScope.childScopes[0] : currentScope;
@@ -1026,9 +1001,9 @@ function runRules(sourceCode, configuredRules, ruleMapper, parserName, languageO
                 getCwd: () => cwd,
                 getFilename: () => filename,
                 getPhysicalFilename: () => physicalFilename || filename,
-                getScope: () => getScope(sourceCode.scopeManager, currentNode),
+                getScope: () => sourceCode.getScope(currentNode),
                 getSourceCode: () => sourceCode,
-                markVariableAsUsed: name => markVariableAsUsed(sourceCode.scopeManager, currentNode, languageOptions, name),
+                markVariableAsUsed: name => markVariableAsUsed(sourceCode, currentNode, languageOptions, name),
                 parserOptions: {
                     ...languageOptions.parserOptions
                 },

package/lib/rule-tester/flat-rule-tester.js

@@ -345,7 +345,7 @@ class FlatRuleTester {
      * @returns {void}
      */
     static setDefaultConfig(config) {
-        if (typeof config !== "object") {
+        if (typeof config !== "object" || config === null) {
             throw new TypeError("FlatRuleTester.setDefaultConfig: config must be an object");
         }
         sharedDefaultConfig = config;

package/lib/rule-tester/rule-tester.js

@@ -412,7 +412,7 @@ class RuleTester {
      * @returns {void}
      */
     static setDefaultConfig(config) {
-        if (typeof config !== "object") {
+        if (typeof config !== "object" || config === null) {
             throw new TypeError("RuleTester.setDefaultConfig: config must be an object");
         }
         defaultConfig = config;

package/lib/rules/camelcase.js

@@ -73,6 +73,7 @@ module.exports = {
         const ignoreImports = options.ignoreImports;
         const ignoreGlobals = options.ignoreGlobals;
         const allow = options.allow || [];
+        const sourceCode = context.getSourceCode();
 
         //--------------------------------------------------------------------------
         // Helpers
@@ -245,8 +246,8 @@ module.exports = {
         return {
 
             // Report camelcase of global variable references ------------------
-            Program() {
-                const scope = context.getScope();
+            Program(node) {
+                const scope = sourceCode.getScope(node);
 
                 if (!ignoreGlobals) {
 

package/lib/rules/consistent-this.js

@@ -36,6 +36,7 @@ module.exports = {
 
     create(context) {
         let aliases = [];
+        const sourceCode = context.getSourceCode();
 
         if (context.options.length === 0) {
             aliases.push("that");
@@ -115,10 +116,11 @@ module.exports = {
 
         /**
          * Check each alias to ensure that is was assigned to the correct value.
+         * @param {ASTNode} node The node that represents the scope to check.
          * @returns {void}
          */
-        function ensureWasAssigned() {
-            const scope = context.getScope();
+        function ensureWasAssigned(node) {
+            const scope = sourceCode.getScope(node);
 
             aliases.forEach(alias => {
                 checkWasAssigned(alias, scope);

package/lib/rules/global-require.js

@@ -71,9 +71,11 @@ module.exports = {
     },
 
     create(context) {
+        const sourceCode = context.getSourceCode();
+
         return {
             CallExpression(node) {
-                const currentScope = context.getScope();
+                const currentScope = sourceCode.getScope(node);
 
                 if (node.callee.name === "require" && !isShadowed(currentScope, node.callee)) {
                     const isGoodRequire = context.getAncestors().every(parent => ACCEPTABLE_PARENTS.has(parent.type));

package/lib/rules/handle-callback-err.js

@@ -38,6 +38,7 @@ module.exports = {
     create(context) {
 
         const errorArgument = context.options[0] || "err";
+        const sourceCode = context.getSourceCode();
 
         /**
          * Checks if the given argument should be interpreted as a regexp pattern.
@@ -79,7 +80,7 @@ module.exports = {
          * @returns {void}
          */
         function checkForError(node) {
-            const scope = context.getScope(),
+            const scope = sourceCode.getScope(node),
                 parameters = getParameters(scope),
                 firstParameter = parameters[0];
 

package/lib/rules/id-blacklist.js

@@ -140,6 +140,7 @@ module.exports = {
 
         const denyList = new Set(context.options);
         const reportedNodes = new Set();
+        const sourceCode = context.getSourceCode();
 
         let globalScope;
 
@@ -231,8 +232,8 @@ module.exports = {
 
         return {
 
-            Program() {
-                globalScope = context.getScope();
+            Program(node) {
+                globalScope = sourceCode.getScope(node);
             },
 
             Identifier(node) {

package/lib/rules/id-denylist.js

@@ -121,6 +121,7 @@ module.exports = {
 
         const denyList = new Set(context.options);
         const reportedNodes = new Set();
+        const sourceCode = context.getSourceCode();
 
         let globalScope;
 
@@ -210,8 +211,8 @@ module.exports = {
 
         return {
 
-            Program() {
-                globalScope = context.getScope();
+            Program(node) {
+                globalScope = sourceCode.getScope(node);
             },
 
             [[

package/lib/rules/id-match.js

@@ -67,6 +67,7 @@ module.exports = {
             onlyDeclarations = !!options.onlyDeclarations,
             ignoreDestructuring = !!options.ignoreDestructuring;
 
+        const sourceCode = context.getSourceCode();
         let globalScope;
 
         //--------------------------------------------------------------------------
@@ -170,8 +171,8 @@ module.exports = {
 
         return {
 
-            Program() {
-                globalScope = context.getScope();
+            Program(node) {
+                globalScope = sourceCode.getScope(node);
             },
 
             Identifier(node) {

package/lib/rules/logical-assignment-operators.js

@@ -159,7 +159,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "Require or disallow logical assignment logical operator shorthand",
+            description: "Require or disallow logical assignment operator shorthand",
             recommended: false,
             url: "https://eslint.org/docs/rules/logical-assignment-operators"
         },
@@ -206,7 +206,7 @@ module.exports = {
         const mode = context.options[0] === "never" ? "never" : "always";
         const checkIf = mode === "always" && context.options.length > 1 && context.options[1].enforceForIfStatements;
         const sourceCode = context.getSourceCode();
-        const isStrict = context.getScope().isStrict;
+        const isStrict = sourceCode.getScope(sourceCode.ast).isStrict;
 
         /**
          * Returns false if the access could be a getter
@@ -409,7 +409,7 @@ module.exports = {
                 }
 
                 const body = hasBody ? ifNode.consequent.body[0] : ifNode.consequent;
-                const scope = context.getScope();
+                const scope = sourceCode.getScope(ifNode);
                 const existence = getExistence(ifNode.test, scope);
 
                 if (

package/lib/rules/no-alert.js

@@ -101,10 +101,12 @@ module.exports = {
     },
 
     create(context) {
+        const sourceCode = context.getSourceCode();
+
         return {
             CallExpression(node) {
                 const callee = skipChainExpression(node.callee),
-                    currentScope = context.getScope();
+                    currentScope = sourceCode.getScope(node);
 
                 // without window.
                 if (callee.type === "Identifier") {

package/lib/rules/no-catch-shadow.js

@@ -39,6 +39,8 @@ module.exports = {
 
     create(context) {
 
+        const sourceCode = context.getSourceCode();
+
         //--------------------------------------------------------------------------
         // Helpers
         //--------------------------------------------------------------------------
@@ -60,7 +62,7 @@ module.exports = {
         return {
 
             "CatchClause[param!=null]"(node) {
-                let scope = context.getScope();
+                let scope = sourceCode.getScope(node);
 
                 /*
                  * When ecmaVersion >= 6, CatchClause creates its own scope

package/lib/rules/no-console.js

@@ -51,6 +51,7 @@ module.exports = {
     create(context) {
         const options = context.options[0] || {};
         const allowed = options.allow || [];
+        const sourceCode = context.getSourceCode();
 
         /**
          * Checks whether the given reference is 'console' or not.
@@ -109,8 +110,8 @@ module.exports = {
         }
 
         return {
-            "Program:exit"() {
-                const scope = context.getScope();
+            "Program:exit"(node) {
+                const scope = sourceCode.getScope(node);
                 const consoleVar = astUtils.getVariableByName(scope, "console");
                 const shadowed = consoleVar && consoleVar.defs.length > 0;
 

package/lib/rules/no-constant-binary-expression.js

@@ -453,10 +453,12 @@ module.exports = {
     },
 
     create(context) {
+        const sourceCode = context.getSourceCode();
+
         return {
             LogicalExpression(node) {
                 const { operator, left } = node;
-                const scope = context.getScope();
+                const scope = sourceCode.getScope(node);
 
                 if ((operator === "&&" || operator === "||") && isConstant(scope, left, true)) {
                     context.report({ node: left, messageId: "constantShortCircuit", data: { property: "truthiness", operator } });
@@ -465,7 +467,7 @@ module.exports = {
                 }
             },
             BinaryExpression(node) {
-                const scope = context.getScope();
+                const scope = sourceCode.getScope(node);
                 const { right, left, operator } = node;
                 const rightConstantOperand = findBinaryExpressionConstantOperand(scope, left, right, operator);
                 const leftConstantOperand = findBinaryExpressionConstantOperand(scope, right, left, operator);

package/lib/rules/no-constant-condition.js

@@ -48,6 +48,7 @@ module.exports = {
         const options = context.options[0] || {},
             checkLoops = options.checkLoops !== false,
             loopSetStack = [];
+        const sourceCode = context.getSourceCode();
 
         let loopsInCurrentScope = new Set();
 
@@ -62,7 +63,7 @@ module.exports = {
          * @private
          */
         function trackConstantConditionLoop(node) {
-            if (node.test && isConstant(context.getScope(), node.test, true)) {
+            if (node.test && isConstant(sourceCode.getScope(node), node.test, true)) {
                 loopsInCurrentScope.add(node);
             }
         }
@@ -87,7 +88,7 @@ module.exports = {
          * @private
          */
         function reportIfConstant(node) {
-            if (node.test && isConstant(context.getScope(), node.test, true)) {
+            if (node.test && isConstant(sourceCode.getScope(node), node.test, true)) {
                 context.report({ node: node.test, messageId: "unexpected" });
             }
         }

package/lib/rules/no-else-return.js

@@ -47,6 +47,8 @@ module.exports = {
 
     create(context) {
 
+        const sourceCode = context.getSourceCode();
+
         //--------------------------------------------------------------------------
         // Helpers
         //--------------------------------------------------------------------------
@@ -169,25 +171,24 @@ module.exports = {
 
         /**
          * Display the context report if rule is violated
-         * @param {Node} node The 'else' node
+         * @param {Node} elseNode The 'else' node
          * @returns {void}
          */
-        function displayReport(node) {
-            const currentScope = context.getScope();
+        function displayReport(elseNode) {
+            const currentScope = sourceCode.getScope(elseNode.parent);
 
             context.report({
-                node,
+                node: elseNode,
                 messageId: "unexpected",
                 fix(fixer) {
 
-                    if (!isSafeFromNameCollisions(node, currentScope)) {
+                    if (!isSafeFromNameCollisions(elseNode, currentScope)) {
                         return null;
                     }
 
-                    const sourceCode = context.getSourceCode();
-                    const startToken = sourceCode.getFirstToken(node);
+                    const startToken = sourceCode.getFirstToken(elseNode);
                     const elseToken = sourceCode.getTokenBefore(startToken);
-                    const source = sourceCode.getText(node);
+                    const source = sourceCode.getText(elseNode);
                     const lastIfToken = sourceCode.getTokenBefore(elseToken);
                     let fixedSource, firstTokenOfElseBlock;
 
@@ -203,14 +204,14 @@ module.exports = {
                      * safe to remove the else keyword, because ASI will not add a semicolon
                      * after the if block
                      */
-                    const ifBlockMaybeUnsafe = node.parent.consequent.type !== "BlockStatement" && lastIfToken.value !== ";";
+                    const ifBlockMaybeUnsafe = elseNode.parent.consequent.type !== "BlockStatement" && lastIfToken.value !== ";";
                     const elseBlockUnsafe = /^[([/+`-]/u.test(firstTokenOfElseBlock.value);
 
                     if (ifBlockMaybeUnsafe && elseBlockUnsafe) {
                         return null;
                     }
 
-                    const endToken = sourceCode.getLastToken(node);
+                    const endToken = sourceCode.getLastToken(elseNode);
                     const lastTokenOfElseBlock = sourceCode.getTokenBefore(endToken);
 
                     if (lastTokenOfElseBlock.value !== ";") {
@@ -244,8 +245,8 @@ module.exports = {
                      * Also, to avoid name collisions between two else blocks.
                      */
                     return new FixTracker(fixer, sourceCode)
-                        .retainEnclosingFunction(node)
-                        .replaceTextRange([elseToken.range[0], node.range[1]], fixedSource);
+                        .retainEnclosingFunction(elseNode)
+                        .replaceTextRange([elseToken.range[0], elseNode.range[1]], fixedSource);
                 }
             });
         }

package/lib/rules/no-eval.js

@@ -84,7 +84,7 @@ module.exports = {
          * @returns {void}
          */
         function enterThisScope(node) {
-            const strict = context.getScope().isStrict;
+            const strict = sourceCode.getScope(node).isStrict;
 
             funcInfo = {
                 upper: funcInfo,
@@ -221,7 +221,7 @@ module.exports = {
             },
 
             Program(node) {
-                const scope = context.getScope(),
+                const scope = sourceCode.getScope(node),
                     features = context.parserOptions.ecmaFeatures || {},
                     strict =
                         scope.isStrict ||
@@ -239,8 +239,8 @@ module.exports = {
                 };
             },
 
-            "Program:exit"() {
-                const globalScope = context.getScope();
+            "Program:exit"(node) {
+                const globalScope = sourceCode.getScope(node);
 
                 exitThisScope();
                 reportAccessingEval(globalScope);

package/lib/rules/no-extend-native.js

@@ -51,6 +51,7 @@ module.exports = {
     create(context) {
 
         const config = context.options[0] || {};
+        const sourceCode = context.getSourceCode();
         const exceptions = new Set(config.exceptions || []);
         const modifiedBuiltins = new Set(
             Object.keys(globals.builtin)
@@ -159,8 +160,8 @@ module.exports = {
 
         return {
 
-            "Program:exit"() {
-                const globalScope = context.getScope();
+            "Program:exit"(node) {
+                const globalScope = sourceCode.getScope(node);
 
                 modifiedBuiltins.forEach(builtin => {
                     const builtinVar = globalScope.set.get(builtin);

package/lib/rules/no-global-assign.js

@@ -41,6 +41,7 @@ module.exports = {
 
     create(context) {
         const config = context.options[0];
+        const sourceCode = context.getSourceCode();
         const exceptions = (config && config.exceptions) || [];
 
         /**
@@ -84,8 +85,8 @@ module.exports = {
         }
 
         return {
-            Program() {
-                const globalScope = context.getScope();
+            Program(node) {
+                const globalScope = sourceCode.getScope(node);
 
                 globalScope.variables.forEach(checkVariable);
             }

package/lib/rules/no-implicit-globals.js

@@ -43,6 +43,7 @@ module.exports = {
     create(context) {
 
         const checkLexicalBindings = context.options[0] && context.options[0].lexicalBindings === true;
+        const sourceCode = context.getSourceCode();
 
         /**
          * Reports the node.
@@ -62,8 +63,8 @@ module.exports = {
         }
 
         return {
-            Program() {
-                const scope = context.getScope();
+            Program(node) {
+                const scope = sourceCode.getScope(node);
 
                 scope.variables.forEach(variable => {
 

package/lib/rules/no-implied-eval.js

@@ -37,6 +37,7 @@ module.exports = {
     create(context) {
         const GLOBAL_CANDIDATES = Object.freeze(["global", "window", "globalThis"]);
         const EVAL_LIKE_FUNC_PATTERN = /^(?:set(?:Interval|Timeout)|execScript)$/u;
+        const sourceCode = context.getSourceCode();
 
         /**
          * Checks whether a node is evaluated as a string or not.
@@ -66,7 +67,7 @@ module.exports = {
 
             if (firstArgument) {
 
-                const staticValue = getStaticValue(firstArgument, context.getScope());
+                const staticValue = getStaticValue(firstArgument, sourceCode.getScope(node));
                 const isStaticString = staticValue && typeof staticValue.value === "string";
                 const isString = isStaticString || isEvaluatedString(firstArgument);
 
@@ -117,8 +118,8 @@ module.exports = {
                     reportImpliedEvalCallExpression(node);
                 }
             },
-            "Program:exit"() {
-                const globalScope = context.getScope();
+            "Program:exit"(node) {
+                const globalScope = sourceCode.getScope(node);
 
                 GLOBAL_CANDIDATES
                     .map(candidate => astUtils.getVariableByName(globalScope, candidate))

package/lib/rules/no-import-assign.js

@@ -194,9 +194,11 @@ module.exports = {
     },
 
     create(context) {
+        const sourceCode = context.getSourceCode();
+
         return {
             ImportDeclaration(node) {
-                const scope = context.getScope();
+                const scope = sourceCode.getScope(node);
 
                 for (const variable of context.getDeclaredVariables(node)) {
                     const shouldCheckMembers = variable.defs.some(