eslint 8.34.0 → 8.39.0

package/lib/rules/no-setter-return.js

@@ -10,7 +10,7 @@
 //------------------------------------------------------------------------------
 
 const astUtils = require("./utils/ast-utils");
-const { findVariable } = require("eslint-utils");
+const { findVariable } = require("@eslint-community/eslint-utils");
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -156,6 +156,7 @@ module.exports = {
 
     create(context) {
         let funcInfo = null;
+        const sourceCode = context.getSourceCode();
 
         /**
          * Creates and pushes to the stack a function info object for the given function node.
@@ -163,7 +164,7 @@ module.exports = {
          * @returns {void}
          */
         function enterFunction(node) {
-            const outerScope = getOuterScope(context.getScope());
+            const outerScope = getOuterScope(sourceCode.getScope(node));
 
             funcInfo = {
                 upper: funcInfo,

package/lib/rules/no-shadow-restricted-names.js

@@ -43,10 +43,11 @@ module.exports = {
 
 
         const RESTRICTED = new Set(["undefined", "NaN", "Infinity", "arguments", "eval"]);
+        const sourceCode = context.getSourceCode();
 
         return {
             "VariableDeclaration, :function, CatchClause"(node) {
-                for (const variable of context.getDeclaredVariables(node)) {
+                for (const variable of sourceCode.getDeclaredVariables(node)) {
                     if (variable.defs.length > 0 && RESTRICTED.has(variable.name) && !safelyShadowsUndefined(variable)) {
                         context.report({
                             node: variable.defs[0].name,

package/lib/rules/no-shadow.js

@@ -67,6 +67,7 @@ module.exports = {
             allow: (context.options[0] && context.options[0].allow) || [],
             ignoreOnInitialization: context.options[0] && context.options[0].ignoreOnInitialization
         };
+        const sourceCode = context.getSourceCode();
 
         /**
          * Checks whether or not a given location is inside of the range of a given node.
@@ -318,8 +319,8 @@ module.exports = {
         }
 
         return {
-            "Program:exit"() {
-                const globalScope = context.getScope();
+            "Program:exit"(node) {
+                const globalScope = sourceCode.getScope(node);
                 const stack = globalScope.childScopes.slice();
 
                 while (stack.length) {

package/lib/rules/no-undef-init.js

@@ -39,7 +39,7 @@ module.exports = {
             VariableDeclarator(node) {
                 const name = sourceCode.getText(node.id),
                     init = node.init && node.init.name,
-                    scope = context.getScope(),
+                    scope = sourceCode.getScope(node),
                     undefinedVar = astUtils.getVariableByName(scope, "undefined"),
                     shadowed = undefinedVar && undefinedVar.defs.length > 0,
                     lastToken = sourceCode.getLastToken(node);

package/lib/rules/no-undef.js

@@ -54,10 +54,11 @@ module.exports = {
     create(context) {
         const options = context.options[0];
         const considerTypeOf = options && options.typeof === true || false;
+        const sourceCode = context.getSourceCode();
 
         return {
-            "Program:exit"(/* node */) {
-                const globalScope = context.getScope();
+            "Program:exit"(node) {
+                const globalScope = sourceCode.getScope(node);
 
                 globalScope.through.forEach(ref => {
                     const identifier = ref.identifier;

package/lib/rules/no-undefined.js

@@ -28,6 +28,8 @@ module.exports = {
 
     create(context) {
 
+        const sourceCode = context.getSourceCode();
+
         /**
          * Report an invalid "undefined" identifier node.
          * @param {ASTNode} node The node to report.
@@ -66,8 +68,8 @@ module.exports = {
         }
 
         return {
-            "Program:exit"() {
-                const globalScope = context.getScope();
+            "Program:exit"(node) {
+                const globalScope = sourceCode.getScope(node);
 
                 const stack = [globalScope];
 

package/lib/rules/no-underscore-dangle.js

@@ -84,6 +84,7 @@ module.exports = {
         const allowFunctionParams = typeof options.allowFunctionParams !== "undefined" ? options.allowFunctionParams : true;
         const allowInArrayDestructuring = typeof options.allowInArrayDestructuring !== "undefined" ? options.allowInArrayDestructuring : true;
         const allowInObjectDestructuring = typeof options.allowInObjectDestructuring !== "undefined" ? options.allowInObjectDestructuring : true;
+        const sourceCode = context.getSourceCode();
 
         //-------------------------------------------------------------------------
         // Helpers
@@ -213,7 +214,7 @@ module.exports = {
          * @private
          */
         function checkForDanglingUnderscoreInVariableExpression(node) {
-            context.getDeclaredVariables(node).forEach(variable => {
+            sourceCode.getDeclaredVariables(node).forEach(variable => {
                 const definition = variable.defs.find(def => def.node === node);
                 const identifierNode = definition.name;
                 const identifier = identifierNode.name;

package/lib/rules/no-unmodified-loop-condition.js

@@ -340,8 +340,8 @@ module.exports = {
         }
 
         return {
-            "Program:exit"() {
-                const queue = [context.getScope()];
+            "Program:exit"(node) {
+                const queue = [sourceCode.getScope(node)];
 
                 groupMap = new Map();
 

package/lib/rules/no-unused-expressions.js

@@ -109,12 +109,11 @@ module.exports = {
         /**
          * Detect if a Node is a directive.
          * @param {ASTNode} node any node
-         * @param {ASTNode[]} ancestors the given node's ancestors
          * @returns {boolean} whether the given node is considered a directive in its current position
          */
-        function isDirective(node, ancestors) {
-            const parent = ancestors[ancestors.length - 1],
-                grandparent = ancestors[ancestors.length - 2];
+        function isDirective(node) {
+            const parent = node.parent,
+                grandparent = parent.parent;
 
             /**
              * https://tc39.es/ecma262/#directive-prologue
@@ -180,7 +179,7 @@ module.exports = {
 
         return {
             ExpressionStatement(node) {
-                if (Checker.isDisallowed(node.expression) && !isDirective(node, context.getAncestors())) {
+                if (Checker.isDisallowed(node.expression) && !isDirective(node)) {
                     context.report({ node, messageId: "unusedExpression" });
                 }
             }

package/lib/rules/no-unused-vars.js

@@ -555,7 +555,7 @@ module.exports = {
          */
         function isAfterLastUsedArg(variable) {
             const def = variable.defs[0];
-            const params = context.getDeclaredVariables(def.node);
+            const params = sourceCode.getDeclaredVariables(def.node);
             const posteriorParams = params.slice(params.indexOf(variable) + 1);
 
             // If any used parameters occur after this parameter, do not report.
@@ -673,7 +673,7 @@ module.exports = {
 
         return {
             "Program:exit"(programNode) {
-                const unusedVars = collectUnusedVariables(context.getScope(), []);
+                const unusedVars = collectUnusedVariables(sourceCode.getScope(programNode), []);
 
                 for (let i = 0, l = unusedVars.length; i < l; ++i) {
                     const unusedVar = unusedVars[i];

package/lib/rules/no-use-before-define.js

@@ -258,6 +258,7 @@ module.exports = {
 
     create(context) {
         const options = parseOptions(context.options[0]);
+        const sourceCode = context.getSourceCode();
 
         /**
          * Determines whether a given reference should be checked.
@@ -339,8 +340,8 @@ module.exports = {
         }
 
         return {
-            Program() {
-                checkReferencesInScope(context.getScope());
+            Program(node) {
+                checkReferencesInScope(sourceCode.getScope(node));
             }
         };
     }

package/lib/rules/no-useless-backreference.js

@@ -9,8 +9,8 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const { CALL, CONSTRUCT, ReferenceTracker, getStringIfConstant } = require("eslint-utils");
-const { RegExpParser, visitRegExpAST } = require("regexpp");
+const { CALL, CONSTRUCT, ReferenceTracker, getStringIfConstant } = require("@eslint-community/eslint-utils");
+const { RegExpParser, visitRegExpAST } = require("@eslint-community/regexpp");
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -82,6 +82,8 @@ module.exports = {
 
     create(context) {
 
+        const sourceCode = context.getSourceCode();
+
         /**
          * Checks and reports useless backreferences in the given regular expression.
          * @param {ASTNode} node Node that represents regular expression. A regex literal or RegExp constructor call.
@@ -167,8 +169,8 @@ module.exports = {
 
                 checkRegex(node, pattern, flags);
             },
-            Program() {
-                const scope = context.getScope(),
+            Program(node) {
+                const scope = sourceCode.getScope(node),
                     tracker = new ReferenceTracker(scope),
                     traceMap = {
                         RegExp: {
@@ -177,13 +179,13 @@ module.exports = {
                         }
                     };
 
-                for (const { node } of tracker.iterateGlobalReferences(traceMap)) {
-                    const [patternNode, flagsNode] = node.arguments,
+                for (const { node: refNode } of tracker.iterateGlobalReferences(traceMap)) {
+                    const [patternNode, flagsNode] = refNode.arguments,
                         pattern = getStringIfConstant(patternNode, scope),
                         flags = getStringIfConstant(flagsNode, scope);
 
                     if (typeof pattern === "string") {
-                        checkRegex(node, pattern, flags || "");
+                        checkRegex(refNode, pattern, flags || "");
                     }
                 }
             }

package/lib/rules/no-useless-return.js

@@ -197,7 +197,7 @@ module.exports = {
 
         return {
 
-            // Makes and pushs a new scope information.
+            // Makes and pushes a new scope information.
             onCodePathStart(codePath) {
                 scopeInfo = {
                     upper: scopeInfo,

package/lib/rules/no-var.js

@@ -210,7 +210,7 @@ module.exports = {
             if (!declarator.init) {
                 return false;
             }
-            const variables = context.getDeclaredVariables(declarator);
+            const variables = sourceCode.getDeclaredVariables(declarator);
 
             return variables.some(hasReferenceInTDZ(declarator.init));
         }
@@ -268,7 +268,7 @@ module.exports = {
          * @returns {boolean} `true` if it can fix the node.
          */
         function canFix(node) {
-            const variables = context.getDeclaredVariables(node);
+            const variables = sourceCode.getDeclaredVariables(node);
             const scopeNode = getScopeNode(node);
 
             if (node.parent.type === "SwitchCase" ||

package/lib/rules/object-shorthand.js

@@ -354,11 +354,12 @@ module.exports = {
         /**
          * Enters a function. This creates a new lexical identifier scope, so a new Set of arrow functions is pushed onto the stack.
          * Also, this marks all `arguments` identifiers so that they can be detected later.
+         * @param {ASTNode} node The node representing the function.
          * @returns {void}
          */
-        function enterFunction() {
+        function enterFunction(node) {
             lexicalScopeStack.unshift(new Set());
-            context.getScope().variables.filter(variable => variable.name === "arguments").forEach(variable => {
+            sourceCode.getScope(node).variables.filter(variable => variable.name === "arguments").forEach(variable => {
                 variable.references.map(ref => ref.identifier).forEach(identifier => argumentsIdentifiers.add(identifier));
             });
         }

package/lib/rules/prefer-arrow-callback.js

@@ -263,14 +263,14 @@ module.exports = {
                 }
 
                 // Skip recursive functions.
-                const nameVar = context.getDeclaredVariables(node)[0];
+                const nameVar = sourceCode.getDeclaredVariables(node)[0];
 
                 if (isFunctionName(nameVar) && nameVar.references.length > 0) {
                     return;
                 }
 
                 // Skip if it's using arguments.
-                const variable = getVariableOfArguments(context.getScope());
+                const variable = getVariableOfArguments(sourceCode.getScope(node));
 
                 if (variable && variable.references.length > 0) {
                     return;

package/lib/rules/prefer-const.js

@@ -493,7 +493,7 @@ module.exports = {
 
             VariableDeclaration(node) {
                 if (node.kind === "let" && !isInitOfForStatement(node)) {
-                    variables.push(...context.getDeclaredVariables(node));
+                    variables.push(...sourceCode.getDeclaredVariables(node));
                 }
             }
         };

package/lib/rules/prefer-exponentiation-operator.js

@@ -10,7 +10,7 @@
 //------------------------------------------------------------------------------
 
 const astUtils = require("./utils/ast-utils");
-const { CALL, ReferenceTracker } = require("eslint-utils");
+const { CALL, ReferenceTracker } = require("@eslint-community/eslint-utils");
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -172,8 +172,8 @@ module.exports = {
         }
 
         return {
-            Program() {
-                const scope = context.getScope();
+            Program(node) {
+                const scope = sourceCode.getScope(node);
                 const tracker = new ReferenceTracker(scope);
                 const trackMap = {
                     Math: {
@@ -181,8 +181,8 @@ module.exports = {
                     }
                 };
 
-                for (const { node } of tracker.iterateGlobalReferences(trackMap)) {
-                    report(node);
+                for (const { node: refNode } of tracker.iterateGlobalReferences(trackMap)) {
+                    report(refNode);
                 }
             }
         };

package/lib/rules/prefer-named-capture-group.js

@@ -14,8 +14,8 @@ const {
     CONSTRUCT,
     ReferenceTracker,
     getStringIfConstant
-} = require("eslint-utils");
-const regexpp = require("regexpp");
+} = require("@eslint-community/eslint-utils");
+const regexpp = require("@eslint-community/regexpp");
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -151,8 +151,8 @@ module.exports = {
                     checkRegex(node.regex.pattern, node, node, node.regex.flags.includes("u"));
                 }
             },
-            Program() {
-                const scope = context.getScope();
+            Program(node) {
+                const scope = sourceCode.getScope(node);
                 const tracker = new ReferenceTracker(scope);
                 const traceMap = {
                     RegExp: {
@@ -161,12 +161,12 @@ module.exports = {
                     }
                 };
 
-                for (const { node } of tracker.iterateGlobalReferences(traceMap)) {
-                    const regex = getStringIfConstant(node.arguments[0]);
-                    const flags = getStringIfConstant(node.arguments[1]);
+                for (const { node: refNode } of tracker.iterateGlobalReferences(traceMap)) {
+                    const regex = getStringIfConstant(refNode.arguments[0]);
+                    const flags = getStringIfConstant(refNode.arguments[1]);
 
                     if (regex) {
-                        checkRegex(regex, node, node.arguments[0], flags && flags.includes("u"));
+                        checkRegex(regex, refNode, refNode.arguments[0], flags && flags.includes("u"));
                     }
                 }
             }

package/lib/rules/prefer-object-has-own.js

@@ -61,6 +61,9 @@ module.exports = {
         fixable: "code"
     },
     create(context) {
+
+        const sourceCode = context.getSourceCode();
+
         return {
             CallExpression(node) {
                 if (!(node.callee.type === "MemberExpression" && node.callee.object.type === "MemberExpression")) {
@@ -72,7 +75,7 @@ module.exports = {
                 const isObject = hasLeftHandObject(node.callee.object);
 
                 // check `Object` scope
-                const scope = context.getScope();
+                const scope = sourceCode.getScope(node);
                 const variable = astUtils.getVariableByName(scope, "Object");
 
                 if (
@@ -85,7 +88,6 @@ module.exports = {
                         node,
                         messageId: "useHasOwn",
                         fix(fixer) {
-                            const sourceCode = context.getSourceCode();
 
                             if (sourceCode.getCommentsInside(node.callee).length > 0) {
                                 return null;

package/lib/rules/prefer-object-spread.js

@@ -1,12 +1,11 @@
 /**
  * @fileoverview Prefers object spread property over Object.assign
  * @author Sharmila Jesupaul
- * See LICENSE file in root directory for full license.
  */
 
 "use strict";
 
-const { CALL, ReferenceTracker } = require("eslint-utils");
+const { CALL, ReferenceTracker } = require("@eslint-community/eslint-utils");
 const {
     isCommaToken,
     isOpeningParenToken,
@@ -265,8 +264,8 @@ module.exports = {
         const sourceCode = context.getSourceCode();
 
         return {
-            Program() {
-                const scope = context.getScope();
+            Program(node) {
+                const scope = sourceCode.getScope(node);
                 const tracker = new ReferenceTracker(scope);
                 const trackMap = {
                     Object: {
@@ -275,22 +274,22 @@ module.exports = {
                 };
 
                 // Iterate all calls of `Object.assign` (only of the global variable `Object`).
-                for (const { node } of tracker.iterateGlobalReferences(trackMap)) {
+                for (const { node: refNode } of tracker.iterateGlobalReferences(trackMap)) {
                     if (
-                        node.arguments.length >= 1 &&
-                        node.arguments[0].type === "ObjectExpression" &&
-                        !hasArraySpread(node) &&
+                        refNode.arguments.length >= 1 &&
+                        refNode.arguments[0].type === "ObjectExpression" &&
+                        !hasArraySpread(refNode) &&
                         !(
-                            node.arguments.length > 1 &&
-                            hasArgumentsWithAccessors(node)
+                            refNode.arguments.length > 1 &&
+                            hasArgumentsWithAccessors(refNode)
                         )
                     ) {
-                        const messageId = node.arguments.length === 1
+                        const messageId = refNode.arguments.length === 1
                             ? "useLiteralMessage"
                             : "useSpreadMessage";
-                        const fix = defineFixer(node, sourceCode);
+                        const fix = defineFixer(refNode, sourceCode);
 
-                        context.report({ node, messageId, fix });
+                        context.report({ node: refNode, messageId, fix });
                     }
                 }
             }

package/lib/rules/prefer-promise-reject-errors.js

@@ -41,6 +41,7 @@ module.exports = {
     create(context) {
 
         const ALLOW_EMPTY_REJECT = context.options.length && context.options[0].allowEmptyReject;
+        const sourceCode = context.getSourceCode();
 
         //----------------------------------------------------------------------
         // Helpers
@@ -100,7 +101,7 @@ module.exports = {
                     node.arguments.length && astUtils.isFunction(node.arguments[0]) &&
                     node.arguments[0].params.length > 1 && node.arguments[0].params[1].type === "Identifier"
                 ) {
-                    context.getDeclaredVariables(node.arguments[0])
+                    sourceCode.getDeclaredVariables(node.arguments[0])
 
                         /*
                          * Find the first variable that matches the second parameter's name.

package/lib/rules/prefer-regex-literals.js

@@ -10,16 +10,15 @@
 //------------------------------------------------------------------------------
 
 const astUtils = require("./utils/ast-utils");
-const { CALL, CONSTRUCT, ReferenceTracker, findVariable } = require("eslint-utils");
-const { RegExpValidator, visitRegExpAST, RegExpParser } = require("regexpp");
+const { CALL, CONSTRUCT, ReferenceTracker, findVariable } = require("@eslint-community/eslint-utils");
+const { RegExpValidator, visitRegExpAST, RegExpParser } = require("@eslint-community/regexpp");
 const { canTokensBeAdjacent } = require("./utils/ast-utils");
+const { REGEXPP_LATEST_ECMA_VERSION } = require("./utils/regular-expressions");
 
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
 
-const REGEXPP_LATEST_ECMA_VERSION = 2022;
-
 /**
  * Determines whether the given node is a string literal.
  * @param {ASTNode} node Node to check.
@@ -163,7 +162,7 @@ module.exports = {
          * @returns {boolean} True if the identifier is a reference to a global variable.
          */
         function isGlobalReference(node) {
-            const scope = context.getScope();
+            const scope = sourceCode.getScope(node);
             const variable = findVariable(scope, node);
 
             return variable !== null && variable.scope.type === "global" && variable.defs.length === 0;
@@ -375,8 +374,8 @@ module.exports = {
         }
 
         return {
-            Program() {
-                const scope = context.getScope();
+            Program(node) {
+                const scope = sourceCode.getScope(node);
                 const tracker = new ReferenceTracker(scope);
                 const traceMap = {
                     RegExp: {
@@ -385,16 +384,16 @@ module.exports = {
                     }
                 };
 
-                for (const { node } of tracker.iterateGlobalReferences(traceMap)) {
-                    if (disallowRedundantWrapping && isUnnecessarilyWrappedRegexLiteral(node)) {
-                        const regexNode = node.arguments[0];
+                for (const { node: refNode } of tracker.iterateGlobalReferences(traceMap)) {
+                    if (disallowRedundantWrapping && isUnnecessarilyWrappedRegexLiteral(refNode)) {
+                        const regexNode = refNode.arguments[0];
 
-                        if (node.arguments.length === 2) {
+                        if (refNode.arguments.length === 2) {
                             const suggests = [];
 
-                            const argFlags = getStringValue(node.arguments[1]) || "";
+                            const argFlags = getStringValue(refNode.arguments[1]) || "";
 
-                            if (canFixTo(node, regexNode.regex.pattern, argFlags)) {
+                            if (canFixTo(refNode, regexNode.regex.pattern, argFlags)) {
                                 suggests.push({
                                     messageId: "replaceWithLiteralAndFlags",
                                     pattern: regexNode.regex.pattern,
@@ -407,7 +406,7 @@ module.exports = {
 
                             if (
                                 !areFlagsEqual(mergedFlags, argFlags) &&
-                                canFixTo(node, regexNode.regex.pattern, mergedFlags)
+                                canFixTo(refNode, regexNode.regex.pattern, mergedFlags)
                             ) {
                                 suggests.push({
                                     messageId: "replaceWithIntendedLiteralAndFlags",
@@ -417,7 +416,7 @@ module.exports = {
                             }
 
                             context.report({
-                                node,
+                                node: refNode,
                                 messageId: "unexpectedRedundantRegExpWithFlags",
                                 suggest: suggests.map(({ flags, pattern, messageId }) => ({
                                     messageId,
@@ -425,42 +424,42 @@ module.exports = {
                                         flags
                                     },
                                     fix(fixer) {
-                                        return fixer.replaceText(node, getSafeOutput(node, `/${pattern}/${flags}`));
+                                        return fixer.replaceText(refNode, getSafeOutput(refNode, `/${pattern}/${flags}`));
                                     }
                                 }))
                             });
                         } else {
                             const outputs = [];
 
-                            if (canFixTo(node, regexNode.regex.pattern, regexNode.regex.flags)) {
+                            if (canFixTo(refNode, regexNode.regex.pattern, regexNode.regex.flags)) {
                                 outputs.push(sourceCode.getText(regexNode));
                             }
 
 
                             context.report({
-                                node,
+                                node: refNode,
                                 messageId: "unexpectedRedundantRegExp",
                                 suggest: outputs.map(output => ({
                                     messageId: "replaceWithLiteral",
                                     fix(fixer) {
                                         return fixer.replaceText(
-                                            node,
-                                            getSafeOutput(node, output)
+                                            refNode,
+                                            getSafeOutput(refNode, output)
                                         );
                                     }
                                 }))
                             });
                         }
-                    } else if (hasOnlyStaticStringArguments(node)) {
-                        let regexContent = getStringValue(node.arguments[0]);
+                    } else if (hasOnlyStaticStringArguments(refNode)) {
+                        let regexContent = getStringValue(refNode.arguments[0]);
                         let noFix = false;
                         let flags;
 
-                        if (node.arguments[1]) {
-                            flags = getStringValue(node.arguments[1]);
+                        if (refNode.arguments[1]) {
+                            flags = getStringValue(refNode.arguments[1]);
                         }
 
-                        if (!canFixTo(node, regexContent, flags)) {
+                        if (!canFixTo(refNode, regexContent, flags)) {
                             noFix = true;
                         }
 
@@ -494,12 +493,12 @@ module.exports = {
                         const newRegExpValue = `/${regexContent || "(?:)"}/${flags || ""}`;
 
                         context.report({
-                            node,
+                            node: refNode,
                             messageId: "unexpectedRegExp",
                             suggest: noFix ? [] : [{
                                 messageId: "replaceWithLiteral",
                                 fix(fixer) {
-                                    return fixer.replaceText(node, getSafeOutput(node, newRegExpValue));
+                                    return fixer.replaceText(refNode, getSafeOutput(refNode, newRegExpValue));
                                 }
                             }]
                         });