npm - eslint - Versions diffs - 8.30.0 → 8.32.0 - Mend

eslint 8.30.0 → 8.32.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (15) hide show

package/README.md +50 -44
package/conf/rule-type-list.json +2 -2
package/lib/cli-engine/formatters/formatters-meta.json +2 -2
package/lib/eslint/flat-eslint.js +37 -1
package/lib/linter/linter.js +4 -1
package/lib/rule-tester/flat-rule-tester.js +1 -1
package/lib/rule-tester/rule-tester.js +3 -3
package/lib/rules/key-spacing.js +35 -23
package/lib/rules/no-fallthrough.js +18 -2
package/lib/rules/no-underscore-dangle.js +36 -11
package/lib/rules/prefer-arrow-callback.js +2 -1
package/lib/rules/prefer-regex-literals.js +144 -29
package/lib/shared/directives.js +15 -0
package/messages/print-config-with-directory-path.js +1 -1
package/package.json +9 -8

package/README.md CHANGED Viewed

@@ -10,10 +10,10 @@
 # ESLint
 [Website](https://eslint.org) |
-[Configuring](https://eslint.org/docs/user-guide/configuring) |
+[Configuring](https://eslint.org/docs/latest/use/configure) |
 [Rules](https://eslint.org/docs/rules/) |
-[Contributing](https://eslint.org/docs/developer-guide/contributing) |
-[Reporting Bugs](https://eslint.org/docs/developer-guide/contributing/reporting-bugs) |
+[Contributing](https://eslint.org/docs/latest/contribute) |
+[Reporting Bugs](https://eslint.org/docs/latest/contribute/report-bugs) |
 [Code of Conduct](https://eslint.org/conduct) |
 [Twitter](https://twitter.com/geteslint) |
 [Mailing List](https://groups.google.com/group/eslint) |
@@ -31,7 +31,7 @@ ESLint is a tool for identifying and reporting on patterns found in ECMAScript/J
 2. [Configuration](#configuration)
 3. [Code of Conduct](#code-of-conduct)
 4. [Filing Issues](#filing-issues)
-5. [Frequently Asked Questions](#faq)
+5. [Frequently Asked Questions](#frequently-asked-questions)
 6. [Releases](#releases)
 7. [Security Policy](#security-policy)
 8. [Semantic Versioning Policy](#semantic-versioning-policy)
@@ -41,7 +41,7 @@ ESLint is a tool for identifying and reporting on patterns found in ECMAScript/J
 12. [Sponsors](#sponsors)
 13. [Technology Sponsors](#technology-sponsors)
-## <a name="installation-and-usage"></a>Installation and Usage
+## Installation and Usage
 Prerequisites: [Node.js](https://nodejs.org/) (`^12.22.0`, `^14.17.0`, or `>=16.0.0`) built with SSL support. (If you are using an official Node.js distribution, SSL is always built in.)
@@ -57,7 +57,7 @@ After that, you can run ESLint on any file or directory like this:
 ./node_modules/.bin/eslint yourfile.js
 ```
-## <a name="configuration"></a>Configuration
+## Configuration
 After running `npm init @eslint/config`, you'll have a `.eslintrc` file in your directory. In it, you'll see some rules configured like this:
@@ -76,28 +76,28 @@ The names `"semi"` and `"quotes"` are the names of [rules](https://eslint.org/do
 * `"warn"` or `1` - turn the rule on as a warning (doesn't affect exit code)
 * `"error"` or `2` - turn the rule on as an error (exit code will be 1)
-The three error levels allow you fine-grained control over how ESLint applies rules (for more configuration options and details, see the [configuration docs](https://eslint.org/docs/user-guide/configuring)).
+The three error levels allow you fine-grained control over how ESLint applies rules (for more configuration options and details, see the [configuration docs](https://eslint.org/docs/latest/use/configure)).
-## <a name="code-of-conduct"></a>Code of Conduct
+## Code of Conduct
 ESLint adheres to the [JS Foundation Code of Conduct](https://eslint.org/conduct).
-## <a name="filing-issues"></a>Filing Issues
+## Filing Issues
 Before filing an issue, please be sure to read the guidelines for what you're reporting:
-* [Bug Report](https://eslint.org/docs/developer-guide/contributing/reporting-bugs)
-* [Propose a New Rule](https://eslint.org/docs/developer-guide/contributing/new-rules)
-* [Proposing a Rule Change](https://eslint.org/docs/developer-guide/contributing/rule-changes)
-* [Request a Change](https://eslint.org/docs/developer-guide/contributing/changes)
+* [Bug Report](https://eslint.org/docs/latest/contribute/report-bugs)
+* [Propose a New Rule](https://eslint.org/docs/latest/contribute/propose-new-rule)
+* [Proposing a Rule Change](https://eslint.org/docs/latest/contribute/propose-rule-change)
+* [Request a Change](https://eslint.org/docs/latest/contribute/request-change)
-## <a name="faq"></a>Frequently Asked Questions
+## Frequently Asked Questions
 ### I'm using JSCS, should I migrate to ESLint?
 Yes. [JSCS has reached end of life](https://eslint.org/blog/2016/07/jscs-end-of-life) and is no longer supported.
-We have prepared a [migration guide](https://eslint.org/docs/user-guide/migrating-from-jscs) to help you convert your JSCS settings to an ESLint configuration.
+We have prepared a [migration guide](https://eslint.org/docs/latest/use/migrating-from-jscs) to help you convert your JSCS settings to an ESLint configuration.
 We are now at or near 100% compatibility with JSCS. If you try ESLint and believe we are not yet compatible with a JSCS rule/configuration, please create an issue (mentioning that it is a JSCS compatibility issue) and we will evaluate it as per our normal process.
@@ -113,11 +113,11 @@ No, ESLint does both traditional linting (looking for problematic patterns) and
 ### Does ESLint support JSX?
-Yes, ESLint natively supports parsing JSX syntax (this must be enabled in [configuration](https://eslint.org/docs/user-guide/configuring)). Please note that supporting JSX syntax *is not* the same as supporting React. React applies specific semantics to JSX syntax that ESLint doesn't recognize. We recommend using [eslint-plugin-react](https://www.npmjs.com/package/eslint-plugin-react) if you are using React and want React semantics.
+Yes, ESLint natively supports parsing JSX syntax (this must be enabled in [configuration](https://eslint.org/docs/latest/use/configure)). Please note that supporting JSX syntax *is not* the same as supporting React. React applies specific semantics to JSX syntax that ESLint doesn't recognize. We recommend using [eslint-plugin-react](https://www.npmjs.com/package/eslint-plugin-react) if you are using React and want React semantics.
 ### What ECMAScript versions does ESLint support?
-ESLint has full support for ECMAScript 3, 5 (default), 2015, 2016, 2017, 2018, 2019, 2020, 2021 and 2022. You can set your desired ECMAScript syntax (and other settings, like global variables or your target environments) through [configuration](https://eslint.org/docs/user-guide/configuring).
+ESLint has full support for ECMAScript 3, 5 (default), 2015, 2016, 2017, 2018, 2019, 2020, 2021 and 2022. You can set your desired ECMAScript syntax (and other settings, like global variables or your target environments) through [configuration](https://eslint.org/docs/latest/use/configure).
 ### What about experimental features?
@@ -125,7 +125,7 @@ ESLint's parser only officially supports the latest final ECMAScript standard. W
 In other cases (including if rules need to warn on more or fewer cases due to new syntax, rather than just not crashing), we recommend you use other parsers and/or rule plugins. If you are using Babel, you can use [@babel/eslint-parser](https://www.npmjs.com/package/@babel/eslint-parser) and [@babel/eslint-plugin](https://www.npmjs.com/package/@babel/eslint-plugin) to use any option available in Babel.
-Once a language feature has been adopted into the ECMAScript standard (stage 4 according to the [TC39 process](https://tc39.github.io/process-document/)), we will accept issues and pull requests related to the new feature, subject to our [contributing guidelines](https://eslint.org/docs/developer-guide/contributing). Until then, please use the appropriate parser and plugin(s) for your experimental feature.
+Once a language feature has been adopted into the ECMAScript standard (stage 4 according to the [TC39 process](https://tc39.github.io/process-document/)), we will accept issues and pull requests related to the new feature, subject to our [contributing guidelines](https://eslint.org/docs/latest/contribute). Until then, please use the appropriate parser and plugin(s) for your experimental feature.
 ### Where to ask for help?
@@ -141,15 +141,15 @@ We intentionally don't lock dependency versions so that we have the latest compa
 The Twilio blog has a [deeper dive](https://www.twilio.com/blog/lockfiles-nodejs) to learn more.
-## <a name="releases"></a>Releases
+## Releases
 We have scheduled releases every two weeks on Friday or Saturday. You can follow a [release issue](https://github.com/eslint/eslint/issues?q=is%3Aopen+is%3Aissue+label%3Arelease) for updates about the scheduling of any particular release.
-## <a name="security-policy"></a>Security Policy
+## Security Policy
 ESLint takes security seriously. We work hard to ensure that ESLint is safe for everyone and that security issues are addressed quickly and responsibly. Read the full [security policy](https://github.com/eslint/.github/blob/master/SECURITY.md).
-## <a name="semantic-versioning-policy"></a>Semantic Versioning Policy
+## Semantic Versioning Policy
 ESLint follows [semantic versioning](https://semver.org). However, due to the nature of ESLint as a code quality tool, it's not always clear when a minor or major version bump occurs. To help clarify this for everyone, we've defined the following semantic versioning policy for ESLint:
@@ -182,7 +182,7 @@ ESLint follows [semantic versioning](https://semver.org). However, due to the na
 According to our policy, any minor update may report more linting errors than the previous release (ex: from a bug fix). As such, we recommend using the tilde (`~`) in `package.json` e.g. `"eslint": "~3.1.0"` to guarantee the results of your builds.
-## <a name="stylistic-rule-updates"></a>Stylistic Rule Updates
+## Stylistic Rule Updates
 Stylistic rules are frozen according to [our policy](https://eslint.org/blog/2020/05/changes-to-rules-policies) on how we evaluate new rules and rule changes.
 This means:
@@ -191,11 +191,11 @@ This means:
 * **New ECMAScript features**: We will also make sure stylistic rules are compatible with new ECMAScript features.
 * **New options**: We will **not** add any new options to stylistic rules unless an option is the only way to fix a bug or support a newly-added ECMAScript feature.
-## <a name="license"></a>License
+## License
 [![FOSSA Status](https://app.fossa.io/api/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Feslint%2Feslint.svg?type=large)](https://app.fossa.io/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Feslint%2Feslint?ref=badge_large)
-## <a name="team"></a>Team
+## Team
 These folks keep the project moving and are resources for help.
@@ -245,11 +245,6 @@ Nitin Kumar
 The people who review and fix bugs and help triage issues.
 <table><tbody><tr><td align="center" valign="top" width="11%">
-<a href="https://github.com/brettz9">
-<img src="https://github.com/brettz9.png?s=75" width="75" height="75"><br />
-Brett Zamir
-</a>
-</td><td align="center" valign="top" width="11%">
 <a href="https://github.com/bmish">
 <img src="https://github.com/bmish.png?s=75" width="75" height="75"><br />
 Bryan Mishkin
@@ -260,38 +255,49 @@ Bryan Mishkin
 Sara Soueidan
 </a>
 </td><td align="center" valign="top" width="11%">
-<a href="https://github.com/g-plane">
-<img src="https://github.com/g-plane.png?s=75" width="75" height="75"><br />
-Pig Fang
+<a href="https://github.com/yeonjuan">
+<img src="https://github.com/yeonjuan.png?s=75" width="75" height="75"><br />
+YeonJuan
+</a>
+</td></tr></tbody></table>
+### Website Team
+Team members who focus specifically on eslint.org
+<table><tbody><tr><td align="center" valign="top" width="11%">
+<a href="https://github.com/amareshsm">
+<img src="https://github.com/amareshsm.png?s=75" width="75" height="75"><br />
+Amaresh  S M
 </a>
 </td><td align="center" valign="top" width="11%">
-<a href="https://github.com/anikethsaha">
-<img src="https://github.com/anikethsaha.png?s=75" width="75" height="75"><br />
-Anix
+<a href="https://github.com/harish-sethuraman">
+<img src="https://github.com/harish-sethuraman.png?s=75" width="75" height="75"><br />
+Strek
 </a>
 </td><td align="center" valign="top" width="11%">
-<a href="https://github.com/yeonjuan">
-<img src="https://github.com/yeonjuan.png?s=75" width="75" height="75"><br />
-YeonJuan
+<a href="https://github.com/kecrily">
+<img src="https://github.com/kecrily.png?s=75" width="75" height="75"><br />
+Percy Ma
 </a>
 </td></tr></tbody></table>
 <!--teamend-->
-## <a name="sponsors"></a>Sponsors
+## Sponsors
 The following companies, organizations, and individuals support ESLint's ongoing maintenance and development. [Become a Sponsor](https://opencollective.com/eslint) to get your logo on our README and website.
 <!-- NOTE: This section is autogenerated. Do not manually edit.-->
 <!--sponsorsstart-->
 <h3>Platinum Sponsors</h3>
-<p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a></p><h3>Gold Sponsors</h3>
-<p><a href="https://www.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="96"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301?v=4" alt="American Express" height="96"></a></p><h3>Silver Sponsors</h3>
-<p><a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://launchdarkly.com"><img src="https://images.opencollective.com/launchdarkly/574bb9e/logo.png" alt="launchdarkly" height="32"></a> <a href="https://nx.dev"><img src="https://images.opencollective.com/nx/0efbe42/logo.png" alt="Nx (by Nrwl)" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://www.vpsserver.com"><img src="https://images.opencollective.com/vpsservercom/logo.png" alt="VPS" height="32"></a> <a href="https://icons8.com"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8: free icons, photos, illustrations, and music" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://themeisle.com"><img src="https://images.opencollective.com/themeisle/d5592fe/logo.png" alt="ThemeIsle" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a></p>
+<p><a href="#"><img src="https://images.opencollective.com/2021-frameworks-fund/logo.png" alt="Chrome Frameworks Fund" height="undefined"></a> <a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="undefined"></a></p><h3>Gold Sponsors</h3>
+<p><a href="https://ridicorp.com/career/"><img src="https://images.opencollective.com/ridi-corporation/175dcf3/logo.png" alt="RIDI" height="96"></a> <a href="https://engineering.salesforce.com"><img src="https://images.opencollective.com/salesforce/ca8f997/logo.png" alt="Salesforce" height="96"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="96"></a></p><h3>Silver Sponsors</h3>
+<p><a href="https://sentry.io"><img src="https://avatars.githubusercontent.com/u/1396951?v=4" alt="Sentry" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a></p><h3>Bronze Sponsors</h3>
+<p><a href="https://themeisle.com"><img src="https://images.opencollective.com/themeisle/d5592fe/logo.png" alt="ThemeIsle" height="32"></a> <a href="https://nx.dev"><img src="https://images.opencollective.com/nx/0efbe42/logo.png" alt="Nx (by Nrwl)" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8: free icons, photos, illustrations, and music" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.ignitionapp.com"><img src="https://avatars.githubusercontent.com/u/5753491?v=4" alt="Ignition" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774?v=4" alt="HeroCoders" height="32"></a> <a href="https://quickbookstoolhub.com"><img src="https://avatars.githubusercontent.com/u/95090305?u=e5bc398ef775c9ed19f955c675cdc1fb6abf01df&v=4" alt="QuickBooks Tool hub" height="32"></a></p>
 <!--sponsorsend-->
-## <a name="technology-sponsors"></a>Technology Sponsors
+## Technology Sponsors
 * Site search ([eslint.org](https://eslint.org)) is sponsored by [Algolia](https://www.algolia.com)
 * Hosting for ([eslint.org](https://eslint.org)) is sponsored by [Netlify](https://www.netlify.com)

package/conf/rule-type-list.json CHANGED Viewed

@@ -6,12 +6,12 @@
     ],
     "deprecated": {
         "name": "Deprecated",
-        "description": "These rules have been deprecated in accordance with the <a href=\"/docs/user-guide/rule-deprecation\">deprecation policy</a>, and replaced by newer rules:",
+        "description": "These rules have been deprecated in accordance with the <a href=\"/docs/use/rule-deprecation\">deprecation policy</a>, and replaced by newer rules:",
         "rules": []
     },
     "removed": {
         "name": "Removed",
-        "description": "These rules from older versions of ESLint (before the <a href=\"/docs/user-guide/rule-deprecation\">deprecation policy</a> existed) have been replaced by newer rules:",
+        "description": "These rules from older versions of ESLint (before the <a href=\"/docs/use/rule-deprecation\">deprecation policy</a> existed) have been replaced by newer rules:",
         "rules": [
             { "removed": "generator-star", "replacedBy": ["generator-star-spacing"] },
             { "removed": "global-strict", "replacedBy": ["strict"] },

package/lib/cli-engine/formatters/formatters-meta.json CHANGED Viewed

@@ -17,11 +17,11 @@
     },
     {
         "name": "json-with-metadata",
-        "description": "Outputs JSON-serialized results. The `json-with-metadata` provides the same linting results as the [`json`](#json) formatter with additional metadata about the rules applied. The linting results are included in the `results` property and the rules metadata is included in the `metadata` property.\n\nAlternatively, you can use the [ESLint Node.js API](../../developer-guide/nodejs-api) to programmatically use ESLint."
+        "description": "Outputs JSON-serialized results. The `json-with-metadata` provides the same linting results as the [`json`](#json) formatter with additional metadata about the rules applied. The linting results are included in the `results` property and the rules metadata is included in the `metadata` property.\n\nAlternatively, you can use the [ESLint Node.js API](../../integrate/nodejs-api) to programmatically use ESLint."
     },
     {
         "name": "json",
-        "description": "Outputs JSON-serialized results. The `json` formatter is useful when you want to programmatically work with the CLI's linting results.\n\nAlternatively, you can use the [ESLint Node.js API](../../developer-guide/nodejs-api) to programmatically use ESLint."
+        "description": "Outputs JSON-serialized results. The `json` formatter is useful when you want to programmatically work with the CLI's linting results.\n\nAlternatively, you can use the [ESLint Node.js API](../../integrate/nodejs-api) to programmatically use ESLint."
     },
     {
         "name": "junit",

package/lib/eslint/flat-eslint.js CHANGED Viewed

@@ -93,6 +93,7 @@ const FLAT_CONFIG_FILENAME = "eslint.config.js";
 const debug = require("debug")("eslint:flat-eslint");
 const removedFormatters = new Set(["table", "codeframe"]);
 const privateMembers = new WeakMap();
+const importedConfigFileModificationTime = new Map();
 /**
  * It will calculate the error and warning count for collection of messages per file
@@ -281,7 +282,42 @@ async function loadFlatConfigFile(filePath) {
     debug(`Config file URL is ${fileURL}`);
-    return (await import(fileURL)).default;
+    const mtime = (await fs.stat(filePath)).mtime.getTime();
+    /*
+     * Append a query with the config file's modification time (`mtime`) in order
+     * to import the current version of the config file. Without the query, `import()` would
+     * cache the config file module by the pathname only, and then always return
+     * the same version (the one that was actual when the module was imported for the first time).
+     *
+     * This ensures that the config file module is loaded and executed again
+     * if it has been changed since the last time it was imported.
+     * If it hasn't been changed, `import()` will just return the cached version.
+     *
+     * Note that we should not overuse queries (e.g., by appending the current time
+     * to always reload the config file module) as that could cause memory leaks
+     * because entries are never removed from the import cache.
+     */
+    fileURL.searchParams.append("mtime", mtime);
+    /*
+     * With queries, we can bypass the import cache. However, when import-ing a CJS module,
+     * Node.js uses the require infrastructure under the hood. That includes the require cache,
+     * which caches the config file module by its file path (queries have no effect).
+     * Therefore, we also need to clear the require cache before importing the config file module.
+     * In order to get the same behavior with ESM and CJS config files, in particular - to reload
+     * the config file only if it has been changed, we track file modification times and clear
+     * the require cache only if the file has been changed.
+     */
+    if (importedConfigFileModificationTime.get(filePath) !== mtime) {
+        delete require.cache[filePath];
+    }
+    const config = (await import(fileURL)).default;
+    importedConfigFileModificationTime.set(filePath, mtime);
+    return config;
 }
 /**

package/lib/linter/linter.js CHANGED Viewed

@@ -18,6 +18,9 @@ const
     merge = require("lodash.merge"),
     pkg = require("../../package.json"),
     astUtils = require("../shared/ast-utils"),
+    {
+        directivesPattern
+    } = require("../shared/directives"),
     {
         Legacy: {
             ConfigOps,
@@ -377,7 +380,7 @@ function getDirectiveComments(ast, ruleMapper, warnInlineConfig) {
     ast.comments.filter(token => token.type !== "Shebang").forEach(comment => {
         const { directivePart, justificationPart } = extractDirectiveComment(comment.value);
-        const match = /^(eslint(?:-env|-enable|-disable(?:(?:-next)?-line)?)?|exported|globals?)(?:\s|$)/u.exec(directivePart);
+        const match = directivesPattern.exec(directivePart);
         if (!match) {
             return;

package/lib/rule-tester/flat-rule-tester.js CHANGED Viewed

@@ -430,7 +430,7 @@ class FlatRuleTester {
         if (typeof this[DESCRIBE] === "function" || typeof this[IT] === "function") {
             throw new Error(
                 "Set `RuleTester.itOnly` to use `only` with a custom test framework.\n" +
-                "See https://eslint.org/docs/developer-guide/nodejs-api#customizing-ruletester for more."
+                "See https://eslint.org/docs/latest/integrate/nodejs-api#customizing-ruletester for more."
             );
         }
         if (typeof it === "function") {

package/lib/rule-tester/rule-tester.js CHANGED Viewed

@@ -314,7 +314,7 @@ function emitLegacyRuleAPIWarning(ruleName) {
     if (!emitLegacyRuleAPIWarning[`warned-${ruleName}`]) {
         emitLegacyRuleAPIWarning[`warned-${ruleName}`] = true;
         process.emitWarning(
-            `"${ruleName}" rule is using the deprecated function-style format and will stop working in ESLint v9. Please use object-style format: https://eslint.org/docs/developer-guide/working-with-rules`,
+            `"${ruleName}" rule is using the deprecated function-style format and will stop working in ESLint v9. Please use object-style format: https://eslint.org/docs/latest/extend/custom-rules`,
             "DeprecationWarning"
         );
     }
@@ -329,7 +329,7 @@ function emitMissingSchemaWarning(ruleName) {
     if (!emitMissingSchemaWarning[`warned-${ruleName}`]) {
         emitMissingSchemaWarning[`warned-${ruleName}`] = true;
         process.emitWarning(
-            `"${ruleName}" rule has options but is missing the "meta.schema" property and will stop working in ESLint v9. Please add a schema: https://eslint.org/docs/developer-guide/working-with-rules#options-schemas`,
+            `"${ruleName}" rule has options but is missing the "meta.schema" property and will stop working in ESLint v9. Please add a schema: https://eslint.org/docs/latest/extend/custom-rules#options-schemas`,
             "DeprecationWarning"
         );
     }
@@ -493,7 +493,7 @@ class RuleTester {
         if (typeof this[DESCRIBE] === "function" || typeof this[IT] === "function") {
             throw new Error(
                 "Set `RuleTester.itOnly` to use `only` with a custom test framework.\n" +
-                "See https://eslint.org/docs/developer-guide/nodejs-api#customizing-ruletester for more."
+                "See https://eslint.org/docs/latest/integrate/nodejs-api#customizing-ruletester for more."
             );
         }
         if (typeof it === "function") {

package/lib/rules/key-spacing.js CHANGED Viewed

@@ -347,6 +347,40 @@ module.exports = {
             );
         }
+        /**
+         * Starting from the given node (a property.key node here) looks forward
+         * until it finds the colon punctuator and returns it.
+         * @param {ASTNode} node The node to start looking from.
+         * @returns {ASTNode} The colon punctuator.
+         */
+        function getNextColon(node) {
+            return sourceCode.getTokenAfter(node, astUtils.isColonToken);
+        }
+        /**
+         * Starting from the given node (a property.key node here) looks forward
+         * until it finds the last token before a colon punctuator and returns it.
+         * @param {ASTNode} node The node to start looking from.
+         * @returns {ASTNode} The last token before a colon punctuator.
+         */
+        function getLastTokenBeforeColon(node) {
+            const colonToken = getNextColon(node);
+            return sourceCode.getTokenBefore(colonToken);
+        }
+        /**
+         * Starting from the given node (a property.key node here) looks forward
+         * until it finds the first token after a colon punctuator and returns it.
+         * @param {ASTNode} node The node to start looking from.
+         * @returns {ASTNode} The first token after a colon punctuator.
+         */
+        function getFirstTokenAfterColon(node) {
+            const colonToken = getNextColon(node);
+            return sourceCode.getTokenAfter(colonToken);
+        }
         /**
          * Checks whether a property is a member of the property group it follows.
          * @param {ASTNode} lastMember The last Property known to be in the group.
@@ -355,7 +389,7 @@ module.exports = {
          */
         function continuesPropertyGroup(lastMember, candidate) {
             const groupEndLine = lastMember.loc.start.line,
-                candidateValueStartLine = (isKeyValueProperty(candidate) ? candidate.value : candidate).loc.start.line;
+                candidateValueStartLine = (isKeyValueProperty(candidate) ? getFirstTokenAfterColon(candidate.key) : candidate).loc.start.line;
             if (candidateValueStartLine - groupEndLine <= 1) {
                 return true;
@@ -384,28 +418,6 @@ module.exports = {
             return false;
         }
-        /**
-         * Starting from the given a node (a property.key node here) looks forward
-         * until it finds the last token before a colon punctuator and returns it.
-         * @param {ASTNode} node The node to start looking from.
-         * @returns {ASTNode} The last token before a colon punctuator.
-         */
-        function getLastTokenBeforeColon(node) {
-            const colonToken = sourceCode.getTokenAfter(node, astUtils.isColonToken);
-            return sourceCode.getTokenBefore(colonToken);
-        }
-        /**
-         * Starting from the given a node (a property.key node here) looks forward
-         * until it finds the colon punctuator and returns it.
-         * @param {ASTNode} node The node to start looking from.
-         * @returns {ASTNode} The colon punctuator.
-         */
-        function getNextColon(node) {
-            return sourceCode.getTokenAfter(node, astUtils.isColonToken);
-        }
         /**
          * Gets an object literal property's key as the identifier name or string value.
          * @param {ASTNode} property Property node whose key to retrieve.

package/lib/rules/no-fallthrough.js CHANGED Viewed

@@ -4,12 +4,28 @@
  */
 "use strict";
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+const { directivesPattern } = require("../shared/directives");
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
 const DEFAULT_FALLTHROUGH_COMMENT = /falls?\s?through/iu;
+/**
+ * Checks whether or not a given comment string is really a fallthrough comment and not an ESLint directive.
+ * @param {string} comment The comment string to check.
+ * @param {RegExp} fallthroughCommentPattern The regular expression used for checking for fallthrough comments.
+ * @returns {boolean} `true` if the comment string is truly a fallthrough comment.
+ */
+function isFallThroughComment(comment, fallthroughCommentPattern) {
+    return fallthroughCommentPattern.test(comment) && !directivesPattern.test(comment.trim());
+}
 /**
  * Checks whether or not a given case has a fallthrough comment.
  * @param {ASTNode} caseWhichFallsThrough SwitchCase node which falls through.
@@ -25,14 +41,14 @@ function hasFallthroughComment(caseWhichFallsThrough, subsequentCase, context, f
         const trailingCloseBrace = sourceCode.getLastToken(caseWhichFallsThrough.consequent[0]);
         const commentInBlock = sourceCode.getCommentsBefore(trailingCloseBrace).pop();
-        if (commentInBlock && fallthroughCommentPattern.test(commentInBlock.value)) {
+        if (commentInBlock && isFallThroughComment(commentInBlock.value, fallthroughCommentPattern)) {
             return true;
         }
     }
     const comment = sourceCode.getCommentsBefore(subsequentCase).pop();
-    return Boolean(comment && fallthroughCommentPattern.test(comment.value));
+    return Boolean(comment && isFallThroughComment(comment.value, fallthroughCommentPattern));
 }
 /**

package/lib/rules/no-underscore-dangle.js CHANGED Viewed

@@ -53,6 +53,14 @@ module.exports = {
                     enforceInClassFields: {
                         type: "boolean",
                         default: false
+                    },
+                    allowInArrayDestructuring: {
+                        type: "boolean",
+                        default: true
+                    },
+                    allowInObjectDestructuring: {
+                        type: "boolean",
+                        default: true
                     }
                 },
                 additionalProperties: false
@@ -74,6 +82,8 @@ module.exports = {
         const enforceInMethodNames = typeof options.enforceInMethodNames !== "undefined" ? options.enforceInMethodNames : false;
         const enforceInClassFields = typeof options.enforceInClassFields !== "undefined" ? options.enforceInClassFields : false;
         const allowFunctionParams = typeof options.allowFunctionParams !== "undefined" ? options.allowFunctionParams : true;
+        const allowInArrayDestructuring = typeof options.allowInArrayDestructuring !== "undefined" ? options.allowInArrayDestructuring : true;
+        const allowInObjectDestructuring = typeof options.allowInObjectDestructuring !== "undefined" ? options.allowInObjectDestructuring : true;
         //-------------------------------------------------------------------------
         // Helpers
@@ -195,6 +205,7 @@ module.exports = {
             checkForDanglingUnderscoreInFunctionParameters(node);
         }
         /**
          * Check if variable expression has a dangling underscore
          * @param {ASTNode} node node to evaluate
@@ -202,18 +213,32 @@ module.exports = {
          * @private
          */
         function checkForDanglingUnderscoreInVariableExpression(node) {
-            const identifier = node.id.name;
+            context.getDeclaredVariables(node).forEach(variable => {
+                const definition = variable.defs.find(def => def.node === node);
+                const identifierNode = definition.name;
+                const identifier = identifierNode.name;
+                let parent = identifierNode.parent;
+                while (!["VariableDeclarator", "ArrayPattern", "ObjectPattern"].includes(parent.type)) {
+                    parent = parent.parent;
+                }
-            if (typeof identifier !== "undefined" && hasDanglingUnderscore(identifier) &&
-                !isSpecialCaseIdentifierInVariableExpression(identifier) && !isAllowed(identifier)) {
-                context.report({
-                    node,
-                    messageId: "unexpectedUnderscore",
-                    data: {
-                        identifier
-                    }
-                });
-            }
+                if (
+                    hasDanglingUnderscore(identifier) &&
+                    !isSpecialCaseIdentifierInVariableExpression(identifier) &&
+                    !isAllowed(identifier) &&
+                    !(allowInArrayDestructuring && parent.type === "ArrayPattern") &&
+                    !(allowInObjectDestructuring && parent.type === "ObjectPattern")
+                ) {
+                    context.report({
+                        node,
+                        messageId: "unexpectedUnderscore",
+                        data: {
+                            identifier
+                        }
+                    });
+                }
+            });
         }
         /**

package/lib/rules/prefer-arrow-callback.js CHANGED Viewed

@@ -335,6 +335,7 @@ module.exports = {
                             // Convert the function expression to an arrow function.
                             const functionToken = sourceCode.getFirstToken(node, node.async ? 1 : 0);
                             const leftParenToken = sourceCode.getTokenAfter(functionToken, astUtils.isOpeningParenToken);
+                            const tokenBeforeBody = sourceCode.getTokenBefore(node.body);
                             if (sourceCode.commentsExistBetween(functionToken, leftParenToken)) {
@@ -348,7 +349,7 @@ module.exports = {
                                 // Remove extra tokens and spaces.
                                 yield fixer.removeRange([functionToken.range[0], leftParenToken.range[0]]);
                             }
-                            yield fixer.insertTextBefore(node.body, "=> ");
+                            yield fixer.insertTextAfter(tokenBeforeBody, " =>");
                             // Get the node that will become the new arrow function.
                             let replacedNode = callbackInfo.isLexicalThis ? node.parent.parent : node;

package/lib/rules/prefer-regex-literals.js CHANGED Viewed

@@ -146,6 +146,8 @@ module.exports = {
         messages: {
             unexpectedRegExp: "Use a regular expression literal instead of the 'RegExp' constructor.",
             replaceWithLiteral: "Replace with an equivalent regular expression literal.",
+            replaceWithLiteralAndFlags: "Replace with an equivalent regular expression literal with flags '{{ flags }}'.",
+            replaceWithIntendedLiteralAndFlags: "Replace with a regular expression literal with flags '{{ flags }}'.",
             unexpectedRedundantRegExp: "Regular expression literal is unnecessarily wrapped within a 'RegExp' constructor.",
             unexpectedRedundantRegExpWithFlags: "Use regular expression literal with flags instead of the 'RegExp' constructor."
         }
@@ -258,6 +260,8 @@ module.exports = {
             return Math.min(ecmaVersion, REGEXPP_LATEST_ECMA_VERSION);
         }
+        const regexppEcmaVersion = getRegexppEcmaVersion(context.languageOptions.ecmaVersion);
         /**
          * Makes a character escaped or else returns null.
          * @param {string} character The character to escape.
@@ -293,6 +297,83 @@ module.exports = {
             }
         }
+        /**
+         * Checks whether the given regex and flags are valid for the ecma version or not.
+         * @param {string} pattern The regex pattern to check.
+         * @param {string | undefined} flags The regex flags to check.
+         * @returns {boolean} True if the given regex pattern and flags are valid for the ecma version.
+         */
+        function isValidRegexForEcmaVersion(pattern, flags) {
+            const validator = new RegExpValidator({ ecmaVersion: regexppEcmaVersion });
+            try {
+                validator.validatePattern(pattern, 0, pattern.length, flags ? flags.includes("u") : false);
+                if (flags) {
+                    validator.validateFlags(flags);
+                }
+                return true;
+            } catch {
+                return false;
+            }
+        }
+        /**
+         * Checks whether two given regex flags contain the same flags or not.
+         * @param {string} flagsA The regex flags.
+         * @param {string} flagsB The regex flags.
+         * @returns {boolean} True if two regex flags contain same flags.
+         */
+        function areFlagsEqual(flagsA, flagsB) {
+            return [...flagsA].sort().join("") === [...flagsB].sort().join("");
+        }
+        /**
+         * Merges two regex flags.
+         * @param {string} flagsA The regex flags.
+         * @param {string} flagsB The regex flags.
+         * @returns {string} The merged regex flags.
+         */
+        function mergeRegexFlags(flagsA, flagsB) {
+            const flagsSet = new Set([
+                ...flagsA,
+                ...flagsB
+            ]);
+            return [...flagsSet].join("");
+        }
+        /**
+         * Checks whether a give node can be fixed to the given regex pattern and flags.
+         * @param {ASTNode} node The node to check.
+         * @param {string} pattern The regex pattern to check.
+         * @param {string} flags The regex flags
+         * @returns {boolean} True if a node can be fixed to the given regex pattern and flags.
+         */
+        function canFixTo(node, pattern, flags) {
+            const tokenBefore = sourceCode.getTokenBefore(node);
+            return sourceCode.getCommentsInside(node).length === 0 &&
+                (!tokenBefore || validPrecedingTokens.has(tokenBefore.value)) &&
+                isValidRegexForEcmaVersion(pattern, flags);
+        }
+        /**
+         * Returns a safe output code considering the before and after tokens.
+         * @param {ASTNode} node The regex node.
+         * @param {string} newRegExpValue The new regex expression value.
+         * @returns {string} The output code.
+         */
+        function getSafeOutput(node, newRegExpValue) {
+            const tokenBefore = sourceCode.getTokenBefore(node);
+            const tokenAfter = sourceCode.getTokenAfter(node);
+            return (tokenBefore && !canTokensBeAdjacent(tokenBefore, newRegExpValue) && tokenBefore.range[1] === node.range[0] ? " " : "") +
+                newRegExpValue +
+            (tokenAfter && !canTokensBeAdjacent(newRegExpValue, tokenAfter) && node.range[1] === tokenAfter.range[0] ? " " : "");
+        }
         return {
             Program() {
                 const scope = context.getScope();
@@ -306,10 +387,69 @@ module.exports = {
                 for (const { node } of tracker.iterateGlobalReferences(traceMap)) {
                     if (disallowRedundantWrapping && isUnnecessarilyWrappedRegexLiteral(node)) {
+                        const regexNode = node.arguments[0];
                         if (node.arguments.length === 2) {
-                            context.report({ node, messageId: "unexpectedRedundantRegExpWithFlags" });
+                            const suggests = [];
+                            const argFlags = getStringValue(node.arguments[1]) || "";
+                            if (canFixTo(node, regexNode.regex.pattern, argFlags)) {
+                                suggests.push({
+                                    messageId: "replaceWithLiteralAndFlags",
+                                    pattern: regexNode.regex.pattern,
+                                    flags: argFlags
+                                });
+                            }
+                            const literalFlags = regexNode.regex.flags || "";
+                            const mergedFlags = mergeRegexFlags(literalFlags, argFlags);
+                            if (
+                                !areFlagsEqual(mergedFlags, argFlags) &&
+                                canFixTo(node, regexNode.regex.pattern, mergedFlags)
+                            ) {
+                                suggests.push({
+                                    messageId: "replaceWithIntendedLiteralAndFlags",
+                                    pattern: regexNode.regex.pattern,
+                                    flags: mergedFlags
+                                });
+                            }
+                            context.report({
+                                node,
+                                messageId: "unexpectedRedundantRegExpWithFlags",
+                                suggest: suggests.map(({ flags, pattern, messageId }) => ({
+                                    messageId,
+                                    data: {
+                                        flags
+                                    },
+                                    fix(fixer) {
+                                        return fixer.replaceText(node, getSafeOutput(node, `/${pattern}/${flags}`));
+                                    }
+                                }))
+                            });
                         } else {
-                            context.report({ node, messageId: "unexpectedRedundantRegExp" });
+                            const outputs = [];
+                            if (canFixTo(node, regexNode.regex.pattern, regexNode.regex.flags)) {
+                                outputs.push(sourceCode.getText(regexNode));
+                            }
+                            context.report({
+                                node,
+                                messageId: "unexpectedRedundantRegExp",
+                                suggest: outputs.map(output => ({
+                                    messageId: "replaceWithLiteral",
+                                    fix(fixer) {
+                                        return fixer.replaceText(
+                                            node,
+                                            getSafeOutput(node, output)
+                                        );
+                                    }
+                                }))
+                            });
                         }
                     } else if (hasOnlyStaticStringArguments(node)) {
                         let regexContent = getStringValue(node.arguments[0]);
@@ -320,21 +460,7 @@ module.exports = {
                             flags = getStringValue(node.arguments[1]);
                         }
-                        const regexppEcmaVersion = getRegexppEcmaVersion(context.languageOptions.ecmaVersion);
-                        const RegExpValidatorInstance = new RegExpValidator({ ecmaVersion: regexppEcmaVersion });
-                        try {
-                            RegExpValidatorInstance.validatePattern(regexContent, 0, regexContent.length, flags ? flags.includes("u") : false);
-                            if (flags) {
-                                RegExpValidatorInstance.validateFlags(flags);
-                            }
-                        } catch {
-                            noFix = true;
-                        }
-                        const tokenBefore = sourceCode.getTokenBefore(node);
-                        if (tokenBefore && !validPrecedingTokens.has(tokenBefore.value)) {
+                        if (!canFixTo(node, regexContent, flags)) {
                             noFix = true;
                         }
@@ -342,10 +468,6 @@ module.exports = {
                             noFix = true;
                         }
-                        if (sourceCode.getCommentsInside(node).length > 0) {
-                            noFix = true;
-                        }
                         if (regexContent && !noFix) {
                             let charIncrease = 0;
@@ -377,14 +499,7 @@ module.exports = {
                             suggest: noFix ? [] : [{
                                 messageId: "replaceWithLiteral",
                                 fix(fixer) {
-                                    const tokenAfter = sourceCode.getTokenAfter(node);
-                                    return fixer.replaceText(
-                                        node,
-                                        (tokenBefore && !canTokensBeAdjacent(tokenBefore, newRegExpValue) && tokenBefore.range[1] === node.range[0] ? " " : "") +
-                                            newRegExpValue +
-                                            (tokenAfter && !canTokensBeAdjacent(newRegExpValue, tokenAfter) && node.range[1] === tokenAfter.range[0] ? " " : "")
-                                    );
+                                    return fixer.replaceText(node, getSafeOutput(node, newRegExpValue));
                                 }
                             }]
                         });

package/lib/shared/directives.js ADDED Viewed

@@ -0,0 +1,15 @@
+/**
+ * @fileoverview Common utils for directives.
+ *
+ * This file contains only shared items for directives.
+ * If you make a utility for rules, please see `../rules/utils/ast-utils.js`.
+ *
+ * @author gfyoung <https://github.com/gfyoung>
+ */
+"use strict";
+const directivesPattern = /^(eslint(?:-env|-enable|-disable(?:(?:-next)?-line)?)?|exported|globals?)(?:\s|$)/u;
+module.exports = {
+    directivesPattern
+};

package/messages/print-config-with-directory-path.js CHANGED Viewed

@@ -3,6 +3,6 @@
 module.exports = function() {
     return `
 The '--print-config' CLI option requires a path to a source code file rather than a directory.
-See also: https://eslint.org/docs/user-guide/command-line-interface#--print-config
+See also: https://eslint.org/docs/latest/use/command-line-interface#--print-config
 `.trimStart();
 };

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "8.30.0",
+  "version": "8.32.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "bin": {
@@ -14,17 +14,18 @@
   },
   "scripts": {
     "build:docs:update-links": "node tools/fetch-docs-links.js",
-    "release:generate:latest": "node Makefile.js generateRelease",
-    "release:generate:alpha": "node Makefile.js generatePrerelease -- alpha",
-    "release:generate:beta": "node Makefile.js generatePrerelease -- beta",
-    "release:publish": "node Makefile.js publishRelease",
-    "release:generate:rc": "node Makefile.js generatePrerelease -- rc",
     "build:site": "node Makefile.js gensite",
     "build:webpack": "node Makefile.js webpack",
+    "build:readme": "node tools/update-readme.js",
     "lint": "node Makefile.js lint",
-    "lint:fix": "node Makefile.js lint -- fix",
     "lint:docs:js": "node Makefile.js lintDocsJS",
+    "lint:fix": "node Makefile.js lint -- fix",
     "lint:fix:docs:js": "node Makefile.js lintDocsJS -- fix",
+    "release:generate:alpha": "node Makefile.js generatePrerelease -- alpha",
+    "release:generate:beta": "node Makefile.js generatePrerelease -- beta",
+    "release:generate:latest": "node Makefile.js generateRelease",
+    "release:generate:rc": "node Makefile.js generatePrerelease -- rc",
+    "release:publish": "node Makefile.js publishRelease",
     "test": "node Makefile.js test",
     "test:cli": "mocha",
     "test:fuzz": "node Makefile.js fuzz",
@@ -55,7 +56,7 @@
   "homepage": "https://eslint.org",
   "bugs": "https://github.com/eslint/eslint/issues/",
   "dependencies": {
-    "@eslint/eslintrc": "^1.4.0",
+    "@eslint/eslintrc": "^1.4.1",
     "@humanwhocodes/config-array": "^0.11.8",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@nodelib/fs.walk": "^1.2.8",