eslint 8.21.0 → 8.23.1

package/lib/eslint/flat-eslint.js

@@ -30,6 +30,7 @@ const {
 const {
     fileExists,
     findFiles,
+    getCacheFile,
 
     isNonEmptyString,
     isArrayOfNonEmptyString,
@@ -41,6 +42,7 @@ const {
 } = require("./eslint-helpers");
 const { pathToFileURL } = require("url");
 const { FlatConfigArray } = require("../config/flat-config-array");
+const LintResultCache = require("../cli-engine/lint-result-cache");
 
 /*
  * This is necessary to allow overwriting writeFile for testing purposes.
@@ -71,7 +73,6 @@ const { FlatConfigArray } = require("../config/flat-config-array");
  * @property {"metadata" | "content"} [cacheStrategy] The strategy used to detect changed files.
  * @property {string} [cwd] The value to use for the current working directory.
  * @property {boolean} [errorOnUnmatchedPattern] If `false` then `ESLint#lintFiles()` doesn't throw even if no target files found. Defaults to `true`.
- * @property {string[]} [extensions] An array of file extensions to check.
  * @property {boolean|Function} [fix] Execute in autofix mode. If a function, should return a boolean.
  * @property {string[]} [fixTypes] Array of rule types to apply fixes for.
  * @property {boolean} [globInputPaths] Set to false to skip glob resolution of input file paths to lint (default: true). If false, each input file paths is assumed to be a non-glob path to an existing file.
@@ -319,8 +320,7 @@ async function calculateConfigArray(eslint, {
     configFile,
     ignore: shouldIgnore,
     ignorePath,
-    ignorePatterns,
-    extensions
+    ignorePatterns
 }) {
 
     // check for cached instance
@@ -363,13 +363,6 @@ async function calculateConfigArray(eslint, {
     // add in any configured defaults
     configs.push(...slots.defaultConfigs);
 
-    // if there are any extensions, create configs for them for easier matching
-    if (extensions && extensions.length) {
-        configs.push({
-            files: extensions.map(ext => `**/*${ext}`)
-        });
-    }
-
     let allIgnorePatterns = [];
     let ignoreFilePath;
 
@@ -513,6 +506,7 @@ function verifyText({
     const result = {
         filePath: filePath === "<text>" ? filePath : path.resolve(filePath),
         messages,
+        suppressedMessages: linter.getSuppressedMessages(),
         ...calculateStatsPerFile(messages)
     };
 
@@ -606,9 +600,20 @@ class FlatESLint {
             configType: "flat"
         });
 
+        const cacheFilePath = getCacheFile(
+            processedOptions.cacheLocation,
+            processedOptions.cwd
+        );
+
+        const lintResultCache = processedOptions.cache
+            ? new LintResultCache(cacheFilePath, processedOptions.cacheStrategy)
+            : null;
+
         privateMembers.set(this, {
             options: processedOptions,
             linter,
+            cacheFilePath,
+            lintResultCache,
             defaultConfigs,
             defaultIgnores: () => false,
             configs: null
@@ -676,11 +681,13 @@ class FlatESLint {
 
         results.forEach(result => {
             const filteredMessages = result.messages.filter(isErrorMessage);
+            const filteredSuppressedMessages = result.suppressedMessages.filter(isErrorMessage);
 
             if (filteredMessages.length > 0) {
                 filtered.push({
                     ...result,
                     messages: filteredMessages,
+                    suppressedMessages: filteredSuppressedMessages,
                     errorCount: filteredMessages.length,
                     warningCount: 0,
                     fixableErrorCount: result.fixableErrorCount,
@@ -733,11 +740,12 @@ class FlatESLint {
              * calculated config for the given file.
              */
             const config = configs.getConfig(filePath);
+            const allMessages = result.messages.concat(result.suppressedMessages);
 
-            for (const { ruleId } of result.messages) {
+            for (const { ruleId } of allMessages) {
                 const rule = getRuleFromConfig(ruleId, config);
 
-                // ensure the rule exists exists
+                // ensure the rule exists
                 if (!rule) {
                     throw new TypeError(`Could not find the rule "${ruleId}".`);
                 }
@@ -773,8 +781,8 @@ class FlatESLint {
             fix,
             fixTypes,
             reportUnusedDisableDirectives,
-            extensions,
-            globInputPaths
+            globInputPaths,
+            errorOnUnmatchedPattern
         } = eslintOptions;
         const startTime = Date.now();
         const usedConfigs = [];
@@ -782,6 +790,8 @@ class FlatESLint {
 
         // Delete cache file; should this be done here?
         if (!cache && cacheFilePath) {
+            debug(`Deleting cache file at ${cacheFilePath}`);
+
             try {
                 await fs.unlink(cacheFilePath);
             } catch (error) {
@@ -797,9 +807,9 @@ class FlatESLint {
         const filePaths = await findFiles({
             patterns: typeof patterns === "string" ? [patterns] : patterns,
             cwd,
-            extensions,
             globInputPaths,
-            configs
+            configs,
+            errorOnUnmatchedPattern
         });
 
         debug(`${filePaths.length} files found in: ${Date.now() - startTime}ms`);
@@ -1112,6 +1122,7 @@ class FlatESLint {
                 results.sort(compareResultsByFilePath);
 
                 return formatter(results, {
+                    cwd,
                     get rulesMeta() {
                         if (!rulesMeta) {
                             rulesMeta = eslint.getRulesMetaForResults(results);
@@ -1160,5 +1171,6 @@ class FlatESLint {
 //------------------------------------------------------------------------------
 
 module.exports = {
-    FlatESLint
+    FlatESLint,
+    findFlatConfigFile
 };

package/lib/linter/code-path-analysis/code-path-segment.js

@@ -88,10 +88,10 @@ class CodePathSegment {
             }
         });
 
-        /* istanbul ignore if */
+        /* c8 ignore start */
         if (debug.enabled) {
             this.internal.nodes = [];
-        }
+        }/* c8 ignore stop */
     }
 
     /**

package/lib/linter/code-path-analysis/code-path-state.js

@@ -59,7 +59,7 @@ function getContinueContext(state, label) {
         context = context.upper;
     }
 
-    /* istanbul ignore next: foolproof (syntax error) */
+    /* c8 ignore next */
     return null;
 }
 
@@ -79,7 +79,7 @@ function getBreakContext(state, label) {
         context = context.upper;
     }
 
-    /* istanbul ignore next: foolproof (syntax error) */
+    /* c8 ignore next */
     return null;
 }
 
@@ -433,7 +433,7 @@ class CodePathState {
                  */
                 return context;
 
-            /* istanbul ignore next */
+            /* c8 ignore next */
             default:
                 throw new Error("unreachable");
         }
@@ -1030,7 +1030,7 @@ class CodePathState {
                 };
                 break;
 
-            /* istanbul ignore next */
+            /* c8 ignore next */
             default:
                 throw new Error(`unknown type: "${type}"`);
         }
@@ -1095,7 +1095,7 @@ class CodePathState {
                 );
                 break;
 
-            /* istanbul ignore next */
+            /* c8 ignore next */
             default:
                 throw new Error("unreachable");
         }
@@ -1392,11 +1392,12 @@ class CodePathState {
 
         const context = getBreakContext(this, label);
 
-        /* istanbul ignore else: foolproof (syntax error) */
+
         if (context) {
             context.brokenForkContext.add(forkContext.head);
         }
 
+        /* c8 ignore next */
         forkContext.replaceHead(forkContext.makeUnreachable(-1, -1));
     }
 
@@ -1417,7 +1418,6 @@ class CodePathState {
 
         const context = getContinueContext(this, label);
 
-        /* istanbul ignore else: foolproof (syntax error) */
         if (context) {
             if (context.continueDestSegments) {
                 makeLooped(this, forkContext.head, context.continueDestSegments);

package/lib/linter/code-path-analysis/debug-helpers.js

@@ -20,7 +20,7 @@ const debug = require("debug")("eslint:code-path");
  * @param {CodePathSegment} segment A segment to get.
  * @returns {string} Id of the segment.
  */
-/* istanbul ignore next */
+/* c8 ignore next */
 function getId(segment) { // eslint-disable-line jsdoc/require-jsdoc -- Ignoring
     return segment.id + (segment.reachable ? "" : "!");
 }
@@ -67,7 +67,7 @@ module.exports = {
      * @param {boolean} leaving A flag whether or not it's leaving
      * @returns {void}
      */
-    dumpState: !debug.enabled ? debug : /* istanbul ignore next */ function(node, state, leaving) {
+    dumpState: !debug.enabled ? debug : /* c8 ignore next */ function(node, state, leaving) {
         for (let i = 0; i < state.currentSegments.length; ++i) {
             const segInternal = state.currentSegments[i].internal;
 
@@ -98,7 +98,7 @@ module.exports = {
      * @see http://www.graphviz.org
      * @see http://www.webgraphviz.com
      */
-    dumpDot: !debug.enabled ? debug : /* istanbul ignore next */ function(codePath) {
+    dumpDot: !debug.enabled ? debug : /* c8 ignore next */ function(codePath) {
         let text =
             "\n" +
             "digraph {\n" +

package/lib/linter/code-path-analysis/id-generator.js

@@ -33,10 +33,10 @@ class IdGenerator {
     next() {
         this.n = 1 + this.n | 0;
 
-        /* istanbul ignore if */
+        /* c8 ignore start */
         if (this.n < 0) {
             this.n = 1;
-        }
+        }/* c8 ignore stop */
 
         return this.prefix + this.n;
     }

package/lib/linter/config-comment-parser.js

@@ -131,8 +131,7 @@ module.exports = class ConfigCommentParser {
 
         const items = {};
 
-        // Collapse whitespace around commas
-        string.replace(/\s*,\s*/gu, ",").split(/,+/u).forEach(name => {
+        string.split(",").forEach(name => {
             const trimmedName = name.trim();
 
             if (trimmedName) {

package/lib/linter/timing.js

@@ -9,7 +9,7 @@
 // Helpers
 //------------------------------------------------------------------------------
 
-/* istanbul ignore next */
+/* c8 ignore next */
 /**
  * Align the string to left
  * @param {string} str string to evaluate
@@ -22,7 +22,7 @@ function alignLeft(str, len, ch) {
     return str + new Array(len - str.length + 1).join(ch || " ");
 }
 
-/* istanbul ignore next */
+/* c8 ignore next */
 /**
  * Align the string to right
  * @param {string} str string to evaluate
@@ -64,7 +64,7 @@ function getListSize() {
     return TIMING_ENV_VAR_AS_INTEGER > 10 ? TIMING_ENV_VAR_AS_INTEGER : MINIMUM_SIZE;
 }
 
-/* istanbul ignore next */
+/* c8 ignore next */
 /**
  * display the data
  * @param {Object} data Data object to be displayed
@@ -119,7 +119,7 @@ function display(data) {
     console.log(table.join("\n")); // eslint-disable-line no-console -- Debugging function
 }
 
-/* istanbul ignore next */
+/* c8 ignore next */
 module.exports = (function() {
 
     const data = Object.create(null);