eslint 8.16.0 → 8.19.0

package/lib/rules/indent.js

@@ -500,7 +500,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce consistent indentation",
+            description: "Enforce consistent indentation",
             recommended: false,
             url: "https://eslint.org/docs/rules/indent"
         },
@@ -916,18 +916,6 @@ module.exports = {
                 }
 
                 offsets.setDesiredOffsets([firstBodyToken.range[0], lastBodyToken.range[1]], lastParentToken, 1);
-
-                /*
-                 * For blockless nodes with semicolon-first style, don't indent the semicolon.
-                 * e.g.
-                 * if (foo) bar()
-                 * ; [1, 2, 3].map(foo)
-                 */
-                const lastToken = sourceCode.getLastToken(node);
-
-                if (node.type !== "EmptyStatement" && astUtils.isSemicolonToken(lastToken)) {
-                    offsets.setDesiredOffset(lastToken, lastParentToken, 0);
-                }
             }
         }
 
@@ -1223,7 +1211,7 @@ module.exports = {
                 }
             },
 
-            "DoWhileStatement, WhileStatement, ForInStatement, ForOfStatement": node => addBlocklessNodeIndent(node.body),
+            "DoWhileStatement, WhileStatement, ForInStatement, ForOfStatement, WithStatement": node => addBlocklessNodeIndent(node.body),
 
             ExportNamedDeclaration(node) {
                 if (node.declaration === null) {
@@ -1271,6 +1259,50 @@ module.exports = {
                 }
             },
 
+            /*
+             * For blockless nodes with semicolon-first style, don't indent the semicolon.
+             * e.g.
+             * if (foo)
+             *     bar()
+             * ; [1, 2, 3].map(foo)
+             *
+             * Traversal into the node sets indentation of the semicolon, so we need to override it on exit.
+             */
+            ":matches(DoWhileStatement, ForStatement, ForInStatement, ForOfStatement, IfStatement, WhileStatement, WithStatement):exit"(node) {
+                let nodesToCheck;
+
+                if (node.type === "IfStatement") {
+                    nodesToCheck = [node.consequent];
+                    if (node.alternate) {
+                        nodesToCheck.push(node.alternate);
+                    }
+                } else {
+                    nodesToCheck = [node.body];
+                }
+
+                for (const nodeToCheck of nodesToCheck) {
+                    const lastToken = sourceCode.getLastToken(nodeToCheck);
+
+                    if (astUtils.isSemicolonToken(lastToken)) {
+                        const tokenBeforeLast = sourceCode.getTokenBefore(lastToken);
+                        const tokenAfterLast = sourceCode.getTokenAfter(lastToken);
+
+                        // override indentation of `;` only if its line looks like a semicolon-first style line
+                        if (
+                            !astUtils.isTokenOnSameLine(tokenBeforeLast, lastToken) &&
+                            tokenAfterLast &&
+                            astUtils.isTokenOnSameLine(lastToken, tokenAfterLast)
+                        ) {
+                            offsets.setDesiredOffset(
+                                lastToken,
+                                sourceCode.getFirstToken(node),
+                                0
+                            );
+                        }
+                    }
+                }
+            },
+
             ImportDeclaration(node) {
                 if (node.specifiers.some(specifier => specifier.type === "ImportSpecifier")) {
                     const openingCurly = sourceCode.getFirstToken(node, astUtils.isOpeningBraceToken);

package/lib/rules/init-declarations.js

@@ -48,7 +48,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "require or disallow initialization in variable declarations",
+            description: "Require or disallow initialization in variable declarations",
             recommended: false,
             url: "https://eslint.org/docs/rules/init-declarations"
         },

package/lib/rules/jsx-quotes.js

@@ -42,7 +42,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce the consistent use of either double or single quotes in JSX attributes",
+            description: "Enforce the consistent use of either double or single quotes in JSX attributes",
             recommended: false,
             url: "https://eslint.org/docs/rules/jsx-quotes"
         },

package/lib/rules/key-spacing.js

@@ -139,7 +139,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce consistent spacing between keys and values in object literal properties",
+            description: "Enforce consistent spacing between keys and values in object literal properties",
             recommended: false,
             url: "https://eslint.org/docs/rules/key-spacing"
         },

package/lib/rules/keyword-spacing.js

@@ -67,7 +67,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce consistent spacing before and after keywords",
+            description: "Enforce consistent spacing before and after keywords",
             recommended: false,
             url: "https://eslint.org/docs/rules/keyword-spacing"
         },

package/lib/rules/line-comment-position.js

@@ -16,7 +16,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce position of line comments",
+            description: "Enforce position of line comments",
             recommended: false,
             url: "https://eslint.org/docs/rules/line-comment-position"
         },

package/lib/rules/linebreak-style.js

@@ -21,7 +21,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce consistent linebreak style",
+            description: "Enforce consistent linebreak style",
             recommended: false,
             url: "https://eslint.org/docs/rules/linebreak-style"
         },

package/lib/rules/lines-around-comment.js

@@ -55,7 +55,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "require empty lines around comments",
+            description: "Require empty lines around comments",
             recommended: false,
             url: "https://eslint.org/docs/rules/lines-around-comment"
         },

package/lib/rules/lines-around-directive.js

@@ -18,7 +18,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "require or disallow newlines around directives",
+            description: "Require or disallow newlines around directives",
             recommended: false,
             url: "https://eslint.org/docs/rules/lines-around-directive"
         },

package/lib/rules/lines-between-class-members.js

@@ -20,7 +20,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "require or disallow an empty line between class members",
+            description: "Require or disallow an empty line between class members",
             recommended: false,
             url: "https://eslint.org/docs/rules/lines-between-class-members"
         },

package/lib/rules/max-classes-per-file.js

@@ -19,7 +19,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a maximum number of classes per file",
+            description: "Enforce a maximum number of classes per file",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-classes-per-file"
         },

package/lib/rules/max-depth.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a maximum depth that blocks can be nested",
+            description: "Enforce a maximum depth that blocks can be nested",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-depth"
         },

package/lib/rules/max-len.js

@@ -69,7 +69,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce a maximum line length",
+            description: "Enforce a maximum line length",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-len"
         },

package/lib/rules/max-lines-per-function.js

@@ -71,7 +71,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a maximum number of lines of code in a function",
+            description: "Enforce a maximum number of lines of code in a function",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-lines-per-function"
         },

package/lib/rules/max-lines.js

@@ -34,7 +34,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a maximum number of lines per file",
+            description: "Enforce a maximum number of lines per file",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-lines"
         },

package/lib/rules/max-nested-callbacks.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a maximum depth that callbacks can be nested",
+            description: "Enforce a maximum depth that callbacks can be nested",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-nested-callbacks"
         },

package/lib/rules/max-params.js

@@ -22,7 +22,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a maximum number of parameters in function definitions",
+            description: "Enforce a maximum number of parameters in function definitions",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-params"
         },

package/lib/rules/max-statements-per-line.js

@@ -20,7 +20,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce a maximum number of statements allowed per line",
+            description: "Enforce a maximum number of statements allowed per line",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-statements-per-line"
         },

package/lib/rules/max-statements.js

@@ -22,7 +22,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a maximum number of statements allowed in function blocks",
+            description: "Enforce a maximum number of statements allowed in function blocks",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-statements"
         },
@@ -126,7 +126,7 @@ module.exports = {
 
             /*
              * This rule does not apply to class static blocks, but we have to track them so
-             * that stataments in them do not count as statements in the enclosing function.
+             * that statements in them do not count as statements in the enclosing function.
              */
             if (node.type === "StaticBlock") {
                 return;

package/lib/rules/multiline-comment-style.js

@@ -16,7 +16,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "enforce a particular style for multiline comments",
+            description: "Enforce a particular style for multiline comments",
             recommended: false,
             url: "https://eslint.org/docs/rules/multiline-comment-style"
         },

package/lib/rules/multiline-ternary.js

@@ -17,7 +17,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce newlines between operands of ternary expressions",
+            description: "Enforce newlines between operands of ternary expressions",
             recommended: false,
             url: "https://eslint.org/docs/rules/multiline-ternary"
         },

package/lib/rules/new-cap.js

@@ -82,7 +82,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "require constructor names to begin with a capital letter",
+            description: "Require constructor names to begin with a capital letter",
             recommended: false,
             url: "https://eslint.org/docs/rules/new-cap"
         },

package/lib/rules/new-parens.js

@@ -25,7 +25,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "enforce or disallow parentheses when invoking a constructor with no arguments",
+            description: "Enforce or disallow parentheses when invoking a constructor with no arguments",
             recommended: false,
             url: "https://eslint.org/docs/rules/new-parens"
         },

package/lib/rules/newline-after-var.js

@@ -22,7 +22,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "require or disallow an empty line after variable declarations",
+            description: "Require or disallow an empty line after variable declarations",
             recommended: false,
             url: "https://eslint.org/docs/rules/newline-after-var"
         },

package/lib/rules/newline-before-return.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "require an empty line before `return` statements",
+            description: "Require an empty line before `return` statements",
             recommended: false,
             url: "https://eslint.org/docs/rules/newline-before-return"
         },

package/lib/rules/newline-per-chained-call.js

@@ -18,7 +18,7 @@ module.exports = {
         type: "layout",
 
         docs: {
-            description: "require a newline after each call in a method chain",
+            description: "Require a newline after each call in a method chain",
             recommended: false,
             url: "https://eslint.org/docs/rules/newline-per-chained-call"
         },

package/lib/rules/no-alert.js

@@ -88,7 +88,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow the use of `alert`, `confirm`, and `prompt`",
+            description: "Disallow the use of `alert`, `confirm`, and `prompt`",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-alert"
         },

package/lib/rules/no-array-constructor.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow `Array` constructors",
+            description: "Disallow `Array` constructors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-array-constructor"
         },

package/lib/rules/no-async-promise-executor.js

@@ -14,7 +14,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow using an async function as a Promise executor",
+            description: "Disallow using an async function as a Promise executor",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-async-promise-executor"
         },

package/lib/rules/no-await-in-loop.js

@@ -59,7 +59,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow `await` inside of loops",
+            description: "Disallow `await` inside of loops",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-await-in-loop"
         },

package/lib/rules/no-bitwise.js

@@ -26,7 +26,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow bitwise operators",
+            description: "Disallow bitwise operators",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-bitwise"
         },

package/lib/rules/no-buffer-constructor.js

@@ -19,7 +19,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow use of the `Buffer()` constructor",
+            description: "Disallow use of the `Buffer()` constructor",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-buffer-constructor"
         },

package/lib/rules/no-caller.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow the use of `arguments.caller` or `arguments.callee`",
+            description: "Disallow the use of `arguments.caller` or `arguments.callee`",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-caller"
         },

package/lib/rules/no-case-declarations.js

@@ -14,7 +14,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow lexical declarations in case clauses",
+            description: "Disallow lexical declarations in case clauses",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-case-declarations"
         },

package/lib/rules/no-catch-shadow.js

@@ -22,7 +22,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow `catch` clause parameters from shadowing variables in the outer scope",
+            description: "Disallow `catch` clause parameters from shadowing variables in the outer scope",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-catch-shadow"
         },

package/lib/rules/no-class-assign.js

@@ -17,7 +17,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow reassigning class members",
+            description: "Disallow reassigning class members",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-class-assign"
         },

package/lib/rules/no-compare-neg-zero.js

@@ -14,7 +14,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow comparing against -0",
+            description: "Disallow comparing against -0",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-compare-neg-zero"
         },

package/lib/rules/no-cond-assign.js

@@ -34,7 +34,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow assignment operators in conditional expressions",
+            description: "Disallow assignment operators in conditional expressions",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-cond-assign"
         },

package/lib/rules/no-confusing-arrow.js

@@ -31,7 +31,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow arrow functions where they could be confused with comparisons",
+            description: "Disallow arrow functions where they could be confused with comparisons",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-confusing-arrow"
         },

package/lib/rules/no-console.js

@@ -21,7 +21,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow the use of `console`",
+            description: "Disallow the use of `console`",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-console"
         },

package/lib/rules/no-const-assign.js

@@ -17,7 +17,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow reassigning `const` variables",
+            description: "Disallow reassigning `const` variables",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-const-assign"
         },

package/lib/rules/no-constant-binary-expression.js

@@ -120,7 +120,7 @@ function isStaticBoolean(scope, node) {
 
 /**
  * Test if an AST node will always give the same result when compared to a
- * bolean value. Note that comparison to boolean values is different than
+ * boolean value. Note that comparison to boolean values is different than
  * truthiness.
  * https://262.ecma-international.org/5.1/#sec-11.9.3
  *
@@ -238,7 +238,7 @@ function hasConstantLooseBooleanComparison(scope, node) {
 
 /**
  * Test if an AST node will always give the same result when _strictly_ compared
- * to a bolean value. This can happen if the expression can never be boolean, or
+ * to a boolean value. This can happen if the expression can never be boolean, or
  * if it is always the same boolean value.
  * @param {Scope} scope The scope in which the node was found.
  * @param {ASTNode} node The node to test
@@ -432,7 +432,7 @@ module.exports = {
     meta: {
         type: "problem",
         docs: {
-            description: "disallow expressions where the operation doesn't affect the value",
+            description: "Disallow expressions where the operation doesn't affect the value",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-constant-binary-expression"
         },
@@ -488,7 +488,7 @@ module.exports = {
             }
 
             /*
-             * In theory we could handle short circuting assignment operators,
+             * In theory we could handle short-circuiting assignment operators,
              * for some constant values, but that would require walking the
              * scope to find the value of the variable being assigned. This is
              * dependant on https://github.com/eslint/eslint/issues/13776

package/lib/rules/no-constant-condition.js

@@ -21,7 +21,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow constant expressions in conditions",
+            description: "Disallow constant expressions in conditions",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-constant-condition"
         },

package/lib/rules/no-constructor-return.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow returning value from constructor",
+            description: "Disallow returning value from constructor",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-constructor-return"
         },

package/lib/rules/no-continue.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow `continue` statements",
+            description: "Disallow `continue` statements",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-continue"
         },

package/lib/rules/no-control-regex.js

@@ -54,7 +54,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow control characters in regular expressions",
+            description: "Disallow control characters in regular expressions",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-control-regex"
         },

package/lib/rules/no-debugger.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow the use of `debugger`",
+            description: "Disallow the use of `debugger`",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-debugger"
         },

package/lib/rules/no-delete-var.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow deleting variables",
+            description: "Disallow deleting variables",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-delete-var"
         },

package/lib/rules/no-div-regex.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "disallow division operators explicitly at the beginning of regular expressions",
+            description: "Disallow division operators explicitly at the beginning of regular expressions",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-div-regex"
         },

package/lib/rules/no-dupe-args.js

@@ -15,7 +15,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow duplicate arguments in `function` definitions",
+            description: "Disallow duplicate arguments in `function` definitions",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-dupe-args"
         },

package/lib/rules/no-dupe-class-members.js

@@ -17,7 +17,7 @@ module.exports = {
         type: "problem",
 
         docs: {
-            description: "disallow duplicate class members",
+            description: "Disallow duplicate class members",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-dupe-class-members"
         },