eslint 5.7.0 → 5.11.0

package/lib/rules/newline-before-return.js

@@ -11,16 +11,19 @@
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "require an empty line before `return` statements",
             category: "Stylistic Issues",
             recommended: false,
-            replacedBy: ["padding-line-between-statements"],
             url: "https://eslint.org/docs/rules/newline-before-return"
         },
+
         fixable: "whitespace",
         schema: [],
-        deprecated: true
+        deprecated: true,
+        replacedBy: ["padding-line-between-statements"]
     },
 
     create(context) {
@@ -33,7 +36,7 @@ module.exports = {
         /**
          * Tests whether node is preceded by supplied tokens
          * @param {ASTNode} node - node to check
-         * @param {array} testTokens - array of tokens to test against
+         * @param {Array} testTokens - array of tokens to test against
          * @returns {boolean} Whether or not the node is preceded by one of the supplied tokens
          * @private
          */

package/lib/rules/newline-per-chained-call.js

@@ -14,13 +14,17 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "require a newline after each call in a method chain",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/newline-per-chained-call"
         },
+
         fixable: "whitespace",
+
         schema: [{
             type: "object",
             properties: {

package/lib/rules/no-alert.js

@@ -74,6 +74,8 @@ function isGlobalThisReferenceOrGlobalWindow(scope, node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `alert`, `confirm`, and `prompt`",
             category: "Best Practices",

package/lib/rules/no-array-constructor.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `Array` constructors",
             category: "Stylistic Issues",

package/lib/rules/no-async-promise-executor.js

@@ -10,12 +10,15 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow using an async function as a Promise executor",
             category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-async-promise-executor"
         },
+
         fixable: null,
         schema: []
     },

package/lib/rules/no-await-in-loop.js

@@ -55,13 +55,17 @@ function isLooped(node, parent) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow `await` inside of loops",
             category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-await-in-loop"
         },
+
         schema: [],
+
         messages: {
             unexpectedAwait: "Unexpected `await` inside a loop."
         }

package/lib/rules/no-bitwise.js

@@ -22,6 +22,8 @@ const BITWISE_OPERATORS = [
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow bitwise operators",
             category: "Stylistic Issues",

package/lib/rules/no-buffer-constructor.js

@@ -10,13 +10,17 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow use of the `Buffer()` constructor",
             category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-buffer-constructor"
         },
+
         schema: [],
+
         messages: {
             deprecated: "{{expr}} is deprecated. Use Buffer.from(), Buffer.alloc(), or Buffer.allocUnsafe() instead."
         }

package/lib/rules/no-caller.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `arguments.caller` or `arguments.callee`",
             category: "Best Practices",

package/lib/rules/no-case-declarations.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow lexical declarations in case clauses",
             category: "Best Practices",

package/lib/rules/no-catch-shadow.js

@@ -18,15 +18,18 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `catch` clause parameters from shadowing variables in the outer scope",
             category: "Variables",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-catch-shadow",
-            replacedBy: ["no-shadow"]
+            url: "https://eslint.org/docs/rules/no-catch-shadow"
         },
-        deprecated: true,
 
+        replacedBy: ["no-shadow"],
+
+        deprecated: true,
         schema: [],
 
         messages: {

package/lib/rules/no-class-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning class members",
             category: "ECMAScript 6",

package/lib/rules/no-compare-neg-zero.js

@@ -10,14 +10,18 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow comparing against -0",
             category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-compare-neg-zero"
         },
+
         fixable: null,
         schema: [],
+
         messages: {
             unexpected: "Do not use the '{{operator}}' operator to compare against -0."
         }

package/lib/rules/no-cond-assign.js

@@ -19,6 +19,8 @@ const NODE_DESCRIPTIONS = {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow assignment operators in conditional expressions",
             category: "Possible Errors",

package/lib/rules/no-confusing-arrow.js

@@ -27,6 +27,8 @@ function isConditional(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow arrow functions where they could be confused with comparisons",
             category: "ECMAScript 6",

package/lib/rules/no-console.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `console`",
             category: "Possible Errors",

package/lib/rules/no-const-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning `const` variables",
             category: "ECMAScript 6",

package/lib/rules/no-constant-condition.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow constant expressions in conditions",
             category: "Possible Errors",
@@ -171,7 +173,6 @@ module.exports = {
 
         /**
          * Reports when the set still contains stored constant conditions
-         * @param {ASTNode} node The AST node to check.
          * @returns {void}
          * @private
          */

package/lib/rules/no-continue.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `continue` statements",
             category: "Stylistic Issues",

package/lib/rules/no-control-regex.js

@@ -6,7 +6,7 @@
 "use strict";
 
 const RegExpValidator = require("regexpp").RegExpValidator;
-const collector = new class {
+const collector = new (class {
     constructor() {
         this.ecmaVersion = 2018;
         this._source = "";
@@ -41,7 +41,7 @@ const collector = new class {
         }
         return this._controlChars;
     }
-}();
+})();
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -49,6 +49,8 @@ const collector = new class {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow control characters in regular expressions",
             category: "Possible Errors",

package/lib/rules/no-debugger.js

@@ -11,14 +11,18 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow the use of `debugger`",
             category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-debugger"
         },
+
         fixable: null,
         schema: [],
+
         messages: {
             unexpected: "Unexpected 'debugger' statement."
         }

package/lib/rules/no-delete-var.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow deleting variables",
             category: "Variables",

package/lib/rules/no-div-regex.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow division operators explicitly at the beginning of regular expressions",
             category: "Best Practices",

package/lib/rules/no-dupe-args.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate arguments in `function` definitions",
             category: "Possible Errors",

package/lib/rules/no-dupe-class-members.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate class members",
             category: "ECMAScript 6",

package/lib/rules/no-dupe-keys.js

@@ -84,6 +84,8 @@ class ObjectInfo {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate keys in object literals",
             category: "Possible Errors",

package/lib/rules/no-duplicate-case.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate case labels",
             category: "Possible Errors",

package/lib/rules/no-duplicate-imports.js

@@ -101,6 +101,8 @@ function handleExports(context, importsInFile, exportsInFile) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate module imports",
             category: "ECMAScript 6",

package/lib/rules/no-else-return.js

@@ -18,6 +18,8 @@ const FixTracker = require("../util/fix-tracker");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `else` blocks after `return` statements in `if` statements",
             category: "Best Practices",
@@ -181,7 +183,6 @@ module.exports = {
          * code paths.
          *
          * @param {Node} node The consequent or body node
-         * @param {Node} alternate The alternate node
          * @returns {boolean} `true` if it is a Return/If node that always returns.
          */
         function checkForReturnOrIf(node) {

package/lib/rules/no-empty-character-class.js

@@ -29,6 +29,8 @@ const regex = /^\/([^\\[]|\\.|\[([^\\\]]|\\.)+])*\/[gimuys]*$/;
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow empty character classes in regular expressions",
             category: "Possible Errors",

package/lib/rules/no-empty-function.js

@@ -90,6 +90,8 @@ function getKind(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow empty functions",
             category: "Best Practices",

package/lib/rules/no-empty-pattern.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow empty destructuring patterns",
             category: "Best Practices",

package/lib/rules/no-empty.js

@@ -16,6 +16,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow empty block statements",
             category: "Possible Errors",

package/lib/rules/no-eq-null.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `null` comparisons without type-checking operators",
             category: "Best Practices",

package/lib/rules/no-eval.js

@@ -76,6 +76,8 @@ function isMember(node, name) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `eval()`",
             category: "Best Practices",

package/lib/rules/no-ex-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning exceptions in `catch` clauses",
             category: "Possible Errors",

package/lib/rules/no-extend-native.js

@@ -24,6 +24,8 @@ const propertyDefinitionMethods = new Set(["defineProperty", "defineProperties"]
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow extending native types",
             category: "Best Practices",

package/lib/rules/no-extra-bind.js

@@ -22,6 +22,8 @@ const SIDE_EFFECT_FREE_NODE_TYPES = new Set(["Literal", "Identifier", "ThisExpre
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary calls to `.bind()`",
             category: "Best Practices",
@@ -30,7 +32,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-boolean-cast.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary boolean casts",
             category: "Possible Errors",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-label.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary labels",
             category: "Best Practices",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-parens.js

@@ -12,6 +12,8 @@ const astUtils = require("../util/ast-utils.js");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow unnecessary parentheses",
             category: "Possible Errors",
@@ -382,8 +384,7 @@ module.exports = {
                          * Allow extra parens around a new expression if
                          * there are intervening parentheses.
                          */
-                        callee.type === "MemberExpression" &&
-                        doesMemberExpressionContainCallExpression(callee)
+                        (callee.type === "MemberExpression" && doesMemberExpressionContainCallExpression(callee))
                     )
                 ) {
                     report(node.callee);
@@ -574,15 +575,13 @@ module.exports = {
                              * If `let` is the only thing on the left side of the loop, it's the loop variable: `for ((let) of foo);`
                              * Removing it will cause a syntax error, because it will be parsed as the start of a VariableDeclarator.
                              */
-                            firstLeftToken.range[1] === node.left.range[1] ||
-
-                            /*
+                            (firstLeftToken.range[1] === node.left.range[1] || /*
                              * If `let` is followed by a `[` token, it's a property access on the `let` value: `for ((let[foo]) of bar);`
                              * Removing it will cause the property access to be parsed as a destructuring declaration of `foo` instead.
                              */
                             astUtils.isOpeningBracketToken(
                                 sourceCode.getTokenAfter(firstLeftToken, astUtils.isNotClosingParenToken)
-                            )
+                            ))
                         )
                     ) {
                         tokensToIgnore.add(firstLeftToken);

package/lib/rules/no-extra-semi.js

@@ -18,6 +18,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary semicolons",
             category: "Possible Errors",

package/lib/rules/no-fallthrough.js

@@ -55,6 +55,8 @@ function hasBlankLinesBetween(node, token) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow fallthrough of `case` statements",
             category: "Best Practices",

package/lib/rules/no-floating-decimal.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow leading or trailing decimal points in numeric literals",
             category: "Best Practices",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-func-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning `function` declarations",
             category: "Possible Errors",

package/lib/rules/no-global-assign.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow assignments to native objects or read-only global variables",
             category: "Best Practices",

package/lib/rules/no-implicit-coercion.js

@@ -152,6 +152,8 @@ function getNonEmptyOperand(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow shorthand type conversions",
             category: "Best Practices",
@@ -160,6 +162,7 @@ module.exports = {
         },
 
         fixable: "code",
+
         schema: [{
             type: "object",
             properties: {