eslint 5.13.0 → 5.15.1

package/lib/rules/max-len.js

@@ -14,7 +14,8 @@ const OPTIONS_SCHEMA = {
     properties: {
         code: {
             type: "integer",
-            minimum: 0
+            minimum: 0,
+            default: 80
         },
         comments: {
             type: "integer",
@@ -22,28 +23,35 @@ const OPTIONS_SCHEMA = {
         },
         tabWidth: {
             type: "integer",
-            minimum: 0
+            minimum: 0,
+            default: 4
         },
         ignorePattern: {
             type: "string"
         },
         ignoreComments: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         },
         ignoreStrings: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         },
         ignoreUrls: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         },
         ignoreTemplateLiterals: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         },
         ignoreRegExpLiterals: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         },
         ignoreTrailingComments: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         }
     },
     additionalProperties: false
@@ -95,7 +103,7 @@ module.exports = {
          *   too many false positives
          * - We don't care about matching the entire URL, any small segment is fine
          */
-        const URL_REGEXP = /[^:/?#]:\/\/[^?#]/;
+        const URL_REGEXP = /[^:/?#]:\/\/[^?#]/u;
 
         const sourceCode = context.getSourceCode();
 
@@ -110,7 +118,7 @@ module.exports = {
         function computeLineLength(line, tabWidth) {
             let extraCharacterCount = 0;
 
-            line.replace(/\t/g, (match, offset) => {
+            line.replace(/\t/gu, (match, offset) => {
                 const totalOffset = offset + extraCharacterCount,
                     previousTabStopOffset = tabWidth ? totalOffset % tabWidth : 0,
                     spaceCount = tabWidth - previousTabStopOffset;
@@ -121,8 +129,7 @@ module.exports = {
         }
 
         // The options object must be the last option specified…
-        const lastOption = context.options[context.options.length - 1];
-        const options = typeof lastOption === "object" ? Object.create(lastOption) : {};
+        const options = Object.assign({}, context.options[context.options.length - 1]);
 
         // …but max code length…
         if (typeof context.options[0] === "number") {
@@ -146,7 +153,7 @@ module.exports = {
         let ignorePattern = options.ignorePattern || null;
 
         if (ignorePattern) {
-            ignorePattern = new RegExp(ignorePattern);
+            ignorePattern = new RegExp(ignorePattern); // eslint-disable-line require-unicode-regexp
         }
 
         //--------------------------------------------------------------------------
@@ -194,7 +201,7 @@ module.exports = {
         function stripTrailingComment(line, comment) {
 
             // loc.column is zero-indexed
-            return line.slice(0, comment.loc.start.column).replace(/\s+$/, "");
+            return line.slice(0, comment.loc.start.column).replace(/\s+$/u, "");
         }
 
         /**

package/lib/rules/max-lines-per-function.js

@@ -19,16 +19,20 @@ const OPTIONS_SCHEMA = {
     properties: {
         max: {
             type: "integer",
-            minimum: 0
+            minimum: 0,
+            default: 50
         },
         skipComments: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         },
         skipBlankLines: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         },
         IIFEs: {
-            type: "boolean"
+            type: "boolean",
+            default: false
         }
     },
     additionalProperties: false
@@ -97,18 +101,10 @@ module.exports = {
         let IIFEs = false;
 
         if (typeof option === "object") {
-            if (typeof option.max === "number") {
-                maxLines = option.max;
-            }
-            if (typeof option.skipComments === "boolean") {
-                skipComments = option.skipComments;
-            }
-            if (typeof option.skipBlankLines === "boolean") {
-                skipBlankLines = option.skipBlankLines;
-            }
-            if (typeof option.IIFEs === "boolean") {
-                IIFEs = option.IIFEs;
-            }
+            maxLines = option.max;
+            skipComments = option.skipComments;
+            skipBlankLines = option.skipBlankLines;
+            IIFEs = option.IIFEs;
         } else if (typeof option === "number") {
             maxLines = option;
         }
@@ -191,7 +187,7 @@ module.exports = {
                 }
 
                 if (skipBlankLines) {
-                    if (line.match(/^\s*$/)) {
+                    if (line.match(/^\s*$/u)) {
                         continue;
                     }
                 }

package/lib/rules/max-lines.js

@@ -61,11 +61,9 @@ module.exports = {
         const option = context.options[0];
         let max = 300;
 
-        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "max") && typeof option.max === "number") {
+        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "max")) {
             max = option.max;
-        }
-
-        if (typeof option === "number") {
+        } else if (typeof option === "number") {
             max = option;
         }
 
@@ -86,7 +84,7 @@ module.exports = {
         /**
          * Returns the line numbers of a comment that don't have any code on the same line
          * @param {Node} comment The comment node to check
-         * @returns {int[]} The line numbers
+         * @returns {number[]} The line numbers
          */
         function getLinesWithoutCode(comment) {
             let start = comment.loc.start.line;

package/lib/rules/max-nested-callbacks.js

@@ -57,13 +57,12 @@ module.exports = {
         const option = context.options[0];
         let THRESHOLD = 10;
 
-        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "maximum") && typeof option.maximum === "number") {
-            THRESHOLD = option.maximum;
-        }
-        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "max") && typeof option.max === "number") {
-            THRESHOLD = option.max;
-        }
-        if (typeof option === "number") {
+        if (
+            typeof option === "object" &&
+            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+        ) {
+            THRESHOLD = option.maximum || option.max;
+        } else if (typeof option === "number") {
             THRESHOLD = option;
         }
 

package/lib/rules/max-params.js

@@ -62,11 +62,11 @@ module.exports = {
         const option = context.options[0];
         let numParams = 3;
 
-        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "maximum") && typeof option.maximum === "number") {
-            numParams = option.maximum;
-        }
-        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "max") && typeof option.max === "number") {
-            numParams = option.max;
+        if (
+            typeof option === "object" &&
+            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+        ) {
+            numParams = option.maximum || option.max;
         }
         if (typeof option === "number") {
             numParams = option;

package/lib/rules/max-statements-per-line.js

@@ -31,7 +31,8 @@ module.exports = {
                 properties: {
                     max: {
                         type: "integer",
-                        minimum: 1
+                        minimum: 1,
+                        default: 1
                     }
                 },
                 additionalProperties: false
@@ -56,7 +57,7 @@ module.exports = {
         // Helpers
         //--------------------------------------------------------------------------
 
-        const SINGLE_CHILD_ALLOWED = /^(?:(?:DoWhile|For|ForIn|ForOf|If|Labeled|While)Statement|Export(?:Default|Named)Declaration)$/;
+        const SINGLE_CHILD_ALLOWED = /^(?:(?:DoWhile|For|ForIn|ForOf|If|Labeled|While)Statement|Export(?:Default|Named)Declaration)$/u;
 
         /**
          * Reports with the first extra statement, and clears it.

package/lib/rules/max-statements.js

@@ -78,13 +78,12 @@ module.exports = {
             topLevelFunctions = [];
         let maxStatements = 10;
 
-        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "maximum") && typeof option.maximum === "number") {
-            maxStatements = option.maximum;
-        }
-        if (typeof option === "object" && Object.prototype.hasOwnProperty.call(option, "max") && typeof option.max === "number") {
-            maxStatements = option.max;
-        }
-        if (typeof option === "number") {
+        if (
+            typeof option === "object" &&
+            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+        ) {
+            maxStatements = option.maximum || option.max;
+        } else if (typeof option === "number") {
             maxStatements = option;
         }
 

package/lib/rules/multiline-comment-style.js

@@ -52,7 +52,7 @@ module.exports = {
             }
             return commentGroup[0].value
                 .split(astUtils.LINEBREAK_MATCHER)
-                .map(line => line.replace(/^\s*\*?/, ""));
+                .map(line => line.replace(/^\s*\*?/u, ""));
         }
 
         /**
@@ -103,9 +103,9 @@ module.exports = {
             const lines = commentGroup[0].value.split(astUtils.LINEBREAK_MATCHER);
 
             return commentGroup[0].type === "Block" &&
-                /^\*\s*$/.test(lines[0]) &&
-                lines.slice(1, -1).every(line => /^\s* /.test(line)) &&
-                /^\s*$/.test(lines[lines.length - 1]);
+                /^\*\s*$/u.test(lines[0]) &&
+                lines.slice(1, -1).every(line => /^\s* /u.test(line)) &&
+                /^\s*$/u.test(lines[lines.length - 1]);
         }
 
         /**
@@ -143,7 +143,7 @@ module.exports = {
                     const lines = block.value.split(astUtils.LINEBREAK_MATCHER);
                     const expectedLinePrefix = `${sourceCode.text.slice(block.range[0] - block.loc.start.column, block.range[0])} *`;
 
-                    if (!/^\*?\s*$/.test(lines[0])) {
+                    if (!/^\*?\s*$/u.test(lines[0])) {
                         const start = block.value.startsWith("*") ? block.range[0] + 1 : block.range[0];
 
                         context.report({
@@ -156,7 +156,7 @@ module.exports = {
                         });
                     }
 
-                    if (!/^\s*$/.test(lines[lines.length - 1])) {
+                    if (!/^\s*$/u.test(lines[lines.length - 1])) {
                         context.report({
                             loc: {
                                 start: { line: block.loc.end.line, column: block.loc.end.column - 2 },
@@ -176,12 +176,12 @@ module.exports = {
                                     start: { line: lineNumber, column: 0 },
                                     end: { line: lineNumber, column: sourceCode.lines[lineNumber - 1].length }
                                 },
-                                messageId: /^\s*\*/.test(lineText)
+                                messageId: /^\s*\*/u.test(lineText)
                                     ? "alignment"
                                     : "missingStar",
                                 fix(fixer) {
                                     const lineStartIndex = sourceCode.getIndexFromLoc({ line: lineNumber, column: 0 });
-                                    const linePrefixLength = lineText.match(/^\s*\*? ?/)[0].length;
+                                    const linePrefixLength = lineText.match(/^\s*\*? ?/u)[0].length;
                                     const commentStartIndex = lineStartIndex + linePrefixLength;
 
                                     const replacementText = lineNumber === block.loc.end.line || lineText.length === linePrefixLength
@@ -244,7 +244,7 @@ module.exports = {
                         const block = commentGroup[0];
                         const lines = block.value.split(astUtils.LINEBREAK_MATCHER).filter(line => line.trim());
 
-                        if (lines.length > 0 && lines.every(line => /^\s*\*/.test(line))) {
+                        if (lines.length > 0 && lines.every(line => /^\s*\*/u.test(line))) {
                             context.report({
                                 loc: {
                                     start: block.loc.start,

package/lib/rules/new-cap.js

@@ -88,10 +88,12 @@ module.exports = {
                 type: "object",
                 properties: {
                     newIsCap: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     },
                     capIsNew: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     },
                     newIsCapExceptions: {
                         type: "array",
@@ -112,7 +114,8 @@ module.exports = {
                         type: "string"
                     },
                     properties: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     }
                 },
                 additionalProperties: false
@@ -126,17 +129,17 @@ module.exports = {
 
     create(context) {
 
-        const config = context.options[0] ? Object.assign({}, context.options[0]) : {};
+        const config = Object.assign({}, context.options[0]);
 
         config.newIsCap = config.newIsCap !== false;
         config.capIsNew = config.capIsNew !== false;
         const skipProperties = config.properties === false;
 
         const newIsCapExceptions = checkArray(config, "newIsCapExceptions", []).reduce(invert, {});
-        const newIsCapExceptionPattern = config.newIsCapExceptionPattern ? new RegExp(config.newIsCapExceptionPattern) : null;
+        const newIsCapExceptionPattern = config.newIsCapExceptionPattern ? new RegExp(config.newIsCapExceptionPattern) : null; // eslint-disable-line require-unicode-regexp
 
         const capIsNewExceptions = calculateCapIsNewExceptions(config);
-        const capIsNewExceptionPattern = config.capIsNewExceptionPattern ? new RegExp(config.capIsNewExceptionPattern) : null;
+        const capIsNewExceptionPattern = config.capIsNewExceptionPattern ? new RegExp(config.capIsNewExceptionPattern) : null; // eslint-disable-line require-unicode-regexp
 
         const listeners = {};
 

package/lib/rules/newline-per-chained-call.js

@@ -31,7 +31,8 @@ module.exports = {
                 ignoreChainWithDepth: {
                     type: "integer",
                     minimum: 1,
-                    maximum: 10
+                    maximum: 10,
+                    default: 2
                 }
             },
             additionalProperties: false

package/lib/rules/no-alert.js

@@ -20,7 +20,7 @@ const getPropertyName = require("../util/ast-utils").getStaticPropertyName;
  * @returns {boolean} Whether or not the name is prohibited.
  */
 function isProhibitedIdentifier(name) {
-    return /^(alert|confirm|prompt)$/.test(name);
+    return /^(alert|confirm|prompt)$/u.test(name);
 }
 
 /**

package/lib/rules/no-bitwise.js

@@ -43,7 +43,8 @@ module.exports = {
                         uniqueItems: true
                     },
                     int32Hint: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-caller.js

@@ -35,7 +35,7 @@ module.exports = {
                 const objectName = node.object.name,
                     propertyName = node.property.name;
 
-                if (objectName === "arguments" && !node.computed && propertyName && propertyName.match(/^calle[er]$/)) {
+                if (objectName === "arguments" && !node.computed && propertyName && propertyName.match(/^calle[er]$/u)) {
                     context.report({ node, messageId: "unexpected", data: { prop: propertyName } });
                 }
 

package/lib/rules/no-confusing-arrow.js

@@ -41,7 +41,7 @@ module.exports = {
         schema: [{
             type: "object",
             properties: {
-                allowParens: { type: "boolean" }
+                allowParens: { type: "boolean", default: false }
             },
             additionalProperties: false
         }],

package/lib/rules/no-constant-condition.js

@@ -32,7 +32,8 @@ module.exports = {
                 type: "object",
                 properties: {
                     checkLoops: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-dupe-keys.js

@@ -15,8 +15,8 @@ const astUtils = require("../util/ast-utils");
 // Helpers
 //------------------------------------------------------------------------------
 
-const GET_KIND = /^(?:init|get)$/;
-const SET_KIND = /^(?:init|set)$/;
+const GET_KIND = /^(?:init|get)$/u;
+const SET_KIND = /^(?:init|set)$/u;
 
 /**
  * The class which stores properties' information of an object.

package/lib/rules/no-duplicate-imports.js

@@ -113,7 +113,8 @@ module.exports = {
             type: "object",
             properties: {
                 includeExports: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: false
                 }
             },
             additionalProperties: false

package/lib/rules/no-else-return.js

@@ -31,7 +31,8 @@ module.exports = {
             type: "object",
             properties: {
                 allowElseIf: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: true
                 }
             },
             additionalProperties: false
@@ -81,7 +82,7 @@ module.exports = {
                      * after the if block
                      */
                     const ifBlockMaybeUnsafe = node.parent.consequent.type !== "BlockStatement" && lastIfToken.value !== ";";
-                    const elseBlockUnsafe = /^[([/+`-]/.test(firstTokenOfElseBlock.value);
+                    const elseBlockUnsafe = /^[([/+`-]/u.test(firstTokenOfElseBlock.value);
 
                     if (ifBlockMaybeUnsafe && elseBlockUnsafe) {
                         return null;
@@ -93,7 +94,7 @@ module.exports = {
                     if (lastTokenOfElseBlock.value !== ";") {
                         const nextToken = sourceCode.getTokenAfter(endToken);
 
-                        const nextTokenUnsafe = nextToken && /^[([/+`-]/.test(nextToken.value);
+                        const nextTokenUnsafe = nextToken && /^[([/+`-]/u.test(nextToken.value);
                         const nextTokenOnSameLine = nextToken && nextToken.loc.start.line === lastTokenOfElseBlock.loc.start.line;
 
                         /*

package/lib/rules/no-empty-character-class.js

@@ -21,7 +21,7 @@
  * 4. `[gimuy]*`: optional regexp flags
  * 5. `$`: fix the match at the end of the string
  */
-const regex = /^\/([^\\[]|\\.|\[([^\\\]]|\\.)+])*\/[gimuys]*$/;
+const regex = /^\/([^\\[]|\\.|\[([^\\\]]|\\.)+\])*\/[gimuys]*$/u;
 
 //------------------------------------------------------------------------------
 // Rule Definition

package/lib/rules/no-empty.js

@@ -30,7 +30,8 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowEmptyCatch: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-eval.js

@@ -89,7 +89,7 @@ module.exports = {
             {
                 type: "object",
                 properties: {
-                    allowIndirect: { type: "boolean" }
+                    allowIndirect: { type: "boolean", default: false }
                 },
                 additionalProperties: false
             }

package/lib/rules/no-extra-parens.js

@@ -471,6 +471,7 @@ module.exports = {
             const firstToken = isParenthesised(node) ? sourceCode.getTokenBefore(node) : sourceCode.getFirstToken(node);
             const secondToken = sourceCode.getTokenAfter(firstToken, astUtils.isNotOpeningParenToken);
             const thirdToken = secondToken ? sourceCode.getTokenAfter(secondToken) : null;
+            const tokenAfterClosingParens = secondToken ? sourceCode.getTokenAfter(secondToken, astUtils.isNotClosingParenToken) : null;
 
             if (
                 astUtils.isOpeningParenToken(firstToken) &&
@@ -479,7 +480,12 @@ module.exports = {
                     secondToken.type === "Keyword" && (
                         secondToken.value === "function" ||
                         secondToken.value === "class" ||
-                        secondToken.value === "let" && astUtils.isOpeningBracketToken(sourceCode.getTokenAfter(secondToken, astUtils.isNotClosingParenToken))
+                        secondToken.value === "let" &&
+                            tokenAfterClosingParens &&
+                            (
+                                astUtils.isOpeningBracketToken(tokenAfterClosingParens) ||
+                                tokenAfterClosingParens.type === "Identifier"
+                            )
                     ) ||
                     secondToken && secondToken.type === "Identifier" && secondToken.value === "async" && thirdToken && thirdToken.type === "Keyword" && thirdToken.value === "function"
                 )

package/lib/rules/no-fallthrough.js

@@ -14,7 +14,7 @@ const lodash = require("lodash");
 // Helpers
 //------------------------------------------------------------------------------
 
-const DEFAULT_FALLTHROUGH_COMMENT = /falls?\s?through/i;
+const DEFAULT_FALLTHROUGH_COMMENT = /falls?\s?through/iu;
 
 /**
  * Checks whether or not a given node has a fallthrough comment.
@@ -69,7 +69,8 @@ module.exports = {
                 type: "object",
                 properties: {
                     commentPattern: {
-                        type: "string"
+                        type: "string",
+                        default: ""
                     }
                 },
                 additionalProperties: false
@@ -94,7 +95,7 @@ module.exports = {
         let fallthroughCommentPattern = null;
 
         if (options.commentPattern) {
-            fallthroughCommentPattern = new RegExp(options.commentPattern);
+            fallthroughCommentPattern = new RegExp(options.commentPattern); // eslint-disable-line require-unicode-regexp
         } else {
             fallthroughCommentPattern = DEFAULT_FALLTHROUGH_COMMENT;
         }

package/lib/rules/no-implicit-coercion.js

@@ -11,7 +11,7 @@ const astUtils = require("../util/ast-utils");
 // Helpers
 //------------------------------------------------------------------------------
 
-const INDEX_OF_PATTERN = /^(?:i|lastI)ndexOf$/;
+const INDEX_OF_PATTERN = /^(?:i|lastI)ndexOf$/u;
 const ALLOWABLE_OPERATORS = ["~", "!!", "+", "*"];
 
 /**
@@ -21,9 +21,9 @@ const ALLOWABLE_OPERATORS = ["~", "!!", "+", "*"];
  */
 function parseOptions(options) {
     return {
-        boolean: "boolean" in options ? Boolean(options.boolean) : true,
-        number: "number" in options ? Boolean(options.number) : true,
-        string: "string" in options ? Boolean(options.string) : true,
+        boolean: "boolean" in options ? options.boolean : true,
+        number: "number" in options ? options.number : true,
+        string: "string" in options ? options.string : true,
         allow: options.allow || []
     };
 }
@@ -167,13 +167,16 @@ module.exports = {
             type: "object",
             properties: {
                 boolean: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: true
                 },
                 number: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: true
                 },
                 string: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: true
                 },
                 allow: {
                     type: "array",

package/lib/rules/no-implied-eval.js

@@ -24,7 +24,7 @@ module.exports = {
     },
 
     create(context) {
-        const CALLEE_RE = /^(setTimeout|setInterval|execScript)$/;
+        const CALLEE_RE = /^(setTimeout|setInterval|execScript)$/u;
 
         /*
          * Figures out if we should inspect a given binary expression. Is a stack

package/lib/rules/no-invalid-regexp.js

@@ -10,7 +10,7 @@
 
 const RegExpValidator = require("regexpp").RegExpValidator;
 const validator = new RegExpValidator({ ecmaVersion: 2018 });
-const validFlags = /[gimuys]/g;
+const validFlags = /[gimuys]/gu;
 const undefined1 = void 0;
 
 //------------------------------------------------------------------------------
@@ -51,7 +51,7 @@ module.exports = {
             const temp = options.allowConstructorFlags.join("").replace(validFlags, "");
 
             if (temp) {
-                allowedFlags = new RegExp(`[${temp}]`, "gi");
+                allowedFlags = new RegExp(`[${temp}]`, "giu");
             }
         }