eslint 5.12.0 → 5.14.1

package/lib/rules/no-implicit-coercion.js

@@ -21,9 +21,9 @@ const ALLOWABLE_OPERATORS = ["~", "!!", "+", "*"];
  */
 function parseOptions(options) {
     return {
-        boolean: "boolean" in options ? Boolean(options.boolean) : true,
-        number: "number" in options ? Boolean(options.number) : true,
-        string: "string" in options ? Boolean(options.string) : true,
+        boolean: "boolean" in options ? options.boolean : true,
+        number: "number" in options ? options.number : true,
+        string: "string" in options ? options.string : true,
         allow: options.allow || []
     };
 }
@@ -167,13 +167,16 @@ module.exports = {
             type: "object",
             properties: {
                 boolean: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: true
                 },
                 number: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: true
                 },
                 string: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: true
                 },
                 allow: {
                     type: "array",

package/lib/rules/no-irregular-whitespace.js

@@ -41,16 +41,20 @@ module.exports = {
                 type: "object",
                 properties: {
                     skipComments: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     skipStrings: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     },
                     skipTemplates: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     skipRegExps: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-labels.js

@@ -30,10 +30,12 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowLoop: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     allowSwitch: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false
@@ -43,8 +45,8 @@ module.exports = {
 
     create(context) {
         const options = context.options[0];
-        const allowLoop = Boolean(options && options.allowLoop);
-        const allowSwitch = Boolean(options && options.allowSwitch);
+        const allowLoop = options && options.allowLoop;
+        const allowSwitch = options && options.allowSwitch;
         let scopeInfo = null;
 
         /**

package/lib/rules/no-magic-numbers.js

@@ -24,10 +24,12 @@ module.exports = {
             type: "object",
             properties: {
                 detectObjects: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: false
                 },
                 enforceConst: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: false
                 },
                 ignore: {
                     type: "array",
@@ -37,7 +39,8 @@ module.exports = {
                     uniqueItems: true
                 },
                 ignoreArrayIndexes: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: false
                 }
             },
             additionalProperties: false

package/lib/rules/no-mixed-operators.js

@@ -42,10 +42,10 @@ const TARGET_NODE_TYPE = /^(?:Binary|Logical)Expression$/;
  * @param {Object|undefined} options - A options object to normalize.
  * @returns {Object} Normalized option object.
  */
-function normalizeOptions(options) {
-    const hasGroups = (options && options.groups && options.groups.length > 0);
+function normalizeOptions(options = {}) {
+    const hasGroups = options.groups && options.groups.length > 0;
     const groups = hasGroups ? options.groups : DEFAULT_GROUPS;
-    const allowSamePrecedence = (options && options.allowSamePrecedence) !== false;
+    const allowSamePrecedence = options.allowSamePrecedence !== false;
 
     return {
         groups,
@@ -95,7 +95,8 @@ module.exports = {
                         uniqueItems: true
                     },
                     allowSamePrecedence: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-mixed-requires.js

@@ -30,10 +30,12 @@ module.exports = {
                         type: "object",
                         properties: {
                             grouping: {
-                                type: "boolean"
+                                type: "boolean",
+                                default: false
                             },
                             allowCall: {
-                                type: "boolean"
+                                type: "boolean",
+                                default: false
                             }
                         },
                         additionalProperties: false

package/lib/rules/no-multi-spaces.js

@@ -38,7 +38,8 @@ module.exports = {
                         additionalProperties: false
                     },
                     ignoreEOLComments: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-param-reassign.js

@@ -55,7 +55,7 @@ module.exports = {
     },
 
     create(context) {
-        const props = context.options[0] && Boolean(context.options[0].props);
+        const props = context.options[0] && context.options[0].props;
         const ignoredPropertyAssignmentsFor = context.options[0] && context.options[0].ignorePropertyModificationsFor || [];
 
         /**

package/lib/rules/no-plusplus.js

@@ -26,7 +26,8 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowForLoopAfterthoughts: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-redeclare.js

@@ -24,7 +24,7 @@ module.exports = {
             {
                 type: "object",
                 properties: {
-                    builtinGlobals: { type: "boolean" }
+                    builtinGlobals: { type: "boolean", default: false }
                 },
                 additionalProperties: false
             }
@@ -33,7 +33,7 @@ module.exports = {
 
     create(context) {
         const options = {
-            builtinGlobals: Boolean(context.options[0] && context.options[0].builtinGlobals)
+            builtinGlobals: context.options[0] && context.options[0].builtinGlobals
         };
 
         /**

package/lib/rules/no-self-assign.js

@@ -179,7 +179,8 @@ module.exports = {
                 type: "object",
                 properties: {
                     props: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-shadow-restricted-names.js

@@ -4,6 +4,19 @@
  */
 "use strict";
 
+/**
+ * Determines if a variable safely shadows undefined.
+ * This is the case when a variable named `undefined` is never assigned to a value (i.e. it always shares the same value
+ * as the global).
+ * @param {eslintScope.Variable} variable The variable to check
+ * @returns {boolean} true if this variable safely shadows `undefined`
+ */
+function safelyShadowsUndefined(variable) {
+    return variable.name === "undefined" &&
+        variable.references.every(ref => !ref.isWrite()) &&
+        variable.defs.every(def => def.node.type === "VariableDeclarator" && def.node.init === null);
+}
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -24,12 +37,13 @@ module.exports = {
 
     create(context) {
 
-        const RESTRICTED = ["undefined", "NaN", "Infinity", "arguments", "eval"];
+
+        const RESTRICTED = new Set(["undefined", "NaN", "Infinity", "arguments", "eval"]);
 
         return {
             "VariableDeclaration, :function, CatchClause"(node) {
                 for (const variable of context.getDeclaredVariables(node)) {
-                    if (variable.defs.length > 0 && RESTRICTED.includes(variable.name)) {
+                    if (variable.defs.length > 0 && RESTRICTED.has(variable.name) && !safelyShadowsUndefined(variable)) {
                         context.report({
                             node: variable.defs[0].name,
                             message: "Shadowing of global property '{{idName}}'.",

package/lib/rules/no-shadow.js

@@ -30,8 +30,8 @@ module.exports = {
             {
                 type: "object",
                 properties: {
-                    builtinGlobals: { type: "boolean" },
-                    hoist: { enum: ["all", "functions", "never"] },
+                    builtinGlobals: { type: "boolean", default: false },
+                    hoist: { enum: ["all", "functions", "never"], default: "functions" },
                     allow: {
                         type: "array",
                         items: {
@@ -47,7 +47,7 @@ module.exports = {
     create(context) {
 
         const options = {
-            builtinGlobals: Boolean(context.options[0] && context.options[0].builtinGlobals),
+            builtinGlobals: context.options[0] && context.options[0].builtinGlobals,
             hoist: (context.options[0] && context.options[0].hoist) || "functions",
             allow: (context.options[0] && context.options[0].allow) || []
         };

package/lib/rules/no-sync.js

@@ -27,7 +27,8 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowAtRootLevel: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-tabs.js

@@ -30,7 +30,8 @@ module.exports = {
             type: "object",
             properties: {
                 allowIndentationTabs: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: false
                 }
             },
             additionalProperties: false

package/lib/rules/no-trailing-spaces.js

@@ -32,10 +32,12 @@ module.exports = {
                 type: "object",
                 properties: {
                     skipBlankLines: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     ignoreComments: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false
@@ -52,7 +54,7 @@ module.exports = {
 
         const options = context.options[0] || {},
             skipBlankLines = options.skipBlankLines || false,
-            ignoreComments = typeof options.ignoreComments === "boolean" && options.ignoreComments;
+            ignoreComments = options.ignoreComments || false;
 
         /**
          * Report the error message

package/lib/rules/no-undef.js

@@ -39,12 +39,16 @@ module.exports = {
                 type: "object",
                 properties: {
                     typeof: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false
             }
-        ]
+        ],
+        messages: {
+            undef: "'{{name}}' is not defined."
+        }
     },
 
     create(context) {
@@ -64,7 +68,7 @@ module.exports = {
 
                     context.report({
                         node: identifier,
-                        message: "'{{name}}' is not defined.",
+                        messageId: "undef",
                         data: identifier
                     });
                 });

package/lib/rules/no-underscore-dangle.js

@@ -31,13 +31,16 @@ module.exports = {
                         }
                     },
                     allowAfterThis: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     allowAfterSuper: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     enforceInMethodNames: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-unexpected-multiline.js

@@ -25,16 +25,17 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-unexpected-multiline"
         },
 
-        schema: []
+        schema: [],
+        messages: {
+            function: "Unexpected newline between function and ( of function call.",
+            property: "Unexpected newline between object and [ of property access.",
+            taggedTemplate: "Unexpected newline between template tag and template literal.",
+            division: "Unexpected newline between numerator and division operator."
+        }
     },
 
     create(context) {
 
-        const FUNCTION_MESSAGE = "Unexpected newline between function and ( of function call.";
-        const PROPERTY_MESSAGE = "Unexpected newline between object and [ of property access.";
-        const TAGGED_TEMPLATE_MESSAGE = "Unexpected newline between template tag and template literal.";
-        const DIVISION_MESSAGE = "Unexpected newline between numerator and division operator.";
-
         const REGEX_FLAG_MATCHER = /^[gimsuy]+$/;
 
         const sourceCode = context.getSourceCode();
@@ -43,16 +44,16 @@ module.exports = {
          * Check to see if there is a newline between the node and the following open bracket
          * line's expression
          * @param {ASTNode} node The node to check.
-         * @param {string} msg The error message to use.
+         * @param {string} messageId The error messageId to use.
          * @returns {void}
          * @private
          */
-        function checkForBreakAfter(node, msg) {
+        function checkForBreakAfter(node, messageId) {
             const openParen = sourceCode.getTokenAfter(node, astUtils.isNotClosingParenToken);
             const nodeExpressionEnd = sourceCode.getTokenBefore(openParen);
 
             if (openParen.loc.start.line !== nodeExpressionEnd.loc.end.line) {
-                context.report({ node, loc: openParen.loc.start, message: msg, data: { char: openParen.value } });
+                context.report({ node, loc: openParen.loc.start, messageId, data: { char: openParen.value } });
             }
         }
 
@@ -66,21 +67,21 @@ module.exports = {
                 if (!node.computed) {
                     return;
                 }
-                checkForBreakAfter(node.object, PROPERTY_MESSAGE);
+                checkForBreakAfter(node.object, "property");
             },
 
             TaggedTemplateExpression(node) {
                 if (node.tag.loc.end.line === node.quasi.loc.start.line) {
                     return;
                 }
-                context.report({ node, loc: node.loc.start, message: TAGGED_TEMPLATE_MESSAGE });
+                context.report({ node, loc: node.loc.start, messageId: "taggedTemplate" });
             },
 
             CallExpression(node) {
                 if (node.arguments.length === 0) {
                     return;
                 }
-                checkForBreakAfter(node.callee, FUNCTION_MESSAGE);
+                checkForBreakAfter(node.callee, "function");
             },
 
             "BinaryExpression[operator='/'] > BinaryExpression[operator='/'].left"(node) {
@@ -92,7 +93,7 @@ module.exports = {
                     REGEX_FLAG_MATCHER.test(tokenAfterOperator.value) &&
                     secondSlash.range[1] === tokenAfterOperator.range[0]
                 ) {
-                    checkForBreakAfter(node.left, DIVISION_MESSAGE);
+                    checkForBreakAfter(node.left, "division");
                 }
             }
         };

package/lib/rules/no-unneeded-ternary.js

@@ -38,7 +38,8 @@ module.exports = {
                 type: "object",
                 properties: {
                     defaultAssignment: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: true
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-unsafe-negation.js

@@ -51,7 +51,10 @@ module.exports = {
         },
 
         schema: [],
-        fixable: "code"
+        fixable: "code",
+        messages: {
+            unexpected: "Unexpected negating the left operand of '{{operator}}' operator."
+        }
     },
 
     create(context) {
@@ -66,8 +69,8 @@ module.exports = {
                     context.report({
                         node,
                         loc: node.left.loc,
-                        message: "Unexpected negating the left operand of '{{operator}}' operator.",
-                        data: node,
+                        messageId: "unexpected",
+                        data: { operator: node.operator },
 
                         fix(fixer) {
                             const negationToken = sourceCode.getFirstToken(node.left);

package/lib/rules/no-unused-expressions.js

@@ -24,13 +24,16 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowShortCircuit: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     allowTernary: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     allowTaggedTemplates: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false

package/lib/rules/no-unused-labels.js

@@ -21,7 +21,12 @@ module.exports = {
         },
 
         schema: [],
-        fixable: "code"
+
+        fixable: "code",
+
+        messages: {
+            unused: "'{{name}}:' is defined but never used."
+        }
     },
 
     create(context) {
@@ -53,7 +58,7 @@ module.exports = {
             if (!scopeInfo.used) {
                 context.report({
                     node: node.label,
-                    message: "'{{name}}:' is defined but never used.",
+                    messageId: "unused",
                     data: node.label,
                     fix(fixer) {
 

package/lib/rules/no-unused-vars.js

@@ -37,22 +37,26 @@ module.exports = {
                         type: "object",
                         properties: {
                             vars: {
-                                enum: ["all", "local"]
+                                enum: ["all", "local"],
+                                default: "all"
                             },
                             varsIgnorePattern: {
                                 type: "string"
                             },
                             args: {
-                                enum: ["all", "after-used", "none"]
+                                enum: ["all", "after-used", "none"],
+                                default: "after-used"
                             },
                             ignoreRestSiblings: {
-                                type: "boolean"
+                                type: "boolean",
+                                default: false
                             },
                             argsIgnorePattern: {
                                 type: "string"
                             },
                             caughtErrors: {
-                                enum: ["all", "none"]
+                                enum: ["all", "none"],
+                                default: "none"
                             },
                             caughtErrorsIgnorePattern: {
                                 type: "string"

package/lib/rules/no-use-before-define.js

@@ -154,9 +154,9 @@ module.exports = {
                     {
                         type: "object",
                         properties: {
-                            functions: { type: "boolean" },
-                            classes: { type: "boolean" },
-                            variables: { type: "boolean" }
+                            functions: { type: "boolean", default: true },
+                            classes: { type: "boolean", default: true },
+                            variables: { type: "boolean", default: true }
                         },
                         additionalProperties: false
                     }

package/lib/rules/no-useless-rename.js

@@ -26,9 +26,9 @@ module.exports = {
             {
                 type: "object",
                 properties: {
-                    ignoreDestructuring: { type: "boolean" },
-                    ignoreImport: { type: "boolean" },
-                    ignoreExport: { type: "boolean" }
+                    ignoreDestructuring: { type: "boolean", default: false },
+                    ignoreImport: { type: "boolean", default: false },
+                    ignoreExport: { type: "boolean", default: false }
                 },
                 additionalProperties: false
             }

package/lib/rules/object-curly-newline.js

@@ -26,14 +26,16 @@ const OPTION_VALUE = {
             type: "object",
             properties: {
                 multiline: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: false
                 },
                 minProperties: {
                     type: "integer",
                     minimum: 0
                 },
                 consistent: {
-                    type: "boolean"
+                    type: "boolean",
+                    default: false
                 }
             },
             additionalProperties: false,
@@ -59,9 +61,9 @@ function normalizeOptionValue(value) {
         } else if (value === "never") {
             minProperties = Number.POSITIVE_INFINITY;
         } else {
-            multiline = Boolean(value.multiline);
+            multiline = value.multiline;
             minProperties = value.minProperties || Number.POSITIVE_INFINITY;
-            consistent = Boolean(value.consistent);
+            consistent = value.consistent;
         }
     } else {
         consistent = true;

package/lib/rules/object-property-newline.js

@@ -25,10 +25,12 @@ module.exports = {
                 type: "object",
                 properties: {
                     allowAllPropertiesOnSameLine: {
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     },
                     allowMultiplePropertiesPerLine: { // Deprecated
-                        type: "boolean"
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false
@@ -40,7 +42,7 @@ module.exports = {
 
     create(context) {
         const allowSameLine = context.options[0] && (
-            (Boolean(context.options[0].allowAllPropertiesOnSameLine) || Boolean(context.options[0].allowMultiplePropertiesPerLine)) // Deprecated
+            (context.options[0].allowAllPropertiesOnSameLine || context.options[0].allowMultiplePropertiesPerLine /* Deprecated */)
         );
         const errorMessage = allowSameLine
             ? "Object properties must go on a new line if they aren't all on the same line."